CustomerQuery::get_customers() - Code Metrics - Inspection of "Remove empty lines in upgrade query." - wp-pay-gateways/mollie - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — develop ( 13fc2a...744f0f )

by Reüel

created 2020-02-13 11:56 UTC

CustomerQuery::get_customers() A

↳ Parent: CustomerQuery

Complexity

Conditions	2
Paths	2

Size

Total Lines	24
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	9
c	1
b	0
f	0
nc	2
nop	0
dl	0
loc	24
rs	9.9666

<?php
/**
 * Mollie customer query.
 *
 * @author    Pronamic <[email protected]>
 * @copyright 2005-2020 Pronamic
 * @license   GPL-3.0-or-later
 * @package   Pronamic\WordPress\Pay
 */

namespace Pronamic\WordPress\Pay\Gateways\Mollie;

/**
 * Title: Mollie customer query
 * Description:
 * Copyright: 2005-2020 Pronamic
 * Company: Pronamic
 *
 * @author  Remco Tolsma
 * @version 3.0.0
 * @since   3.0.0
 */
class CustomerQuery {
	/**
	 * Construct customer query.
	 *
	 * @param array $args Query arguments.
	 */
	public function __construct( $args = array() ) {
		$this->args = \wp_parse_args(

			$args,
			array(
				'user_id'         => null,
				'organization_id' => null,
				'profile_id'      => null,
			)
		);
	}

	/**
	 * Get customers.
	 *
	 * @return array
	 */
	public function get_customers() {
		global $wpdb;

		$where = '1 = 1';

		if ( array_key_exists( 'user_id', $this->args ) ) {
			$where .= $wpdb->prepare( ' AND mollie_customer_user.user_id = %d', $this->args['user_id'] );
		}

		$query = "
			SELECT
				mollie_customer.mollie_id,
				mollie_customer.test_mode
			FROM
				$wpdb->pronamic_pay_mollie_customer_users AS mollie_customer_user
					INNER JOIN
				$wpdb->pronamic_pay_mollie_customers AS mollie_customer
						ON mollie_customer_user.customer_id = mollie_customer.id
			WHERE
				 $where
			;
		";

		return $wpdb->get_results( $query );
	}
}


1			<?php
2			/**
3			* Mollie customer query.
4			*
5			* @author Pronamic <[email protected]>
6			* @copyright 2005-2020 Pronamic
7			* @license GPL-3.0-or-later
8			* @package Pronamic\WordPress\Pay
9			*/
10
11			namespace Pronamic\WordPress\Pay\Gateways\Mollie;
12
13			/**
14			* Title: Mollie customer query
15			* Description:
16			* Copyright: 2005-2020 Pronamic
17			* Company: Pronamic
18			*
19			* @author Remco Tolsma
20			* @version 3.0.0
21			* @since 3.0.0
22			*/
23			class CustomerQuery {
24			/**
25			* Construct customer query.
26			*
27			* @param array $args Query arguments.
28			*/
29			public function __construct( $args = array() ) {
30			$this->args = \wp_parse_args(
			0 ignored issues – show Bug Best Practice introduced 2020-02-12 14:45 UTC by Report Bug Copy Issue Report The property `args` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
31			$args,
32			array(
33			'user_id' => null,
34			'organization_id' => null,
35			'profile_id' => null,
36			)
37			);
38			}
39
40			/**
41			* Get customers.
42			*
43			* @return array
44			*/
45			public function get_customers() {
46			global $wpdb;
47
48			$where = '1 = 1';
49
50			if ( array_key_exists( 'user_id', $this->args ) ) {
51			$where .= $wpdb->prepare( ' AND mollie_customer_user.user_id = %d', $this->args['user_id'] );
52			}
53
54			$query = "
55			SELECT
56			mollie_customer.mollie_id,
57			mollie_customer.test_mode
58			FROM
59			$wpdb->pronamic_pay_mollie_customer_users AS mollie_customer_user
60			INNER JOIN
61			$wpdb->pronamic_pay_mollie_customers AS mollie_customer
62			ON mollie_customer_user.customer_id = mollie_customer.id
63			WHERE
64			$where
65			;
66			";
67
68			return $wpdb->get_results( $query );
69			}
70			}
71

wp-pay-gateways / mollie

Push — develop ( 13fc2a...744f0f )

CustomerQuery::get_customers() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like