wp-pay-gateways / ideal-advanced-v3

src/XML/DirectoryParser.php

Spacing +6 added lines, -6 removed lines

@@ -24,16 +24,16 @@
 	 *
 	 * @return Directory
 	 */
-	public static function parse( SimpleXMLElement $xml ) {
+	public static function parse(SimpleXMLElement $xml) {
 		$directory = new Directory();
 
-		$timestamp = Security::filter( $xml->directoryDateTimestamp );
-		$directory->set_date( new DateTime( $timestamp ) );
+		$timestamp = Security::filter($xml->directoryDateTimestamp);
+		$directory->set_date(new DateTime($timestamp));
 
-		foreach ( $xml->Country as $element ) {
-			$country = CountryParser::parse( $element );
+		foreach ($xml->Country as $element) {
+			$country = CountryParser::parse($element);
 
-			$directory->add_country( $country );
+			$directory->add_country($country);
 		}
 
 		return $directory;

src/XML/AcquirerStatusReqMessage.php

Spacing +6 added lines, -6 removed lines

@@ -33,7 +33,7 @@ 
 	 * Constructs and initialize an status request message
 	 */
 	public function __construct() {
-		parent::__construct( self::NAME );
+		parent::__construct(self::NAME);
 	}
 
 	/**
@@ -47,17 +47,17 @@ 
 		// Merchant
 		$merchant = $this->get_merchant();
 
-		$element = self::add_element( $document, $document->documentElement, 'Merchant' );
-		self::add_elements( $document, $element, array(
+		$element = self::add_element($document, $document->documentElement, 'Merchant');
+		self::add_elements($document, $element, array(
 			'merchantID' => $merchant->get_id(),
 			'subID'      => $merchant->get_sub_id(),
-		) );
+		));
 
 		// Transaction
 		$transaction = $this->transaction;
 
-		$element = self::add_element( $document, $document->documentElement, 'Transaction' );
-		self::add_element( $document, $element, 'transactionID', $transaction->get_id() );
+		$element = self::add_element($document, $document->documentElement, 'Transaction');
+		self::add_element($document, $element, 'transactionID', $transaction->get_id());
 
 		// Return
 		return $document;

src/XML/TransactionParser.php

Spacing +14 added lines, -14 removed lines

@@ -24,33 +24,33 @@
 	 *
 	 * @return Transaction
 	 */
-	public static function parse( SimpleXMLElement $xml, Transaction $transaction = null ) {
-		if ( ! $transaction instanceof Transaction ) {
+	public static function parse(SimpleXMLElement $xml, Transaction $transaction = null) {
+		if ( ! $transaction instanceof Transaction) {
 			$transaction = new Transaction();
 		}
 
-		if ( $xml->transactionID ) {
-			$transaction->set_id( Security::filter( $xml->transactionID ) );
+		if ($xml->transactionID) {
+			$transaction->set_id(Security::filter($xml->transactionID));
 		}
 
-		if ( $xml->purchaseID ) {
-			$transaction->set_purchase_id( Security::filter( $xml->purchaseID ) );
+		if ($xml->purchaseID) {
+			$transaction->set_purchase_id(Security::filter($xml->purchaseID));
 		}
 
-		if ( $xml->status ) {
-			$transaction->set_status( Security::filter( $xml->status ) );
+		if ($xml->status) {
+			$transaction->set_status(Security::filter($xml->status));
 		}
 
-		if ( $xml->consumerName ) {
-			$transaction->set_consumer_name( Security::filter( $xml->consumerName ) );
+		if ($xml->consumerName) {
+			$transaction->set_consumer_name(Security::filter($xml->consumerName));
 		}
 
-		if ( $xml->consumerIBAN ) {
-			$transaction->set_consumer_iban( Security::filter( $xml->consumerIBAN ) );
+		if ($xml->consumerIBAN) {
+			$transaction->set_consumer_iban(Security::filter($xml->consumerIBAN));
 		}
 
-		if ( $xml->consumerBIC ) {
-			$transaction->set_consumer_bic( Security::filter( $xml->consumerBIC ) );
+		if ($xml->consumerBIC) {
+			$transaction->set_consumer_bic(Security::filter($xml->consumerBIC));
 		}
 
 		return $transaction;

src/Client.php

Spacing +55 added lines, -55 removed lines

@@ -122,7 +122,7 @@ 
 	 *
 	 * @param string $url
 	 */
-	public function set_acquirer_url( $url ) {
+	public function set_acquirer_url($url) {
 		$this->acquirer_url = $url;
 
 		$this->directory_request_url   = $url;
@@ -138,14 +138,14 @@ 
 	 *
 	 * @return ResponseMessage
 	 */
-	private function send_message( $url, RequestMessage $message ) {
+	private function send_message($url, RequestMessage $message) {
 		$result = false;
 
 		// Sign
 		$document = $message->get_document();
-		$document = $this->sign_document( $document );
+		$document = $this->sign_document($document);
 
-		if ( false !== $document ) {
+		if (false !== $document) {
 			// Stringify
 			$data = $document->saveXML();
 
@@ -154,32 +154,32 @@ 
 			 *
 			 * @since 1.1.11
 			 */
-			if ( 'https://www.ideal-checkout.nl/simulator/' === $url ) {
-				$data = $document->C14N( true, false );
+			if ('https://www.ideal-checkout.nl/simulator/' === $url) {
+				$data = $document->C14N(true, false);
 			}
 
 			// Remote post
-			$response = wp_remote_post( $url, array(
+			$response = wp_remote_post($url, array(
 				'method'  => 'POST',
 				'headers' => array(
 					'Content-Type' => 'text/xml; charset=' . Message::XML_ENCODING,
 				),
 				'body'    => $data,
-			) );
+			));
 
 			// Handle response
-			if ( ! is_wp_error( $response ) ) {
-				if ( 200 === wp_remote_retrieve_response_code( $response ) ) {
-					$body = wp_remote_retrieve_body( $response );
+			if ( ! is_wp_error($response)) {
+				if (200 === wp_remote_retrieve_response_code($response)) {
+					$body = wp_remote_retrieve_body($response);
 
-					$xml = Core_Util::simplexml_load_string( $body );
+					$xml = Core_Util::simplexml_load_string($body);
 
-					if ( is_wp_error( $xml ) ) {
+					if (is_wp_error($xml)) {
 						$this->error = $xml;
 					} else {
-						$document = self::parse_document( $xml );
+						$document = self::parse_document($xml);
 
-						if ( is_wp_error( $document ) ) {
+						if (is_wp_error($document)) {
 							$this->error = $document;
 						} else {
 							$result = $document;
@@ -190,8 +190,8 @@ 
 						'wrong_response_code',
 						sprintf(
 							/* translators: %s: response code */
-							__( 'The response code (<code>%s<code>) from the iDEAL provider was incorrect.', 'pronamic_ideal' ),
-							wp_remote_retrieve_response_code( $response )
+							__('The response code (<code>%s<code>) from the iDEAL provider was incorrect.', 'pronamic_ideal'),
+							wp_remote_retrieve_response_code($response)
 						)
 					);
 				}
@@ -210,33 +210,33 @@ 
 	 *
 	 * @return ResponseMessage|WP_Error
 	 */
-	private function parse_document( SimpleXMLElement $document ) {
+	private function parse_document(SimpleXMLElement $document) {
 		$this->error = null;
 
 		$name = $document->getName();
 
-		switch ( $name ) {
+		switch ($name) {
 			case AcquirerErrorResMessage::NAME:
-				$message = AcquirerErrorResMessage::parse( $document );
+				$message = AcquirerErrorResMessage::parse($document);
 
 				$this->error = new WP_Error(
 					'IDealAdvancedV3_error',
-					sprintf( '%s. %s', $message->error->get_message(), $message->error->get_detail() ),
+					sprintf('%s. %s', $message->error->get_message(), $message->error->get_detail()),
 					$message->error
 				);
 
 				return $message;
 			case DirectoryResponseMessage::NAME:
-				return DirectoryResponseMessage::parse( $document );
+				return DirectoryResponseMessage::parse($document);
 			case TransactionResponseMessage::NAME:
-				return TransactionResponseMessage::parse( $document );
+				return TransactionResponseMessage::parse($document);
 			case AcquirerStatusResMessage::NAME:
-				return AcquirerStatusResMessage::parse( $document );
+				return AcquirerStatusResMessage::parse($document);
 			default:
 				return new WP_Error(
 					'IDealAdvancedV3_error',
 					/* translators: %s: XML document element name */
-					sprintf( __( 'Unknwon iDEAL message (%s)', 'pronamic_ideal' ), $name )
+					sprintf(__('Unknwon iDEAL message (%s)', 'pronamic_ideal'), $name)
 				);
 		}
 	}
@@ -252,12 +252,12 @@ 
 		$request_dir_message = new DirectoryRequestMessage();
 
 		$merchant = $request_dir_message->get_merchant();
-		$merchant->set_id( $this->merchant_id );
-		$merchant->set_sub_id( $this->sub_id );
+		$merchant->set_id($this->merchant_id);
+		$merchant->set_sub_id($this->sub_id);
 
-		$response_dir_message = $this->send_message( $this->directory_request_url, $request_dir_message );
+		$response_dir_message = $this->send_message($this->directory_request_url, $request_dir_message);
 
-		if ( $response_dir_message instanceof DirectoryResponseMessage ) {
+		if ($response_dir_message instanceof DirectoryResponseMessage) {
 			$directory = $response_dir_message->get_directory();
 		}
 
@@ -272,20 +272,20 @@ 
 	 *
 	 * @return TransactionResponseMessage
 	 */
-	public function create_transaction( Transaction $transaction, $return_url, $issuer_id ) {
+	public function create_transaction(Transaction $transaction, $return_url, $issuer_id) {
 		$message = new TransactionRequestMessage();
 
 		$merchant = $message->get_merchant();
-		$merchant->set_id( $this->merchant_id );
-		$merchant->set_sub_id( $this->sub_id );
-		$merchant->set_return_url( $return_url );
+		$merchant->set_id($this->merchant_id);
+		$merchant->set_sub_id($this->sub_id);
+		$merchant->set_return_url($return_url);
 
 		$message->issuer = new Issuer();
-		$message->issuer->set_id( $issuer_id );
+		$message->issuer->set_id($issuer_id);
 
 		$message->transaction = $transaction;
 
-		return $this->send_message( $this->transaction_request_url, $message );
+		return $this->send_message($this->transaction_request_url, $message);
 	}
 
 	/**
@@ -295,17 +295,17 @@ 
 	 *
 	 * @return TransactionResponseMessage
 	 */
-	public function get_status( $transaction_id ) {
+	public function get_status($transaction_id) {
 		$message = new AcquirerStatusReqMessage();
 
 		$merchant = $message->get_merchant();
-		$merchant->set_id( $this->merchant_id );
-		$merchant->set_sub_id( $this->sub_id );
+		$merchant->set_id($this->merchant_id);
+		$merchant->set_sub_id($this->sub_id);
 
 		$message->transaction = new Transaction();
-		$message->transaction->set_id( $transaction_id );
+		$message->transaction->set_id($transaction_id);
 
-		return $this->send_message( $this->status_request_url, $message );
+		return $this->send_message($this->status_request_url, $message);
 	}
 
 	/**
@@ -317,7 +317,7 @@ 
 	 *
 	 * @return DOMDocument
 	 */
-	private function sign_document( DOMDocument $document ) {
+	private function sign_document(DOMDocument $document) {
 		$result = false;
 
 		try {
@@ -325,14 +325,14 @@ 
 
 			// For canonicalization purposes the exclusive (9) algorithm must be used.
 			// @see http://pronamic.nl/wp-content/uploads/2012/12/iDEAL-Merchant-Integration-Guide-ENG-v3.3.1.pdf #page 30
-			$dsig->setCanonicalMethod( XMLSecurityDSig::EXC_C14N );
+			$dsig->setCanonicalMethod(XMLSecurityDSig::EXC_C14N);
 
 			// For hashing purposes the SHA-256 (11) algorithm must be used.
 			// @see http://pronamic.nl/wp-content/uploads/2012/12/iDEAL-Merchant-Integration-Guide-ENG-v3.3.1.pdf #page 30
 			$dsig->addReference(
 				$document,
 				XMLSecurityDSig::SHA256,
-				array( 'http://www.w3.org/2000/09/xmldsig#enveloped-signature' ),
+				array('http://www.w3.org/2000/09/xmldsig#enveloped-signature'),
 				array(
 					'force_uri' => true,
 				)
@@ -340,39 +340,39 @@ 
 
 			// For signature purposes the RSAWithSHA 256 (12) algorithm must be used.
 			// @see http://pronamic.nl/wp-content/uploads/2012/12/iDEAL-Merchant-Integration-Guide-ENG-v3.3.1.pdf #page 31
-			$key = new XMLSecurityKey( XMLSecurityKey::RSA_SHA256, array(
+			$key = new XMLSecurityKey(XMLSecurityKey::RSA_SHA256, array(
 				'type' => 'private',
-			) );
+			));
 
 			$key->passphrase = $this->private_key_password;
 
-			$key->loadKey( $this->private_key );
+			$key->loadKey($this->private_key);
 
 			// Test if we can get an private key object, to prefent the following errors:
 			// Warning: openssl_sign() [function.openssl-sign]: supplied key param cannot be coerced into a private key
-			$result = openssl_get_privatekey( $this->private_key, $this->private_key_password );
+			$result = openssl_get_privatekey($this->private_key, $this->private_key_password);
 
-			if ( false !== $result ) {
+			if (false !== $result) {
 				// Sign
-				$dsig->sign( $key );
+				$dsig->sign($key);
 
 				// The public key must be referenced using a fingerprint of an X.509
 				// certificate. The fingerprint must be calculated according
 				// to the following formula HEX(SHA-1(DER certificate)) (13)
 				// @see http://pronamic.nl/wp-content/uploads/2012/12/iDEAL-Merchant-Integration-Guide-ENG-v3.3.1.pdf #page 31
-				$fingerprint = Security::get_sha_fingerprint( $this->private_certificate );
+				$fingerprint = Security::get_sha_fingerprint($this->private_certificate);
 
-				$dsig->addKeyInfoAndName( $fingerprint );
+				$dsig->addKeyInfoAndName($fingerprint);
 
 				// Add the signature
-				$dsig->appendSignature( $document->documentElement );
+				$dsig->appendSignature($document->documentElement);
 
 				$result = $document;
 			} else {
-				throw new Exception( 'Can not load private key' );
+				throw new Exception('Can not load private key');
 			}
-		} catch ( Exception $e ) {
-			$this->error = new WP_Error( 'xml_security', $e->getMessage(), $e );
+		} catch (Exception $e) {
+			$this->error = new WP_Error('xml_security', $e->getMessage(), $e);
 		}
 
 		return $result;

src/Transaction.php

Spacing +14 added lines, -14 removed lines

@@ -124,7 +124,7 @@ 
 	 *
 	 * @param string $id
 	 */
-	public function set_id( $id ) {
+	public function set_id($id) {
 		$this->id = $id;
 	}
 
@@ -146,7 +146,7 @@ 
 	 *
 	 * @param string $id
 	 */
-	public function set_purchase_id( $id ) {
+	public function set_purchase_id($id) {
 		$this->purchase_id = $id;
 	}
 
@@ -164,7 +164,7 @@ 
 	 *
 	 * @param string $amount
 	 */
-	public function set_amount( $amount ) {
+	public function set_amount($amount) {
 		$this->amount = $amount;
 	}
 
@@ -182,7 +182,7 @@ 
 	 *
 	 * @param string $currency
 	 */
-	public function set_currency( $currency ) {
+	public function set_currency($currency) {
 		$this->currency = $currency;
 	}
 
@@ -200,7 +200,7 @@ 
 	 *
 	 * @param string $expiration_period
 	 */
-	public function set_expiration_period( $expiration_period ) {
+	public function set_expiration_period($expiration_period) {
 		$this->expiration_period = $expiration_period;
 	}
 
@@ -218,7 +218,7 @@ 
 	 *
 	 * @param string $language
 	 */
-	public function set_language( $language ) {
+	public function set_language($language) {
 		$this->language = $language;
 	}
 
@@ -237,8 +237,8 @@ 
 	 *
 	 * @param string $description
 	 */
-	public function set_description( $description ) {
-		$this->description = substr( $description, 0, 32 );
+	public function set_description($description) {
+		$this->description = substr($description, 0, 32);
 	}
 
 	/**
@@ -264,8 +264,8 @@ 
 	 *
 	 * @param string $entrance_code
 	 */
-	public function set_entrance_code( $entrance_code ) {
-		$this->entrance_code = substr( $entrance_code, 0, 40 );
+	public function set_entrance_code($entrance_code) {
+		$this->entrance_code = substr($entrance_code, 0, 40);
 	}
 
 	/**
@@ -282,7 +282,7 @@ 
 	 *
 	 * @param string $status
 	 */
-	public function set_status( $status ) {
+	public function set_status($status) {
 		$this->status = $status;
 	}
 
@@ -300,7 +300,7 @@ 
 	 *
 	 * @param $name
 	 */
-	public function set_consumer_name( $name ) {
+	public function set_consumer_name($name) {
 		$this->consumer_name = $name;
 	}
 
@@ -318,7 +318,7 @@ 
 	 *
 	 * @param string $iban
 	 */
-	public function set_consumer_iban( $iban ) {
+	public function set_consumer_iban($iban) {
 		$this->consumer_iban = $iban;
 	}
 
@@ -336,7 +336,7 @@ 
 	 *
 	 * @param string $bic
 	 */
-	public function set_consumer_bic( $bic ) {
+	public function set_consumer_bic($bic) {
 		$this->consumer_bic = $bic;
 	}
 }

src/Merchant.php

Spacing +3 added lines, -3 removed lines

@@ -54,7 +54,7 @@ 
 	 *
 	 * @param string $id
 	 */
-	public function set_id( $id ) {
+	public function set_id($id) {
 		$this->id = $id;
 	}
 
@@ -72,7 +72,7 @@ 
 	 *
 	 * @param string $sub_id
 	 */
-	public function set_sub_id( $sub_id ) {
+	public function set_sub_id($sub_id) {
 		$this->sub_id = $sub_id;
 	}
 
@@ -90,7 +90,7 @@ 
 	 *
 	 * @param string $return_url
 	 */
-	public function set_return_url( $return_url ) {
+	public function set_return_url($return_url) {
 		$this->return_url = $return_url;
 	}
 }

src/Security.php

Spacing +15 added lines, -15 removed lines

@@ -34,8 +34,8 @@ 
 	 *
 	 * @return string Fingerprint or null on failure
 	 */
-	public static function get_sha_fingerprint( $certificate ) {
-		return self::get_fingerprint( $certificate, 'sha1' );
+	public static function get_sha_fingerprint($certificate) {
+		return self::get_fingerprint($certificate, 'sha1');
 	}
 
 	/**
@@ -45,8 +45,8 @@ 
 	 *
 	 * @return string Fingerprint or null on failure
 	 */
-	public static function get_md5_fingerprint( $certificate ) {
-		return self::get_fingerprint( $certificate, 'md5' );
+	public static function get_md5_fingerprint($certificate) {
+		return self::get_fingerprint($certificate, 'md5');
 	}
 
 	/**
@@ -56,36 +56,36 @@ 
 	 *
 	 * @return string Fingerprint or null on failure
 	 */
-	public static function get_fingerprint( $certificate, $hash = null ) {
+	public static function get_fingerprint($certificate, $hash = null) {
 		$fingerprint = null;
 
 		// The openssl_x509_read() function will throw an warning if the supplied
 		// parameter cannot be coerced into an X509 certificate
 		// @codingStandardsIgnoreStart
-		$resource = @openssl_x509_read( $certificate );
+		$resource = @openssl_x509_read($certificate);
 		// @codingStandardsIgnoreEnd
 
-		if ( false === $resource ) {
+		if (false === $resource) {
 			return false;
 		}
 
 		$output = null;
 
-		$result = openssl_x509_export( $resource, $output );
+		$result = openssl_x509_export($resource, $output);
 
-		if ( false === $result ) {
+		if (false === $result) {
 			return false;
 		}
 
-		$output = str_replace( self::CERTIFICATE_BEGIN, '', $output );
-		$output = str_replace( self::CERTIFICATE_END, '', $output );
+		$output = str_replace(self::CERTIFICATE_BEGIN, '', $output);
+		$output = str_replace(self::CERTIFICATE_END, '', $output);
 
 		// Base64 decode
-		$fingerprint = base64_decode( $output );
+		$fingerprint = base64_decode($output);
 
 		// Hash
-		if ( null !== $hash ) {
-			$fingerprint = hash( $hash, $fingerprint );
+		if (null !== $hash) {
+			$fingerprint = hash($hash, $fingerprint);
 		}
 
 		/*
@@ -97,7 +97,7 @@ 
 		 *
 		 * @since 1.1.11
 		 */
-		$fingerprint = strtoupper( $fingerprint );
+		$fingerprint = strtoupper($fingerprint);
 
 		return $fingerprint;
 	}

src/IDeal.php

Spacing +2 added lines, -2 removed lines

@@ -19,9 +19,9 @@
 	 *
 	 * @return string
 	 */
-	public static function format_amount( $amount ) {
+	public static function format_amount($amount) {
 		// The amount payable in euro (with a period (.) used as decimal separator)
 		// page 18 - http://pronamic.nl/wp-content/uploads/2012/12/iDEAL-Merchant-Integration-Guide-ENG-v3.3.1.pdf
-		return number_format( $amount, 2, '.', '' );
+		return number_format($amount, 2, '.', '');
 	}
 }