Util::get_transaction_service() - Code Metrics - Inspection of "Improved error handling on payment start (closes #..." - wp-pay-gateways/buckaroo - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — develop ( 0bf85e...ba0dec )

by Reüel

created 2021-06-25 14:32 UTC

Util::get_transaction_service() A

↳ Parent: Util

Complexity

Conditions	4
Paths	3

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	4
eloc	6
nc	3
nop	1
dl	0
loc	12
ccs	7
cts	7
cp	1
crap	4
rs	10
c	1
b	0
f	0

<?php

namespace Pronamic\WordPress\Pay\Gateways\Buckaroo;

use Pronamic\WordPress\Pay\Payments\Payment;

/**
 * Title: Buckaroo utility class
 * Description:
 * Copyright: 2005-2021 Pronamic
 * Company: Pronamic
 *
 * @author Remco Tolsma
 * @version 2.0.0
 * @since 1.0.0
 */
class Util {
	/**
	 * Get invoice number.
	 *
	 * @param string $invoice_number
	 * @param Payment $payment
	 *
	 * @return string
	 */
	public static function get_invoice_number( $invoice_number, Payment $payment ) {
		// Replacements definition
		$replacements = array(
			'{order_id}'   => $payment->get_order_id(),
			'{payment_id}' => $payment->get_id(),
		);

		// Find and replace
		$invoice_number = str_replace(
			array_keys( $replacements ),
			array_values( $replacements ),
			$invoice_number,
			$count
		);

		// Make sure there is an dynamic part in the order ID
		if ( 0 === $count ) {
			$invoice_number .= $payment->get_id();
		}

		return $invoice_number;
	}

	/**
	 * Get first service name from transaction.
	 *
	 * @param object $transaction Transaction object.
	 * @return string|null
	 */
	public static function get_transaction_service( $transaction ) {
		if ( \property_exists( $transaction, 'Services' ) ) {
			foreach ( $transaction->Services as $service ) {
				if ( ! \property_exists( $service, 'Name' ) ) {
					continue;
				}

				return $service->Name;
			}
		}

		return null;
	}
}


1		<?php
2
3		namespace Pronamic\WordPress\Pay\Gateways\Buckaroo;
4
5		use Pronamic\WordPress\Pay\Payments\Payment;
6
7		/**
8		* Title: Buckaroo utility class
9		* Description:
10		* Copyright: 2005-2021 Pronamic
11		* Company: Pronamic
12		*
13		* @author Remco Tolsma
14		* @version 2.0.0
15		* @since 1.0.0
16		*/
17		class Util {
18		/**
19		* Get invoice number.
20		*
21		* @param string $invoice_number
22		* @param Payment $payment
23		*
24		* @return string
25		*/
26	6	public static function get_invoice_number( $invoice_number, Payment $payment ) {
27		// Replacements definition
28		$replacements = array(
29	6	'{order_id}' => $payment->get_order_id(),
30	6	'{payment_id}' => $payment->get_id(),
31		);
32
33		// Find and replace
34	6	$invoice_number = str_replace(
35	6	array_keys( $replacements ),
36	6	array_values( $replacements ),
37		$invoice_number,
38		$count
39		);
40
41		// Make sure there is an dynamic part in the order ID
42	6	if ( 0 === $count ) {
43	1	$invoice_number .= $payment->get_id();
44		}
45
46	6	return $invoice_number;
47		}
48
49		/**
50		* Get first service name from transaction.
51		*
52		* @param object $transaction Transaction object.
53		* @return string\|null
54		*/
55	2	public static function get_transaction_service( $transaction ) {
56	2	if ( \property_exists( $transaction, 'Services' ) ) {
57	2	foreach ( $transaction->Services as $service ) {
58	2	if ( ! \property_exists( $service, 'Name' ) ) {
59	2	continue;
60		}
61
62	1	return $service->Name;
63		}
64		}
65
66	1	return null;
67		}
68		}
69

wp-pay-gateways / buckaroo

Push — develop ( 0bf85e...ba0dec )

Util::get_transaction_service() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like