Gateway::update_status() - Code Metrics - Inspection of "Improve request and response handling." - wp-pay-gateways/buckaroo - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed
Push — feature/json-api ( f8df9f...4d01fe )

by Remco
created 2021-06-07 11:05 UTC
Gateway::update_status() B

↳ Parent: Gateway
Complexity

Conditions	9
Paths	37
Size

Total Lines	55
Code Lines	22
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	90
Importance

Changes	3
Bugs	0	Features	0
Metric	Value
cc	9
eloc	22
c	3
b	0
f	0
nc	37
nop	1
dl	0
loc	55
ccs	0
cts	0
cp	0
crap	90
rs	8.0555
How to fix Long Method

<?php

namespace Pronamic\WordPress\Pay\Gateways\Buckaroo;

use Pronamic\WordPress\Money\Money;
use Pronamic\WordPress\Pay\Banks\BankAccountDetails;
use Pronamic\WordPress\Pay\Core\Gateway as Core_Gateway;
use Pronamic\WordPress\Pay\Core\PaymentMethods as Core_PaymentMethods;
use Pronamic\WordPress\Pay\Core\Server;
use Pronamic\WordPress\Pay\Payments\Payment;

/**
 * Title: Buckaroo gateway
 * Description:
 * Copyright: 2005-2021 Pronamic
 * Company: Pronamic
 *
 * @author Remco Tolsma
 * @version 2.0.4
 * @since 1.0.0
 */
class Gateway extends Core_Gateway {
	/**
	 * Client.
	 *
	 * @var Client
	 */
	protected $client;

	/**
	 * Constructs and initializes an Buckaroo gateway
	 *
	 * @param Config $config Config.
	 */
	public function __construct( Config $config ) {
		parent::__construct( $config );

		$this->set_method( self::METHOD_HTTP_REDIRECT );

		// Supported features.
		$this->supports = array(
			'payment_status_request',
			'refunds',
			'webhook',
			'webhook_log',
			'webhook_no_config',
		);

		$this->client = new Client();
		$this->client->set_website_key( $config->get_website_key() );
		$this->client->set_secret_key( $config->get_secret_key() );
		$this->client->set_excluded_services( $config->get_excluded_services() );
		$this->client->set_invoice_number( $config->get_invoice_number() );
		$this->client->set_push_url( add_query_arg( 'buckaroo_push', '', home_url( '/' ) ) );

		if ( self::MODE_TEST === $config->mode ) {
			$this->client->set_payment_server_url( Client::GATEWAY_TEST_URL );
		}
	}

	/**
	 * Get issuers.
	 *
	 * @since 1.2.4
	 * @see Pronamic_WP_Pay_Gateway::get_issuers()
	 */
	public function get_issuers() {
		$groups = array();

		try {
			$result = $this->client->get_issuers();

			$groups[] = array(
				'options' => $result,
			);
		} catch ( \Exception $e ) {
			$this->error = new \WP_Error( 'buckaroo', $e->getMessage() );
		}

		return $groups;
	}

	/**
	 * Get supported payment methods
	 *
	 * @see Pronamic_WP_Pay_Gateway::get_supported_payment_methods()
	 */
	public function get_supported_payment_methods() {
		return array(
			Core_PaymentMethods::BANK_TRANSFER,
			Core_PaymentMethods::BANCONTACT,
			Core_PaymentMethods::CREDIT_CARD,
			Core_PaymentMethods::GIROPAY,
			Core_PaymentMethods::IDEAL,
			Core_PaymentMethods::PAYPAL,
			Core_PaymentMethods::SOFORT,
		);
	}

	/**
	 * Start
	 *
	 * @param Payment $payment Payment.
	 *
	 * @see Core_Gateway::start()
	 */
	public function start( Payment $payment ) {
		/**
		 * Currency.
		 */
		$currency_code = $payment->get_total_amount()->get_currency()->get_alphabetic_code();

		if ( null === $currency_code ) {
			throw new \InvalidArgumentException( 'Can not start payment with empty currency code.' );
		}

		/**
		 * JSON Transaction.
		 *
		 * @link https://testcheckout.buckaroo.nl/json/Docs/Api/POST-json-Transaction
		 */
		$data = (object) array(
			'Currency'        => $currency_code,
			'AmountDebit'     => $payment->get_total_amount()->get_value(),
			'Invoice'         => \sprintf(
				'Payment %d',
				$payment->get_id()
			),
			'ReturnURL'       => $payment->get_return_url(),
			'ReturnURLCancel' => \add_query_arg(
				'buckaroo_return_url_cancel',
				true,
				$payment->get_return_url()
			),
			'ReturnURLError'  => \add_query_arg(
				'buckaroo_return_url_error',
				true,
				$payment->get_return_url()
			),
			'ReturnURLReject' => \add_query_arg(
				'buckaroo_return_url_reject',
				true,
				$payment->get_return_url()
			),
			/**
			 * Push URL.
			 * 
			 * When provided, this push URL overrides all the push URLs as configured in the payment plaza under websites for the associated website key
			 *
			 * @link https://dev.buckaroo.nl/Apis
			 */
			'PushURL'         => \rest_url( Integration::REST_ROUTE_NAMESPACE . '/push' ),
			/**
			 * Push URL Failure.
			 * 
			 * When provided, this push URL overrides the push URL for failed transactions as configured in the payment plaza under websites for the associated website key.
			 *
			 * @link https://dev.buckaroo.nl/Apis
			 */
			'PushURLFailure'  => \rest_url( Integration::REST_ROUTE_NAMESPACE . '/push' ),
			/**
			 * Services.
			 *
			 * Specifies which service (can be a payment method and/or additional service) is being called upon in the request.
			 *
			 * @link https://dev.buckaroo.nl/Apis
			 */
			'Services'        => (object) array(
				'ServiceList' => array(
					
				),
			),
		);

		/**
		 * Payment method.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/Api/POST-json-Transaction
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=ServicesRequest
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=ServiceRequest
		 */
		$payment_method = $payment->get_method();

		switch ( $payment_method ) {
			/**
			 * Payment method creditcard.
			 * 
			 * @link https://dev.buckaroo.nl/PaymentMethods/Description/creditcards#pay
			 */
			case Core_PaymentMethods::CREDIT_CARD:
				$data->Services->ServiceList[] = (object) array(
					'Action' => 'Pay',
					'Name'   => PaymentMethods::AMERICAN_EXPRESS,
				);

				$data->Services->ServiceList[] = (object) array(
					'Action' => 'Pay',
					'Name'   => PaymentMethods::MAESTRO,
				);

				$data->Services->ServiceList[] = (object) array(
					'Action' => 'Pay',
					'Name'   => PaymentMethods::MASTERCARD,
				);

				$data->Services->ServiceList[] = (object) array(
					'Action' => 'Pay',
					'Name'   => PaymentMethods::VISA,
				);

				break;
			/**
			 * Payment method iDEAL.
			 * 
			 * @link https://dev.buckaroo.nl/PaymentMethods/Description/ideal#pay
			 */
			case Core_PaymentMethods::IDEAL:
				$data->Services->ServiceList[] = (object) array(
					'Action'     => 'Pay',
					'Name'       => 'ideal',
					'Parameters' => array(
						array(
							'Name'  => 'issuer',
							'Value' => $payment->get_issuer(),
						),
					),
				);

				break;
			/**
			 * Payment method transfer.
			 * 
			 * @link https://dev.buckaroo.nl/PaymentMethods/Description/transfer#pay
			 */
			case Core_PaymentMethods::BANK_TRANSFER:
				$data->Services->ServiceList[] = (object) array(
					'Action'     => 'Pay',
					'Name'       => 'transfer',
				);

				break;
			/**
			 * Payment method Bancontact.
			 * 
			 * @link https://dev.buckaroo.nl/PaymentMethods/Description/bancontact#pay
			 */
			case Core_PaymentMethods::BANCONTACT:
			case Core_PaymentMethods::MISTER_CASH:
			case /** @scrutinizer ignore-deprecated */ Core_PaymentMethods::MISTER_CASH:
				$data->Services->ServiceList[] = (object) array(
					'Action'     => 'Pay',
					'Name'       => 'bancontactmrcash',
				);

				break;
			/**
			 * Payment method Giropay.
			 * 
			 * @link https://dev.buckaroo.nl/PaymentMethods/Description/giropay#pay
			 */
			case Core_PaymentMethods::GIROPAY:
				$data->Services->ServiceList[] = (object) array(
					'Action'     => 'Pay',
					'Name'       => 'giropay',
				);

				break;
			/**
			 * Payment method PayPal.
			 * 
			 * @link https://dev.buckaroo.nl/PaymentMethods/Description/paypal#pay
			 */
			case Core_PaymentMethods::PAYPAL:
				$data->Services->ServiceList[] = (object) array(
					'Action'     => 'Pay',
					'Name'       => 'paypal',
				);

				break;
			/**
			 * Payment method Sofort.
			 * 
			 * @link https://dev.buckaroo.nl/PaymentMethods/Description/sofort#pay
			 */
			case Core_PaymentMethods::SOFORT:
				$data->Services->ServiceList[] = (object) array(
					'Action'     => 'Pay',
					'Name'       => 'sofortueberweisung',
				);

				break;
		}

		/**
		 * Request.
		 */
		$object = $this->request( 'POST', 'Transaction', $data );

		if ( 'Redirect' !== $object->RequiredAction->Name ) {
			throw new \Exception(
				\sprintf(
					'Unsupported Buckaroo required action: %s',
					$object->RequiredAction->Name
				)
			);
		}

		$payment->set_action_url( $object->RequiredAction->RedirectURL );

		/**
		 * Buckaroo keys.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=TransactionResponse
		 */
		$payment->set_meta( 'buckaroo_transaction_key', $object->Key );
		$payment->set_meta( 'buckaroo_transaction_payment_key', $object->PaymentKey );

		/**
		 * Transaction ID.
		 *
		 * @link https://dev.buckaroo.nl/PaymentMethods/Description/ideal]
		 */
		foreach ( $object->Services as $service ) {
			foreach ( $service->Parameters as $parameter ) {
				if ( 'transactionId' === $parameter->Name ) {
					$payment->set_transaction_id( $parameter->Value );
				}
			}
		}
	}

	/**
	 * Get output HTML
	 *
	 * @param Payment $payment Payment.
	 *
	 * @return array
	 *
	 * @see     Core_Gateway::get_output_html()
	 * @since   1.1.1
	 * @version 2.0.4
	 */
	public function get_output_fields( Payment $payment ) {
		$payment_method = $payment->get_method();


		// Locale.
		$culture = null;

		$customer = $payment->get_customer();

		if ( null !== $customer ) {
			$locale = $customer->get_locale();

			// Buckaroo uses 'nl-NL' instead of 'nl_NL'.
			if ( ! empty( $locale ) ) {
				$culture = str_replace( '_', '-', $locale );
			}
		}

		$this->client->set_payment_id( (string) $payment->get_id() );
		$this->client->set_culture( $culture );
		$this->client->set_currency( $payment->get_total_amount()->get_currency()->get_alphabetic_code() );
		$this->client->set_description( $payment->get_description() );
		$this->client->set_amount( $payment->get_total_amount()->get_value() );
		$this->client->set_invoice_number( Util::get_invoice_number( (string) $this->client->get_invoice_number(), $payment ) );
		$this->client->set_return_url( $payment->get_return_url() );
		$this->client->set_return_cancel_url( $payment->get_return_url() );
		$this->client->set_return_error_url( $payment->get_return_url() );
		$this->client->set_return_reject_url( $payment->get_return_url() );

		return $this->client->get_fields();
	}

	/**
	 * JSON API Request.
	 *
	 * @param string      $method   HTTP request method.
	 * @param string      $endpoint JSON API endpoint.
	 * @param object|null $data     Data.
	 */
	private function request( $method, $endpoint, $data = null ) {
		/**
		 * Authentication.
		 * 
		 * The HMAC SHA256 is calculated over a concatenated string (as raw data/binary/bytes) of the following values: WebsiteKey, requestHttpMethod, requestUri, requestTimeStamp, nonce, requestContentBase64String. See the next table for more information about these values. Please note: the Base64 hash should be a string of 44 characters. If yours is longer, it is probably in hexadecimal format.
		 *
		 * @link https://dev.buckaroo.nl/Apis/Description/json
		 * @link https://testcheckout.buckaroo.nl/json/Docs/Authentication
		 */
		$website_key         = $this->config->website_key;
		$request_http_method = $method;
		$request_uri         = 'testcheckout.buckaroo.nl/json/' . $endpoint;
		$request_timestamp   = \strval( \time() );
		$nonce               = \wp_generate_password( 32 );
		$request_content     = null === $data ? '' : \json_encode( $data );

		$values = \implode(
			'',
			array(
				$website_key,
				$request_http_method,
				\strtolower( \urlencode( $request_uri ) ),
				$request_timestamp,
				$nonce,
				null === $data ? '' : \base64_encode( \md5( $request_content, true ) ),
			)
		);

		$hash = \hash_hmac( 'sha256', $values, $this->config->secret_key, true );

		$hmac = \base64_encode( $hash );

		$authorization = \sprintf(
			'hmac %s:%s:%s:%s',
			$this->config->website_key,
			$hmac,
			$nonce,
			$request_timestamp
		);

		$response = \Pronamic\WordPress\Http\Facades\Http::request(
			'https://' . $request_uri,
			array(
				'method'  => $request_http_method,
				'headers' => array(
					'Authorization' => $authorization,
					'Content-Type'  => 'application/json',
				),
				'body'    => $request_content,
			)
		);

		$object = $response->json();

		/**
		 * Request Errors.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/Api/POST-json-Transaction
		 */
		$exception = null;

		/**
		 * Channel errors.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=TransactionRequestResponseChannelError
		 */
		foreach ( $object->RequestErrors->ChannelErrors as $error ) {
			$exception = new \Exception( $error->ErrorMessage, 0, $exception );
		}

		/**
		 * Service errors.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=TransactionRequestResponseServiceError
		 */
		foreach ( $object->RequestErrors->ServiceErrors as $error ) {
			$exception = new \Exception( $error->ErrorMessage, 0, $exception );
		}

		/**
		 * Action errors.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=TransactionRequestResponseActionError
		 */
		foreach ( $object->RequestErrors->ActionErrors as $error ) {
			$exception = new \Exception( $error->ErrorMessage, 0, $exception );
		}

		/**
		 * Action errors.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=TransactionRequestResponseParameterError
		 */
		foreach ( $object->RequestErrors->ParameterErrors as $error ) {
			$exception = new \Exception( $error->ErrorMessage, 0, $exception );
		}

		/**
		 * Action errors.
		 * 
		 * @link https://testcheckout.buckaroo.nl/json/Docs/ResourceModel?modelName=TransactionRequestResponseCustomParameterError
		 */
		foreach ( $object->RequestErrors->CustomParameterErrors as $error ) {
			$exception = new \Exception( $error->ErrorMessage, 0, $exception );
		}

		if ( null !== $exception ) {
			throw $exception;
		}

		/**
		 * OK.
		 */
		return $object;
	}

	/**
	 * Update status of the specified payment
	 *
	 * @link https://testcheckout.buckaroo.nl/json/Docs/Api/GET-json-Transaction-Status-transactionKey
	 * @param Payment $payment Payment.
	 */
	public function update_status( Payment $payment ) {
		$transaction_key = $payment->get_meta( 'buckaroo_transaction_key' );

		if ( empty( $transaction_key ) ) {
			return;
		}

		$result = $this->request( 'GET', 'Transaction/Status/' . $transaction_key );

		$payment->set_status( Statuses::transform( \strval( $result->Status->Code->Code ) ) );

		/**
		 * Consumer bank details.
		 */
		$consumer_bank_details = $payment->get_consumer_bank_details();

		if ( null === $consumer_bank_details ) {
			$consumer_bank_details = new BankAccountDetails();

			$payment->set_consumer_bank_details( $consumer_bank_details );
		}

		/**
		 * Services.
		 */
		foreach ( $result->Services as $service ) {
			foreach ( $service->Parameters as $parameter ) {
				if ( 'transactionId' === $parameter->Name ) {
					$payment->set_transaction_id( $parameter->Value );
				}

				if ( 'consumerName' === $parameter->Name ) {
					$consumer_bank_details->set_name( $parameter->Value );
				}

				if ( 'consumerIBAN' === $parameter->Name ) {
					$consumer_bank_details->set_iban( $parameter->Value );
				}

				if ( 'consumerBIC' === $parameter->Name ) {
					$consumer_bank_details->set_iban( $parameter->Value );
				}
			}
		}

		/**
		 * Refunds.
		 *
		 * @link https://testcheckout.buckaroo.nl/json/Docs/Api/GET-json-Transaction-RefundInfo-transactionKey
		 */
		$result = $this->request( 'GET', 'Transaction/RefundInfo/' . $transaction_key );

		$refunded_amount = new Money( $result->RefundedAmount, $result->RefundCurrency );

		$payment->set_refunded_amount( $refunded_amount );
	}
}

wp-pay-gateways / buckaroo

Push — feature/json-api ( f8df9f...4d01fe )

Gateway::update_status() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
