wp-pay-extensions /
memberpress
| Conditions | 7 |
| Paths | 5 |
| Total Lines | 52 |
| Code Lines | 30 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 56 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 61 | private function get_subscriptions_map( $table ) { |
||
| 62 | if ( is_array( $this->subscriptions_map ) ) { |
||
| 63 | return $this->subscriptions_map; |
||
| 64 | } |
||
| 65 | |||
| 66 | $this->subscriptions_map = array(); |
||
| 67 | |||
| 68 | if ( ! isset( $table->items ) ) { |
||
| 69 | return; |
||
| 70 | } |
||
| 71 | |||
| 72 | $memberpress_subscriptions = $table->items; |
||
| 73 | |||
| 74 | if ( ! is_array( $memberpress_subscriptions ) || empty( $memberpress_subscriptions ) ) { |
||
| 75 | return; |
||
| 76 | } |
||
| 77 | |||
| 78 | $memberpress_subscription_ids = wp_list_pluck( $memberpress_subscriptions, 'id' ); |
||
| 79 | |||
| 80 | $query = new WP_Query( |
||
| 81 | array( |
||
| 82 | 'post_type' => 'pronamic_pay_subscr', |
||
| 83 | 'post_status' => 'any', |
||
| 84 | 'nopaging' => true, |
||
| 85 | 'meta_query' => array( |
||
| 86 | array( |
||
| 87 | 'key' => '_pronamic_subscription_source', |
||
| 88 | 'compare' => '=', |
||
| 89 | 'value' => 'memberpress', |
||
| 90 | ), |
||
| 91 | array( |
||
| 92 | 'key' => '_pronamic_subscription_source_id', |
||
| 93 | 'compare' => 'IN', |
||
| 94 | 'value' => $memberpress_subscription_ids, |
||
| 95 | ), |
||
| 96 | ), |
||
| 97 | ) |
||
| 98 | ); |
||
| 99 | |||
| 100 | if ( $query->have_posts() ) { |
||
| 101 | while ( $query->have_posts() ) { |
||
| 102 | $query->the_post(); |
||
| 103 | |||
| 104 | $memberpress_subscription_id = get_post_meta( get_the_ID(), '_pronamic_subscription_source_id', true ); |
||
|
Bug
introduced
by
|
|||
| 105 | |||
| 106 | $this->subscriptions_map[ $memberpress_subscription_id ] = get_post(); |
||
| 107 | } |
||
| 108 | |||
| 109 | wp_reset_postdata(); |
||
| 110 | } |
||
| 111 | |||
| 112 | return $this->subscriptions_map; |
||
| 113 | } |
||
| 204 |
Loading history...