WPSC_Digital_Contents_Table::fetch_items() - Code Metrics - Inspection of "Hide digital downloads if no sales (#2171)" - wp-e-commerce/WP-e-Commerce - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 09840a...ec6da7 )

by Justin

created 2016-11-22 23:21 UTC

WPSC_Digital_Contents_Table::fetch_items() B

↳ Parent: WPSC_Digital_Contents_Table

Complexity

Conditions	5
Paths	5

Size

Total Lines	62
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	32
nc	5
nop	0
dl	0
loc	62
rs	8.6652
c	0
b	0
f	0

How to fix Long Method

<?php

require_once( WPSC_TE_V2_CLASSES_PATH . '/table.php' );

class WPSC_Digital_Contents_Table extends WPSC_Table {

	public $per_page    = 10;
	public $offset      = 0;
	public $total_items = 0;
	private $digital_items;
	private static $instance;

	public static function get_instance() {
		if ( empty( self::$instance ) ) {
			self::$instance = new WPSC_Digital_Contents_Table();
		}

		return self::$instance;
	}

	public function fetch_items() {
		global $wpdb;

		$vars = array(
			WPSC_Purchase_Log::ACCEPTED_PAYMENT,
			WPSC_Purchase_Log::JOB_DISPATCHED,
			WPSC_Purchase_Log::CLOSED_ORDER,
			get_current_user_id(),
		);

		$sql = $wpdb->prepare( "
			SELECT
				d.*
			FROM " . WPSC_TABLE_DOWNLOAD_STATUS . " AS d
			INNER JOIN " . WPSC_TABLE_PURCHASE_LOGS . " AS p
			ON
				d.purchid = p.id
			WHERE
				d.active = 1 AND
				p.processed IN (%d, %d, %d) AND
				p.user_ID = %d
			ORDER BY p.id DESC
		", $vars );

		$downloadables = $wpdb->get_results( $sql );

		if ( empty( $downloadables ) ) {
			$this->digital_items = array();
			return;
		}
		
		$product_ids = wp_list_pluck( $downloadables, 'product_id' );
		$product_ids = array_unique( array_map( 'absint', $product_ids ) );
		$this->items = get_posts( array(
			'post_type' => 'wpsc-product',
			'post__in'  => $product_ids )
		);
		$this->total_items = count( $this->items );

		$this->digital_items = array();

		foreach ( $downloadables as $file ) {
			if ( ! in_array( $file->product_id, $product_ids ) ) {
				continue;
			}

			if ( ! array_key_exists( $file->product_id, $this->digital_items ) ) {
				$this->digital_items[ $file->product_id ] = array();
			}

			$this->digital_items[ $file->product_id ][] = $file;
		}

		// cache files
		$files = wp_list_pluck( $downloadables, 'fileid' );

		get_posts( array(
			'post_type' => 'wpsc-product-file',
			'post__in'  => $files,
		) );

	}

	public function __construct() {
		parent::__construct();

		$this->columns = array(
			'product'  => _x( 'Product', 'customer account - digital contents - table header', 'wp-e-commerce' ),
			'contents' => _x( 'Digital Contents', 'customer account - digital contents - table header', 'wp-e-commerce' ),
		);
	}

	public function column_product( $item ) {
?>
	<div class="wpsc-digital-product-title">
		<strong><a href="<?php wpsc_product_permalink( $item->ID ); ?>"><?php wpsc_product_title( '', '', $item->ID ); ?></a></strong>
	</div>
	<div class="wpsc-thumbnail wpsc-product-thumbnail">
		<?php if ( wpsc_has_product_thumbnail( $item->ID ) ): ?>
			<?php echo wpsc_get_product_thumbnail( $item->ID, 'cart' ); ?>
		<?php else: ?>
			<?php wpsc_product_no_thumbnail_image( 'cart' ); ?>
		<?php endif; ?>
	</div>
<?php
	}

	public function column_contents( $item ) {

		if ( empty( $this->digital_items ) ) {
			return;
		}

		echo '<div class="wpsc-digital-product-items">';
		echo '<ul>';
		foreach ( $this->digital_items[ $item->ID ] as $file ) {
			echo '<li>';
			$post = get_post( $file->fileid );
			if ( ! $post ) {
				echo '<em class="deleted">' . sprintf( __( 'File ID #%s has been removed.', 'wp-e-commerce' ), $file->id ) . '</em>';
				continue;
			}

			$file_name  = get_the_title( $file->fileid );
			$downloadid = empty( $file->uniqueid ) ? $file->id : $file->uniqueid;
			$url = add_query_arg( 'downloadid', $downloadid, home_url() );

			echo '<a href="' . esc_url( $url ) . '"">' . $file_name . '</a>';

			echo '</li>';
		}
		echo '</ul>';
		echo '</div>';
	}
}


1			<?php
2
3			require_once( WPSC_TE_V2_CLASSES_PATH . '/table.php' );
4
5			class WPSC_Digital_Contents_Table extends WPSC_Table {
6
7			public $per_page = 10;
8			public $offset = 0;
9			public $total_items = 0;
10			private $digital_items;
11			private static $instance;
12
13			public static function get_instance() {
14			if ( empty( self::$instance ) ) {
15			self::$instance = new WPSC_Digital_Contents_Table();
16			}
17
18			return self::$instance;
19			}
20
21			public function fetch_items() {
22			global $wpdb;
23
24			$vars = array(
25			WPSC_Purchase_Log::ACCEPTED_PAYMENT,
26			WPSC_Purchase_Log::JOB_DISPATCHED,
27			WPSC_Purchase_Log::CLOSED_ORDER,
28			get_current_user_id(),
29			);
30
31			$sql = $wpdb->prepare( "
32			SELECT
33			d.*
34			FROM " . WPSC_TABLE_DOWNLOAD_STATUS . " AS d
35			INNER JOIN " . WPSC_TABLE_PURCHASE_LOGS . " AS p
36			ON
37			d.purchid = p.id
38			WHERE
39			d.active = 1 AND
40			p.processed IN (%d, %d, %d) AND
41			p.user_ID = %d
42			ORDER BY p.id DESC
43			", $vars );
44
45			$downloadables = $wpdb->get_results( $sql );
46
47			if ( empty( $downloadables ) ) {
48			$this->digital_items = array();
49			return;
50			}
51
52			$product_ids = wp_list_pluck( $downloadables, 'product_id' );
53			$product_ids = array_unique( array_map( 'absint', $product_ids ) );
54			$this->items = get_posts( array(
55			'post_type' => 'wpsc-product',
56			'post__in' => $product_ids )
57			);
58			$this->total_items = count( $this->items );
59
60			$this->digital_items = array();
61
62			foreach ( $downloadables as $file ) {
63			if ( ! in_array( $file->product_id, $product_ids ) ) {
64			continue;
65			}
66
67			if ( ! array_key_exists( $file->product_id, $this->digital_items ) ) {
68			$this->digital_items[ $file->product_id ] = array();
69			}
70
71			$this->digital_items[ $file->product_id ][] = $file;
72			}
73
74			// cache files
75			$files = wp_list_pluck( $downloadables, 'fileid' );
76
77			get_posts( array(
78			'post_type' => 'wpsc-product-file',
79			'post__in' => $files,
80			) );
81
82			}
83
84			public function __construct() {
85			parent::__construct();
86
87			$this->columns = array(
88			'product' => _x( 'Product', 'customer account - digital contents - table header', 'wp-e-commerce' ),
89			'contents' => _x( 'Digital Contents', 'customer account - digital contents - table header', 'wp-e-commerce' ),
90			);
91			}
92
93			public function column_product( $item ) {
94			?>
95			<div class="wpsc-digital-product-title">
96			<strong><a href="<?php wpsc_product_permalink( $item->ID ); ?>"><?php wpsc_product_title( '', '', $item->ID ); ?></a></strong>
97			</div>
98			<div class="wpsc-thumbnail wpsc-product-thumbnail">
99			<?php if ( wpsc_has_product_thumbnail( $item->ID ) ): ?>
100			<?php echo wpsc_get_product_thumbnail( $item->ID, 'cart' ); ?>
101			<?php else: ?>
102			<?php wpsc_product_no_thumbnail_image( 'cart' ); ?>
103			<?php endif; ?>
104			</div>
105			<?php
106			}
107
108			public function column_contents( $item ) {
109
110			if ( empty( $this->digital_items ) ) {
111			return;
112			}
113
114			echo '<div class="wpsc-digital-product-items">';
115			echo '<ul>';
116			foreach ( $this->digital_items[ $item->ID ] as $file ) {
117			echo '<li>';
118			$post = get_post( $file->fileid );
119			if ( ! $post ) {
120			echo '<em class="deleted">' . sprintf( __( 'File ID #%s has been removed.', 'wp-e-commerce' ), $file->id ) . '</em>';
121			continue;
122			}
123
124			$file_name = get_the_title( $file->fileid );
125			$downloadid = empty( $file->uniqueid ) ? $file->id : $file->uniqueid;
126			$url = add_query_arg( 'downloadid', $downloadid, home_url() );
127
128			echo '<a href="' . esc_url( $url ) . '"">' . $file_name . '</a>';
129
130			echo '</li>';
131			}
132			echo '</ul>';
133			echo '</div>';
134			}
135			}
136

wp-e-commerce / WP-e-Commerce

Push — master ( 09840a...ec6da7 )

WPSC_Digital_Contents_Table::fetch_items() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like