wowstack / php-dbc-parser

src/Command/ExportCommand.php

<?php

declare(strict_types=1);

namespace Wowstack\Dbc\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Style\SymfonyStyle;
use Wowstack\Dbc\DBC;
use Wowstack\Dbc\Mapping;
use Wowstack\Dbc\Export\XMLExport;

/**
 * @codeCoverageIgnore
 */
class ExportCommand extends Command
{
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('dbc:export')
            ->setDescription('Dumps the contents of a DBC file.')
            ->setHelp('This command allows you to dump any DBC file using a file map.')
            ;

        $this
            ->addArgument('file', InputArgument::REQUIRED, 'Path to the DBC file')
            ->addArgument('map', InputArgument::REQUIRED, 'Path to the YAML map')
            ->addArgument('xml', InputArgument::REQUIRED, 'Where to create the XML dump')
            ;

        $this
            ->addOption(
                'client-version',
                null,
                InputOption::VALUE_REQUIRED,
                'WoW client version',
                '1.12.1'
            );
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $DBC = new DBC($input->getArgument('file'), Mapping::fromYAML($input->getArgument('map')));

It seems like $input->getArgument('map') can also be of type null and string[]; however, parameter $yaml of Wowstack\Dbc\Mapping::fromYAML() does only seem to accept string, maybe add an additional type check?

It seems like $input->getArgument('file') can also be of type null and string[]; however, parameter $path of Wowstack\Dbc\DBC::__construct() does only seem to accept string, maybe add an additional type check?

        $format = 'XML';

        $styledOutput = new SymfonyStyle($input, $output);
        $styledOutput->text([
            sprintf(
                'Dumping %s file contents in %s format to %s.',
                $DBC->getName(),
                $format,
                $input->getArgument('xml')

It seems like $input->getArgument('xml') can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            ),
            '',
        ]);

        $XMLExport = new XMLExport();
        $XMLExport->export($DBC, $input->getArgument('xml'), $input->getOption('client-version'));

It seems like $input->getArgument('xml') can also be of type null and string[]; however, parameter $targetPath of Wowstack\Dbc\Export\XMLExport::export() does only seem to accept string, maybe add an additional type check?

        foreach ($DBC->getErrors() as $error) {
            $output->writeln([
                '#'.$error['record'].' ('.$error['type'].'/'.$error['field'].'): '.$error['hint'],

Concat operator must be surrounded by a single space

            ]);
        }
    }
}