woshilapin / codingame-connector

src/codingame/parse.js

/**
 * @file Module 'codingame/parse'
 * @author woshilapin <woshilapin@tuziwo.info>
 */
/**
 * Parse response coming from Codingame's services
 * @module codingame/parse
 */
import CodingameError from './error.js';
import parse_frames from './parsers/frames.js';
import parse_failcompile from './parsers/failcompile.js';
import parse_failexpected from './parsers/failexpected.js';
import parse_success from './parsers/success.js';

let parsers = [];
parsers.push(parse_frames);
parsers.push(parse_failcompile);
parsers.push(parse_failexpected);
parsers.push(parse_success);

/**
 * Parse response coming from tests sent to Codingame website
 *
 * @name parse
 * @function
 * @param {Object} response Body of the response
 * @returns {Promise<Object|CodingameError>} Resolve if test is a success, reject with a CodingameError if test failed or parsing was impossible
 */
let parse = (response) => {
	let body = response.success;
	for (let parser of parsers) {
		try {
			let promise = parser.parse(body);
			return Promise.resolve(promise); // Resume loop if no Error has been thrown
		} catch (error) {
			continue;

This continue has no effect on the loop flow and can be removed.

		}
	}
	let message = `Unknown error. Codingame may have changed its API.  Please contact 'codingame-connector' developer.`;
	let error = new Error(message);

You are assigning a value to the catch variable error, thereby shadowing the original value.

The variable error already seems to be declared on line 35. Consider using another variable name or omitting the var keyword.

	return Promise.reject(error);
};

export default {
	"parse": parse
};