failexpected.js ➔ ??? - Code Metrics - Inspection of "style: change anonymous function into arrow functi..." - woshilapin/codingame-connector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e4da3f...33c5b3 )

by Jean

created 2017-07-06 20:38 UTC

failexpected.js ➔ ??? B

↳ Parent: src/codingame/parsers/failexpected.js

Complexity

Conditions	5
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	1
nop	1
dl	0
loc	22
rs	8.6737
c	0
b	0
f	0

/**
 * @file Module 'codingame/parsers/failexpected'
 * @author woshilapin <[email protected]>
 */
/**
 * Parse failed response from Codingame when test found a value different from the expected.
 *
 * The typical response in this case if of the following form.
 * ```json
 * {
 * 	"success": {
 * 		"output": '43',
 * 		"comparison": {
 * 			"success": false,
 * 			"found": '43',
 * 			"expected": '42'
 * 		}
 * 	}
 * }
 * ```
 * @module codingame/parsers/failexpected
 */
import CodingameError from '../error.js';

let name = `fail-expected`;

/**
 * Attempt to parse the body of a successful request to Codingame test API.
 * This function will try to map a response for a failed test because of a unexpected result for the test.
 *
 * @function parse
 * @param {Object} body Body of the response
 * @returns {Promise<CodingameError>} Reject with a CodingameError if parsing was successful
 * @throws {Error} Throw is parsing failed
 * @instance
 */
let parse = (body) => {
	try {
		let {
			"output": output,
			"comparison": {
				"success": success,
				"expected": expected,
				"found": found
			}
		} = body;
		if (!success && expected !== undefined && found !== undefined) {

			let error = new CodingameError(`Expected <${body.comparison.expected}> but found <${body.comparison.found}>`);
			return Promise.reject(error);
		} else {
			throw `Success value should be false when expected and found properties are provided`;
		}
	} catch (error) {
		let message = `The body is not of response type '${name}'\n`;
		message += error.message;
		throw new Error(message);
	}
};

export default {
	"name": name,
	"parse": parse
};


1			/**
2			* @file Module 'codingame/parsers/failexpected'
3			* @author woshilapin <[email protected]>
4			*/
5			/**
6			* Parse failed response from Codingame when test found a value different from the expected.
7			*
8			* The typical response in this case if of the following form.
9			* ```json
10			* {
11			* "success": {
12			* "output": '43',
13			* "comparison": {
14			* "success": false,
15			* "found": '43',
16			* "expected": '42'
17			* }
18			* }
19			* }
20			* ```
21			* @module codingame/parsers/failexpected
22			*/
23			import CodingameError from '../error.js';
24
25			let name = `fail-expected`;
26
27			/**
28			* Attempt to parse the body of a successful request to Codingame test API.
29			* This function will try to map a response for a failed test because of a unexpected result for the test.
30			*
31			* @function parse
32			* @param {Object} body Body of the response
33			* @returns {Promise<CodingameError>} Reject with a CodingameError if parsing was successful
34			* @throws {Error} Throw is parsing failed
35			* @instance
36			*/
37			let parse = (body) => {
38			try {
39			let {
40			"output": output,
41			"comparison": {
42			"success": success,
43			"expected": expected,
44			"found": found
45			}
46			} = body;
47			if (!success && expected !== undefined && found !== undefined) {
			0 ignored issues – show Comprehensibility Bug Compatibility introduced 2016-11-09 19:18 UTC by Report Bug Copy Issue Report Using `found !== undefined` to check if a variable is declared may throw an `Error`. Consider using `typeof {name} === "undefined"`instead. Loading history... Best Practice introduced 2016-11-09 19:18 UTC by Report Bug Copy Issue Report If you intend to check if the variable `success` is declared in the current environment, consider using `typeof success === "undefined"` instead. This is safe if the variable is not actually declared. Loading history... Comprehensibility Bug Compatibility introduced 2016-11-09 19:18 UTC by Report Bug Copy Issue Report Using `expected !== undefined` to check if a variable is declared may throw an `Error`. Consider using `typeof {name} === "undefined"`instead. Loading history...
48			let error = new CodingameError(`Expected <${body.comparison.expected}> but found <${body.comparison.found}>`);
49			return Promise.reject(error);
50			} else {
51			throw `Success value should be false when expected and found properties are provided`;
52			}
53			} catch (error) {
54			let message = `The body is not of response type '${name}'\n`;
55			message += error.message;
56			throw new Error(message);
57			}
58			};
59
60			export default {
61			"name": name,
62			"parse": parse
63			};
64

woshilapin / codingame-connector

Push — master ( e4da3f...33c5b3 )

failexpected.js ➔ ??? B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like