woshilapin / codingame-connector

test/utils.test.js

import chai from 'chai';
import chaiaspromised from 'chai-as-promised';
import mockfs from 'mock-fs';
import sinon from 'sinon';
import sinonchai from 'sinon-chai';
import mute from 'mute';

import cgapi from '../src/codingame-api.js';
import configure from '../src/configure.js';

import utils from '../src/utils.js';

let expect = chai.expect;
chai.use(chaiaspromised);
chai.use(sinonchai);

describe(`[module] utils`, function() {
	describe(`[method] kill`, function() {
		let exit;
		beforeEach(function() {
			exit = sinon.stub(process, `exit`);
		});
		afterEach(function() {
			exit.restore();
		});
		it(`should call process.exit with an negative value`, mute(function() {
			let message = `Some error message`;
			utils.kill(new Error(message));
			expect(exit).to.have.been.calledOnce;

The result of the property access to expect(exit).to.have.been.calledOnce is not used.

			expect(exit.getCall(0).args[0]).to.be.below(0);
		}));
	});
	describe(`[method] login`, function() {
		let sandbox;
		beforeEach(function() {
			sandbox = sinon.sandbox.create();
		})
		afterEach(function() {
			sandbox.restore();
		});
		it(`should resolve if login is successfull`, function() {
			let login = sinon.stub(cgapi, `login`, function() {return Promise.resolve(true)});
			let get = sinon.stub(configure, `get`, function(property) {return Promise.resolve(property);});
			let log = utils.login(`username`, `password`)
			let calls = log.then(function() {
				expect(login).to.have.been.calledOnce;

The result of the property access to expect(login).to.have.been.calledOnce is not used.

				expect(get).to.have.been.calledTwice;

The result of the property access to expect(get).to.have.been.calledTwice is not used.

				return Promise.resolve(true);
			});
			return Promise.all([
				expect(log).to.eventually.be.fullfilled,
				calls
			]);
		});
		it(`should reject after 3 tries if authentication failed`, mute(function() {
			login = sandbox.stub(cgapi, `login`, function() {

The variable login seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.login.

				return Promise.resolve({
					"error": new Error(`Cannot authenticate`)
				});
			});
			get = sandbox.stub(configure, `get`, function(property) {return Promise.resolve(property);});

The variable get seems to be never declared. Assigning variables without defining them first makes them global. If this was intended, consider making it explicit like using window.get.

			let log = utils.login(`username`, `password`)
			let calls = log.catch(function() {
				expect(login).to.have.been.calledThrice;

The result of the property access to expect(login).to.have.been.calledThrice is not used.

				return Promise.resolve(true);
			});
			return Promise.all([
				expect(log).to.eventually.be.rejected,
				calls
			]);
		}));
	});
	describe(`[method] tests`, function() {
	});
});