configure.test.js ➔ ... ➔ .question - Code Metrics - Inspection of "Sandboxing the use of Sinonjs" - woshilapin/codingame-connector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1cd4b4...40e33e )

by Jean

created 2016-11-03 23:16 UTC

configure.test.js ➔ ... ➔ .question A

↳ Parent: configure.test.js ➔ ... ➔ sandbox.stub

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	2
dl	0
loc	3
rs	10
c	0
b	0
f	0

import chai from 'chai';
import chaiaspromised from 'chai-as-promised';
import mockfs from 'mock-fs';
import sinon from 'sinon';
import sinonchai from 'sinon-chai';
import mute from 'mute';

import readline from 'readline';

import configure from '../src/configure.js';

let expect = chai.expect;
chai.use(chaiaspromised);
chai.use(sinonchai);

describe(`[module] configure`, function() {
	describe(`[method] load`, function() {
		let defaultconfpath = `.codingamerc`;
		let incorrectconfpath = `.codingamerc.txt`;
		let defaultconf = {
			"username": `me`,
			"password": `somepass`,
			"exercise": `5711567e959cf54dd2dd79c1b4c259560d6ba46`,
			"tests": [1, 2],
			"language": `Python`,
			"bundle": `bundle.py`
		};
		before(function() {
			mockfs({
				[defaultconfpath]: JSON.stringify(defaultconf),
				[incorrectconfpath]: `This is not valid JSON!`
			});
		});
		after(function() {
			mockfs.restore();
		});
		afterEach(function() {
			for (let param in defaultconf) {
				configure.forget(param);
			}
		});

		it(`should return the content of file parsed as JSON`, function() {
			let conf = configure.load(defaultconfpath);
			return expect(conf).to.eventually.be.deep.equal(defaultconf);
		});

		it(`should reject because of incorrect file path`, function() {
			let conf = configure.load(`/incorrect/path/.codingamerc`);
			return expect(conf).to.eventually.be.rejected;
		});

		it(`should reject because of incorrect parsing of JSON`, function() {
			let conf = configure.load(incorrectconfpath);
			return expect(conf).to.eventually.be.rejected;
		})

		it(`should return options if path is incorrect and options is defined`, function() {
			let conf = configure.load(undefined, defaultconf);
			return expect(conf).to.eventually.be.deep.equal(defaultconf);
		});
	});
	describe(`[method] get`, function() {
		let filepath = `file.txt`;
		let filecontent = `Hello world!`
		let shellcmd = [`echo`, filecontent];
		let defaultconf = {
			"shell": shellcmd,
			"wrongshell": [`notacommand`],
			"path": filepath,
			"notapath": `/not/a/path`
		};
		let answer = `42`;
		let createInterface;
		before(function(done) {
			mockfs({
				[filepath]: filecontent
			});
			configure.load(undefined, defaultconf).then(function() {
				done();
			})
		});
		after(function() {
			mockfs.restore();
			for (let param in defaultconf) {
				configure.forget(param);
			}
		});
		let sandbox;
		beforeEach(function() {
			sandbox = sinon.sandbox.create()
			createInterface = sandbox.stub(readline, 'createInterface', function() {
				return {
					"question": function(question, cb) {
						cb(answer);
					},
					"close": function() {}
				};
			});
		});
		afterEach(function() {
			sandbox.restore();
		});
		it(`should return the string property as it is`, function() {
			let get = configure.get(`path`);
			return expect(get).to.eventually.be.equal(filepath);
		});
		it(`should return the array property as it is`, function() {
			let get = configure.get(`shell`);
			return expect(get).to.eventually.be.deep.equal(shellcmd);
		});
		it(`should return the result of the shell command`, function() {
			let get = configure.get(`shell`, `shell`);
			return expect(get).to.eventually.be.deep.equal(filecontent);
		});
		it(`should return the content of the file`, function() {
			let get = configure.get(`path`, `file`);
			return expect(get).to.eventually.be.deep.equal({
				"path": filepath,
				"data": filecontent
			});
		});
		it(`should return answer to the question`, function() {
			let ask = `ask something?`;
			let get = configure.get(`questionproperty`, ``, ask);
			expect(createInterface).to.be.calledOnce;

			return expect(get).to.eventually.be.equal(answer);
		});
		it(`should reject because property doesn't exist`, function() {
			let get = configure.get(`notaproperty`);
			return expect(get).to.eventually.be.rejected;
		});
		it(`should reject if first parameter is not a string`, function() {
			let get = configure.get(42);
			return expect(get).to.eventually.be.rejected;
		});
		it(`should reject if shell command is failing`, function() {
			let get = configure.get(`wrongshell`, `shell`);
			return expect(get).to.eventually.be.rejected;
		});
		it(`should reject if file doesn't exist`, function() {
			let get = configure.get(`notapath`, `file`);
			return expect(get).to.eventually.be.rejected;
		});
		it(`should reject if question is not a string`, function() {
			let get = configure.get(`incorrectquestionproperty`, ``, 42);
			expect(createInterface).to.be.calledOnce;

			return expect(get).to.eventually.be.rejected;
		});
	});
	describe(`[method] forget`, function() {
		let conf = {
			"property": `value`
		};
		before(function() {
			configure.load(undefined, conf);
		})
		it(`should forget about the parameter`, function() {
			configure.forget(`property`);
			let get = configure.get(`property`);
			return expect(get).to.eventually.be.rejected;
		});
		it(`should throw an error when the property is not a string`, function() {
			try {
				configure.forget(null);
			} catch(error) {
				return expect(error).to.be.an('error');
			}
			return expect(false).to.be.ok;
		});
	});
});


1			import chai from 'chai';
2			import chaiaspromised from 'chai-as-promised';
3			import mockfs from 'mock-fs';
4			import sinon from 'sinon';
5			import sinonchai from 'sinon-chai';
6			import mute from 'mute';
7
8			import readline from 'readline';
9
10			import configure from '../src/configure.js';
11
12			let expect = chai.expect;
13			chai.use(chaiaspromised);
14			chai.use(sinonchai);
15
16			describe(`[module] configure`, function() {
17			describe(`[method] load`, function() {
18			let defaultconfpath = `.codingamerc`;
19			let incorrectconfpath = `.codingamerc.txt`;
20			let defaultconf = {
21			"username": `me`,
22			"password": `somepass`,
23			"exercise": `5711567e959cf54dd2dd79c1b4c259560d6ba46`,
24			"tests": [1, 2],
25			"language": `Python`,
26			"bundle": `bundle.py`
27			};
28			before(function() {
29			mockfs({
30			[defaultconfpath]: JSON.stringify(defaultconf),
31			[incorrectconfpath]: `This is not valid JSON!`
32			});
33			});
34			after(function() {
35			mockfs.restore();
36			});
37			afterEach(function() {
38			for (let param in defaultconf) {
39			configure.forget(param);
40			}
41			});
42
43			it(`should return the content of file parsed as JSON`, function() {
44			let conf = configure.load(defaultconfpath);
45			return expect(conf).to.eventually.be.deep.equal(defaultconf);
46			});
47
48			it(`should reject because of incorrect file path`, function() {
49			let conf = configure.load(`/incorrect/path/.codingamerc`);
50			return expect(conf).to.eventually.be.rejected;
51			});
52
53			it(`should reject because of incorrect parsing of JSON`, function() {
54			let conf = configure.load(incorrectconfpath);
55			return expect(conf).to.eventually.be.rejected;
56			})
57
58			it(`should return options if path is incorrect and options is defined`, function() {
59			let conf = configure.load(undefined, defaultconf);
60			return expect(conf).to.eventually.be.deep.equal(defaultconf);
61			});
62			});
63			describe(`[method] get`, function() {
64			let filepath = `file.txt`;
65			let filecontent = `Hello world!`
66			let shellcmd = [`echo`, filecontent];
67			let defaultconf = {
68			"shell": shellcmd,
69			"wrongshell": [`notacommand`],
70			"path": filepath,
71			"notapath": `/not/a/path`
72			};
73			let answer = `42`;
74			let createInterface;
75			before(function(done) {
76			mockfs({
77			[filepath]: filecontent
78			});
79			configure.load(undefined, defaultconf).then(function() {
80			done();
81			})
82			});
83			after(function() {
84			mockfs.restore();
85			for (let param in defaultconf) {
86			configure.forget(param);
87			}
88			});
89			let sandbox;
90			beforeEach(function() {
91			sandbox = sinon.sandbox.create()
92			createInterface = sandbox.stub(readline, 'createInterface', function() {
93			return {
94			"question": function(question, cb) {
95			cb(answer);
96			},
97			"close": function() {}
98			};
99			});
100			});
101			afterEach(function() {
102			sandbox.restore();
103			});
104			it(`should return the string property as it is`, function() {
105			let get = configure.get(`path`);
106			return expect(get).to.eventually.be.equal(filepath);
107			});
108			it(`should return the array property as it is`, function() {
109			let get = configure.get(`shell`);
110			return expect(get).to.eventually.be.deep.equal(shellcmd);
111			});
112			it(`should return the result of the shell command`, function() {
113			let get = configure.get(`shell`, `shell`);
114			return expect(get).to.eventually.be.deep.equal(filecontent);
115			});
116			it(`should return the content of the file`, function() {
117			let get = configure.get(`path`, `file`);
118			return expect(get).to.eventually.be.deep.equal({
119			"path": filepath,
120			"data": filecontent
121			});
122			});
123			it(`should return answer to the question`, function() {
124			let ask = `ask something?`;
125			let get = configure.get(`questionproperty`, ``, ask);
126			expect(createInterface).to.be.calledOnce;
			0 ignored issues – show introduced 2016-11-03 15:20 UTC by Report Bug Copy Issue Report The result of the property access to `expect(createInterface).to.be.calledOnce` is not used. Loading history...
127			return expect(get).to.eventually.be.equal(answer);
128			});
129			it(`should reject because property doesn't exist`, function() {
130			let get = configure.get(`notaproperty`);
131			return expect(get).to.eventually.be.rejected;
132			});
133			it(`should reject if first parameter is not a string`, function() {
134			let get = configure.get(42);
135			return expect(get).to.eventually.be.rejected;
136			});
137			it(`should reject if shell command is failing`, function() {
138			let get = configure.get(`wrongshell`, `shell`);
139			return expect(get).to.eventually.be.rejected;
140			});
141			it(`should reject if file doesn't exist`, function() {
142			let get = configure.get(`notapath`, `file`);
143			return expect(get).to.eventually.be.rejected;
144			});
145			it(`should reject if question is not a string`, function() {
146			let get = configure.get(`incorrectquestionproperty`, ``, 42);
147			expect(createInterface).to.be.calledOnce;
			0 ignored issues – show introduced 2016-11-03 15:20 UTC by Report Bug Copy Issue Report The result of the property access to `expect(createInterface).to.be.calledOnce` is not used. Loading history...
148			return expect(get).to.eventually.be.rejected;
149			});
150			});
151			describe(`[method] forget`, function() {
152			let conf = {
153			"property": `value`
154			};
155			before(function() {
156			configure.load(undefined, conf);
157			})
158			it(`should forget about the parameter`, function() {
159			configure.forget(`property`);
160			let get = configure.get(`property`);
161			return expect(get).to.eventually.be.rejected;
162			});
163			it(`should throw an error when the property is not a string`, function() {
164			try {
165			configure.forget(null);
166			} catch(error) {
167			return expect(error).to.be.an('error');
168			}
169			return expect(false).to.be.ok;
170			});
171			});
172			});
173

woshilapin / codingame-connector

Push — master ( 1cd4b4...40e33e )

configure.test.js ➔ ... ➔ .question A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like