ApplyController::actionIndex() - Code Metrics - Inspection of "Simplify+improve error handling." - workingconcept/lever-craft-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 31cd8d...f5f2bf )

by Matt

created 2019-01-11 08:02 UTC

ApplyController::actionIndex() B

↳ Parent: ApplyController

Complexity

Conditions	7
Paths	17

Size

Total Lines	63
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	34
nc	17
nop	0
dl	0
loc	63
rs	8.4426
c	0
b	0
f	0

How to fix Long Method

<?php
/**
 * Lever plugin for Craft CMS 3.x
 *
 * Craft + Lever.
 *
 * @link      https://workingconcept.com
 * @copyright Copyright (c) 2018 Working Concept Inc.
 */

namespace workingconcept\lever\controllers;

use workingconcept\lever\Lever;
use workingconcept\lever\models\LeverJobApplication;
use Craft;
use craft\web\Controller;
use yii\web\Response;
use yii\web\UploadedFile;

class ApplyController extends Controller
{
    // Public Properties
    // =========================================================================

    /**
     * @inheritdoc
     */
    public $allowAnonymous = true;


    // Public Methods
    // =========================================================================

    /**
     * Posts a job application.
     *
     * @return Response|null
     * @throws
     */
    public function actionIndex()
    {
        $this->requirePostRequest();

        $request = Craft::$app->getRequest();

        if ($jobId = $request->getParam('jobId'))
        {
            $resumeIncluded = ! empty($_FILES['resume']['tmp_name'])
                && ! empty($_FILES['resume']['name']);

            $application = new LeverJobApplication([
                'name'     => $request->getParam('name'),
                'email'    => $request->getParam('email'),
                'phone'    => $request->getParam('phone'),
                'org'      => $request->getParam('org'),
                'urls'     => $request->getParam('urls'),
                'comments' => $request->getParam('comments'),
                'ip'       => $request->getUserIP(),
                'silent'   => Lever::$plugin->getSettings()->applySilently,
                'source'   => Lever::$plugin->getSettings()->applicationSource,
            ]);

            if ($resumeIncluded)
            {
                $application->resume = UploadedFile::getInstanceByName('resume');
            }

            if (Lever::$plugin->api->applyForJob($jobId, $application))
            {
                if ($request->getAcceptsJson())
                {
                    return $this->asJson(['success' => true]);
                }

                Craft::$app->getSession()->setNotice('Application submitted.');

                return $this->redirectToPostedUrl();
            }

            if ($request->getAcceptsJson())
            {
                return $this->asJson(['errors' => $application->getErrors()]);
            }

            Craft::$app->getSession()->setError(Craft::t(
                'lever',
                'There was a problem with the application. Please check the form and try again!'
            ));

            Craft::$app->getUrlManager()->setRouteParams([
                'variables' => ['application' => $application]
            ]);

            return null;
        }

        Craft::$app->getSession()->setError(Craft::t(
            'lever',
            'Job ID missing.'
        ));

        return null;
    }

    /**
     * Capture a test post and save its data as a JSON file for troubleshooting.
     *
     * @return Response
     * @throws \yii\web\BadRequestHttpException
     */
    public function actionTest()
    {
        $this->requirePostRequest();

        if (Lever::$plugin->api->applyForJob(Craft::$app->getRequest()->getParam('jobId')))
        {
            file_put_contents('lever-application-test-' . time() . '.json', json_encode(Craft::$app->getRequest()->post()));

            return $this->asJson(Craft::$app->getRequest()->post());
        }

        return $this->asJson(Lever::$plugin->api->errors);
    }
}


1			<?php
2			/**
3			* Lever plugin for Craft CMS 3.x
4			*
5			* Craft + Lever.
6			*
7			* @link https://workingconcept.com
8			* @copyright Copyright (c) 2018 Working Concept Inc.
9			*/
10
11			namespace workingconcept\lever\controllers;
12
13			use workingconcept\lever\Lever;
14			use workingconcept\lever\models\LeverJobApplication;
15			use Craft;
16			use craft\web\Controller;
17			use yii\web\Response;
18			use yii\web\UploadedFile;
19
20			class ApplyController extends Controller
21			{
22			// Public Properties
23			// =========================================================================
24
25			/**
26			* @inheritdoc
27			*/
28			public $allowAnonymous = true;
29
30
31			// Public Methods
32			// =========================================================================
33
34			/**
35			* Posts a job application.
36			*
37			* @return Response\|null
38			* @throws
39			*/
40			public function actionIndex()
41			{
42			$this->requirePostRequest();
43
44			$request = Craft::$app->getRequest();
45
46			if ($jobId = $request->getParam('jobId'))
47			{
48			$resumeIncluded = ! empty($_FILES['resume']['tmp_name'])
49			&& ! empty($_FILES['resume']['name']);
50
51			$application = new LeverJobApplication([
52			'name' => $request->getParam('name'),
53			'email' => $request->getParam('email'),
54			'phone' => $request->getParam('phone'),
55			'org' => $request->getParam('org'),
56			'urls' => $request->getParam('urls'),
57			'comments' => $request->getParam('comments'),
58			'ip' => $request->getUserIP(),
59			'silent' => Lever::$plugin->getSettings()->applySilently,
60			'source' => Lever::$plugin->getSettings()->applicationSource,
61			]);
62
63			if ($resumeIncluded)
64			{
65			$application->resume = UploadedFile::getInstanceByName('resume');
66			}
67
68			if (Lever::$plugin->api->applyForJob($jobId, $application))
69			{
70			if ($request->getAcceptsJson())
71			{
72			return $this->asJson(['success' => true]);
73			}
74
75			Craft::$app->getSession()->setNotice('Application submitted.');
76
77			return $this->redirectToPostedUrl();
78			}
79
80			if ($request->getAcceptsJson())
81			{
82			return $this->asJson(['errors' => $application->getErrors()]);
83			}
84
85			Craft::$app->getSession()->setError(Craft::t(
86			'lever',
87			'There was a problem with the application. Please check the form and try again!'
88			));
89
90			Craft::$app->getUrlManager()->setRouteParams([
91			'variables' => ['application' => $application]
92			]);
93
94			return null;
95			}
96
97			Craft::$app->getSession()->setError(Craft::t(
98			'lever',
99			'Job ID missing.'
100			));
101
102			return null;
103			}
104
105			/**
106			* Capture a test post and save its data as a JSON file for troubleshooting.
107			*
108			* @return Response
109			* @throws \yii\web\BadRequestHttpException
110			*/
111			public function actionTest()
112			{
113			$this->requirePostRequest();
114
115			if (Lever::$plugin->api->applyForJob(Craft::$app->getRequest()->getParam('jobId')))
116			{
117			file_put_contents('lever-application-test-' . time() . '.json', json_encode(Craft::$app->getRequest()->post()));
118
119			return $this->asJson(Craft::$app->getRequest()->post());
120			}
121
122			return $this->asJson(Lever::$plugin->api->errors);
123			}
124			}
125

workingconcept / lever-craft-plugin

Push — master ( 31cd8d...f5f2bf )

ApplyController::actionIndex() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like