Issues in class-wc-order-refund.php (master) - Issues in master - woothemes/woocommerce - Measure and Improve Code Quality continuously with Scrutinizer

Issues (1182)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/class-wc-order-refund.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

if ( ! defined( 'ABSPATH' ) ) {
	exit; // Exit if accessed directly
}

/**
 * Order refund
 *
 * @class    WC_Order_Refund
 * @version  2.2.0
 * @package  WooCommerce/Classes
 * @category Class
 * @author   WooThemes
 */
class WC_Order_Refund extends WC_Abstract_Order {

	/** @public string Order type */
	public $order_type = 'refund';

	/** @var string Date */
	public $date;

	/** @var string Refund reason */
	public $reason;

	/**
	 * Init/load the refund object. Called from the constructor.
	 *
	 * @param  string|int|object|WC_Order_Refund $refund Refund to init
	 * @uses   WP_POST
	 */
	protected function init( $refund ) {

		if ( is_numeric( $refund ) ) {
			$this->id   = absint( $refund );
			$this->post = get_post( $refund );
			$this->get_refund( $this->id );
		} elseif ( $refund instanceof WC_Order_Refund ) {
			$this->id   = absint( $refund->id );
			$this->post = $refund->post;
			$this->get_refund( $this->id );
		} elseif ( isset( $refund->ID ) ) {
			$this->id   = absint( $refund->ID );
			$this->post = $refund;
			$this->get_refund( $this->id );
		}
	}

	/**
	 * Gets an refund from the database.
	 *
	 * @since 2.2
	 * @param int $id
	 * @return bool
	 */
	public function get_refund( $id = 0 ) {

		if ( ! $id ) {
			return false;
		}

		if ( $result = get_post( $id ) ) {
			$this->populate( $result );

			return true;
		}

		return false;
	}

	/**
	 * Populates an refund from the loaded post data.
	 *
	 * @param mixed $result
	 */
	public function populate( $result ) {
		// Standard post data
		$this->id            = $result->ID;
		$this->date          = $result->post_date;
		$this->modified_date = $result->post_modified;
		$this->reason        = $result->post_excerpt;
	}

	/**
	 * Get refunded amount.
	 *
	 * @since 2.2
	 * @return int|float
	 */
	public function get_refund_amount() {
		return apply_filters( 'woocommerce_refund_amount', (double) $this->refund_amount, $this );
	}

	/**
	 * Get formatted refunded amount.
	 *
	 * @since 2.4
	 * @return string
	 */
	public function get_formatted_refund_amount() {
		return apply_filters( 'woocommerce_formatted_refund_amount', wc_price( $this->refund_amount, array('currency' => $this->get_order_currency()) ), $this );
	}


	/**
	 * Get refunded amount.
	 *
	 * @since 2.2
	 * @return int|float
	 */
	public function get_refund_reason() {
		return apply_filters( 'woocommerce_refund_reason', $this->reason, $this );
	}
}


1		<?php
2
3		if ( ! defined( 'ABSPATH' ) ) {
4		exit; // Exit if accessed directly
5		}
6
7		/**
8		* Order refund
9		*
10		* @class WC_Order_Refund
11		* @version 2.2.0
12		* @package WooCommerce/Classes
13		* @category Class
14		* @author WooThemes
15		*/
16		class WC_Order_Refund extends WC_Abstract_Order {
17
18		/** @public string Order type */
19		public $order_type = 'refund';
20
21		/** @var string Date */
22		public $date;
23
24		/** @var string Refund reason */
25		public $reason;
26
27		/**
28		* Init/load the refund object. Called from the constructor.
29		*
30		* @param string\|int\|object\|WC_Order_Refund $refund Refund to init
31		* @uses WP_POST
32		*/
33	View Code Duplication	protected function init( $refund ) {
		0 ignored issues – show Duplication introduced 2015-11-21 02:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		if ( is_numeric( $refund ) ) {
35		$this->id = absint( $refund );
36		$this->post = get_post( $refund );
37		$this->get_refund( $this->id );
38		} elseif ( $refund instanceof WC_Order_Refund ) {
39		$this->id = absint( $refund->id );
40		$this->post = $refund->post;
41		$this->get_refund( $this->id );
42		} elseif ( isset( $refund->ID ) ) {
43		$this->id = absint( $refund->ID );
44		$this->post = $refund;
45		$this->get_refund( $this->id );
46		}
47		}
48
49		/**
50		* Gets an refund from the database.
51		*
52		* @since 2.2
53		* @param int $id
54		* @return bool
55		*/
56	View Code Duplication	public function get_refund( $id = 0 ) {
		0 ignored issues – show Duplication introduced 2015-11-21 02:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		if ( ! $id ) {
58		return false;
59		}
60
61		if ( $result = get_post( $id ) ) {
62		$this->populate( $result );
63
64		return true;
65		}
66
67		return false;
68		}
69
70		/**
71		* Populates an refund from the loaded post data.
72		*
73		* @param mixed $result
74		*/
75		public function populate( $result ) {
76		// Standard post data
77		$this->id = $result->ID;
78		$this->date = $result->post_date;
79		$this->modified_date = $result->post_modified;
80		$this->reason = $result->post_excerpt;
81		}
82
83		/**
84		* Get refunded amount.
85		*
86		* @since 2.2
87		* @return int\|float
88		*/
89		public function get_refund_amount() {
90		return apply_filters( 'woocommerce_refund_amount', (double) $this->refund_amount, $this );
91		}
92
93		/**
94		* Get formatted refunded amount.
95		*
96		* @since 2.4
97		* @return string
98		*/
99		public function get_formatted_refund_amount() {
100		return apply_filters( 'woocommerce_formatted_refund_amount', wc_price( $this->refund_amount, array('currency' => $this->get_order_currency()) ), $this );
101		}
102
103
104		/**
105		* Get refunded amount.
106		*
107		* @since 2.2
108		* @return int\|float
109		*/
110		public function get_refund_reason() {
111		return apply_filters( 'woocommerce_refund_reason', $this->reason, $this );
112		}
113		}
114

woothemes / woocommerce

Issues (1182)

Security Analysis not enabled

includes/class-wc-order-refund.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like