Issues (1182)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

api/class-wc-rest-report-sales-controller.php (5 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
/**
3
 * REST API Reports controller
4
 *
5
 * Handles requests to the reports/sales endpoint.
6
 *
7
 * @author   WooThemes
8
 * @category API
9
 * @package  WooCommerce/API
10
 * @since    2.6.0
11
 */
12
13
if ( ! defined( 'ABSPATH' ) ) {
14
	exit;
15
}
16
17
/**
18
 * REST API Report Sales controller class.
19
 *
20
 * @package WooCommerce/API
21
 * @extends WC_REST_Controller
22
 */
23
class WC_REST_Report_Sales_Controller extends WC_REST_Controller {
24
25
	/**
26
	 * Endpoint namespace.
27
	 *
28
	 * @var string
29
	 */
30
	protected $namespace = 'wc/v1';
31
32
	/**
33
	 * Route base.
34
	 *
35
	 * @var string
36
	 */
37
	protected $rest_base = 'reports/sales';
38
39
	/**
40
	 * Report instance.
41
	 *
42
	 * @var WC_Admin_Report
43
	 */
44
	protected $report;
45
46
	/**
47
	 * Register the routes for sales reports.
48
	 */
49 View Code Duplication
	public function register_routes() {
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
50
		register_rest_route( $this->namespace, '/' . $this->rest_base, array(
51
			array(
52
				'methods'             => WP_REST_Server::READABLE,
53
				'callback'            => array( $this, 'get_items' ),
54
				'permission_callback' => array( $this, 'get_items_permissions_check' ),
55
				'args'                => $this->get_collection_params(),
56
			),
57
			'schema' => array( $this, 'get_public_item_schema' ),
58
		) );
59
	}
60
61
	/**
62
	 * Check whether a given request has permission to read report.
63
	 *
64
	 * @param  WP_REST_Request $request Full details about the request.
65
	 * @return WP_Error|boolean
66
	 */
67 View Code Duplication
	public function get_items_permissions_check( $request ) {
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
68
		if ( ! wc_rest_check_manager_permissions( 'reports', 'read' ) ) {
69
			return new WP_Error( 'woocommerce_rest_cannot_view', __( 'Sorry, you cannot list resources.', 'woocommerce' ), array( 'status' => rest_authorization_required_code() ) );
70
		}
71
72
		return true;
73
	}
74
75
	/**
76
	 * Get sales reports.
77
	 *
78
	 * @param WP_REST_Request $request
79
	 * @return array|WP_Error
80
	 */
81
	public function get_items( $request ) {
82
		$data   = array();
83
		$item   = $this->prepare_item_for_response( null, $request );
84
		$data[] = $this->prepare_response_for_collection( $item );
85
86
		return rest_ensure_response( $data );
87
	}
88
89
	/**
90
	 * Prepare a report sales object for serialization.
91
	 *
92
	 * @param null $_
93
	 * @param WP_REST_Request $request Request object.
94
	 * @return WP_REST_Response $response Response data.
95
	 */
96
	public function prepare_item_for_response( $_, $request ) {
97
		// Set date filtering.
98
		$filter = array(
99
			'period'   => $request['period'],
100
			'date_min' => $request['date_min'],
101
			'date_max' => $request['date_max'],
102
		);
103
		$this->setup_report( $filter );
104
105
		// New customers.
106
		$users_query = new WP_User_Query(
107
			array(
108
				'fields' => array( 'user_registered' ),
109
				'role'   => 'customer',
110
			)
111
		);
112
113
		$customers = $users_query->get_results();
114
115
		foreach ( $customers as $key => $customer ) {
116
			if ( strtotime( $customer->user_registered ) < $this->report->start_date || strtotime( $customer->user_registered ) > $this->report->end_date ) {
117
				unset( $customers[ $key ] );
118
			}
119
		}
120
121
		$total_customers = count( $customers );
122
		$report_data     = $this->report->get_report_data();
0 ignored issues
show
It seems like you code against a specific sub-type and not the parent class WC_Admin_Report as the method get_report_data() does only exist in the following sub-classes of WC_Admin_Report: WC_Report_Sales_By_Date. Maybe you want to instanceof check for one of these explicitly?

Let’s take a look at an example:

abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break.

Available Fixes

  1. Change the type-hint for the parameter:

    class AuthSystem
    {
        public function authenticate(MyUser $user) { /* ... */ }
    }
    
  2. Add an additional type-check:

    class AuthSystem
    {
        public function authenticate(User $user)
        {
            if ($user instanceof MyUser) {
                $this->logger->info(/** ... */);
            }
    
            // or alternatively
            if ( ! $user instanceof MyUser) {
                throw new \LogicException(
                    '$user must be an instance of MyUser, '
                   .'other instances are not supported.'
                );
            }
    
        }
    }
    
Note: PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case.
  1. Add the method to the parent class:

    abstract class User
    {
        /** @return string */
        abstract public function getPassword();
    
        /** @return string */
        abstract public function getDisplayName();
    }
    
Loading history...
123
		$period_totals   = array();
124
125
		// Setup period totals by ensuring each period in the interval has data.
126
		for ( $i = 0; $i <= $this->report->chart_interval; $i++ ) {
127
128
			switch ( $this->report->chart_groupby ) {
129
				case 'day' :
130
					$time = date( 'Y-m-d', strtotime( "+{$i} DAY", $this->report->start_date ) );
131
					break;
132
				default :
133
					$time = date( 'Y-m', strtotime( "+{$i} MONTH", $this->report->start_date ) );
134
					break;
135
			}
136
137
			// Set the customer signups for each period.
138
			$customer_count = 0;
139
			foreach ( $customers as $customer ) {
140
				if ( date( ( 'day' == $this->report->chart_groupby ) ? 'Y-m-d' : 'Y-m', strtotime( $customer->user_registered ) ) == $time ) {
141
					$customer_count++;
142
				}
143
 			}
144
145
			$period_totals[ $time ] = array(
146
				'sales'     => wc_format_decimal( 0.00, 2 ),
147
				'orders'    => 0,
148
				'items'     => 0,
149
				'tax'       => wc_format_decimal( 0.00, 2 ),
150
				'shipping'  => wc_format_decimal( 0.00, 2 ),
151
				'discount'  => wc_format_decimal( 0.00, 2 ),
152
				'customers' => $customer_count,
153
			);
154
		}
155
156
		// add total sales, total order count, total tax and total shipping for each period
157
		foreach ( $report_data->orders as $order ) {
158
			$time = ( 'day' === $this->report->chart_groupby ) ? date( 'Y-m-d', strtotime( $order->post_date ) ) : date( 'Y-m', strtotime( $order->post_date ) );
159
160
			if ( ! isset( $period_totals[ $time ] ) ) {
161
				continue;
162
			}
163
164
			$period_totals[ $time ]['sales']    = wc_format_decimal( $order->total_sales, 2 );
165
			$period_totals[ $time ]['tax']      = wc_format_decimal( $order->total_tax + $order->total_shipping_tax, 2 );
166
			$period_totals[ $time ]['shipping'] = wc_format_decimal( $order->total_shipping, 2 );
167
		}
168
169
		foreach ( $report_data->order_counts as $order ) {
170
			$time = ( 'day' === $this->report->chart_groupby ) ? date( 'Y-m-d', strtotime( $order->post_date ) ) : date( 'Y-m', strtotime( $order->post_date ) );
171
172
			if ( ! isset( $period_totals[ $time ] ) ) {
173
				continue;
174
			}
175
176
			$period_totals[ $time ]['orders']   = (int) $order->count;
177
		}
178
179
		// Add total order items for each period.
180
		foreach ( $report_data->order_items as $order_item ) {
181
			$time = ( 'day' === $this->report->chart_groupby ) ? date( 'Y-m-d', strtotime( $order_item->post_date ) ) : date( 'Y-m', strtotime( $order_item->post_date ) );
182
183
			if ( ! isset( $period_totals[ $time ] ) ) {
184
				continue;
185
			}
186
187
			$period_totals[ $time ]['items'] = (int) $order_item->order_item_count;
188
		}
189
190
		// Add total discount for each period.
191
		foreach ( $report_data->coupons as $discount ) {
192
			$time = ( 'day' === $this->report->chart_groupby ) ? date( 'Y-m-d', strtotime( $discount->post_date ) ) : date( 'Y-m', strtotime( $discount->post_date ) );
193
194
			if ( ! isset( $period_totals[ $time ] ) ) {
195
				continue;
196
			}
197
198
			$period_totals[ $time ]['discount'] = wc_format_decimal( $discount->discount_amount, 2 );
199
		}
200
201
		$sales_data = array(
202
			'total_sales'       => $report_data->total_sales,
203
			'net_sales'         => $report_data->net_sales,
204
			'average_sales'     => $report_data->average_sales,
205
			'total_orders'      => $report_data->total_orders,
206
			'total_items'       => $report_data->total_items,
207
			'total_tax'         => wc_format_decimal( $report_data->total_tax + $report_data->total_shipping_tax, 2 ),
208
			'total_shipping'    => $report_data->total_shipping,
209
			'total_refunds'     => $report_data->total_refunds,
210
			'total_discount'    => $report_data->total_coupons,
211
			'totals_grouped_by' => $this->report->chart_groupby,
212
			'totals'            => $period_totals,
213
			'total_customers'   => $total_customers,
214
		);
215
216
		$context = ! empty( $request['context'] ) ? $request['context'] : 'view';
217
		$data    = $this->add_additional_fields_to_object( $sales_data, $request );
218
		$data    = $this->filter_response_by_context( $data, $context );
219
220
		// Wrap the data in a response object.
221
		$response = rest_ensure_response( $data );
222
		$response->add_links( array(
223
			'about' => array(
224
				'href' => rest_url( sprintf( '%s/reports', $this->namespace ) ),
225
			),
226
		) );
227
228
		/**
229
		 * Filter a report sales returned from the API.
230
		 *
231
		 * Allows modification of the report sales data right before it is returned.
232
		 *
233
		 * @param WP_REST_Response $response The response object.
234
		 * @param stdClass         $data     The original report object.
235
		 * @param WP_REST_Request  $request  Request used to generate the response.
236
		 */
237
		return apply_filters( 'woocommerce_rest_prepare_report_sales', $response, (object) $sales_data, $request );
238
	}
239
240
	/**
241
	 * Setup the report object and parse any date filtering.
242
	 *
243
	 * @param array $filter date filtering
244
	 */
245
	protected function setup_report( $filter ) {
246
		include_once( WC()->plugin_path() . '/includes/admin/reports/class-wc-admin-report.php' );
247
		include_once( WC()->plugin_path() . '/includes/admin/reports/class-wc-report-sales-by-date.php' );
248
249
		$this->report = new WC_Report_Sales_By_Date();
250
251
		if ( empty( $filter['period'] ) ) {
252
253
			// Custom date range.
254
			$filter['period'] = 'custom';
255
256 View Code Duplication
			if ( ! empty( $filter['date_min'] ) || ! empty( $filter['date_max'] ) ) {
0 ignored issues
show
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
257
258
				// Overwrite _GET to make use of WC_Admin_Report::calculate_current_range() for custom date ranges.
259
				$_GET['start_date'] = $filter['date_min'];
260
				$_GET['end_date'] = isset( $filter['date_max'] ) ? $filter['date_max'] : null;
261
262
			} else {
263
264
				// Default custom range to today.
265
				$_GET['start_date'] = $_GET['end_date'] = date( 'Y-m-d', current_time( 'timestamp' ) );
266
			}
267
268
		} else {
269
270
			$filter['period'] = empty( $filter['period'] ) ? 'week' : $filter['period'];
271
272
			// Change "week" period to "7day".
273
			if ( 'week' === $filter['period'] ) {
274
				$filter['period'] = '7day';
275
			}
276
		}
277
278
		$this->report->calculate_current_range( $filter['period'] );
279
	}
280
281
	/**
282
	 * Get the Report's schema, conforming to JSON Schema.
283
	 *
284
	 * @return array
285
	 */
286 View Code Duplication
	public function get_item_schema() {
0 ignored issues
show
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
287
		$schema = array(
288
			'$schema'    => 'http://json-schema.org/draft-04/schema#',
289
			'title'      => 'sales_report',
290
			'type'       => 'object',
291
			'properties' => array(
292
				'total_sales' => array(
293
					'description' => __( 'Gross sales in the period.', 'woocommerce' ),
294
					'type'        => 'string',
295
					'context'     => array( 'view' ),
296
					'readonly'    => true,
297
				),
298
				'net_sales' => array(
299
					'description' => __( 'Net sales in the period.', 'woocommerce' ),
300
					'type'        => 'string',
301
					'context'     => array( 'view' ),
302
					'readonly'    => true,
303
				),
304
				'average_sales' => array(
305
					'description' => __( 'Average net daily sales.', 'woocommerce' ),
306
					'type'        => 'string',
307
					'context'     => array( 'view' ),
308
					'readonly'    => true,
309
				),
310
				'total_orders' => array(
311
					'description' => __( 'Total of orders placed.', 'woocommerce' ),
312
					'type'        => 'integer',
313
					'context'     => array( 'view' ),
314
					'readonly'    => true,
315
				),
316
				'total_items' => array(
317
					'description' => __( 'Total of items purchased.', 'woocommerce' ),
318
					'type'        => 'integer',
319
					'context'     => array( 'view' ),
320
					'readonly'    => true,
321
				),
322
				'total_tax' => array(
323
					'description' => __( 'Total charged for taxes.', 'woocommerce' ),
324
					'type'        => 'string',
325
					'context'     => array( 'view' ),
326
					'readonly'    => true,
327
				),
328
				'total_shipping' => array(
329
					'description' => __( 'Total charged for shipping.', 'woocommerce' ),
330
					'type'        => 'string',
331
					'context'     => array( 'view' ),
332
					'readonly'    => true,
333
				),
334
				'total_refunds' => array(
335
					'description' => __( 'Total of refunded orders.', 'woocommerce' ),
336
					'type'        => 'integer',
337
					'context'     => array( 'view' ),
338
					'readonly'    => true,
339
				),
340
				'total_discount' => array(
341
					'description' => __( 'Total of coupons used.', 'woocommerce' ),
342
					'type'        => 'integer',
343
					'context'     => array( 'view' ),
344
					'readonly'    => true,
345
				),
346
				'totals_grouped_by' => array(
347
					'description' => __( 'Group type.', 'woocommerce' ),
348
					'type'        => 'string',
349
					'context'     => array( 'view' ),
350
					'readonly'    => true,
351
				),
352
				'totals' => array(
353
					'description' => __( 'Totals.', 'woocommerce' ),
354
					'type'        => 'array',
355
					'context'     => array( 'view' ),
356
					'readonly'    => true,
357
				),
358
			),
359
		);
360
361
		return $this->add_additional_fields_schema( $schema );
362
	}
363
364
	/**
365
	 * Get the query params for collections.
366
	 *
367
	 * @return array
368
	 */
369
	public function get_collection_params() {
370
		return array(
371
			'context' => $this->get_context_param( array( 'default' => 'view' ) ),
372
			'period' => array(
373
				'description'       => __( 'Report period.', 'woocommerce' ),
374
				'type'              => 'string',
375
				'enum'              => array( 'week', 'month', 'last_month', 'year' ),
376
				'validate_callback' => 'rest_validate_request_arg',
377
				'sanitize_callback' => 'sanitize_text_field',
378
			),
379
			'date_min' => array(
380
				'description'       => sprintf( __( 'Return sales for a specific start date, the date need to be in the %s format.', 'woocommerce' ), 'YYYY-MM-AA' ),
381
				'type'              => 'string',
382
				'format'            => 'date',
383
				'validate_callback' => 'wc_rest_validate_reports_request_arg',
384
				'sanitize_callback' => 'sanitize_text_field',
385
			),
386
			'date_max' => array(
387
				'description'       => sprintf( __( 'Return sales for a specific end date, the date need to be in the %s format.', 'woocommerce' ), 'YYYY-MM-AA' ),
388
				'type'              => 'string',
389
				'format'            => 'date',
390
				'validate_callback' => 'wc_rest_validate_reports_request_arg',
391
				'sanitize_callback' => 'sanitize_text_field',
392
			),
393
		);
394
	}
395
}
396