woothemes /
woocommerce
| Conditions | 47 |
| Paths | 146 |
| Total Lines | 74 |
| Code Lines | 47 |
| Lines | 28 |
| Ratio | 37.84 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 159 | function rest_validate_request_arg( $value, $request, $param ) { |
||
| 160 | |||
| 161 | $attributes = $request->get_attributes(); |
||
| 162 | if ( ! isset( $attributes['args'][ $param ] ) || ! is_array( $attributes['args'][ $param ] ) ) { |
||
| 163 | return true; |
||
| 164 | } |
||
| 165 | $args = $attributes['args'][ $param ]; |
||
| 166 | |||
| 167 | View Code Duplication | if ( ! empty( $args['enum'] ) ) { |
|
| 168 | if ( ! in_array( $value, $args['enum'] ) ) { |
||
| 169 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s is not one of %s', 'woocommerce' ), $param, implode( ', ', $args['enum'] ) ) ); |
||
| 170 | } |
||
| 171 | } |
||
| 172 | |||
| 173 | if ( 'integer' === $args['type'] && ! is_numeric( $value ) ) { |
||
| 174 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s is not of type %s', 'woocommerce' ), $param, 'integer' ) ); |
||
| 175 | } |
||
| 176 | |||
| 177 | View Code Duplication | if ( 'string' === $args['type'] && ! is_string( $value ) ) { |
|
| 178 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s is not of type %s', 'woocommerce' ), $param, 'string' ) ); |
||
| 179 | } |
||
| 180 | |||
| 181 | View Code Duplication | if ( isset( $args['format'] ) ) { |
|
| 182 | switch ( $args['format'] ) { |
||
| 183 | case 'date-time' : |
||
| 184 | if ( ! rest_parse_date( $value ) ) { |
||
| 185 | return new WP_Error( 'rest_invalid_date', __( 'The date you provided is invalid.', 'woocommerce' ) ); |
||
| 186 | } |
||
| 187 | break; |
||
| 188 | |||
| 189 | case 'email' : |
||
| 190 | if ( ! is_email( $value ) ) { |
||
| 191 | return new WP_Error( 'rest_invalid_email', __( 'The email address you provided is invalid.', 'woocommerce' ) ); |
||
| 192 | } |
||
| 193 | break; |
||
| 194 | } |
||
| 195 | } |
||
| 196 | |||
| 197 | if ( in_array( $args['type'], array( 'numeric', 'integer' ) ) && ( isset( $args['minimum'] ) || isset( $args['maximum'] ) ) ) { |
||
| 198 | if ( isset( $args['minimum'] ) && ! isset( $args['maximum'] ) ) { |
||
| 199 | View Code Duplication | if ( ! empty( $args['exclusiveMinimum'] ) && $value <= $args['minimum'] ) { |
|
| 200 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be greater than %d (exclusive)', 'woocommerce' ), $param, $args['minimum'] ) ); |
||
| 201 | } else if ( empty( $args['exclusiveMinimum'] ) && $value < $args['minimum'] ) { |
||
| 202 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be greater than %d (inclusive)', 'woocommerce' ), $param, $args['minimum'] ) ); |
||
| 203 | } |
||
| 204 | } else if ( isset( $args['maximum'] ) && ! isset( $args['minimum'] ) ) { |
||
| 205 | View Code Duplication | if ( ! empty( $args['exclusiveMaximum'] ) && $value >= $args['maximum'] ) { |
|
| 206 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be less than %d (exclusive)', 'woocommerce' ), $param, $args['maximum'] ) ); |
||
| 207 | } else if ( empty( $args['exclusiveMaximum'] ) && $value > $args['maximum'] ) { |
||
| 208 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be less than %d (inclusive)', 'woocommerce' ), $param, $args['maximum'] ) ); |
||
| 209 | } |
||
| 210 | } else if ( isset( $args['maximum'] ) && isset( $args['minimum'] ) ) { |
||
| 211 | if ( ! empty( $args['exclusiveMinimum'] ) && ! empty( $args['exclusiveMaximum'] ) ) { |
||
| 212 | if ( $value >= $args['maximum'] || $value <= $args['minimum'] ) { |
||
| 213 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be between %d (exclusive) and %d (exclusive)', 'woocommerce' ), $param, $args['minimum'], $args['maximum'] ) ); |
||
| 214 | } |
||
| 215 | View Code Duplication | } else if ( empty( $args['exclusiveMinimum'] ) && ! empty( $args['exclusiveMaximum'] ) ) { |
|
| 216 | if ( $value >= $args['maximum'] || $value < $args['minimum'] ) { |
||
| 217 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be between %d (inclusive) and %d (exclusive)', 'woocommerce' ), $param, $args['minimum'], $args['maximum'] ) ); |
||
| 218 | } |
||
| 219 | } else if ( ! empty( $args['exclusiveMinimum'] ) && empty( $args['exclusiveMaximum'] ) ) { |
||
| 220 | if ( $value > $args['maximum'] || $value <= $args['minimum'] ) { |
||
| 221 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be between %d (exclusive) and %d (inclusive)', 'woocommerce' ), $param, $args['minimum'], $args['maximum'] ) ); |
||
| 222 | } |
||
| 223 | } else if ( empty( $args['exclusiveMinimum'] ) && empty( $args['exclusiveMaximum'] ) ) { |
||
| 224 | if ( $value > $args['maximum'] || $value < $args['minimum'] ) { |
||
| 225 | return new WP_Error( 'rest_invalid_param', sprintf( __( '%s must be between %d (inclusive) and %d (inclusive)', 'woocommerce' ), $param, $args['minimum'], $args['maximum'] ) ); |
||
| 226 | } |
||
| 227 | } |
||
| 228 | } |
||
| 229 | } |
||
| 230 | |||
| 231 | return true; |
||
| 232 | } |
||
| 233 | } |
||
| 276 |
Loading history...
This check looks for functions that have already been defined in other files.
Some Codebases, like WordPress, make a practice of defining functions multiple times. This may lead to problems with the detection of function parameters and types. If you really need to do this, you can mark the duplicate definition with the
@ignoreannotation.See also the PhpDoc documentation for @ignore.