Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like WC_Shipping_Method often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use WC_Shipping_Method, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
18 | abstract class WC_Shipping_Method extends WC_Settings_API { |
||
19 | |||
20 | /** |
||
21 | * Features this method supports. Possible features used by core: |
||
22 | * - shipping-zones Shipping zone functionality + instances |
||
23 | * - instance-settings Instance settings screens. |
||
24 | * - settings Non-instance settings screens. Enabled by default for BW compatibility with methods before instances existed. |
||
25 | * @var array |
||
26 | */ |
||
27 | public $supports = array( 'settings' ); |
||
28 | |||
29 | /** |
||
30 | * Unique ID for the shipping method - must be set. |
||
31 | * @var string |
||
32 | */ |
||
33 | public $id = ''; |
||
34 | |||
35 | /** |
||
36 | * Method title. |
||
37 | * @var string |
||
38 | */ |
||
39 | public $method_title = ''; |
||
40 | |||
41 | /** |
||
42 | * Method description. |
||
43 | * @var string |
||
44 | */ |
||
45 | public $method_description = ''; |
||
46 | |||
47 | /** |
||
48 | * yes or no based on whether the method is enabled. |
||
49 | * @var string |
||
50 | */ |
||
51 | public $enabled = 'yes'; |
||
52 | |||
53 | /** |
||
54 | * Shipping method title for the frontend. |
||
55 | * @var string |
||
56 | */ |
||
57 | public $title; |
||
58 | |||
59 | /** |
||
60 | * This is an array of rates - methods must populate this array to register shipping costs. |
||
61 | * @var array |
||
62 | */ |
||
63 | public $rates = array(); |
||
64 | |||
65 | /** |
||
66 | * If 'taxable' tax will be charged for this method (if applicable). |
||
67 | * @var string |
||
68 | */ |
||
69 | public $tax_status = 'taxable'; |
||
70 | |||
71 | /** |
||
72 | * Fee for the method (if applicable). |
||
73 | * @var string |
||
74 | */ |
||
75 | public $fee = null; |
||
76 | |||
77 | /** @var float Minimum fee for the method */ |
||
78 | /** |
||
79 | * Minimum fee for the method (if applicable). |
||
80 | * @var string |
||
81 | */ |
||
82 | public $minimum_fee = null; |
||
83 | |||
84 | /** |
||
85 | * Instance ID if used. |
||
86 | * @var int |
||
87 | */ |
||
88 | public $instance_id = 0; |
||
89 | |||
90 | /** |
||
91 | * Instance form fields. |
||
92 | * @var array |
||
93 | */ |
||
94 | public $instance_form_fields = array(); |
||
95 | |||
96 | /** |
||
97 | * Instance settings. |
||
98 | * @var array |
||
99 | */ |
||
100 | public $instance_settings = array(); |
||
101 | |||
102 | /** |
||
103 | * Availability - legacy. Used for method Availability. |
||
104 | * No longer useful for instance based shipping methods. |
||
105 | * @deprecated 2.6.0 |
||
106 | * @var string |
||
107 | */ |
||
108 | public $availability; |
||
109 | |||
110 | /** |
||
111 | * Availability countries - legacy. Used for method Availability. |
||
112 | * No longer useful for instance based shipping methods. |
||
113 | * @deprecated 2.6.0 |
||
114 | * @var string |
||
115 | */ |
||
116 | public $countries = array(); |
||
117 | |||
118 | /** |
||
119 | * Constructor. |
||
120 | * @param int $instance_id |
||
121 | */ |
||
122 | public function __construct( $instance_id = 0 ) { |
||
125 | |||
126 | /** |
||
127 | * Check if a shipping method supports a given feature. |
||
128 | * |
||
129 | * Methods should override this to declare support (or lack of support) for a feature. |
||
130 | * |
||
131 | * @param $feature string The name of a feature to test support for. |
||
132 | * @return bool True if the shipping method supports the feature, false otherwise. |
||
133 | */ |
||
134 | public function supports( $feature ) { |
||
137 | |||
138 | /** |
||
139 | * Called to calculate shipping rates for this method. Rates can be added using the add_rate() method. |
||
140 | */ |
||
141 | public function calculate_shipping() {} |
||
142 | |||
143 | /** |
||
144 | * Whether or not we need to calculate tax on top of the shipping rate. |
||
145 | * @return boolean |
||
146 | */ |
||
147 | public function is_taxable() { |
||
150 | |||
151 | /** |
||
152 | * Whether or not this method is enabled in settings. |
||
153 | * @since 2.6.0 |
||
154 | * @return boolean |
||
155 | */ |
||
156 | public function is_enabled() { |
||
159 | |||
160 | /** |
||
161 | * Return the shipping method instance ID. |
||
162 | * @since 2.6.0 |
||
163 | * @return int |
||
164 | */ |
||
165 | public function get_instance_id() { |
||
168 | |||
169 | /** |
||
170 | * Return the shipping method title. |
||
171 | * @since 2.6.0 |
||
172 | * @return string |
||
173 | */ |
||
174 | public function get_method_title() { |
||
177 | |||
178 | /** |
||
179 | * Return the shipping method description. |
||
180 | * @since 2.6.0 |
||
181 | * @return string |
||
182 | */ |
||
183 | public function get_method_description() { |
||
186 | |||
187 | /** |
||
188 | * Return the shipping title which is user set. |
||
189 | * |
||
190 | * @return string |
||
191 | */ |
||
192 | public function get_title() { |
||
195 | |||
196 | /** |
||
197 | * Return calculated rates for a package. |
||
198 | * @since 2.6.0 |
||
199 | * @param object $package |
||
200 | * @return array |
||
201 | */ |
||
202 | public function get_rates_for_package( $package ) { |
||
209 | |||
210 | /** |
||
211 | * Add a shipping rate. If taxes are not set they will be calculated based on cost. |
||
212 | * @param array $args (default: array()) |
||
213 | */ |
||
214 | public function add_rate( $args = array() ) { |
||
239 | |||
240 | /** |
||
241 | * Calc taxes per item being shipping in costs array. |
||
242 | * @since 2.6.0 |
||
243 | * @access protected |
||
244 | * @param array $costs |
||
245 | * @return array of taxes |
||
246 | */ |
||
247 | protected function get_taxes_per_item( $costs ) { |
||
281 | |||
282 | /** |
||
283 | * Is this method available? |
||
284 | * @param array $package |
||
285 | * @return bool |
||
286 | */ |
||
287 | public function is_available( $package ) { |
||
310 | |||
311 | /** |
||
312 | * Get fee to add to shipping cost. |
||
313 | * @param string|float $fee |
||
314 | * @param float $total |
||
315 | * @return float |
||
316 | */ |
||
317 | public function get_fee( $fee, $total ) { |
||
326 | |||
327 | /** |
||
328 | * Does this method have a settings page? |
||
329 | * @return bool |
||
330 | */ |
||
331 | public function has_settings() { |
||
334 | |||
335 | /** |
||
336 | * Output the shipping settings screen. |
||
337 | */ |
||
338 | public function admin_options() { |
||
348 | |||
349 | /** |
||
350 | * get_option function. |
||
351 | * |
||
352 | * Gets and option from the settings API, using defaults if necessary to prevent undefined notices. |
||
353 | * |
||
354 | * @param string $key |
||
355 | * @param mixed $empty_value |
||
356 | * @return mixed The value specified for the option or a default value for the option. |
||
357 | */ |
||
358 | public function get_option( $key, $empty_value = null ) { |
||
367 | |||
368 | /** |
||
369 | * Gets an option from the settings API, using defaults if necessary to prevent undefined notices. |
||
370 | * |
||
371 | * @param string $key |
||
372 | * @param mixed $empty_value |
||
373 | * @return mixed The value specified for the option or a default value for the option. |
||
374 | */ |
||
375 | View Code Duplication | public function get_instance_option( $key, $empty_value = null ) { |
|
392 | |||
393 | /** |
||
394 | * Get settings fields for instances of this shipping method (within zones). |
||
395 | * Should be overridden by shipping methods to add options. |
||
396 | * @since 2.6.0 |
||
397 | * @return array |
||
398 | */ |
||
399 | public function get_instance_form_fields() { |
||
402 | |||
403 | /** |
||
404 | * Return the name of the option in the WP DB. |
||
405 | * @since 2.6.0 |
||
406 | * @return string |
||
407 | */ |
||
408 | public function get_instance_option_key() { |
||
411 | |||
412 | /** |
||
413 | * Initialise Settings for instances. |
||
414 | * @since 2.6.0 |
||
415 | */ |
||
416 | View Code Duplication | public function init_instance_settings() { |
|
425 | |||
426 | /** |
||
427 | * Processes and saves options. |
||
428 | * If there is an error thrown, will continue to save and validate fields, but will leave the erroring field out. |
||
429 | * @since 2.6.0 |
||
430 | * @return bool was anything saved? |
||
431 | */ |
||
432 | public function process_admin_options() { |
||
451 | } |
||
452 |
The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.
The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.
To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.