WC_Shipping_Zones::delete_zone() - Code Metrics - Inspection of "Shipping zones" - woothemes/woocommerce - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9826)

by Mike

created 2015-12-15 16:24 UTC

WC_Shipping_Zones::delete_zone() A

↳ Parent: WC_Shipping_Zones

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	6
rs	9.4286
cc	1
eloc	5
nc	1
nop	1

<?php


if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Handles storage and retrieval of shipping zones
 *
 * @class 		WC_Shipping_Zones
 * @since 		2.6.0
 * @version		2.6.0
 * @package		WooCommerce/Classes
 * @category	Class
 * @author 		WooThemes
 */
class WC_Shipping_Zones {

	/**
	 * Get shipping zones from the database
	 * @since 2.6.0
	 * @return array of arrays
	 */
    public static function get_zones() {
		global $wpdb;

        $raw_zones = $wpdb->get_results( "SELECT zone_id, zone_name, zone_order FROM {$wpdb->prefix}woocommerce_shipping_zones order by zone_order ASC;" );
		$zones     = array();

		foreach ( $raw_zones as $raw_zone ) {
			$zone                                                     = new WC_Shipping_Zone( $raw_zone );
			$zones[ $zone->get_zone_id() ]                            = $zone->get_data();
			$zones[ $zone->get_zone_id() ]['formatted_zone_location'] = $zone->get_formatted_location();
			$zones[ $zone->get_zone_id() ]['shipping_methods']        = $zone->get_shipping_methods();
		}

		return $zones;
    }

	/**
	 * Get shipping zone using it's ID
	 * @since 2.6.0
	 * @param int $zone_id
	 * @return WC_Shipping_Zone|bool
	 */
	public static function get_zone( $zone_id ) {
		return self::get_zone_by( 'zone_id', $zone_id );
	}

	/**
	 * Get shipping zone by an ID.
	 * @since 2.6.0
	 * @param string $by zone_id or instance_id
	 * @param int $id
	 * @return WC_Shipping_Zone|bool
	 */
	public static function get_zone_by( $by = 'zone_id', $id = 0 ) {
		global $wpdb;

		switch ( $by ) {
			case 'zone_id' :
				$raw_zone = $wpdb->get_row( $wpdb->prepare( "SELECT zone_id, zone_name, zone_order FROM {$wpdb->prefix}woocommerce_shipping_zones WHERE zone_id = %d LIMIT 1;", $id ) );
			break;
			case 'instance_id' :
				$raw_zone = $wpdb->get_row( $wpdb->prepare( "
					SELECT zones.zone_id, zones.zone_name, zones.zone_order FROM {$wpdb->prefix}woocommerce_shipping_zones as zones
					LEFT JOIN {$wpdb->prefix}woocommerce_shipping_zone_methods as methods ON zones.zone_id = methods.zone_id
					WHERE methods.instance_id = %d LIMIT 1;
					", $id ) );
			break;
			default :
				$raw_zone = false;
			break;
		}

		return $raw_zone ? new WC_Shipping_Zone( $raw_zone ) : false;
	}

	/**
	 * Get shipping zone using it's ID
	 * @since 2.6.0
	 * @param int $zone_id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return WC_Shipping_Meethod|bool
	 */
	public static function get_shipping_method( $instance_id ) {
		global $wpdb;
        $raw_shipping_method = $wpdb->get_row( $wpdb->prepare( "SELECT instance_id, method_id FROM {$wpdb->prefix}woocommerce_shipping_zone_methods WHERE instance_id = %d LIMIT 1;", $instance_id ) );
		$wc_shipping         = WC_Shipping::instance();
		$allowed_classes     = $wc_shipping->get_shipping_method_class_names();

		if ( in_array( $raw_shipping_method->method_id, array_keys( $allowed_classes ) ) ) {

			$class_name = $allowed_classes[ $raw_shipping_method->method_id ];
			return new $class_name( $raw_shipping_method->instance_id );
		}
		return false;
	}

	/**
	 * Delete a zone using it's ID
	 * @param int $zone_id
	 * @since 2.6.0
	 */
    public static function delete_zone( $zone_id ) {
        global $wpdb;
        $wpdb->delete( $wpdb->prefix . 'woocommerce_shipping_zone_locations', array( 'zone_id' => $zone_id ) );
		$wpdb->delete( $wpdb->prefix . 'woocommerce_shipping_zones', array( 'zone_id' => $zone_id ) );
		WC_Cache_Helper::incr_cache_prefix( 'shipping_zones' );
    }

	/**
	 * Get postcode wildcards in array format.
	 *
	 * Internal use only.
	 *
	 * @since 2.6.0
	 * @access private
	 *
	 * @param  string  $postcode array of values
	 * @return string[] Array of postcodes with wildcards
	 */
	private static function _get_wildcard_postcodes( $postcode ) {

		$postcodes         = array( '*', strtoupper( $postcode ), strtoupper( $postcode ) . '*' );
		$postcode_length   = strlen( $postcode );
		$wildcard_postcode = strtoupper( $postcode );

		for ( $i = 0; $i < $postcode_length; $i ++ ) {
			$wildcard_postcode = substr( $wildcard_postcode, 0, -1 );
			$postcodes[] = $wildcard_postcode . '*';
		}
		return $postcodes;
	}

	/**
	 * Find a matching zone for a given package.
	 * @since  2.6.0
	 * @uses   wc_make_numeric_postcode()
	 * @param  object $package
	 * @return WC_Shipping_Zone
	 */
	public static function get_zone_matching_package( $package ) {
		global $wpdb;

		$country          = strtoupper( wc_clean( $package['destination']['country'] ) );
		$state            = strtoupper( wc_clean( $package['destination']['state'] ) );
		$continent        = strtoupper( wc_clean( WC()->countries->get_continent_code_for_country( $country ) ) );
		$postcode         = strtoupper( wc_clean( $package['destination']['postcode'] ) );
		$valid_postcodes  = array_map( 'wc_clean', self::_get_wildcard_postcodes( $postcode ) );
		$cache_key        = WC_Cache_Helper::get_cache_prefix( 'shipping_zones' ) . 'wc_shipping_zone_' . md5( sprintf( '%s+%s+%s', $country, $state, $postcode ) );
		$matching_zone_id = wp_cache_get( $cache_key, 'shipping_zones' );

		if ( false === $matching_zone_id ) {

			// Work out criteria for our zone search
			$criteria = array();
			$criteria[] = $wpdb->prepare( "( ( location_type = 'country' AND location_code = %s )", $country );
			$criteria[] = $wpdb->prepare( "OR ( location_type = 'state' AND location_code = %s )", $country . ':' . $state );
			$criteria[] = $wpdb->prepare( "OR ( location_type = 'continent' AND location_code = %s ) )", $continent );

			// Postcode range and wildcard matching
			$postcode_locations = $wpdb->get_results( "SELECT zone_id, location_code FROM {$wpdb->prefix}woocommerce_shipping_zone_locations WHERE location_type = 'postcode';" );

			if ( $postcode_locations ) {
				$zone_ids_with_postcode_rules = array_map( 'absint', wp_list_pluck( $postcode_locations, 'zone_id' ) );
				$zone_id_matches              = array();

				foreach ( $postcode_locations as $postcode_location ) {
					$postcode_to_match = trim( strtoupper( $postcode_location->location_code ) );

					// Ranges
					if ( strstr( '-', $postcode_to_match ) ) {
						$range = array_map( 'trim', explode( '-', $postcode_to_match ) );

						if ( sizeof( $range ) != 2 ) {
							continue;
						}

						if ( is_numeric( $range[0] ) && is_numeric( $range[1] ) ) {
							$encoded_postcode = $postcode;
							$min              = $range[0];
							$max              = $range[1];
						} else {
							$min = wc_make_numeric_postcode( $range[0] );
							$max = wc_make_numeric_postcode( $range[1] );
							$min = str_pad( $min, $encoded_postcode_len, '0' );
							$max = str_pad( $max, $encoded_postcode_len, '9' );
						}

						if ( $encoded_postcode >= $min && $encoded_postcode <= $max ) {
							$zone_id_matches[] = absint( $postcode_location->zone_id );
						}

					// Wildcard/standard
					} elseif ( in_array( $postcode_to_match, $valid_postcodes ) ) {
						$zone_id_matches[] = absint( $postcode_location->zone_id );
					}
				}

				$do_not_match = array_unique( array_diff( $zone_ids_with_postcode_rules, $zone_id_matches ) );

				if ( $do_not_match ) {

					$criteria[] = "AND zones.zone_id NOT IN (" . implode( ',', $do_not_match ) . ")";
				}
			}

			// Get matching zones
			$matching_zone_id = $wpdb->get_var( "
				SELECT zones.zone_id FROM {$wpdb->prefix}woocommerce_shipping_zones as zones
				LEFT OUTER JOIN {$wpdb->prefix}woocommerce_shipping_zone_locations as locations ON zones.zone_id = locations.zone_id
				WHERE " . implode( ' ', $criteria ) . "
				ORDER BY zone_order ASC LIMIT 1
			" );

			wp_cache_set( $cache_key, $matching_zone_id, 'shipping_zones' );
		}

		return new WC_Shipping_Zone( $matching_zone_id ? $matching_zone_id : 0 );
	}
}


1		<?php
		1 ignored issue – show Coding Style Compatibility introduced 2015-12-11 16:51 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 17 and the first side effect is on line 4. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		if ( ! defined( 'ABSPATH' ) ) {
4		exit;
5		}
6
7		/**
8		* Handles storage and retrieval of shipping zones
9		*
10		* @class WC_Shipping_Zones
11		* @since 2.6.0
12		* @version 2.6.0
13		* @package WooCommerce/Classes
14		* @category Class
15		* @author WooThemes
16		*/
17		class WC_Shipping_Zones {
18
19		/**
20		* Get shipping zones from the database
21		* @since 2.6.0
22		* @return array of arrays
23		*/
24		public static function get_zones() {
25		global $wpdb;
26
27		$raw_zones = $wpdb->get_results( "SELECT zone_id, zone_name, zone_order FROM {$wpdb->prefix}woocommerce_shipping_zones order by zone_order ASC;" );
28		$zones = array();
29
30		foreach ( $raw_zones as $raw_zone ) {
31		$zone = new WC_Shipping_Zone( $raw_zone );
32		$zones[ $zone->get_zone_id() ] = $zone->get_data();
33		$zones[ $zone->get_zone_id() ]['formatted_zone_location'] = $zone->get_formatted_location();
34		$zones[ $zone->get_zone_id() ]['shipping_methods'] = $zone->get_shipping_methods();
35		}
36
37		return $zones;
38		}
39
40		/**
41		* Get shipping zone using it's ID
42		* @since 2.6.0
43		* @param int $zone_id
44		* @return WC_Shipping_Zone\|bool
45		*/
46		public static function get_zone( $zone_id ) {
47		return self::get_zone_by( 'zone_id', $zone_id );
48		}
49
50		/**
51		* Get shipping zone by an ID.
52		* @since 2.6.0
53		* @param string $by zone_id or instance_id
54		* @param int $id
55		* @return WC_Shipping_Zone\|bool
56		*/
57		public static function get_zone_by( $by = 'zone_id', $id = 0 ) {
58		global $wpdb;
59
60		switch ( $by ) {
61		case 'zone_id' :
62		$raw_zone = $wpdb->get_row( $wpdb->prepare( "SELECT zone_id, zone_name, zone_order FROM {$wpdb->prefix}woocommerce_shipping_zones WHERE zone_id = %d LIMIT 1;", $id ) );
63		break;
64		case 'instance_id' :
65		$raw_zone = $wpdb->get_row( $wpdb->prepare( "
66		SELECT zones.zone_id, zones.zone_name, zones.zone_order FROM {$wpdb->prefix}woocommerce_shipping_zones as zones
67		LEFT JOIN {$wpdb->prefix}woocommerce_shipping_zone_methods as methods ON zones.zone_id = methods.zone_id
68		WHERE methods.instance_id = %d LIMIT 1;
69		", $id ) );
70		break;
71		default :
72		$raw_zone = false;
73		break;
74		}
75
76		return $raw_zone ? new WC_Shipping_Zone( $raw_zone ) : false;
77		}
78
79		/**
80		* Get shipping zone using it's ID
81		* @since 2.6.0
82		* @param int $zone_id
		0 ignored issues – show Bug introduced 2015-12-11 16:51 UTC by Report Bug Copy Issue Report There is no parameter named `$zone_id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
83		* @return WC_Shipping_Meethod\|bool
84		*/
85		public static function get_shipping_method( $instance_id ) {
86		global $wpdb;
87		$raw_shipping_method = $wpdb->get_row( $wpdb->prepare( "SELECT instance_id, method_id FROM {$wpdb->prefix}woocommerce_shipping_zone_methods WHERE instance_id = %d LIMIT 1;", $instance_id ) );
88		$wc_shipping = WC_Shipping::instance();
89		$allowed_classes = $wc_shipping->get_shipping_method_class_names();
90
91	View Code Duplication	if ( in_array( $raw_shipping_method->method_id, array_keys( $allowed_classes ) ) ) {
		0 ignored issues – show Duplication introduced 2015-12-11 16:51 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
92		$class_name = $allowed_classes[ $raw_shipping_method->method_id ];
93		return new $class_name( $raw_shipping_method->instance_id );
94		}
95		return false;
96		}
97
98		/**
99		* Delete a zone using it's ID
100		* @param int $zone_id
101		* @since 2.6.0
102		*/
103		public static function delete_zone( $zone_id ) {
104		global $wpdb;
105		$wpdb->delete( $wpdb->prefix . 'woocommerce_shipping_zone_locations', array( 'zone_id' => $zone_id ) );
106		$wpdb->delete( $wpdb->prefix . 'woocommerce_shipping_zones', array( 'zone_id' => $zone_id ) );
107		WC_Cache_Helper::incr_cache_prefix( 'shipping_zones' );
108		}
109
110		/**
111		* Get postcode wildcards in array format.
112		*
113		* Internal use only.
114		*
115		* @since 2.6.0
116		* @access private
117		*
118		* @param string $postcode array of values
119		* @return string[] Array of postcodes with wildcards
120		*/
121	View Code Duplication	private static function _get_wildcard_postcodes( $postcode ) {
		0 ignored issues – show Duplication introduced 2015-12-15 12:48 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
122		$postcodes = array( '', strtoupper( $postcode ), strtoupper( $postcode ) . '' );
123		$postcode_length = strlen( $postcode );
124		$wildcard_postcode = strtoupper( $postcode );
125
126		for ( $i = 0; $i < $postcode_length; $i ++ ) {
127		$wildcard_postcode = substr( $wildcard_postcode, 0, -1 );
128		$postcodes[] = $wildcard_postcode . '*';
129		}
130		return $postcodes;
131		}
132
133		/**
134		* Find a matching zone for a given package.
135		* @since 2.6.0
136		* @uses wc_make_numeric_postcode()
137		* @param object $package
138		* @return WC_Shipping_Zone
139		*/
140		public static function get_zone_matching_package( $package ) {
141		global $wpdb;
142
143		$country = strtoupper( wc_clean( $package['destination']['country'] ) );
144		$state = strtoupper( wc_clean( $package['destination']['state'] ) );
145		$continent = strtoupper( wc_clean( WC()->countries->get_continent_code_for_country( $country ) ) );
146		$postcode = strtoupper( wc_clean( $package['destination']['postcode'] ) );
147		$valid_postcodes = array_map( 'wc_clean', self::_get_wildcard_postcodes( $postcode ) );
148		$cache_key = WC_Cache_Helper::get_cache_prefix( 'shipping_zones' ) . 'wc_shipping_zone_' . md5( sprintf( '%s+%s+%s', $country, $state, $postcode ) );
149		$matching_zone_id = wp_cache_get( $cache_key, 'shipping_zones' );
150
151		if ( false === $matching_zone_id ) {
152
153		// Work out criteria for our zone search
154		$criteria = array();
155		$criteria[] = $wpdb->prepare( "( ( location_type = 'country' AND location_code = %s )", $country );
156		$criteria[] = $wpdb->prepare( "OR ( location_type = 'state' AND location_code = %s )", $country . ':' . $state );
157		$criteria[] = $wpdb->prepare( "OR ( location_type = 'continent' AND location_code = %s ) )", $continent );
158
159		// Postcode range and wildcard matching
160		$postcode_locations = $wpdb->get_results( "SELECT zone_id, location_code FROM {$wpdb->prefix}woocommerce_shipping_zone_locations WHERE location_type = 'postcode';" );
161
162		if ( $postcode_locations ) {
163		$zone_ids_with_postcode_rules = array_map( 'absint', wp_list_pluck( $postcode_locations, 'zone_id' ) );
164		$zone_id_matches = array();
165
166		foreach ( $postcode_locations as $postcode_location ) {
167		$postcode_to_match = trim( strtoupper( $postcode_location->location_code ) );
168
169		// Ranges
170		if ( strstr( '-', $postcode_to_match ) ) {
171		$range = array_map( 'trim', explode( '-', $postcode_to_match ) );
172
173		if ( sizeof( $range ) != 2 ) {
174		continue;
175		}
176
177		if ( is_numeric( $range[0] ) && is_numeric( $range[1] ) ) {
178		$encoded_postcode = $postcode;
179		$min = $range[0];
180		$max = $range[1];
181		} else {
182		$min = wc_make_numeric_postcode( $range[0] );
183		$max = wc_make_numeric_postcode( $range[1] );
184		$min = str_pad( $min, $encoded_postcode_len, '0' );
185		$max = str_pad( $max, $encoded_postcode_len, '9' );
186		}
187
188		if ( $encoded_postcode >= $min && $encoded_postcode <= $max ) {
189		$zone_id_matches[] = absint( $postcode_location->zone_id );
190		}
191
192		// Wildcard/standard
193		} elseif ( in_array( $postcode_to_match, $valid_postcodes ) ) {
194		$zone_id_matches[] = absint( $postcode_location->zone_id );
195		}
196		}
197
198		$do_not_match = array_unique( array_diff( $zone_ids_with_postcode_rules, $zone_id_matches ) );
199
200		if ( $do_not_match ) {
		0 ignored issues – show Bug Best Practice introduced 2015-12-15 12:48 UTC by Report Bug Copy Issue Report The expression `$do_not_match` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
201		$criteria[] = "AND zones.zone_id NOT IN (" . implode( ',', $do_not_match ) . ")";
202		}
203		}
204
205		// Get matching zones
206		$matching_zone_id = $wpdb->get_var( "
207		SELECT zones.zone_id FROM {$wpdb->prefix}woocommerce_shipping_zones as zones
208		LEFT OUTER JOIN {$wpdb->prefix}woocommerce_shipping_zone_locations as locations ON zones.zone_id = locations.zone_id
209		WHERE " . implode( ' ', $criteria ) . "
210		ORDER BY zone_order ASC LIMIT 1
211		" );
212
213		wp_cache_set( $cache_key, $matching_zone_id, 'shipping_zones' );
214		}
215
216		return new WC_Shipping_Zone( $matching_zone_id ? $matching_zone_id : 0 );
217		}
218		}
219

woothemes / woocommerce

Pull Request — master (#9826)

WC_Shipping_Zones::delete_zone() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like