Issues in lessons.php (master) - Issues in master - woothemes/sensei - Measure and Improve Code Quality continuously with Scrutinizer

Issues (896)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

templates/course-results/lessons.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
if ( ! defined( 'ABSPATH' ) ) exit;
/**
 * The Template for displaying all course lessons on the course results page.
 *
 * Override this template by copying it to yourtheme/sensei/course-results/course-lessons.php
 *
 * @author 		Automattic
 * @package 	Sensei
 * @category    Templates
 * @version     1.9.0
 */

global $course;
?>

<?php if ( is_user_logged_in() ): ?>

    <?php
    /**
     * Fires inside course-results/lessons.php after the
     * is uer logged check, just above the lessons header.
     * @since 1.4.0
     */
    do_action( 'sensei_course_results_before_lessons', $course->ID );
    ?>

    <header>

        <h2>  <?php _e( 'Lessons', 'woothemes-sensei' );  ?> </h2>

    </header>

    <article class="<?php  esc_attr_e( join( ' ', get_post_class( array( 'course', 'post' ), $course->ID ) ) ); ?> ">

        <?php

		$displayed_lessons = array();
        $modules = Sensei()->modules->get_course_modules( intval( $course->ID ) );

        // List modules with lessons
        $course_has_lessons_in_modules = false;
        foreach( $modules as $module ) {

            $lessons_query = Sensei()->modules->get_lessons_query( $course->ID, $module->term_id );
            $lessons = $lessons_query->get_posts();

            if( count( $lessons ) > 0 ) {

	            $course_has_lessons_in_modules = true;

	            ?>

                <h3> <?php echo $module->name; ?></h3>

                <?php
                $count = 0;
                foreach( $lessons as $lesson ) {

                    $lesson_grade = 'n/a';
                    $has_questions = get_post_meta( $lesson->ID, '_quiz_has_questions', true );
                    if ( $has_questions ) {

                        $lesson_status = Sensei_Utils::user_lesson_status( $lesson->ID, get_current_user_id() );
                        // Get user quiz grade
                        $lesson_grade = get_comment_meta( $lesson_status->comment_ID, 'grade', true );
                        if ( $lesson_grade ) {
                            $lesson_grade .= '%';
                        }
                    }
                    ?>
                    <h2>

                        <a href="<?php esc_url_raw( get_permalink( $lesson->ID ) ); ?>"
                           title="<?php esc_attr_e( sprintf( __( 'Start %s', 'woothemes-sensei' ), $lesson->post_title ) ); ?>">

                            <?php esc_html_e( $lesson->post_title ); ?>

                        </a>

                        <span class="lesson-grade">
                            <?php echo $lesson_grade; ?>
                        </span>

                    </h2>

                <?php

                }// end for each

            }// end if count lesson

        } // end for each module
        ?>

        <?php

        $lessons = Sensei()->modules->get_none_module_lessons( $course->ID );
        if( 0 < count( $lessons ) ): ?>

			<h3>

                <?php
                // lesson title will already appear above
                if ( $course_has_lessons_in_modules ) {
	                _e( 'Other Lessons', 'woothemes-sensei' );
                }
                ?>

            </h3>

            <?php foreach ( $lessons as $lesson ): ?>

                <?php
                $lesson_grade = 'n/a';
                $has_questions = get_post_meta( $lesson->ID, '_quiz_has_questions', true );
                if ( $has_questions ) {

                    $lesson_status = Sensei_Utils::user_lesson_status( $lesson->ID, get_current_user_id());
                    // Get user quiz grade
	                $lesson_grade = '';
	                if( ! empty( $lesson_status ) ) {
		                $lesson_grade = get_comment_meta( $lesson_status->comment_ID, 'grade', true );
		                if ( $lesson_grade ) {
			                $lesson_grade .= '%';
		                }
	                }
                }
                ?>

                <h2>

                    <a href="<?php echo esc_url_raw( get_permalink( $lesson->ID ) ) ?>" title="<?php esc_attr_e( sprintf( __( 'Start %s', 'woothemes-sensei' ), $lesson->post_title ) ) ?>" >

                        <?php esc_html_e( sprintf( __( '%s', 'woothemes-sensei' ), $lesson->post_title ) ); ?>

                    </a>

                    <span class="lesson-grade"><?php echo  $lesson_grade; ?></span>

                </h2>

            <?php endforeach; // lessons ?>

        <?php endif; // lessons count > 0  ?>


        <h2 class="total-grade">

            <?php _e( 'Total Grade', 'woothemes-sensei' ); ?>
            <span class="lesson-grade">

                <?php

                    $course_user_grade = Sensei_Utils::sensei_course_user_grade( $course->ID, get_current_user_id() );
                    echo $course_user_grade . '%';

                ?>

            </span>

        </h2>

    </article>

    <?php
    /**
     * Fires inside course-results/lessons.php after the
     * is uer logged check, at the bottom of all lessons.
     *
     * @since 1.4.0
     */
	do_action( 'sensei_course_results_after_lessons', $course->ID );
    ?>

<?php endif; //user logged in ?>

1		<?php
2		if ( ! defined( 'ABSPATH' ) ) exit;
3		/**
4		* The Template for displaying all course lessons on the course results page.
5		*
6		* Override this template by copying it to yourtheme/sensei/course-results/course-lessons.php
7		*
8		* @author Automattic
9		* @package Sensei
10		* @category Templates
11		* @version 1.9.0
12		*/
13
14		global $course;
15		?>
16
17		<?php if ( is_user_logged_in() ): ?>
18
19		<?php
20		/**
21		* Fires inside course-results/lessons.php after the
22		* is uer logged check, just above the lessons header.
23		* @since 1.4.0
24		*/
25		do_action( 'sensei_course_results_before_lessons', $course->ID );
26		?>
27
28		<header>
29
30		<h2> <?php _e( 'Lessons', 'woothemes-sensei' ); ?> </h2>
31
32		</header>
33
34		<article class="<?php esc_attr_e( join( ' ', get_post_class( array( 'course', 'post' ), $course->ID ) ) ); ?> ">
35
36		<?php
37
38		$displayed_lessons = array();
39		$modules = Sensei()->modules->get_course_modules( intval( $course->ID ) );
40
41		// List modules with lessons
42		$course_has_lessons_in_modules = false;
43		foreach( $modules as $module ) {
44
45		$lessons_query = Sensei()->modules->get_lessons_query( $course->ID, $module->term_id );
46		$lessons = $lessons_query->get_posts();
47
48		if( count( $lessons ) > 0 ) {
49
50		$course_has_lessons_in_modules = true;
51
52		?>
53
54		<h3> <?php echo $module->name; ?></h3>
55
56		<?php
57		$count = 0;
58		foreach( $lessons as $lesson ) {
59
60		$lesson_grade = 'n/a';
61		$has_questions = get_post_meta( $lesson->ID, '_quiz_has_questions', true );
62	View Code Duplication	if ( $has_questions ) {
		0 ignored issues – show Duplication introduced 2016-02-11 05:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
63		$lesson_status = Sensei_Utils::user_lesson_status( $lesson->ID, get_current_user_id() );
64		// Get user quiz grade
65		$lesson_grade = get_comment_meta( $lesson_status->comment_ID, 'grade', true );
66		if ( $lesson_grade ) {
67		$lesson_grade .= '%';
68		}
69		}
70		?>
71		<h2>
72
73		<a href="<?php esc_url_raw( get_permalink( $lesson->ID ) ); ?>"
74		title="<?php esc_attr_e( sprintf( __( 'Start %s', 'woothemes-sensei' ), $lesson->post_title ) ); ?>">
75
76		<?php esc_html_e( $lesson->post_title ); ?>
77
78		</a>
79
80		<span class="lesson-grade">
81		<?php echo $lesson_grade; ?>
82		</span>
83
84		</h2>
85
86		<?php
87
88		}// end for each
89
90		}// end if count lesson
91
92		} // end for each module
93		?>
94
95		<?php
96
97		$lessons = Sensei()->modules->get_none_module_lessons( $course->ID );
98		if( 0 < count( $lessons ) ): ?>
99
100		<h3>
101
102		<?php
103		// lesson title will already appear above
104		if ( $course_has_lessons_in_modules ) {
105		_e( 'Other Lessons', 'woothemes-sensei' );
106		}
107		?>
108
109		</h3>
110
111		<?php foreach ( $lessons as $lesson ): ?>
112
113		<?php
114		$lesson_grade = 'n/a';
115		$has_questions = get_post_meta( $lesson->ID, '_quiz_has_questions', true );
116	View Code Duplication	if ( $has_questions ) {
		0 ignored issues – show Duplication introduced 2016-02-11 05:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
117		$lesson_status = Sensei_Utils::user_lesson_status( $lesson->ID, get_current_user_id());
118		// Get user quiz grade
119		$lesson_grade = '';
120		if( ! empty( $lesson_status ) ) {
121		$lesson_grade = get_comment_meta( $lesson_status->comment_ID, 'grade', true );
122		if ( $lesson_grade ) {
123		$lesson_grade .= '%';
124		}
125		}
126		}
127		?>
128
129		<h2>
130
131		<a href="<?php echo esc_url_raw( get_permalink( $lesson->ID ) ) ?>" title="<?php esc_attr_e( sprintf( __( 'Start %s', 'woothemes-sensei' ), $lesson->post_title ) ) ?>" >
132
133		<?php esc_html_e( sprintf( __( '%s', 'woothemes-sensei' ), $lesson->post_title ) ); ?>
134
135		</a>
136
137		<span class="lesson-grade"><?php echo $lesson_grade; ?></span>
138
139		</h2>
140
141		<?php endforeach; // lessons ?>
142
143		<?php endif; // lessons count > 0 ?>
144
145
146		<h2 class="total-grade">
147
148		<?php _e( 'Total Grade', 'woothemes-sensei' ); ?>
149		<span class="lesson-grade">
150
151		<?php
152
153		$course_user_grade = Sensei_Utils::sensei_course_user_grade( $course->ID, get_current_user_id() );
154		echo $course_user_grade . '%';
155
156		?>
157
158		</span>
159
160		</h2>
161
162		</article>
163
164		<?php
165		/**
166		* Fires inside course-results/lessons.php after the
167		* is uer logged check, at the bottom of all lessons.
168		*
169		* @since 1.4.0
170		*/
171		do_action( 'sensei_course_results_after_lessons', $course->ID );
172		?>
173
174		<?php endif; //user logged in ?>

woothemes / sensei

Issues (896)

Security Analysis not enabled

templates/course-results/lessons.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like