Issues in class-sensei-shortcode-lesson-page.php (master) - Issues in master - woothemes/sensei - Measure and Improve Code Quality continuously with Scrutinizer

Issues (896)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

shortcodes/class-sensei-shortcode-lesson-page.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly
/**
 *
 * Renders the [sensei_lesson_page] shortcode. Display a single lesson based on the ID parameter given.
 *
 * This class is loaded int WP by the shortcode loader class.
 *
 * @class Sensei_Shortcode_Lesson_Page
 *
 * @package Content
 * @subpackage Shortcode
 * @author Automattic
 *
 * @since 1.9.0
 */
class Sensei_Shortcode_Lesson_Page implements Sensei_Shortcode_Interface {

    /**
     * @var array $lesson_page_query {
     *     @type WP_Post
     * }
     * The lessons query
     */
    protected $lesson_page_query;

    /**
     * Setup the shortcode object
     *
     * @since 1.9.0
     * @param array $attributes
     * @param string $content
     * @param string $shortcode the shortcode that was called for this instance
     */
    public function __construct( $attributes, $content, $shortcode ){

        $this->id = isset( $attributes['id'] ) ? $attributes['id'] : '';
        $this->setup_lesson_query();

    }

    /**
     * create the lessons query .
     *
     * @return mixed
     */
    public function setup_lesson_query(){


        if( empty( $this->id ) ){
            return;
        }

        $args = array(
            'post_type' => 'lesson',
            'posts_per_page' => 1,
            'post_status' => 'publish',
            'post__in' => array( $this->id ),
        );

        $this->lesson_page_query  = new WP_Query( $args );


    }

    /**
     * Rendering the shortcode this class is responsible for.
     *
     * @return string $content
     */
    public function render(){

        if( empty(  $this->id  ) ){

            return __( 'Please supply a lesson ID for this shortcode.', 'woothemes-sensei' );

        }

        //set the wp_query to the current lessons query
        global $wp_query;
        $wp_query = $this->lesson_page_query;

        if( have_posts() ){

            the_post();

        }else{

            return __('No posts found.', 'woothemes-sensei');

        }

        ob_start();
        Sensei_Templates::get_template('content-single-lesson.php');
        $shortcode_output = ob_get_clean();

        // set back the global query
        wp_reset_query();

        return $shortcode_output;

    }// end render

}// end class



1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-02-23 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 17 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2		if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly
3		/**
4		*
5		* Renders the [sensei_lesson_page] shortcode. Display a single lesson based on the ID parameter given.
6		*
7		* This class is loaded int WP by the shortcode loader class.
8		*
9		* @class Sensei_Shortcode_Lesson_Page
10		*
11		* @package Content
12		* @subpackage Shortcode
13		* @author Automattic
14		*
15		* @since 1.9.0
16		*/
17		class Sensei_Shortcode_Lesson_Page implements Sensei_Shortcode_Interface {
18
19		/**
20		* @var array $lesson_page_query {
21		* @type WP_Post
22		* }
23		* The lessons query
24		*/
25		protected $lesson_page_query;
26
27		/**
28		* Setup the shortcode object
29		*
30		* @since 1.9.0
31		* @param array $attributes
32		* @param string $content
33		* @param string $shortcode the shortcode that was called for this instance
34		*/
35		public function __construct( $attributes, $content, $shortcode ){
36
37		$this->id = isset( $attributes['id'] ) ? $attributes['id'] : '';
38		$this->setup_lesson_query();
39
40		}
41
42		/**
43		* create the lessons query .
44		*
45		* @return mixed
46		*/
47	View Code Duplication	public function setup_lesson_query(){
		0 ignored issues – show Duplication introduced 2015-12-01 16:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48
49		if( empty( $this->id ) ){
50		return;
51		}
52
53		$args = array(
54		'post_type' => 'lesson',
55		'posts_per_page' => 1,
56		'post_status' => 'publish',
57		'post__in' => array( $this->id ),
58		);
59
60		$this->lesson_page_query = new WP_Query( $args );
		0 ignored issues – show Documentation Bug introduced 2015-12-01 16:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new \WP_Query($args)` of type `object<WP_Query>` is incompatible with the declared type `array` of property `$lesson_page_query`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
61
62		}
63
64		/**
65		* Rendering the shortcode this class is responsible for.
66		*
67		* @return string $content
68		*/
69		public function render(){
70
71		if( empty( $this->id ) ){
72
73		return __( 'Please supply a lesson ID for this shortcode.', 'woothemes-sensei' );
74
75		}
76
77		//set the wp_query to the current lessons query
78		global $wp_query;
79		$wp_query = $this->lesson_page_query;
80
81		if( have_posts() ){
82
83		the_post();
84
85		}else{
86
87		return __('No posts found.', 'woothemes-sensei');
88
89		}
90
91		ob_start();
92		Sensei_Templates::get_template('content-single-lesson.php');
93		$shortcode_output = ob_get_clean();
94
95		// set back the global query
96		wp_reset_query();
97
98		return $shortcode_output;
99
100		}// end render
101
102		}// end class
103
104

woothemes / sensei

Issues (896)

Security Analysis not enabled

shortcodes/class-sensei-shortcode-lesson-page.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like