Issues in class-sensei-grading-user-quiz.php (master) - Issues in master - woothemes/sensei - Measure and Improve Code Quality continuously with Scrutinizer

Issues (896)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

includes/class-sensei-grading-user-quiz.php (6 issues)

Labels

Severity

David Page 6

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly

/**
 * Grading User Profile in Sensei.
 *
 * @package Assessment
 * @author Automattic
 *
 * @since 1.3.0
 */
class Sensei_Grading_User_Quiz {
	public $user_id;
	public $lesson_id;
	public $quiz_id;

	/**
	 * Constructor
	 * @since  1.3.0
	 */
	public function __construct ( $user_id = 0, $quiz_id = 0 ) {
		$this->user_id = intval( $user_id );
		$this->quiz_id = intval( $quiz_id );
		$this->lesson_id = get_post_meta( $this->quiz_id, '_quiz_lesson', true );
	} // End __construct()

	/**
	 * build_data_array builds the data for use on the page
	 * Overloads the parent method
	 * @since  1.3.0
	 * @return array
	 */
	public function build_data_array() {
		$data_array = Sensei_Utils::sensei_get_quiz_questions( $this->quiz_id );
		return $data_array;
	} // End build_data_array()

	/**
	 * Display output to the admin view
     *
     * This view is shown when grading a quiz for a single user in admin under grading
     *
	 * @since  1.3.0
	 * @return html
	 */
	public function display() {
		// Get data for the user
		$questions = $this->build_data_array();


		$count = 0;
		$graded_count = 0;
		$user_quiz_grade_total = 0;
		$quiz_grade_total = 0;
		$quiz_grade = 0;
        $lesson_id = $this->lesson_id;
        $user_id = $this->user_id;

		?><form name="<?php esc_attr_e( 'quiz_' . $this->quiz_id ); ?>" action="" method="post">
			<?php wp_nonce_field( 'sensei_manual_grading', '_wp_sensei_manual_grading_nonce' ); ?>
			<input type="hidden" name="sensei_manual_grade" value="<?php esc_attr_e( $this->quiz_id ); ?>" />
			<input type="hidden" name="sensei_grade_next_learner" value="<?php esc_attr_e( $this->user_id ); ?>" />
			<div class="total_grade_display">
				<span><?php esc_attr_e( __( 'Grade:', 'woothemes-sensei' ) ); ?></span>
				<span class="total_grade_total"><?php echo $user_quiz_grade_total; ?></span> / <span class="quiz_grade_total"><?php echo $quiz_grade_total; ?></span> (<span class="total_grade_percent"><?php echo $quiz_grade; ?></span>%)
			</div>
			<div class="buttons">
				<input type="submit" value="<?php esc_attr_e( __( 'Save', 'woothemes-sensei' ) ); ?>" class="grade-button button-primary" title="Saves grades as currently marked on this page" />
				<input type="button" value="<?php esc_attr_e( __( 'Auto grade', 'woothemes-sensei' ) ); ?>" class="autograde-button button-secondary" title="Where possible, automatically grades questions that have not yet been graded" />
				<input type="reset" value="<?php esc_attr_e( __( 'Reset', 'woothemes-sensei' ) ); ?>" class="reset-button button-secondary" title="Resets all questions to ungraded and total grade to 0" />
			</div>
			<div class="clear"></div><br/><?php

		$lesson_status_id = Sensei_Utils::sensei_get_activity_value( array( 'post_id' => $this->lesson_id, 'user_id' => $this->user_id, 'type' => 'sensei_lesson_status', 'field' => 'comment_ID' ) );
		$user_quiz_grade = get_comment_meta( $lesson_status_id, 'grade', true );
		$correct_answers = 0;

		foreach( $questions as $question ) {
			$question_id = $question->ID;
			++$count;

			$type = false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			$type_name = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

			$type = Sensei()->question->get_question_type( $question_id );

			$question_answer_notes = Sensei()->quiz->get_user_question_feedback( $lesson_id, $question_id, $user_id );


			$question_grade_total = Sensei()->question->get_question_grade( $question_id );
			$quiz_grade_total += $question_grade_total;

			$right_answer = get_post_meta( $question_id, '_question_right_answer', true );
			$user_answer_content = Sensei()->quiz->get_user_question_answer( $lesson_id, $question_id, $user_id );
			$type_name = __( 'Multiple Choice', 'woothemes-sensei' );
			$grade_type = 'manual-grade';

			switch( $type ) {
				case 'boolean':
					$type_name = __( 'True/False', 'woothemes-sensei' );
					$right_answer = ucfirst( $right_answer );
					$user_answer_content = ucfirst( $user_answer_content );
					$grade_type = 'auto-grade';
				break;
				case 'multiple-choice':
					$type_name = __( 'Multiple Choice', 'woothemes-sensei' );
					$grade_type = 'auto-grade';
				break;
				case 'gap-fill':
					$type_name = __( 'Gap Fill', 'woothemes-sensei' );

					$right_answer_array = explode( '||', $right_answer );
					if ( isset( $right_answer_array[0] ) ) { $gapfill_pre = $right_answer_array[0]; } else { $gapfill_pre = ''; }
					if ( isset( $right_answer_array[1] ) ) { $gapfill_gap = $right_answer_array[1]; } else { $gapfill_gap = ''; }
					if ( isset( $right_answer_array[2] ) ) { $gapfill_post = $right_answer_array[2]; } else { $gapfill_post = ''; }

					if( ! $user_answer_content ) {
						$user_answer_content = '______';
					}

					$right_answer = $gapfill_pre . ' <span class="highlight">' . $gapfill_gap . '</span> ' . $gapfill_post;
					$user_answer_content = $gapfill_pre . ' <span class="highlight">' . $user_answer_content . '</span> ' . $gapfill_post;
					$grade_type = 'auto-grade';

				break;
				case 'multi-line':
					$type_name = __( 'Multi Line', 'woothemes-sensei' );
					$grade_type = 'manual-grade';
				break;
				case 'single-line':
					$type_name = __( 'Single Line', 'woothemes-sensei' );
					$grade_type = 'manual-grade';
				break;
				case 'file-upload':
					$type_name = __( 'File Upload', 'woothemes-sensei' );
					$grade_type = 'manual-grade';

					// Get uploaded file
					if( $user_answer_content ) {
						$attachment_id = $user_answer_content;
						$answer_media_url = $answer_media_filename = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
						if( 0 < intval( $attachment_id ) ) {
							$answer_media_url = wp_get_attachment_url( $attachment_id );
							$answer_media_filename = basename( $answer_media_url );
							if( $answer_media_url && $answer_media_filename ) {
								$user_answer_content = sprintf( __( 'Submitted file: %1$s', 'woothemes-sensei' ), '<a href="' . esc_url( $answer_media_url ) . '" target="_blank">' . esc_html( $answer_media_filename ) . '</a>' );
							}
						}
					} else {
						$user_answer_content = '';
					}
				break;
				default:
					// Nothing
				break;
			}
			$user_answer_content = (array) $user_answer_content;
			$right_answer = (array) $right_answer;
			$question_title = sprintf( __( 'Question %d: ', 'woothemes-sensei' ), $count ) . $type_name;

			$graded_class = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			$user_question_grade = Sensei()->quiz->get_user_question_grade( $lesson_id, $question_id, $user_id );
			$graded_class = 'ungraded';
			if ( 0 == $question_grade_total && 0 == intval( $user_question_grade ) ) {
				// Question skips grading
				$grade_type = 'zero-graded';
				$graded_class = '';
				++$correct_answers;
				++$graded_count;
				$user_question_grade = 0;
			}
			elseif( intval( $user_question_grade ) > 0 ) {
				$graded_class = 'user_right';
				++$correct_answers;
				$user_quiz_grade_total += $user_question_grade;
				++$graded_count;
			} else {
				if( ! is_string( $user_question_grade ) && intval( $user_question_grade ) == 0 ) {
					$graded_class = 'user_wrong';
					++$graded_count;
				}
				$user_question_grade = 0;
			}

			?><div class="postbox question_box <?php esc_attr_e( $type ); ?> <?php esc_attr_e( $grade_type ); ?> <?php esc_attr_e( $graded_class ); ?>" id="<?php esc_attr_e( 'question_' . $question_id . '_box' ); ?>">
				<div class="handlediv" title="Click to toggle"><br></div>
				<h3 class="hndle"><span><?php echo $question_title; ?></span></h3>
				<div class="inside">
					<div class="sensei-grading-actions">
						<div class="actions">
							<input type="hidden" class="question_id" value="<?php esc_attr_e( $question_id ); ?>" />
							<input type="hidden" class="question_total_grade" name="question_total_grade" value="<?php echo esc_attr( $question_grade_total ); ?>" />
							<span class="grading-mark icon_right"><input type="radio" class="<?php esc_attr_e( 'question_' . $question_id . '_right_option' ); ?>" name="<?php esc_attr_e( 'question_' . $question_id ); ?>" value="right" <?php checked( $graded_class, 'user_right', true ); ?> /></span>
							<span class="grading-mark icon_wrong"><input type="radio" class="<?php esc_attr_e( 'question_' . $question_id . '_wrong_option' ); ?>" name="<?php esc_attr_e( 'question_' . $question_id ); ?>" value="wrong" <?php checked( $graded_class, 'user_wrong', true ); ?> /></span>
							<input type="number" class="question-grade" name="<?php esc_attr_e( 'question_' . $question_id . '_grade' ); ?>" id="<?php esc_attr_e( 'question_' . $question_id . '_grade' ); ?>" value="<?php echo esc_attr( $user_question_grade ); ?>" min="0" max="<?php echo esc_attr( $question_grade_total ); ?>" />
							<span class="question-grade-total"><?php echo $question_grade_total; ?></span>
						</div>
					</div>
					<div class="sensei-grading-answer">
						<h4><?php echo apply_filters( 'sensei_question_title', $question->post_title ); ?></h4>
						<?php echo apply_filters( 'the_content', $question->post_content );?>
						<p class="user-answer"><?php
							foreach ( $user_answer_content as $_user_answer ) {

                                if( 'multi-line' == Sensei()->question->get_question_type( $question->ID ) ){

                                    $_user_answer = htmlspecialchars_decode( nl2br( esc_html($_user_answer) ) );

                                }

								echo apply_filters( 'sensei_answer_text', $_user_answer ) . "<br>";
							}
						?></p>
						<div class="right-answer">
							<h5><?php _e( 'Correct answer', 'woothemes-sensei' ) ?></h5>
							<span class="correct-answer"><?php
								foreach ( $right_answer as $_right_answer ) {

									echo apply_filters( 'sensei_answer_text', $_right_answer ) . "<br>";

								}
							?></span>
						</div>
						<div class="answer-notes">
							<h5><?php _e( 'Grading Notes', 'woothemes-sensei' ) ?></h5>
							<textarea class="correct-answer" name="questions_feedback[<?php esc_attr_e( $question_id ); ?>]" placeholder="<?php _e( 'Add notes here...', 'woothemes-sensei' ) ?>"><?php echo $question_answer_notes; ?></textarea>
						</div>
					</div>
				</div>
			</div><?php
		}

		$quiz_grade = intval( $user_quiz_grade );
		$all_graded = 'no';
		if( intval( $count ) == intval( $graded_count ) ) {
			$all_graded = 'yes';
		}

		?>  <input type="hidden" name="total_grade" id="total_grade" value="<?php esc_attr_e( $user_quiz_grade_total ); ?>" />
			<input type="hidden" name="total_questions" id="total_questions" value="<?php esc_attr_e( $count ); ?>" />
			<input type="hidden" name="quiz_grade_total" id="quiz_grade_total" value="<?php esc_attr_e( $quiz_grade_total ); ?>" />
			<input type="hidden" name="total_graded_questions" id="total_graded_questions" value="<?php esc_attr_e( $graded_count ); ?>" />
			<input type="hidden" name="all_questions_graded" id="all_questions_graded" value="<?php esc_attr_e( $all_graded ); ?>" />
			<div class="total_grade_display">
				<span><?php esc_attr_e( __( 'Grade:', 'woothemes-sensei' ) ); ?></span>
				<span class="total_grade_total"><?php echo $user_quiz_grade_total; ?></span> / <span class="quiz_grade_total"><?php echo $quiz_grade_total; ?></span> (<span class="total_grade_percent"><?php echo $quiz_grade; ?></span>%)
			</div>
			<div class="buttons">
				<input type="submit" value="<?php esc_attr_e( 'Save' ); ?>" class="grade-button button-primary" title="Saves grades as currently marked on this page" />
				<input type="button" value="<?php esc_attr_e( __( 'Auto grade', 'woothemes-sensei' ) ); ?>" class="autograde-button button-secondary" title="Where possible, automatically grades questions that have not yet been graded" />
				<input type="reset" value="<?php esc_attr_e( __( 'Reset', 'woothemes-sensei' ) ); ?>" class="reset-button button-secondary" title="Resets all questions to ungraded and total grade to 0" />
			</div>
			<div class="clear"></div>
			<script type="text/javascript">
				jQuery( window ).load( function() {
					// Calculate total grade on page load to make sure everything is set up correctly
					jQuery.fn.autoGrade();
				});
			</script>
		</form><?php
	} // End display()

} // End Class

/**
 * Class WooThemes_Sensei_Grading_User_Quiz
 * @ignore only for backward compatibility
 * @since 1.9.0
 */
class WooThemes_Sensei_Grading_User_Quiz extends Sensei_Grading_User_Quiz{}


1			<?php
			0 ignored issues – show Coding Style Compatibility introduced 2016-02-23 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 12 and the first side effect is on line 2. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2			if ( ! defined( 'ABSPATH' ) ) exit; // Exit if accessed directly
3
4			/**
5			* Grading User Profile in Sensei.
6			*
7			* @package Assessment
8			* @author Automattic
9			*
10			* @since 1.3.0
11			*/
12			class Sensei_Grading_User_Quiz {
13			public $user_id;
14			public $lesson_id;
15			public $quiz_id;
16
17			/**
18			* Constructor
19			* @since 1.3.0
20			*/
21			public function __construct ( $user_id = 0, $quiz_id = 0 ) {
22			$this->user_id = intval( $user_id );
23			$this->quiz_id = intval( $quiz_id );
24			$this->lesson_id = get_post_meta( $this->quiz_id, '_quiz_lesson', true );
25			} // End __construct()
26
27			/**
28			* build_data_array builds the data for use on the page
29			* Overloads the parent method
30			* @since 1.3.0
31			* @return array
32			*/
33			public function build_data_array() {
34			$data_array = Sensei_Utils::sensei_get_quiz_questions( $this->quiz_id );
35			return $data_array;
36			} // End build_data_array()
37
38			/**
39			* Display output to the admin view
40			*
41			* This view is shown when grading a quiz for a single user in admin under grading
42			*
43			* @since 1.3.0
44			* @return html
45			*/
46			public function display() {
47			// Get data for the user
48			$questions = $this->build_data_array();
49
50
51			$count = 0;
52			$graded_count = 0;
53			$user_quiz_grade_total = 0;
54			$quiz_grade_total = 0;
55			$quiz_grade = 0;
56			$lesson_id = $this->lesson_id;
57			$user_id = $this->user_id;
58
59			?><form name="<?php esc_attr_e( 'quiz_' . $this->quiz_id ); ?>" action="" method="post">
60			<?php wp_nonce_field( 'sensei_manual_grading', '_wp_sensei_manual_grading_nonce' ); ?>
61			<input type="hidden" name="sensei_manual_grade" value="<?php esc_attr_e( $this->quiz_id ); ?>" />
62			<input type="hidden" name="sensei_grade_next_learner" value="<?php esc_attr_e( $this->user_id ); ?>" />
63			<div class="total_grade_display">
64			<span><?php esc_attr_e( __( 'Grade:', 'woothemes-sensei' ) ); ?></span>
65			<span class="total_grade_total"><?php echo $user_quiz_grade_total; ?></span> / <span class="quiz_grade_total"><?php echo $quiz_grade_total; ?></span> (<span class="total_grade_percent"><?php echo $quiz_grade; ?></span>%)
66			</div>
67			<div class="buttons">
68			<input type="submit" value="<?php esc_attr_e( __( 'Save', 'woothemes-sensei' ) ); ?>" class="grade-button button-primary" title="Saves grades as currently marked on this page" />
69			<input type="button" value="<?php esc_attr_e( __( 'Auto grade', 'woothemes-sensei' ) ); ?>" class="autograde-button button-secondary" title="Where possible, automatically grades questions that have not yet been graded" />
70			<input type="reset" value="<?php esc_attr_e( __( 'Reset', 'woothemes-sensei' ) ); ?>" class="reset-button button-secondary" title="Resets all questions to ungraded and total grade to 0" />
71			</div>
72			<div class="clear"></div><br/><?php
73
74			$lesson_status_id = Sensei_Utils::sensei_get_activity_value( array( 'post_id' => $this->lesson_id, 'user_id' => $this->user_id, 'type' => 'sensei_lesson_status', 'field' => 'comment_ID' ) );
75			$user_quiz_grade = get_comment_meta( $lesson_status_id, 'grade', true );
76			$correct_answers = 0;
77
78			foreach( $questions as $question ) {
79			$question_id = $question->ID;
80			++$count;
81
82			$type = false;
			0 ignored issues – show Unused Code introduced 2015-12-01 16:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$type` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
83			$type_name = '';
			0 ignored issues – show Unused Code introduced 2015-12-01 16:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$type_name` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
84
85			$type = Sensei()->question->get_question_type( $question_id );
86
87			$question_answer_notes = Sensei()->quiz->get_user_question_feedback( $lesson_id, $question_id, $user_id );
88
89
90			$question_grade_total = Sensei()->question->get_question_grade( $question_id );
91			$quiz_grade_total += $question_grade_total;
92
93			$right_answer = get_post_meta( $question_id, '_question_right_answer', true );
94			$user_answer_content = Sensei()->quiz->get_user_question_answer( $lesson_id, $question_id, $user_id );
95			$type_name = __( 'Multiple Choice', 'woothemes-sensei' );
96			$grade_type = 'manual-grade';
97
98			switch( $type ) {
99			case 'boolean':
100			$type_name = __( 'True/False', 'woothemes-sensei' );
101			$right_answer = ucfirst( $right_answer );
102			$user_answer_content = ucfirst( $user_answer_content );
103			$grade_type = 'auto-grade';
104			break;
105			case 'multiple-choice':
106			$type_name = __( 'Multiple Choice', 'woothemes-sensei' );
107			$grade_type = 'auto-grade';
108			break;
109			case 'gap-fill':
110			$type_name = __( 'Gap Fill', 'woothemes-sensei' );
111
112			$right_answer_array = explode( '\|\|', $right_answer );
113			if ( isset( $right_answer_array[0] ) ) { $gapfill_pre = $right_answer_array[0]; } else { $gapfill_pre = ''; }
114			if ( isset( $right_answer_array[1] ) ) { $gapfill_gap = $right_answer_array[1]; } else { $gapfill_gap = ''; }
115			if ( isset( $right_answer_array[2] ) ) { $gapfill_post = $right_answer_array[2]; } else { $gapfill_post = ''; }
116
117			if( ! $user_answer_content ) {
118			$user_answer_content = '______';
119			}
120
121			$right_answer = $gapfill_pre . ' <span class="highlight">' . $gapfill_gap . '</span> ' . $gapfill_post;
122			$user_answer_content = $gapfill_pre . ' <span class="highlight">' . $user_answer_content . '</span> ' . $gapfill_post;
123			$grade_type = 'auto-grade';
124
125			break;
126			case 'multi-line':
127			$type_name = __( 'Multi Line', 'woothemes-sensei' );
128			$grade_type = 'manual-grade';
129			break;
130			case 'single-line':
131			$type_name = __( 'Single Line', 'woothemes-sensei' );
132			$grade_type = 'manual-grade';
133			break;
134			case 'file-upload':
135			$type_name = __( 'File Upload', 'woothemes-sensei' );
136			$grade_type = 'manual-grade';
137
138			// Get uploaded file
139			if( $user_answer_content ) {
140			$attachment_id = $user_answer_content;
141			$answer_media_url = $answer_media_filename = '';
			0 ignored issues – show Unused Code introduced 2015-12-01 16:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$answer_media_filename` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history... Unused Code introduced 2015-12-01 16:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$answer_media_url` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
142			if( 0 < intval( $attachment_id ) ) {
143			$answer_media_url = wp_get_attachment_url( $attachment_id );
144			$answer_media_filename = basename( $answer_media_url );
145			if( $answer_media_url && $answer_media_filename ) {
146			$user_answer_content = sprintf( __( 'Submitted file: %1$s', 'woothemes-sensei' ), '<a href="' . esc_url( $answer_media_url ) . '" target="_blank">' . esc_html( $answer_media_filename ) . '</a>' );
147			}
148			}
149			} else {
150			$user_answer_content = '';
151			}
152			break;
153			default:
154			// Nothing
155			break;
156			}
157			$user_answer_content = (array) $user_answer_content;
158			$right_answer = (array) $right_answer;
159			$question_title = sprintf( __( 'Question %d: ', 'woothemes-sensei' ), $count ) . $type_name;
160
161			$graded_class = '';
			0 ignored issues – show Unused Code introduced 2015-12-01 16:21 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$graded_class` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
162			$user_question_grade = Sensei()->quiz->get_user_question_grade( $lesson_id, $question_id, $user_id );
163			$graded_class = 'ungraded';
164			if ( 0 == $question_grade_total && 0 == intval( $user_question_grade ) ) {
165			// Question skips grading
166			$grade_type = 'zero-graded';
167			$graded_class = '';
168			++$correct_answers;
169			++$graded_count;
170			$user_question_grade = 0;
171			}
172			elseif( intval( $user_question_grade ) > 0 ) {
173			$graded_class = 'user_right';
174			++$correct_answers;
175			$user_quiz_grade_total += $user_question_grade;
176			++$graded_count;
177			} else {
178			if( ! is_string( $user_question_grade ) && intval( $user_question_grade ) == 0 ) {
179			$graded_class = 'user_wrong';
180			++$graded_count;
181			}
182			$user_question_grade = 0;
183			}
184
185			?><div class="postbox question_box <?php esc_attr_e( $type ); ?> <?php esc_attr_e( $grade_type ); ?> <?php esc_attr_e( $graded_class ); ?>" id="<?php esc_attr_e( 'question_' . $question_id . '_box' ); ?>">
186			<div class="handlediv" title="Click to toggle"><br></div>
187			<h3 class="hndle"><span><?php echo $question_title; ?></span></h3>
188			<div class="inside">
189			<div class="sensei-grading-actions">
190			<div class="actions">
191			<input type="hidden" class="question_id" value="<?php esc_attr_e( $question_id ); ?>" />
192			<input type="hidden" class="question_total_grade" name="question_total_grade" value="<?php echo esc_attr( $question_grade_total ); ?>" />
193			<span class="grading-mark icon_right"><input type="radio" class="<?php esc_attr_e( 'question_' . $question_id . '_right_option' ); ?>" name="<?php esc_attr_e( 'question_' . $question_id ); ?>" value="right" <?php checked( $graded_class, 'user_right', true ); ?> /></span>
194			<span class="grading-mark icon_wrong"><input type="radio" class="<?php esc_attr_e( 'question_' . $question_id . '_wrong_option' ); ?>" name="<?php esc_attr_e( 'question_' . $question_id ); ?>" value="wrong" <?php checked( $graded_class, 'user_wrong', true ); ?> /></span>
195			<input type="number" class="question-grade" name="<?php esc_attr_e( 'question_' . $question_id . '_grade' ); ?>" id="<?php esc_attr_e( 'question_' . $question_id . '_grade' ); ?>" value="<?php echo esc_attr( $user_question_grade ); ?>" min="0" max="<?php echo esc_attr( $question_grade_total ); ?>" />
196			<span class="question-grade-total"><?php echo $question_grade_total; ?></span>
197			</div>
198			</div>
199			<div class="sensei-grading-answer">
200			<h4><?php echo apply_filters( 'sensei_question_title', $question->post_title ); ?></h4>
201			<?php echo apply_filters( 'the_content', $question->post_content );?>
202			<p class="user-answer"><?php
203			foreach ( $user_answer_content as $_user_answer ) {
204
205			if( 'multi-line' == Sensei()->question->get_question_type( $question->ID ) ){
206
207			$_user_answer = htmlspecialchars_decode( nl2br( esc_html($_user_answer) ) );
208
209			}
210
211			echo apply_filters( 'sensei_answer_text', $_user_answer ) . "<br>";
212			}
213			?></p>
214			<div class="right-answer">
215			<h5><?php _e( 'Correct answer', 'woothemes-sensei' ) ?></h5>
216			<span class="correct-answer"><?php
217			foreach ( $right_answer as $_right_answer ) {
218
219			echo apply_filters( 'sensei_answer_text', $_right_answer ) . "<br>";
220
221			}
222			?></span>
223			</div>
224			<div class="answer-notes">
225			<h5><?php _e( 'Grading Notes', 'woothemes-sensei' ) ?></h5>
226			<textarea class="correct-answer" name="questions_feedback[<?php esc_attr_e( $question_id ); ?>]" placeholder="<?php _e( 'Add notes here...', 'woothemes-sensei' ) ?>"><?php echo $question_answer_notes; ?></textarea>
227			</div>
228			</div>
229			</div>
230			</div><?php
231			}
232
233			$quiz_grade = intval( $user_quiz_grade );
234			$all_graded = 'no';
235			if( intval( $count ) == intval( $graded_count ) ) {
236			$all_graded = 'yes';
237			}
238
239			?> <input type="hidden" name="total_grade" id="total_grade" value="<?php esc_attr_e( $user_quiz_grade_total ); ?>" />
240			<input type="hidden" name="total_questions" id="total_questions" value="<?php esc_attr_e( $count ); ?>" />
241			<input type="hidden" name="quiz_grade_total" id="quiz_grade_total" value="<?php esc_attr_e( $quiz_grade_total ); ?>" />
242			<input type="hidden" name="total_graded_questions" id="total_graded_questions" value="<?php esc_attr_e( $graded_count ); ?>" />
243			<input type="hidden" name="all_questions_graded" id="all_questions_graded" value="<?php esc_attr_e( $all_graded ); ?>" />
244			<div class="total_grade_display">
245			<span><?php esc_attr_e( __( 'Grade:', 'woothemes-sensei' ) ); ?></span>
246			<span class="total_grade_total"><?php echo $user_quiz_grade_total; ?></span> / <span class="quiz_grade_total"><?php echo $quiz_grade_total; ?></span> (<span class="total_grade_percent"><?php echo $quiz_grade; ?></span>%)
247			</div>
248			<div class="buttons">
249			<input type="submit" value="<?php esc_attr_e( 'Save' ); ?>" class="grade-button button-primary" title="Saves grades as currently marked on this page" />
250			<input type="button" value="<?php esc_attr_e( __( 'Auto grade', 'woothemes-sensei' ) ); ?>" class="autograde-button button-secondary" title="Where possible, automatically grades questions that have not yet been graded" />
251			<input type="reset" value="<?php esc_attr_e( __( 'Reset', 'woothemes-sensei' ) ); ?>" class="reset-button button-secondary" title="Resets all questions to ungraded and total grade to 0" />
252			</div>
253			<div class="clear"></div>
254			<script type="text/javascript">
255			jQuery( window ).load( function() {
256			// Calculate total grade on page load to make sure everything is set up correctly
257			jQuery.fn.autoGrade();
258			});
259			</script>
260			</form><?php
261			} // End display()
262
263			} // End Class
264
265			/**
266			* Class WooThemes_Sensei_Grading_User_Quiz
267			* @ignore only for backward compatibility
268			* @since 1.9.0
269			*/
270			class WooThemes_Sensei_Grading_User_Quiz extends Sensei_Grading_User_Quiz{}
271

woothemes / sensei

Issues (896)

Security Analysis not enabled

includes/class-sensei-grading-user-quiz.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like