Sensei_Student::get_full_name() - Code Metrics - Inspection of "Let the user know when they have no messages yet...." - woothemes/sensei - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d51ce1...80c0ca )

by Dwain

created 2015-12-06 01:46 UTC

Sensei_Student::get_full_name() B

↳ Parent: Sensei_Student

Complexity

Conditions	6
Paths	3

Size

Total Lines	32
Code Lines	11

Duplication

Lines	9
Ratio	28.13 %

Metric	Value
dl	9
loc	32
rs	8.439
cc	6
eloc	11
nc	3
nop	1

<?php

/**
 * Sensei_Student
 *
 * The class is responsible for all student specific functionality and helper functions
 *
 * @package WordPress
 * @subpackage Sensei
 * @category Core
 * @author Automattic
 * @since 1.9.0
 */
class Sensei_Student{

    /**
     * Get the students full name
     *
     * This function replaces Sensei_Learner_Managment->get_learner_full_name
     * @since 1.9.0
     *
     * @param $user_id
     * @return bool|mixed|void
     */
    public static function get_full_name( $user_id ){

        $full_name = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if( empty( $user_id ) || ! ( 0 < intval( $user_id ) )
            || !( get_userdata( $user_id ) ) ){
            return false;
        }

        // get the user details
        $user = get_user_by( 'id', $user_id );

        if( ! empty( $user->first_name  ) && ! empty( $user->last_name  )  ){


            $full_name = trim( $user->first_name   ) . ' ' . trim( $user->last_name  );

        }else{

            $full_name =  $user->display_name;

        }

        /**
         * Filter the user full name from the get_learner_full_name function.
         *
         * @since 1.8.0
         * @param $full_name
         * @param $user_id
         */
        return apply_filters( 'sensei_learner_full_name' , $full_name , $user_id );

    }// end get_full_name

}

1		<?php
2
3		/**
4		* Sensei_Student
5		*
6		* The class is responsible for all student specific functionality and helper functions
7		*
8		* @package WordPress
9		* @subpackage Sensei
10		* @category Core
11		* @author Automattic
12		* @since 1.9.0
13		*/
14		class Sensei_Student{
15
16		/**
17		* Get the students full name
18		*
19		* This function replaces Sensei_Learner_Managment->get_learner_full_name
20		* @since 1.9.0
21		*
22		* @param $user_id
23		* @return bool\|mixed\|void
24		*/
25		public static function get_full_name( $user_id ){
26
27		$full_name = '';
		0 ignored issues – show Unused Code introduced 2015-12-06 01:52 UTC by Report Bug Copy Issue Report `$full_name` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
28
29		if( empty( $user_id ) \|\| ! ( 0 < intval( $user_id ) )
30		\|\| !( get_userdata( $user_id ) ) ){
31		return false;
32		}
33
34		// get the user details
35		$user = get_user_by( 'id', $user_id );
36
37	View Code Duplication	if( ! empty( $user->first_name ) && ! empty( $user->last_name ) ){
		0 ignored issues – show Duplication introduced 2015-12-06 01:52 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38
39		$full_name = trim( $user->first_name ) . ' ' . trim( $user->last_name );
40
41		}else{
42
43		$full_name = $user->display_name;
44
45		}
46
47		/**
48		* Filter the user full name from the get_learner_full_name function.
49		*
50		* @since 1.8.0
51		* @param $full_name
52		* @param $user_id
53		*/
54		return apply_filters( 'sensei_learner_full_name' , $full_name , $user_id );
55
56		}// end get_full_name
57
58		}

woothemes / sensei

Push — master ( d51ce1...80c0ca )

Sensei_Student::get_full_name() B

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like