woocommerce / woocommerce-rest-api

unit-tests/Tests/Version4/Coupons.php

Spacing +9 added lines, -9 removed lines

@@ -158,9 +158,9 @@ 
 			$this->assertArrayHasKey( $property, $response->data );
 		}
 
-		$this->assertEquals( $coupon->get_id(), $response->data['id'] );
-		$this->assertEquals( 'new-code', $response->data['code'] );
-		$this->assertEquals( 'new description', $response->data['description'] );
+		$this->assertEquals( $coupon->get_id(), $response->data[ 'id' ] );
+		$this->assertEquals( 'new-code', $response->data[ 'code' ] );
+		$this->assertEquals( 'new description', $response->data[ 'description' ] );
 	}
 
 	/**
@@ -272,7 +272,7 @@ 
 		);
 
 		$this->assertEquals( 400, $result->status );
-		$this->assertEquals( 'Invalid parameter(s): discount_type', $result->data['message'] );
+		$this->assertEquals( 'Invalid parameter(s): discount_type', $result->data[ 'message' ] );
 	}
 
 	/**
@@ -307,11 +307,11 @@ 
 			)
 		);
 
-		$this->assertEquals( '5.15', $result->data['update'][0]['amount'] );
-		$this->assertEquals( '11.00', $result->data['create'][0]['amount'] );
-		$this->assertEquals( 'new-coupon', $result->data['create'][0]['code'] );
-		$this->assertEquals( $coupon_2->get_id(), $result->data['delete'][0]['previous']['id'] );
-		$this->assertEquals( $coupon_3->get_id(), $result->data['delete'][1]['previous']['id'] );
+		$this->assertEquals( '5.15', $result->data[ 'update' ][ 0 ][ 'amount' ] );
+		$this->assertEquals( '11.00', $result->data[ 'create' ][ 0 ][ 'amount' ] );
+		$this->assertEquals( 'new-coupon', $result->data[ 'create' ][ 0 ][ 'code' ] );
+		$this->assertEquals( $coupon_2->get_id(), $result->data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
+		$this->assertEquals( $coupon_3->get_id(), $result->data[ 'delete' ][ 1 ][ 'previous' ][ 'id' ] );
 
 		$result = $this->do_request( '/wc/v4/coupons' );
 		$this->assertEquals( 3, count( $result->data ) );

unit-tests/Tests/Version4/Orders.php

Spacing +33 added lines, -33 removed lines

@@ -185,22 +185,22 @@ 
 			),
 		];
 		$response = $this->do_request( '/wc/v4/orders', 'POST', $data );
-		$order    = wc_get_order( $response->data['id'] );
+		$order    = wc_get_order( $response->data[ 'id' ] );
 		$this->assertExpectedResponse( $response, 201 );
-		$this->assertEquals( $order->get_payment_method(), $response->data['payment_method'] );
+		$this->assertEquals( $order->get_payment_method(), $response->data[ 'payment_method' ] );
 		$this->assertEquals( $order->get_payment_method_title(), 'Sanitize this' );
 
 		// Test when updating order.
 		$response = $this->do_request(
-			'/wc/v4/orders/' . $response->data['id'],
+			'/wc/v4/orders/' . $response->data[ 'id' ],
 			'POST', [
 				'payment_method'       => 'bacs',
 				'payment_method_title' => '<h1>Sanitize this too <script>alert(1);</script></h1>',
 			]
 		);
-		$order    = wc_get_order( $response->data['id'] );
+		$order = wc_get_order( $response->data[ 'id' ] );
 		$this->assertExpectedResponse( $response, 200 );
-		$this->assertEquals( $order->get_payment_method(), $response->data['payment_method'] );
+		$this->assertEquals( $order->get_payment_method(), $response->data[ 'payment_method' ] );
 		$this->assertEquals( $order->get_payment_method_title(), 'Sanitize this too' );
 	}
 
@@ -259,25 +259,25 @@ 
 	 * Test read.
 	 */
 	public function test_read() {
-		$product  = ProductHelper::create_simple_product();
+		$product = ProductHelper::create_simple_product();
 		$product->set_regular_price( 10.95 );
 		$product->set_sale_price( false );
 		$product->save();
 		$customer = CustomerHelper::create_customer();
-		$orders   = [];
-		$orders[] = OrderHelper::create_order( $customer->get_id(), $product );
+		$orders   = [ ];
+		$orders[ ] = OrderHelper::create_order( $customer->get_id(), $product );
 
 		// Create orders.
 		for ( $i = 0; $i < 9; $i++ ) {
-			$orders[] = OrderHelper::create_order( $this->user );
+			$orders[ ] = OrderHelper::create_order( $this->user );
 		}
 
-		$orders[5]->set_status( 'on-hold' );
-		$orders[5]->save();
-		$orders[6]->set_status( 'on-hold' );
-		$orders[6]->save();
-		$orders[0]->calculate_totals();
-		$orders[0]->save();
+		$orders[ 5 ]->set_status( 'on-hold' );
+		$orders[ 5 ]->save();
+		$orders[ 6 ]->set_status( 'on-hold' );
+		$orders[ 6 ]->save();
+		$orders[ 0 ]->calculate_totals();
+		$orders[ 0 ]->save();
 
 		// Collection.
 		$response = $this->do_request( '/wc/v4/orders', 'GET' );
@@ -289,7 +289,7 @@ 
 		$this->assertExpectedResponse( $response, 200 );
 		$this->assertEquals( 2, count( $response->data ) );
 
-		$response = $this->do_request( '/wc/v4/orders', 'GET', [ 'number' => (string) $orders[0]->get_id() ] );
+		$response = $this->do_request( '/wc/v4/orders', 'GET', [ 'number' => (string) $orders[ 0 ]->get_id() ] );
 		$this->assertExpectedResponse( $response, 200 );
 		$this->assertEquals( 1, count( $response->data ) );
 
@@ -302,13 +302,13 @@ 
 		$this->assertEquals( 1, count( $response->data ) );
 
 		// Single collection args.
-		$response = $this->do_request( '/wc/v4/orders/' . $orders[0]->get_id(), 'GET', [ 'dp' => 0 ] );
-		$this->assertEquals( '54', $response->data['total'] );
-		$response = $this->do_request( '/wc/v4/orders/' . $orders[0]->get_id(), 'GET', [ 'dp' => 2 ] );
-		$this->assertEquals( '53.80', $response->data['total'] );
+		$response = $this->do_request( '/wc/v4/orders/' . $orders[ 0 ]->get_id(), 'GET', [ 'dp' => 0 ] );
+		$this->assertEquals( '54', $response->data[ 'total' ] );
+		$response = $this->do_request( '/wc/v4/orders/' . $orders[ 0 ]->get_id(), 'GET', [ 'dp' => 2 ] );
+		$this->assertEquals( '53.80', $response->data[ 'total' ] );
 
 		// Single.
-		$response = $this->do_request( '/wc/v4/orders/' . $orders[0]->get_id(), 'GET' );
+		$response = $this->do_request( '/wc/v4/orders/' . $orders[ 0 ]->get_id(), 'GET' );
 		$this->assertExpectedResponse( $response, 200 );
 
 		foreach ( $this->get_properties( 'view' ) as $property ) {
@@ -480,7 +480,7 @@ 
 			]
 		);
 		$this->assertEquals( 400, $response->status );
-		$this->assertEquals( 'Invalid parameter(s): status', $response->data['message'] );
+		$this->assertEquals( 'Invalid parameter(s): status', $response->data[ 'message' ] );
 
 		$response = $this->do_request(
 			'/wc/v4/orders/' . $order->get_id(),
@@ -490,7 +490,7 @@ 
 			]
 		);
 		$this->assertEquals( 400, $response->status );
-		$this->assertEquals( 'Invalid parameter(s): currency', $response->data['message'] );
+		$this->assertEquals( 'Invalid parameter(s): currency', $response->data[ 'message' ] );
 	}
 
 	/**
@@ -517,9 +517,9 @@ 
 				),
 			)
 		);
-		$this->assertEquals( 'updated', $result->data['update'][0]['payment_method'] );
-		$this->assertEquals( $order2->get_id(), $result->data['delete'][0]['previous']['id'] );
-		$this->assertEquals( $order3->get_id(), $result->data['delete'][1]['previous']['id'] );
+		$this->assertEquals( 'updated', $result->data[ 'update' ][ 0 ][ 'payment_method' ] );
+		$this->assertEquals( $order2->get_id(), $result->data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
+		$this->assertEquals( $order3->get_id(), $result->data[ 'delete' ][ 1 ][ 'previous' ][ 'id' ] );
 
 		$result = $this->do_request( '/wc/v4/orders' );
 		$this->assertEquals( 1, count( $result->data ) );
@@ -558,7 +558,7 @@ 
 			]
 		);
 		$this->assertEquals( 200, $response->status );
-		$this->assertTrue( empty( $response->data['fee_lines'] ) );
+		$this->assertTrue( empty( $response->data[ 'fee_lines' ] ) );
 	}
 
 	/**
@@ -585,8 +585,8 @@ 
 			]
 		);
 		$this->assertEquals( 200, $response->status );
-		$this->assertCount( 1, $response->data['coupon_lines'] );
-		$this->assertEquals( '45.00', $response->data['total'] );
+		$this->assertCount( 1, $response->data[ 'coupon_lines' ] );
+		$this->assertEquals( '45.00', $response->data[ 'total' ] );
 	}
 
 	/**
@@ -627,8 +627,8 @@ 
 			]
 		);
 		$this->assertEquals( 200, $response->status );
-		$this->assertTrue( empty( $response->data['coupon_lines'] ) );
-		$this->assertEquals( '50.00', $response->data['total'] );
+		$this->assertTrue( empty( $response->data[ 'coupon_lines' ] ) );
+		$this->assertEquals( '50.00', $response->data[ 'total' ] );
 	}
 
 	/**
@@ -650,7 +650,7 @@ 
 			]
 		);
 		$this->assertEquals( 400, $response->status );
-		$this->assertEquals( 'woocommerce_rest_invalid_coupon', $response->data['code'] );
-		$this->assertEquals( 'Coupon "non_existing_coupon" does not exist!', $response->data['message'] );
+		$this->assertEquals( 'woocommerce_rest_invalid_coupon', $response->data[ 'code' ] );
+		$this->assertEquals( 'Coupon "non_existing_coupon" does not exist!', $response->data[ 'message' ] );
 	}
 }

unit-tests/Tests/Version4/Customers.php

Spacing +48 added lines, -48 removed lines

@@ -244,11 +244,11 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'create_customer_test@woo.local',
 				'first_name'         => '',
 				'last_name'          => '',
@@ -280,7 +280,7 @@ 
 				),
 				'is_paying_customer' => false,
 				'meta_data'          => array(),
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -310,11 +310,11 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'create_customer_test2@woo.local',
 				'first_name'         => 'Test',
 				'last_name'          => 'McTestFace',
@@ -346,7 +346,7 @@ 
 				),
 				'is_paying_customer' => false,
 				'meta_data'          => array(),
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -397,11 +397,11 @@ 
 
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'get_customer_test@woo.local',
 				'first_name'         => 'Justin',
 				'billing'            => array(
@@ -433,7 +433,7 @@ 
 				'last_name'          => '',
 				'role'               => 'customer',
 				'username'           => 'get_customer_test',
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -471,8 +471,8 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/customers/' . $customer->get_id() ) );
 		$data     = $response->get_data();
-		$this->assertEquals( 'update_customer_test', $data['username'] );
-		$this->assertEquals( 'update_customer_test@woo.local', $data['email'] );
+		$this->assertEquals( 'update_customer_test', $data[ 'username' ] );
+		$this->assertEquals( 'update_customer_test@woo.local', $data[ 'email' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/customers/' . $customer->get_id() );
 		$request->set_body_params(
@@ -484,8 +484,8 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'updated_email@woo.local', $data['email'] );
-		$this->assertEquals( 'UpdatedTest', $data['first_name'] );
+		$this->assertEquals( 'updated_email@woo.local', $data[ 'email' ] );
+		$this->assertEquals( 'UpdatedTest', $data[ 'first_name' ] );
 	}
 
 	/**
@@ -586,11 +586,11 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'McTest', $data['update'][0]['last_name'] );
-		$this->assertEquals( 'newuser', $data['create'][0]['username'] );
-		$this->assertEmpty( $data['create'][0]['last_name'] );
-		$this->assertEquals( $customer_2->get_id(), $data['delete'][0]['id'] );
-		$this->assertEquals( $customer_3->get_id(), $data['delete'][1]['id'] );
+		$this->assertEquals( 'McTest', $data[ 'update' ][ 0 ][ 'last_name' ] );
+		$this->assertEquals( 'newuser', $data[ 'create' ][ 0 ][ 'username' ] );
+		$this->assertEmpty( $data[ 'create' ][ 0 ][ 'last_name' ] );
+		$this->assertEquals( $customer_2->get_id(), $data[ 'delete' ][ 0 ][ 'id' ] );
+		$this->assertEquals( $customer_3->get_id(), $data[ 'delete' ][ 1 ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v4/customers' );
 		$response = $this->server->dispatch( $request );
@@ -608,7 +608,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/customers' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 16, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -624,26 +624,26 @@ 
 		$this->assertArrayHasKey( 'password', $properties );
 		$this->assertArrayHasKey( 'avatar_url', $properties );
 		$this->assertArrayHasKey( 'billing', $properties );
-		$this->assertArrayHasKey( 'first_name', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'last_name', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'company', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'address_1', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'address_2', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'city', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'state', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'postcode', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'country', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'email', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'phone', $properties['billing']['properties'] );
+		$this->assertArrayHasKey( 'first_name', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'last_name', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'company', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_1', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_2', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'city', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'state', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'postcode', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'country', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'email', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'phone', $properties[ 'billing' ][ 'properties' ] );
 		$this->assertArrayHasKey( 'shipping', $properties );
-		$this->assertArrayHasKey( 'first_name', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'last_name', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'company', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'address_1', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'address_2', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'city', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'state', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'postcode', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'country', $properties['shipping']['properties'] );
+		$this->assertArrayHasKey( 'first_name', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'last_name', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'company', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_1', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_2', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'city', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'state', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'postcode', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'country', $properties[ 'shipping' ][ 'properties' ] );
 	}
 }

unit-tests/Tests/Version4/ShippingZones.php

Spacing +49 added lines, -49 removed lines

@@ -64,7 +64,7 @@ 
 		$zone->set_locations( $locations );
 		$zone->save();
 
-		$this->zones[] = $zone;
+		$this->zones[ ] = $zone;
 
 		return $zone;
 	}
@@ -97,13 +97,13 @@ 
 		$this->assertEquals( count( $data ), 1 );
 		$this->assertContains(
 			array(
-				'id'     => $data[0]['id'],
+				'id'     => $data[ 0 ][ 'id' ],
 				'name'   => 'Locations not covered by your other zones',
 				'order'  => 0,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[0]['id'] ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 0 ][ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -113,7 +113,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[0]['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 0 ][ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -131,13 +131,13 @@ 
 		$this->assertEquals( count( $data ), 2 );
 		$this->assertContains(
 			array(
-				'id'     => $data[1]['id'],
+				'id'     => $data[ 1 ][ 'id' ],
 				'name'   => 'Zone 1',
 				'order'  => 0,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[1]['id'] ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 1 ][ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -147,7 +147,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[1]['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 1 ][ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -191,10 +191,10 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/shipping/zones' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
-		$this->assertTrue( $properties['id']['readonly'] );
+		$this->assertTrue( $properties[ 'id' ][ 'readonly' ] );
 		$this->assertArrayHasKey( 'name', $properties );
 		$this->assertArrayHasKey( 'order', $properties );
 	}
@@ -218,13 +218,13 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'     => $data['id'],
+				'id'     => $data[ 'id' ],
 				'name'   => 'Test Zone',
 				'order'  => 1,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data['id'] ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -234,7 +234,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -591,16 +591,16 @@ 
 		foreach ( $method->get_instance_form_fields() as $id => $field ) {
 			$data = array(
 				'id'          => $id,
-				'label'       => $field['title'],
-				'description' => ( empty( $field['description'] ) ? '' : $field['description'] ),
-				'type'        => $field['type'],
+				'label'       => $field[ 'title' ],
+				'description' => ( empty( $field[ 'description' ] ) ? '' : $field[ 'description' ] ),
+				'type'        => $field[ 'type' ],
 				'value'       => $method->instance_settings[ $id ],
-				'default'     => ( empty( $field['default'] ) ? '' : $field['default'] ),
-				'tip'         => ( empty( $field['description'] ) ? '' : $field['description'] ),
-				'placeholder' => ( empty( $field['placeholder'] ) ? '' : $field['placeholder'] ),
+				'default'     => ( empty( $field[ 'default' ] ) ? '' : $field[ 'default' ] ),
+				'tip'         => ( empty( $field[ 'description' ] ) ? '' : $field[ 'description' ] ),
+				'placeholder' => ( empty( $field[ 'placeholder' ] ) ? '' : $field[ 'placeholder' ] ),
 			);
-			if ( ! empty( $field['options'] ) ) {
-				$data['options'] = $field['options'];
+			if ( ! empty( $field[ 'options' ] ) ) {
+				$data[ 'options' ] = $field[ 'options' ];
 			}
 			$settings[ $id ] = $data;
 		}
@@ -610,7 +610,7 @@ 
 		$expected = array(
 			'id'                 => $instance_id,
 			'instance_id'        => $instance_id,
-			'title'              => $method->instance_settings['title'],
+			'title'              => $method->instance_settings[ 'title' ],
 			'order'              => $method->method_order,
 			'enabled'            => ( 'yes' === $method->enabled ),
 			'method_id'          => $method->id,
@@ -690,12 +690,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'taxable', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '0', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'taxable', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '0', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Update a single value
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -709,12 +709,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'taxable', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '5', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'taxable', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '5', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Test multiple settings
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -729,12 +729,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'none', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '10', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'none', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '10', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Test bogus
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -750,8 +750,8 @@ 
 		$this->assertEquals( 400, $response->get_status() );
 
 		// Test other parameters
-		$this->assertTrue( $data['enabled'] );
-		$this->assertEquals( 1, $data['order'] );
+		$this->assertTrue( $data[ 'enabled' ] );
+		$this->assertEquals( 1, $data[ 'order' ] );
 
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
 		$request->set_body_params(
@@ -763,10 +763,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertFalse( $data['enabled'] );
-		$this->assertEquals( 2, $data['order'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '10', $data['settings']['cost']['value'] );
+		$this->assertFalse( $data[ 'enabled' ] );
+		$this->assertEquals( 2, $data[ 'order' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '10', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 	}
 
 	/**
@@ -787,10 +787,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertFalse( $data['enabled'] );
-		$this->assertEquals( 2, $data['order'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '0', $data['settings']['cost']['value'] );
+		$this->assertFalse( $data[ 'enabled' ] );
+		$this->assertEquals( 2, $data[ 'order' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '0', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 	}
 
 	/**

unit-tests/Tests/Version4/PaymentGateways.php

Spacing +25 added lines, -25 removed lines

@@ -178,9 +178,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/payment_gateways/paypal' ) );
 		$paypal   = $response->get_data();
 
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'admin@example.org', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'admin@example.org', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating single setting
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -195,9 +195,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating multiple settings
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -213,9 +213,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// Test other parameters, and recheck settings
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -228,11 +228,11 @@ 
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
 
-		$this->assertFalse( $paypal['enabled'] );
-		$this->assertEquals( 2, $paypal['order'] );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertFalse( $paypal[ 'enabled' ] );
+		$this->assertEquals( 2, $paypal[ 'order' ] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test bogus
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -256,7 +256,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
-		$this->assertEquals( 'authorization', $paypal['settings']['paymentaction']['value'] );
+		$this->assertEquals( 'authorization', $paypal[ 'settings' ][ 'paymentaction' ][ 'value' ] );
 	}
 
 	/**
@@ -304,7 +304,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/payment_gateways' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 9, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -330,7 +330,7 @@ 
 		$gateway->init_form_fields();
 		foreach ( $gateway->form_fields as $id => $field ) {
 			// Make sure we at least have a title and type
-			if ( empty( $field['title'] ) || empty( $field['type'] ) ) {
+			if ( empty( $field[ 'title' ] ) || empty( $field[ 'type' ] ) ) {
 				continue;
 			}
 			// Ignore 'enabled' and 'description', to be in line with \WC_REST_Payment_Gateways_Controller::get_settings.
@@ -339,16 +339,16 @@ 
 			}
 			$data = array(
 				'id'          => $id,
-				'label'       => empty( $field['label'] ) ? $field['title'] : $field['label'],
-				'description' => empty( $field['description'] ) ? '' : $field['description'],
-				'type'        => $field['type'],
+				'label'       => empty( $field[ 'label' ] ) ? $field[ 'title' ] : $field[ 'label' ],
+				'description' => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'type'        => $field[ 'type' ],
 				'value'       => $gateway->settings[ $id ],
-				'default'     => empty( $field['default'] ) ? '' : $field['default'],
-				'tip'         => empty( $field['description'] ) ? '' : $field['description'],
-				'placeholder' => empty( $field['placeholder'] ) ? '' : $field['placeholder'],
+				'default'     => empty( $field[ 'default' ] ) ? '' : $field[ 'default' ],
+				'tip'         => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'placeholder' => empty( $field[ 'placeholder' ] ) ? '' : $field[ 'placeholder' ],
 			);
-			if ( ! empty( $field['options'] ) ) {
-				$data['options'] = $field['options'];
+			if ( ! empty( $field[ 'options' ] ) ) {
+				$data[ 'options' ] = $field[ 'options' ];
 			}
 			$settings[ $id ] = $data;
 		}

unit-tests/Tests/Version4/Products.php

Spacing +75 added lines, -75 removed lines

@@ -74,10 +74,10 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 
 		$this->assertEquals( 2, count( $products ) );
-		$this->assertEquals( 'Dummy Product', $products[0]['name'] );
-		$this->assertEquals( 'DUMMY SKU', $products[0]['sku'] );
-		$this->assertEquals( 'Dummy External Product', $products[1]['name'] );
-		$this->assertEquals( 'DUMMY EXTERNAL SKU', $products[1]['sku'] );
+		$this->assertEquals( 'Dummy Product', $products[ 0 ][ 'name' ] );
+		$this->assertEquals( 'DUMMY SKU', $products[ 0 ][ 'sku' ] );
+		$this->assertEquals( 'Dummy External Product', $products[ 1 ][ 'name' ] );
+		$this->assertEquals( 'DUMMY EXTERNAL SKU', $products[ 1 ][ 'sku' ] );
 	}
 
 	/**
@@ -185,9 +185,9 @@ 
 		$data         = $response->get_data();
 		$date_created = date( 'Y-m-d\TH:i:s', current_time( 'timestamp' ) );
 
-		$this->assertEquals( 'DUMMY SKU', $data['sku'] );
-		$this->assertEquals( 10, $data['regular_price'] );
-		$this->assertEmpty( $data['sale_price'] );
+		$this->assertEquals( 'DUMMY SKU', $data[ 'sku' ] );
+		$this->assertEquals( 10, $data[ 'regular_price' ] );
+		$this->assertEmpty( $data[ 'sale_price' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/products/' . $product->get_id() );
 		$request->set_body_params(
@@ -208,14 +208,14 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertContains( 'Testing', $data['description'] );
-		$this->assertEquals( '8', $data['price'] );
-		$this->assertEquals( '8', $data['sale_price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertEquals( 'FIXED-SKU', $data['sku'] );
-		$this->assertEquals( $date_created, $data['date_created'] );
-		$this->assertContains( 'Dr1Bczxq4q', $data['images'][0]['src'] );
-		$this->assertContains( 'test upload image', $data['images'][0]['alt'] );
+		$this->assertContains( 'Testing', $data[ 'description' ] );
+		$this->assertEquals( '8', $data[ 'price' ] );
+		$this->assertEquals( '8', $data[ 'sale_price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertEquals( 'FIXED-SKU', $data[ 'sku' ] );
+		$this->assertEquals( $date_created, $data[ 'date_created' ] );
+		$this->assertContains( 'Dr1Bczxq4q', $data[ 'images' ][ 0 ][ 'src' ] );
+		$this->assertContains( 'test upload image', $data[ 'images' ][ 0 ][ 'alt' ] );
 		$product->delete( true );
 
 		// test variable product (variations are tested in product-variations.php).
@@ -224,7 +224,7 @@ 
 		$data     = $response->get_data();
 
 		foreach ( array( 'small', 'large' ) as $term_name ) {
-			$this->assertContains( $term_name, $data['attributes'][0]['options'] );
+			$this->assertContains( $term_name, $data[ 'attributes' ][ 0 ][ 'options' ] );
 		}
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/products/' . $product->get_id() );
@@ -256,10 +256,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( array( 'small' ), $data['attributes'][0]['options'] );
+		$this->assertEquals( array( 'small' ), $data[ 'attributes' ][ 0 ][ 'options' ] );
 
 		foreach ( array( 'red', 'yellow' ) as $term_name ) {
-			$this->assertContains( $term_name, $data['attributes'][1]['options'] );
+			$this->assertContains( $term_name, $data[ 'attributes' ][ 1 ][ 'options' ] );
 		}
 
 		$product->delete( true );
@@ -269,8 +269,8 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/products/' . $product->get_id() ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Buy external product', $data['button_text'] );
-		$this->assertEquals( 'http://woocommerce.com', $data['external_url'] );
+		$this->assertEquals( 'Buy external product', $data[ 'button_text' ] );
+		$this->assertEquals( 'http://woocommerce.com', $data[ 'external_url' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/products/' . $product->get_id() );
 		$request->set_body_params(
@@ -282,8 +282,8 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Test API Update', $data['button_text'] );
-		$this->assertEquals( 'http://automattic.com', $data['external_url'] );
+		$this->assertEquals( 'Test API Update', $data[ 'button_text' ] );
+		$this->assertEquals( 'http://automattic.com', $data[ 'external_url' ] );
 	}
 
 	/**
@@ -335,7 +335,7 @@ 
 		);
 		$response          = $this->server->dispatch( $request );
 		$data              = $response->get_data();
-		$shipping_class_id = $data['id'];
+		$shipping_class_id = $data[ 'id' ];
 
 		// Create simple.
 		$request = new WP_REST_Request( 'POST', '/wc/v4/products' );
@@ -351,13 +351,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '10', $data['price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertTrue( $data['purchasable'] );
-		$this->assertEquals( 'DUMMY SKU SIMPLE API', $data['sku'] );
-		$this->assertEquals( 'Test Simple Product', $data['name'] );
-		$this->assertEquals( 'simple', $data['type'] );
-		$this->assertEquals( $shipping_class_id, $data['shipping_class_id'] );
+		$this->assertEquals( '10', $data[ 'price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertTrue( $data[ 'purchasable' ] );
+		$this->assertEquals( 'DUMMY SKU SIMPLE API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test Simple Product', $data[ 'name' ] );
+		$this->assertEquals( 'simple', $data[ 'type' ] );
+		$this->assertEquals( $shipping_class_id, $data[ 'shipping_class_id' ] );
 
 		// Create external.
 		$request = new WP_REST_Request( 'POST', '/wc/v4/products' );
@@ -374,14 +374,14 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '10', $data['price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertFalse( $data['purchasable'] );
-		$this->assertEquals( 'DUMMY SKU EXTERNAL API', $data['sku'] );
-		$this->assertEquals( 'Test External Product', $data['name'] );
-		$this->assertEquals( 'external', $data['type'] );
-		$this->assertEquals( 'Test Button', $data['button_text'] );
-		$this->assertEquals( 'https://wordpress.org', $data['external_url'] );
+		$this->assertEquals( '10', $data[ 'price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertFalse( $data[ 'purchasable' ] );
+		$this->assertEquals( 'DUMMY SKU EXTERNAL API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test External Product', $data[ 'name' ] );
+		$this->assertEquals( 'external', $data[ 'type' ] );
+		$this->assertEquals( 'Test Button', $data[ 'button_text' ] );
+		$this->assertEquals( 'https://wordpress.org', $data[ 'external_url' ] );
 
 		// Create variable.
 		$request = new WP_REST_Request( 'POST', '/wc/v4/products' );
@@ -407,10 +407,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'DUMMY SKU VARIABLE API', $data['sku'] );
-		$this->assertEquals( 'Test Variable Product', $data['name'] );
-		$this->assertEquals( 'variable', $data['type'] );
-		$this->assertEquals( array( 'small', 'medium' ), $data['attributes'][0]['options'] );
+		$this->assertEquals( 'DUMMY SKU VARIABLE API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test Variable Product', $data[ 'name' ] );
+		$this->assertEquals( 'variable', $data[ 'type' ] );
+		$this->assertEquals( array( 'small', 'medium' ), $data[ 'attributes' ][ 0 ][ 'options' ] );
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/products' ) );
 		$products = $response->get_data();
@@ -476,13 +476,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertContains( 'Updated description.', $data['update'][0]['description'] );
-		$this->assertEquals( 'DUMMY SKU BATCH TEST 1', $data['create'][0]['sku'] );
-		$this->assertEquals( 'DUMMY SKU BATCH TEST 2', $data['create'][1]['sku'] );
-		$this->assertEquals( 'Test Button', $data['create'][0]['button_text'] );
-		$this->assertEquals( 'external', $data['create'][0]['type'] );
-		$this->assertEquals( 'simple', $data['create'][1]['type'] );
-		$this->assertEquals( $product_2->get_id(), $data['delete'][0]['previous']['id'] );
+		$this->assertContains( 'Updated description.', $data[ 'update' ][ 0 ][ 'description' ] );
+		$this->assertEquals( 'DUMMY SKU BATCH TEST 1', $data[ 'create' ][ 0 ][ 'sku' ] );
+		$this->assertEquals( 'DUMMY SKU BATCH TEST 2', $data[ 'create' ][ 1 ][ 'sku' ] );
+		$this->assertEquals( 'Test Button', $data[ 'create' ][ 0 ][ 'button_text' ] );
+		$this->assertEquals( 'external', $data[ 'create' ][ 0 ][ 'type' ] );
+		$this->assertEquals( 'simple', $data[ 'create' ][ 1 ][ 'type' ] );
+		$this->assertEquals( $product_2->get_id(), $data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v4/products' );
 		$response = $this->server->dispatch( $request );
@@ -518,7 +518,7 @@ 
 
 		$this->assertEquals( 4, count( $products ) );
 		foreach ( $products as $product ) {
-			$this->assertEquals( 'publish', $product['status'] );
+			$this->assertEquals( 'publish', $product[ 'status' ] );
 		}
 
 		// Test filtering with status=draft.
@@ -529,7 +529,7 @@ 
 
 		$this->assertEquals( 4, count( $products ) );
 		foreach ( $products as $product ) {
-			$this->assertEquals( 'draft', $product['status'] );
+			$this->assertEquals( 'draft', $product[ 'status' ] );
 		}
 
 		// Test filtering with no filters - which should return 'any' (all 8).
@@ -550,7 +550,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/products/' . $product->get_id() );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 65, count( $properties ) );
 	}
 
@@ -564,7 +564,7 @@ 
 		$category = wp_insert_term( 'Some Category', 'product_cat' );
 
 		$product = new \WC_Product_Simple();
-		$product->set_category_ids( array( $category['term_id'] ) );
+		$product->set_category_ids( array( $category[ 'term_id' ] ) );
 		$product->save();
 
 		// Create one product without category, i.e. Uncategorized.
@@ -573,7 +573,7 @@ 
 
 		// Test product assigned to a single category.
 		$query_params = array(
-			'category' => (string) $category['term_id'],
+			'category' => (string) $category[ 'term_id' ],
 		);
 		$request      = new WP_REST_Request( 'GET', '/wc/v4/products' );
 		$request->set_query_params( $query_params );
@@ -582,8 +582,8 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $product->get_id(), $response_product['id'] );
-			$this->assertEquals( $product->get_category_ids(), wp_list_pluck( $response_product['categories'], 'id' ) );
+			$this->assertEquals( $product->get_id(), $response_product[ 'id' ] );
+			$this->assertEquals( $product->get_category_ids(), wp_list_pluck( $response_product[ 'categories' ], 'id' ) );
 		}
 
 		// Test product without categories.
@@ -592,8 +592,8 @@ 
 		$response_product = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertCount( 1, $response_product['categories'], print_r( $response_product, true ) );
-		$this->assertEquals( 'uncategorized', $response_product['categories'][0]['slug'] );
+		$this->assertCount( 1, $response_product[ 'categories' ], print_r( $response_product, true ) );
+		$this->assertEquals( 'uncategorized', $response_product[ 'categories' ][ 0 ][ 'slug' ] );
 
 	}
 
@@ -616,7 +616,7 @@ 
 		);
 
 		foreach ( $grouped->get_children() as $additional_product ) {
-			$product_ids_for_type['simple'][] = $additional_product;
+			$product_ids_for_type[ 'simple' ][ ] = $additional_product;
 		}
 
 		foreach ( $product_ids_for_type as $product_type => $product_ids ) {
@@ -631,7 +631,7 @@ 
 			$this->assertEquals( 200, $response->get_status() );
 			$this->assertEquals( count( $product_ids ), count( $response_products ) );
 			foreach ( $response_products as $response_product ) {
-				$this->assertContains( $response_product['id'], $product_ids_for_type[ $product_type ], 'REST API: ' . $product_type . ' not found correctly' );
+				$this->assertContains( $response_product[ 'id' ], $product_ids_for_type[ $product_type ], 'REST API: ' . $product_type . ' not found correctly' );
 			}
 		}
 	}
@@ -661,7 +661,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $feat_product->get_id(), $response_product['id'], 'REST API: Featured product not found correctly' );
+			$this->assertEquals( $feat_product->get_id(), $response_product[ 'id' ], 'REST API: Featured product not found correctly' );
 		}
 
 		$query_params = array(
@@ -674,7 +674,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $nonfeat_product->get_id(), $response_product['id'], 'REST API: Featured product not found correctly' );
+			$this->assertEquals( $nonfeat_product->get_id(), $response_product[ 'id' ], 'REST API: Featured product not found correctly' );
 		}
 	}
 
@@ -687,11 +687,11 @@ 
 		$shipping_class_1 = wp_insert_term( 'Bulky', 'product_shipping_class' );
 
 		$product_1 = new \WC_Product_Simple();
-		$product_1->set_shipping_class_id( $shipping_class_1['term_id'] );
+		$product_1->set_shipping_class_id( $shipping_class_1[ 'term_id' ] );
 		$product_1->save();
 
 		$query_params = array(
-			'shipping_class' => (string) $shipping_class_1['term_id'],
+			'shipping_class' => (string) $shipping_class_1[ 'term_id' ],
 		);
 		$request      = new WP_REST_Request( 'GET', '/wc/v4/products' );
 		$request->set_query_params( $query_params );
@@ -700,7 +700,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $product_1->get_id(), $response_product['id'] );
+			$this->assertEquals( $product_1->get_id(), $response_product[ 'id' ] );
 		}
 	}
 
@@ -714,14 +714,14 @@ 
 
 		// Product with a tag.
 		$product = ProductHelper::create_simple_product();
-		$product->set_tag_ids( array( $test_tag_1['term_id'] ) );
+		$product->set_tag_ids( array( $test_tag_1[ 'term_id' ] ) );
 		$product->save();
 
 		// Product without a tag.
 		$product_2 = ProductHelper::create_simple_product();
 
 		$query_params = array(
-			'tag' => (string) $test_tag_1['term_id'],
+			'tag' => (string) $test_tag_1[ 'term_id' ],
 		);
 		$request      = new WP_REST_Request( 'GET', '/wc/v4/products' );
 		$request->set_query_params( $query_params );
@@ -730,7 +730,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $product->get_id(), $response_product['id'] );
+			$this->assertEquals( $product->get_id(), $response_product[ 'id' ] );
 		}
 	}
 
@@ -772,11 +772,11 @@ 
 			$variable_product->get_id(),
 			$product_2->get_id(),
 		);
-		$query_params         = array(
+		$query_params = array(
 			'attribute'      => 'pa_size',
 			'attribute_term' => (string) $term_large->term_id,
 		);
-		$request              = new WP_REST_Request( 'GET', '/wc/v4/products' );
+		$request = new WP_REST_Request( 'GET', '/wc/v4/products' );
 		$request->set_query_params( $query_params );
 		$response          = $this->server->dispatch( $request );
 		$response_products = $response->get_data();
@@ -784,7 +784,7 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( count( $expected_product_ids ), count( $response_products ) );
 		foreach ( $response_products as $response_product ) {
-			$this->assertContains( $response_product['id'], $expected_product_ids );
+			$this->assertContains( $response_product[ 'id' ], $expected_product_ids );
 		}
 
 		// Products with attribute size == small.
@@ -795,7 +795,7 @@ 
 			'attribute'      => 'pa_size',
 			'attribute_term' => (string) $term_small->term_id,
 		);
-		$request              = new WP_REST_Request( 'GET', '/wc/v4/products' );
+		$request = new WP_REST_Request( 'GET', '/wc/v4/products' );
 		$request->set_query_params( $query_params );
 		$response          = $this->server->dispatch( $request );
 		$response_products = $response->get_data();
@@ -803,7 +803,7 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( count( $expected_product_ids ), count( $response_products ) );
 		foreach ( $response_products as $response_product ) {
-			$this->assertContains( $response_product['id'], $expected_product_ids );
+			$this->assertContains( $response_product[ 'id' ], $expected_product_ids );
 		}
 	}
 
@@ -815,7 +815,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/products/' . $product->get_id() );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$properties_to_embed = array(
 			'id',
@@ -829,7 +829,7 @@ 
 
 		foreach ( $properties as $property_key => $property ) {
 			if ( in_array( $property_key, $properties_to_embed, true ) ) {
-				$this->assertEquals( array( 'view', 'edit', 'embed' ), $property['context'] );
+				$this->assertEquals( array( 'view', 'edit', 'embed' ), $property[ 'context' ] );
 			}
 		}
 

unit-tests/Tests/Version4/ProductVariations.php

Spacing +40 added lines, -40 removed lines

@@ -67,8 +67,8 @@ 
 		$variations = $response->get_data();
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( 2, count( $variations ) );
-		$this->assertEquals( 'DUMMY SKU VARIABLE LARGE', $variations[0]['sku'] );
-		$this->assertEquals( 'size', $variations[0]['attributes'][0]['name'] );
+		$this->assertEquals( 'DUMMY SKU VARIABLE LARGE', $variations[ 0 ][ 'sku' ] );
+		$this->assertEquals( 'size', $variations[ 0 ][ 'attributes' ][ 0 ][ 'name' ] );
 	}
 
 	/**
@@ -91,14 +91,14 @@ 
 	public function test_get_variation() {
 		$product      = ProductHelper::create_variation_product();
 		$children     = $product->get_children();
-		$variation_id = $children[0];
+		$variation_id = $children[ 0 ];
 
 		$response  = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id ) );
 		$variation = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( $variation_id, $variation['id'] );
-		$this->assertEquals( 'size', $variation['attributes'][0]['name'] );
+		$this->assertEquals( $variation_id, $variation[ 'id' ] );
+		$this->assertEquals( 'size', $variation[ 'attributes' ][ 0 ][ 'name' ] );
 	}
 
 	/**
@@ -110,7 +110,7 @@ 
 		wp_set_current_user( 0 );
 		$product      = ProductHelper::create_variation_product();
 		$children     = $product->get_children();
-		$variation_id = $children[0];
+		$variation_id = $children[ 0 ];
 		$response     = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id ) );
 		$this->assertEquals( 401, $response->get_status() );
 	}
@@ -123,7 +123,7 @@ 
 	public function test_delete_variation() {
 		$product      = ProductHelper::create_variation_product();
 		$children     = $product->get_children();
-		$variation_id = $children[0];
+		$variation_id = $children[ 0 ];
 
 		$request = new WP_REST_Request( 'DELETE', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id );
 		$request->set_param( 'force', true );
@@ -144,7 +144,7 @@ 
 		wp_set_current_user( 0 );
 		$product      = ProductHelper::create_variation_product();
 		$children     = $product->get_children();
-		$variation_id = $children[0];
+		$variation_id = $children[ 0 ];
 
 		$request = new WP_REST_Request( 'DELETE', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id );
 		$request->set_param( 'force', true );
@@ -174,15 +174,15 @@ 
 	public function test_update_variation() {
 		$product      = ProductHelper::create_variation_product();
 		$children     = $product->get_children();
-		$variation_id = $children[0];
+		$variation_id = $children[ 0 ];
 
 		$response  = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id ) );
 		$variation = $response->get_data();
 
-		$this->assertEquals( 'DUMMY SKU VARIABLE SMALL', $variation['sku'] );
-		$this->assertEquals( 10, $variation['regular_price'] );
-		$this->assertEmpty( $variation['sale_price'] );
-		$this->assertEquals( 'small', $variation['attributes'][0]['option'] );
+		$this->assertEquals( 'DUMMY SKU VARIABLE SMALL', $variation[ 'sku' ] );
+		$this->assertEquals( 10, $variation[ 'regular_price' ] );
+		$this->assertEmpty( $variation[ 'sale_price' ] );
+		$this->assertEquals( 'small', $variation[ 'attributes' ][ 0 ][ 'option' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id );
 		$request->set_body_params(
@@ -206,15 +206,15 @@ 
 		$response  = $this->server->dispatch( $request );
 		$variation = $response->get_data();
 
-		$this->assertTrue( isset( $variation['description'] ), print_r( $variation, true ) );
-		$this->assertContains( 'O_O', $variation['description'], print_r( $variation, true ) );
-		$this->assertEquals( '8', $variation['price'], print_r( $variation, true ) );
-		$this->assertEquals( '8', $variation['sale_price'], print_r( $variation, true ) );
-		$this->assertEquals( '10', $variation['regular_price'], print_r( $variation, true ) );
-		$this->assertEquals( 'FIXED-\'SKU', $variation['sku'], print_r( $variation, true ) );
-		$this->assertEquals( 'medium', $variation['attributes'][0]['option'], print_r( $variation, true ) );
-		$this->assertContains( 'Dr1Bczxq4q', $variation['image']['src'], print_r( $variation, true ) );
-		$this->assertContains( 'test upload image', $variation['image']['alt'], print_r( $variation, true ) );
+		$this->assertTrue( isset( $variation[ 'description' ] ), print_r( $variation, true ) );
+		$this->assertContains( 'O_O', $variation[ 'description' ], print_r( $variation, true ) );
+		$this->assertEquals( '8', $variation[ 'price' ], print_r( $variation, true ) );
+		$this->assertEquals( '8', $variation[ 'sale_price' ], print_r( $variation, true ) );
+		$this->assertEquals( '10', $variation[ 'regular_price' ], print_r( $variation, true ) );
+		$this->assertEquals( 'FIXED-\'SKU', $variation[ 'sku' ], print_r( $variation, true ) );
+		$this->assertEquals( 'medium', $variation[ 'attributes' ][ 0 ][ 'option' ], print_r( $variation, true ) );
+		$this->assertContains( 'Dr1Bczxq4q', $variation[ 'image' ][ 'src' ], print_r( $variation, true ) );
+		$this->assertContains( 'test upload image', $variation[ 'image' ][ 'alt' ], print_r( $variation, true ) );
 	}
 
 	/**
@@ -226,7 +226,7 @@ 
 		wp_set_current_user( 0 );
 		$product      = ProductHelper::create_variation_product();
 		$children     = $product->get_children();
-		$variation_id = $children[0];
+		$variation_id = $children[ 0 ];
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id );
 		$request->set_body_params(
@@ -284,12 +284,12 @@ 
 		$response  = $this->server->dispatch( $request );
 		$variation = $response->get_data();
 
-		$this->assertContains( 'A medium size.', $variation['description'] );
-		$this->assertEquals( '12', $variation['price'] );
-		$this->assertEquals( '12', $variation['regular_price'] );
-		$this->assertTrue( $variation['purchasable'] );
-		$this->assertEquals( 'DUMMY SKU VARIABLE MEDIUM', $variation['sku'] );
-		$this->assertEquals( 'medium', $variation['attributes'][0]['option'] );
+		$this->assertContains( 'A medium size.', $variation[ 'description' ] );
+		$this->assertEquals( '12', $variation[ 'price' ] );
+		$this->assertEquals( '12', $variation[ 'regular_price' ] );
+		$this->assertTrue( $variation[ 'purchasable' ] );
+		$this->assertEquals( 'DUMMY SKU VARIABLE MEDIUM', $variation[ 'sku' ] );
+		$this->assertEquals( 'medium', $variation[ 'attributes' ][ 0 ][ 'option' ] );
 
 		$response   = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/products/' . $product->get_id() . '/variations' ) );
 		$variations = $response->get_data();
@@ -336,7 +336,7 @@ 
 			array(
 				'update' => array(
 					array(
-						'id'          => $children[0],
+						'id'          => $children[ 0 ],
 						'description' => 'Updated description.',
 						'image'       => array(
 							'position' => 0,
@@ -346,7 +346,7 @@ 
 					),
 				),
 				'delete' => array(
-					$children[1],
+					$children[ 1 ],
 				),
 				'create' => array(
 					array(
@@ -366,10 +366,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertContains( 'Updated description.', $data['update'][0]['description'] );
-		$this->assertEquals( 'DUMMY SKU VARIABLE MEDIUM', $data['create'][0]['sku'] );
-		$this->assertEquals( 'medium', $data['create'][0]['attributes'][0]['option'] );
-		$this->assertEquals( $children[1], $data['delete'][0]['previous']['id'] );
+		$this->assertContains( 'Updated description.', $data[ 'update' ][ 0 ][ 'description' ] );
+		$this->assertEquals( 'DUMMY SKU VARIABLE MEDIUM', $data[ 'create' ][ 0 ][ 'sku' ] );
+		$this->assertEquals( 'medium', $data[ 'create' ][ 0 ][ 'attributes' ][ 0 ][ 'option' ] );
+		$this->assertEquals( $children[ 1 ], $data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v4/products/' . $product->get_id() . '/variations' );
 		$response = $this->server->dispatch( $request );
@@ -388,7 +388,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/products/' . $product->get_id() . '/variations' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 40, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -438,7 +438,7 @@ 
 		$product->save();
 
 		$children     = $product->get_children();
-		$variation_id = $children[0];
+		$variation_id = $children[ 0 ];
 
 		// Set stock to true.
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id );
@@ -452,7 +452,7 @@ 
 		$variation = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( true, $variation['manage_stock'] );
+		$this->assertEquals( true, $variation[ 'manage_stock' ] );
 
 		// Set stock to false.
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/products/' . $product->get_id() . '/variations/' . $variation_id );
@@ -466,7 +466,7 @@ 
 		$variation = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( false, $variation['manage_stock'] );
+		$this->assertEquals( false, $variation[ 'manage_stock' ] );
 
 		// Set stock to false but parent is managing stock.
 		$product->set_manage_stock( true );
@@ -482,6 +482,6 @@ 
 		$variation = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'parent', $variation['manage_stock'] );
+		$this->assertEquals( 'parent', $variation[ 'manage_stock' ] );
 	}
 }

unit-tests/Tests/Version4/Data.php

Spacing +3 added lines, -3 removed lines

@@ -59,7 +59,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( 4, count( $data ) );
-		$this->assertEquals( 'download-ips', $data[3]['slug'] );
+		$this->assertEquals( 'download-ips', $data[ 3 ][ 'slug' ] );
 	}
 
 	/**
@@ -127,7 +127,7 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( 2, count( $addresses ) );
 
-		$this->assertEquals( '54.2.1.3', $addresses[0]['user_ip_address'] );
-		$this->assertEquals( '54.5.1.7', $addresses[1]['user_ip_address'] );
+		$this->assertEquals( '54.2.1.3', $addresses[ 0 ][ 'user_ip_address' ] );
+		$this->assertEquals( '54.5.1.7', $addresses[ 1 ][ 'user_ip_address' ] );
 	}
 }

unit-tests/Tests/Version4/Settings.php

Spacing +44 added lines, -44 removed lines

@@ -142,7 +142,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/settings' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 5, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
 		$this->assertArrayHasKey( 'parent_id', $properties );
@@ -160,7 +160,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/settings/test/woocommerce_shop_page_display' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 10, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
 		$this->assertArrayHasKey( 'label', $properties );
@@ -196,8 +196,8 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/test' ) );
 		$data     = $response->get_data();
 		$this->assertEquals( 1, count( $data ) );
-		$this->assertEquals( 'woocommerce_shop_page_display', $data[0]['id'] );
-		$this->assertEmpty( $data[0]['value'] );
+		$this->assertEquals( 'woocommerce_shop_page_display', $data[ 0 ][ 'id' ] );
+		$this->assertEmpty( $data[ 0 ][ 'value' ] );
 	}
 
 	/**
@@ -221,7 +221,7 @@ 
 		// test defaults first
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/test/woocommerce_shop_page_display' ) );
 		$data     = $response->get_data();
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( '', $data[ 'value' ] );
 
 		// test updating shop display setting
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -233,7 +233,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'both', $data['value'] );
+		$this->assertEquals( 'both', $data[ 'value' ] );
 		$this->assertEquals( 'both', get_option( 'woocommerce_shop_page_display' ) );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -245,7 +245,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'subcategories', $data['value'] );
+		$this->assertEquals( 'subcategories', $data[ 'value' ] );
 		$this->assertEquals( 'subcategories', get_option( 'woocommerce_shop_page_display' ) );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -257,7 +257,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( '', $data[ 'value' ] );
 		$this->assertEquals( '', get_option( 'woocommerce_shop_page_display' ) );
 	}
 
@@ -270,7 +270,7 @@ 
 		// test defaults first
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/test' ) );
 		$data     = $response->get_data();
-		$this->assertEquals( '', $data[0]['value'] );
+		$this->assertEquals( '', $data[ 0 ][ 'value' ] );
 
 		// test setting both at once
 		$request = new WP_REST_Request( 'POST', '/wc/v4/settings/test/batch' );
@@ -287,7 +287,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'both', $data['update'][0]['value'] );
+		$this->assertEquals( 'both', $data[ 'update' ][ 0 ][ 'value' ] );
 		$this->assertEquals( 'both', get_option( 'woocommerce_shop_page_display' ) );
 
 		// test updating one, but making sure the other value stays the same
@@ -304,7 +304,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$this->assertEquals( 'subcategories', $data['update'][0]['value'] );
+		$this->assertEquals( 'subcategories', $data[ 'update' ][ 0 ][ 'value' ] );
 		$this->assertEquals( 'subcategories', get_option( 'woocommerce_shop_page_display' ) );
 	}
 
@@ -330,11 +330,11 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'woocommerce_shop_page_display', $data['id'] );
-		$this->assertEquals( 'Shop page display', $data['label'] );
-		$this->assertEquals( '', $data['default'] );
-		$this->assertEquals( 'select', $data['type'] );
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( 'woocommerce_shop_page_display', $data[ 'id' ] );
+		$this->assertEquals( 'Shop page display', $data[ 'label' ] );
+		$this->assertEquals( '', $data[ 'default' ] );
+		$this->assertEquals( 'select', $data[ 'type' ] );
+		$this->assertEquals( '', $data[ 'value' ] );
 	}
 
 	/**
@@ -491,7 +491,7 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/products/woocommerce_dimension_unit' ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'cm', $data['default'] );
+		$this->assertEquals( 'cm', $data[ 'default' ] );
 
 		// test update
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'products', 'woocommerce_dimension_unit' ) );
@@ -503,7 +503,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'yd', $data['value'] );
+		$this->assertEquals( 'yd', $data[ 'value' ] );
 		$this->assertEquals( 'yd', get_option( 'woocommerce_dimension_unit' ) );
 	}
 
@@ -590,7 +590,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
 
-		$this->assertEmpty( $setting['value'] );
+		$this->assertEmpty( $setting[ 'value' ] );
 
 		// test update
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'email_customer_new_account', 'subject' ) );
@@ -602,13 +602,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'This is my new subject', $setting['value'] );
+		$this->assertEquals( 'This is my new subject', $setting[ 'value' ] );
 
 		// make sure the other is what we left it
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/email_new_order/subject' ) );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'This is my subject', $setting['value'] );
+		$this->assertEquals( 'This is my subject', $setting[ 'value' ] );
 	}
 
 	/**
@@ -683,7 +683,7 @@ 
 	public function test_validation_multiselect() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', sprintf( '/wc/v4/settings/%s/%s', 'general', 'woocommerce_specific_allowed_countries' ) ) );
 		$setting  = $response->get_data();
-		$this->assertEmpty( $setting['value'] );
+		$this->assertEmpty( $setting[ 'value' ] );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'general', 'woocommerce_specific_allowed_countries' ) );
 		$request->set_body_params(
@@ -693,7 +693,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( array( 'AX', 'DZ' ), $setting['value'] );
+		$this->assertEquals( array( 'AX', 'DZ' ), $setting[ 'value' ] );
 	}
 
 	/**
@@ -704,7 +704,7 @@ 
 	public function test_validation_select() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', sprintf( '/wc/v4/settings/%s/%s', 'products', 'woocommerce_weight_unit' ) ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'kg', $setting['value'] );
+		$this->assertEquals( 'kg', $setting[ 'value' ] );
 
 		// invalid
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'products', 'woocommerce_weight_unit' ) );
@@ -725,7 +725,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'lbs', $setting['value'] );
+		$this->assertEquals( 'lbs', $setting[ 'value' ] );
 	}
 
 	/**
@@ -739,9 +739,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_default_country' ) );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'select', $setting['type'] );
-		$this->assertArrayHasKey( 'GB', $setting['options'] );
-		$this->assertArrayHasKey( 'US:OR', $setting['options'] );
+		$this->assertEquals( 'select', $setting[ 'type' ] );
+		$this->assertArrayHasKey( 'GB', $setting[ 'options' ] );
+		$this->assertArrayHasKey( 'US:OR', $setting[ 'options' ] );
 	}
 
 	/**
@@ -752,10 +752,10 @@ 
 	public function test_woocommerce_store_address() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_address' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address' );
 		$request->set_body_params(
@@ -765,7 +765,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address' );
@@ -776,7 +776,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -787,10 +787,10 @@ 
 	public function test_woocommerce_store_address_2() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_address_2' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address_2' );
 		$request->set_body_params(
@@ -800,7 +800,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address_2' );
@@ -811,7 +811,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -822,10 +822,10 @@ 
 	public function test_woocommerce_store_city() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_city' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_city' );
 		$request->set_body_params(
@@ -835,7 +835,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_city' );
@@ -846,7 +846,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -857,10 +857,10 @@ 
 	public function test_woocommerce_store_postcode() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_postcode' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_postcode' );
 		$request->set_body_params(
@@ -870,7 +870,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_postcode' );
@@ -881,6 +881,6 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 }