woocommerce / woocommerce-rest-api

unit-tests/Tests/Version3/orders.php

Spacing +53 added lines, -53 removed lines

@@ -50,7 +50,7 @@ 
 
 		// Create 10 orders.
 		for ( $i = 0; $i < 10; $i++ ) {
-			$this->orders[] = \Automattic\WooCommerce\RestApi\UnitTests\Helpers\OrderHelper::create_order( $this->user );
+			$this->orders[ ] = \Automattic\WooCommerce\RestApi\UnitTests\Helpers\OrderHelper::create_order( $this->user );
 		}
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/orders' ) );
@@ -67,7 +67,7 @@ 
 	 */
 	public function test_get_items_without_permission() {
 		wp_set_current_user( 0 );
-		$this->orders[] = \Automattic\WooCommerce\RestApi\UnitTests\Helpers\OrderHelper::create_order();
+		$this->orders[ ] = \Automattic\WooCommerce\RestApi\UnitTests\Helpers\OrderHelper::create_order();
 		$response       = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/orders' ) );
 		$this->assertEquals( 401, $response->get_status() );
 	}
@@ -82,18 +82,18 @@ 
 		$order->add_meta_data( 'key', 'value' );
 		$order->add_meta_data( 'key2', 'value2' );
 		$order->save();
-		$this->orders[] = $order;
+		$this->orders[ ] = $order;
 		$response       = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/orders/' . $order->get_id() ) );
 		$data           = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( $order->get_id(), $data['id'] );
+		$this->assertEquals( $order->get_id(), $data[ 'id' ] );
 
 		// Test meta data is set.
-		$this->assertEquals( 'key', $data['meta_data'][0]->key );
-		$this->assertEquals( 'value', $data['meta_data'][0]->value );
-		$this->assertEquals( 'key2', $data['meta_data'][1]->key );
-		$this->assertEquals( 'value2', $data['meta_data'][1]->value );
+		$this->assertEquals( 'key', $data[ 'meta_data' ][ 0 ]->key );
+		$this->assertEquals( 'value', $data[ 'meta_data' ][ 0 ]->value );
+		$this->assertEquals( 'key2', $data[ 'meta_data' ][ 1 ]->key );
+		$this->assertEquals( 'value2', $data[ 'meta_data' ][ 1 ]->value );
 	}
 
 	/**
@@ -103,7 +103,7 @@ 
 	public function test_get_item_without_permission() {
 		wp_set_current_user( 0 );
 		$order          = \Automattic\WooCommerce\RestApi\UnitTests\Helpers\OrderHelper::create_order();
-		$this->orders[] = $order;
+		$this->orders[ ] = $order;
 		$response       = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/orders/' . $order->get_id() ) );
 		$this->assertEquals( 401, $response->get_status() );
 	}
@@ -186,32 +186,32 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$order    = wc_get_order( $data['id'] );
+		$order    = wc_get_order( $data[ 'id' ] );
 		$this->assertEquals( 201, $response->get_status() );
-		$this->assertEquals( $order->get_payment_method(), $data['payment_method'] );
-		$this->assertEquals( $order->get_payment_method_title(), $data['payment_method_title'] );
-		$this->assertEquals( $order->get_billing_first_name(), $data['billing']['first_name'] );
-		$this->assertEquals( $order->get_billing_last_name(), $data['billing']['last_name'] );
-		$this->assertEquals( '', $data['billing']['company'] );
-		$this->assertEquals( $order->get_billing_address_1(), $data['billing']['address_1'] );
-		$this->assertEquals( $order->get_billing_address_2(), $data['billing']['address_2'] );
-		$this->assertEquals( $order->get_billing_city(), $data['billing']['city'] );
-		$this->assertEquals( $order->get_billing_state(), $data['billing']['state'] );
-		$this->assertEquals( $order->get_billing_postcode(), $data['billing']['postcode'] );
-		$this->assertEquals( $order->get_billing_country(), $data['billing']['country'] );
-		$this->assertEquals( $order->get_billing_email(), $data['billing']['email'] );
-		$this->assertEquals( $order->get_billing_phone(), $data['billing']['phone'] );
-		$this->assertEquals( $order->get_shipping_first_name(), $data['shipping']['first_name'] );
-		$this->assertEquals( $order->get_shipping_last_name(), $data['shipping']['last_name'] );
-		$this->assertEquals( '', $data['shipping']['company'] );
-		$this->assertEquals( $order->get_shipping_address_1(), $data['shipping']['address_1'] );
-		$this->assertEquals( $order->get_shipping_address_2(), $data['shipping']['address_2'] );
-		$this->assertEquals( $order->get_shipping_city(), $data['shipping']['city'] );
-		$this->assertEquals( $order->get_shipping_state(), $data['shipping']['state'] );
-		$this->assertEquals( $order->get_shipping_postcode(), $data['shipping']['postcode'] );
-		$this->assertEquals( $order->get_shipping_country(), $data['shipping']['country'] );
-		$this->assertEquals( 1, count( $data['line_items'] ) );
-		$this->assertEquals( 1, count( $data['shipping_lines'] ) );
+		$this->assertEquals( $order->get_payment_method(), $data[ 'payment_method' ] );
+		$this->assertEquals( $order->get_payment_method_title(), $data[ 'payment_method_title' ] );
+		$this->assertEquals( $order->get_billing_first_name(), $data[ 'billing' ][ 'first_name' ] );
+		$this->assertEquals( $order->get_billing_last_name(), $data[ 'billing' ][ 'last_name' ] );
+		$this->assertEquals( '', $data[ 'billing' ][ 'company' ] );
+		$this->assertEquals( $order->get_billing_address_1(), $data[ 'billing' ][ 'address_1' ] );
+		$this->assertEquals( $order->get_billing_address_2(), $data[ 'billing' ][ 'address_2' ] );
+		$this->assertEquals( $order->get_billing_city(), $data[ 'billing' ][ 'city' ] );
+		$this->assertEquals( $order->get_billing_state(), $data[ 'billing' ][ 'state' ] );
+		$this->assertEquals( $order->get_billing_postcode(), $data[ 'billing' ][ 'postcode' ] );
+		$this->assertEquals( $order->get_billing_country(), $data[ 'billing' ][ 'country' ] );
+		$this->assertEquals( $order->get_billing_email(), $data[ 'billing' ][ 'email' ] );
+		$this->assertEquals( $order->get_billing_phone(), $data[ 'billing' ][ 'phone' ] );
+		$this->assertEquals( $order->get_shipping_first_name(), $data[ 'shipping' ][ 'first_name' ] );
+		$this->assertEquals( $order->get_shipping_last_name(), $data[ 'shipping' ][ 'last_name' ] );
+		$this->assertEquals( '', $data[ 'shipping' ][ 'company' ] );
+		$this->assertEquals( $order->get_shipping_address_1(), $data[ 'shipping' ][ 'address_1' ] );
+		$this->assertEquals( $order->get_shipping_address_2(), $data[ 'shipping' ][ 'address_2' ] );
+		$this->assertEquals( $order->get_shipping_city(), $data[ 'shipping' ][ 'city' ] );
+		$this->assertEquals( $order->get_shipping_state(), $data[ 'shipping' ][ 'state' ] );
+		$this->assertEquals( $order->get_shipping_postcode(), $data[ 'shipping' ][ 'postcode' ] );
+		$this->assertEquals( $order->get_shipping_country(), $data[ 'shipping' ][ 'country' ] );
+		$this->assertEquals( 1, count( $data[ 'line_items' ] ) );
+		$this->assertEquals( 1, count( $data[ 'shipping_lines' ] ) );
 	}
 
 	/**
@@ -269,13 +269,13 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$order    = wc_get_order( $data['id'] );
+		$order    = wc_get_order( $data[ 'id' ] );
 		$this->assertEquals( 201, $response->get_status() );
-		$this->assertEquals( $order->get_payment_method(), $data['payment_method'] );
+		$this->assertEquals( $order->get_payment_method(), $data[ 'payment_method' ] );
 		$this->assertEquals( $order->get_payment_method_title(), 'Sanitize this' );
 
 		// Test when updating order.
-		$request = new WP_REST_Request( 'PUT', '/wc/v3/orders/' . $data['id'] );
+		$request = new WP_REST_Request( 'PUT', '/wc/v3/orders/' . $data[ 'id' ] );
 		$request->set_body_params(
 			array(
 				'payment_method'       => 'bacs',
@@ -284,9 +284,9 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$order    = wc_get_order( $data['id'] );
+		$order    = wc_get_order( $data[ 'id' ] );
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( $order->get_payment_method(), $data['payment_method'] );
+		$this->assertEquals( $order->get_payment_method(), $data[ 'payment_method' ] );
 		$this->assertEquals( $order->get_payment_method_title(), 'Sanitize this too' );
 	}
 
@@ -370,9 +370,9 @@ 
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'test-update', $data['payment_method'] );
-		$this->assertEquals( 'Fish', $data['billing']['first_name'] );
-		$this->assertEquals( 'Face', $data['billing']['last_name'] );
+		$this->assertEquals( 'test-update', $data[ 'payment_method' ] );
+		$this->assertEquals( 'Fish', $data[ 'billing' ][ 'first_name' ] );
+		$this->assertEquals( 'Face', $data[ 'billing' ][ 'last_name' ] );
 	}
 
 	/**
@@ -412,7 +412,7 @@ 
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertTrue( empty( $data['fee_lines'] ) );
+		$this->assertTrue( empty( $data[ 'fee_lines' ] ) );
 	}
 
 	/**
@@ -443,8 +443,8 @@ 
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertCount( 1, $data['coupon_lines'] );
-		$this->assertEquals( '45.00', $data['total'] );
+		$this->assertCount( 1, $data[ 'coupon_lines' ] );
+		$this->assertEquals( '45.00', $data[ 'total' ] );
 	}
 
 	/**
@@ -490,8 +490,8 @@ 
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertTrue( empty( $data['coupon_lines'] ) );
-		$this->assertEquals( '50.00', $data['total'] );
+		$this->assertTrue( empty( $data[ 'coupon_lines' ] ) );
+		$this->assertEquals( '50.00', $data[ 'total' ] );
 	}
 
 	/**
@@ -517,8 +517,8 @@ 
 		$data     = $response->get_data();
 
 		$this->assertEquals( 400, $response->get_status() );
-		$this->assertEquals( 'woocommerce_rest_invalid_coupon', $data['code'] );
-		$this->assertEquals( 'Coupon "non_existing_coupon" does not exist!', $data['message'] );
+		$this->assertEquals( 'woocommerce_rest_invalid_coupon', $data[ 'code' ] );
+		$this->assertEquals( 'Coupon "non_existing_coupon" does not exist!', $data[ 'message' ] );
 	}
 
 	/**
@@ -636,9 +636,9 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'updated', $data['update'][0]['payment_method'] );
-		$this->assertEquals( $order2->get_id(), $data['delete'][0]['id'] );
-		$this->assertEquals( $order3->get_id(), $data['delete'][1]['id'] );
+		$this->assertEquals( 'updated', $data[ 'update' ][ 0 ][ 'payment_method' ] );
+		$this->assertEquals( $order2->get_id(), $data[ 'delete' ][ 0 ][ 'id' ] );
+		$this->assertEquals( $order3->get_id(), $data[ 'delete' ][ 1 ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v3/orders' );
 		$response = $this->server->dispatch( $request );
@@ -657,7 +657,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/orders/' . $order->get_id() );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 42, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version3/product-reviews.php

Spacing +23 added lines, -23 removed lines

@@ -53,8 +53,8 @@ 
 		$this->assertContains(
 			array(
 				'id'                   => $review_id,
-				'date_created'         => $product_reviews[0]['date_created'],
-				'date_created_gmt'     => $product_reviews[0]['date_created_gmt'],
+				'date_created'         => $product_reviews[ 0 ][ 'date_created' ],
+				'date_created_gmt'     => $product_reviews[ 0 ][ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'admin',
@@ -62,7 +62,7 @@ 
 				'review'               => "<p>Review content here</p>\n",
 				'rating'               => 0,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $product_reviews[0]['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $product_reviews[ 0 ][ 'reviewer_avatar_urls' ],
 				'_links'               => array(
 					'self'       => array(
 						array(
@@ -125,8 +125,8 @@ 
 		$this->assertEquals(
 			array(
 				'id'                   => $product_review_id,
-				'date_created'         => $data['date_created'],
-				'date_created_gmt'     => $data['date_created_gmt'],
+				'date_created'         => $data[ 'date_created' ],
+				'date_created_gmt'     => $data[ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'admin',
@@ -134,7 +134,7 @@ 
 				'review'               => "<p>Review content here</p>\n",
 				'rating'               => 0,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $data['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $data[ 'reviewer_avatar_urls' ],
 			),
 			$data
 		);
@@ -189,9 +189,9 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                   => $data['id'],
-				'date_created'         => $data['date_created'],
-				'date_created_gmt'     => $data['date_created_gmt'],
+				'id'                   => $data[ 'id' ],
+				'date_created'         => $data[ 'date_created' ],
+				'date_created_gmt'     => $data[ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'Admin',
@@ -199,7 +199,7 @@ 
 				'review'               => 'Hello world.',
 				'rating'               => 5,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $data['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $data[ 'reviewer_avatar_urls' ],
 			),
 			$data
 		);
@@ -266,10 +266,10 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/products/reviews/' . $product_review_id ) );
 		$data     = $response->get_data();
-		$this->assertEquals( "<p>Review content here</p>\n", $data['review'] );
-		$this->assertEquals( 'admin', $data['reviewer'] );
-		$this->assertEquals( 'woo@woo.local', $data['reviewer_email'] );
-		$this->assertEquals( 0, $data['rating'] );
+		$this->assertEquals( "<p>Review content here</p>\n", $data[ 'review' ] );
+		$this->assertEquals( 'admin', $data[ 'reviewer' ] );
+		$this->assertEquals( 'woo@woo.local', $data[ 'reviewer_email' ] );
+		$this->assertEquals( 0, $data[ 'rating' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/products/reviews/' . $product_review_id );
 		$request->set_body_params(
@@ -282,10 +282,10 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$this->assertEquals( 'Hello world - updated.', $data['review'] );
-		$this->assertEquals( 'Justin', $data['reviewer'] );
-		$this->assertEquals( 'woo2@woo.local', $data['reviewer_email'] );
-		$this->assertEquals( 3, $data['rating'] );
+		$this->assertEquals( 'Hello world - updated.', $data[ 'review' ] );
+		$this->assertEquals( 'Justin', $data[ 'reviewer' ] );
+		$this->assertEquals( 'woo2@woo.local', $data[ 'reviewer_email' ] );
+		$this->assertEquals( 3, $data[ 'rating' ] );
 	}
 
 	/**
@@ -424,10 +424,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Updated review.', $data['update'][0]['review'] );
-		$this->assertEquals( 'New review.', $data['create'][0]['review'] );
-		$this->assertEquals( $review_2_id, $data['delete'][0]['previous']['id'] );
-		$this->assertEquals( $review_3_id, $data['delete'][1]['previous']['id'] );
+		$this->assertEquals( 'Updated review.', $data[ 'update' ][ 0 ][ 'review' ] );
+		$this->assertEquals( 'New review.', $data[ 'create' ][ 0 ][ 'review' ] );
+		$this->assertEquals( $review_2_id, $data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
+		$this->assertEquals( $review_3_id, $data[ 'delete' ][ 1 ][ 'previous' ][ 'id' ] );
 
 		$request = new WP_REST_Request( 'GET', '/wc/v3/products/reviews' );
 		$request->set_param( 'product', $product->get_id() );
@@ -449,7 +449,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/products/reviews' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 11, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version3/customers.php

Spacing +48 added lines, -48 removed lines

@@ -220,11 +220,11 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'create_customer_test@woo.local',
 				'first_name'         => '',
 				'last_name'          => '',
@@ -256,7 +256,7 @@ 
 				),
 				'is_paying_customer' => false,
 				'meta_data'          => array(),
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -286,11 +286,11 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'create_customer_test2@woo.local',
 				'first_name'         => 'Test',
 				'last_name'          => 'McTestFace',
@@ -322,7 +322,7 @@ 
 				),
 				'is_paying_customer' => false,
 				'meta_data'          => array(),
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -374,11 +374,11 @@ 
 
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'get_customer_test@woo.local',
 				'first_name'         => 'Justin',
 				'billing'            => array(
@@ -410,7 +410,7 @@ 
 				'last_name'          => '',
 				'role'               => 'customer',
 				'username'           => 'get_customer_test',
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -450,8 +450,8 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/customers/' . $customer->get_id() ) );
 		$data     = $response->get_data();
-		$this->assertEquals( 'update_customer_test', $data['username'] );
-		$this->assertEquals( 'update_customer_test@woo.local', $data['email'] );
+		$this->assertEquals( 'update_customer_test', $data[ 'username' ] );
+		$this->assertEquals( 'update_customer_test@woo.local', $data[ 'email' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/customers/' . $customer->get_id() );
 		$request->set_body_params(
@@ -463,8 +463,8 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'updated_email@woo.local', $data['email'] );
-		$this->assertEquals( 'UpdatedTest', $data['first_name'] );
+		$this->assertEquals( 'updated_email@woo.local', $data[ 'email' ] );
+		$this->assertEquals( 'UpdatedTest', $data[ 'first_name' ] );
 	}
 
 	/**
@@ -570,11 +570,11 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'McTest', $data['update'][0]['last_name'] );
-		$this->assertEquals( 'newuser', $data['create'][0]['username'] );
-		$this->assertEmpty( $data['create'][0]['last_name'] );
-		$this->assertEquals( $customer_2->get_id(), $data['delete'][0]['id'] );
-		$this->assertEquals( $customer_3->get_id(), $data['delete'][1]['id'] );
+		$this->assertEquals( 'McTest', $data[ 'update' ][ 0 ][ 'last_name' ] );
+		$this->assertEquals( 'newuser', $data[ 'create' ][ 0 ][ 'username' ] );
+		$this->assertEmpty( $data[ 'create' ][ 0 ][ 'last_name' ] );
+		$this->assertEquals( $customer_2->get_id(), $data[ 'delete' ][ 0 ][ 'id' ] );
+		$this->assertEquals( $customer_3->get_id(), $data[ 'delete' ][ 1 ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v3/customers' );
 		$response = $this->server->dispatch( $request );
@@ -593,7 +593,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/customers' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 16, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -609,26 +609,26 @@ 
 		$this->assertArrayHasKey( 'password', $properties );
 		$this->assertArrayHasKey( 'avatar_url', $properties );
 		$this->assertArrayHasKey( 'billing', $properties );
-		$this->assertArrayHasKey( 'first_name', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'last_name', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'company', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'address_1', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'address_2', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'city', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'state', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'postcode', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'country', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'email', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'phone', $properties['billing']['properties'] );
+		$this->assertArrayHasKey( 'first_name', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'last_name', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'company', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_1', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_2', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'city', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'state', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'postcode', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'country', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'email', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'phone', $properties[ 'billing' ][ 'properties' ] );
 		$this->assertArrayHasKey( 'shipping', $properties );
-		$this->assertArrayHasKey( 'first_name', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'last_name', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'company', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'address_1', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'address_2', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'city', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'state', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'postcode', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'country', $properties['shipping']['properties'] );
+		$this->assertArrayHasKey( 'first_name', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'last_name', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'company', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_1', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_2', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'city', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'state', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'postcode', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'country', $properties[ 'shipping' ][ 'properties' ] );
 	}
 }

unit-tests/Tests/Version3/functions.php

Spacing +5 added lines, -5 removed lines

@@ -36,8 +36,8 @@ 
 		$this->http_responder = array( $this, 'mock_http_responses' );
 
 		$upload_dir_info       = wp_upload_dir();
-		$this->upload_dir_path = $upload_dir_info['path'];
-		$this->upload_dir_url  = $upload_dir_info['url'];
+		$this->upload_dir_path = $upload_dir_info[ 'path' ];
+		$this->upload_dir_url  = $upload_dir_info[ 'url' ];
 		$this->file_name       = 'Dr1Bczxq4q.png';
 	}
 
@@ -108,7 +108,7 @@ 
 			'url'  => $this->upload_dir_url . '/' . $this->file_name,
 			'type' => 'image/png',
 		);
-		$result          = wc_rest_upload_image_from_url( 'http://somedomain.com/' . $this->file_name );
+		$result = wc_rest_upload_image_from_url( 'http://somedomain.com/' . $this->file_name );
 
 		$this->assertEquals( $expected_result, $result );
 	}
@@ -232,14 +232,14 @@ 
 		} elseif ( 'http://somedomain.com/invalid-image-2.png' === $url ) {
 			// image with an unsupported mime type.
 			// we need to manually copy the file as we are mocking the request. without this an empty file is created.
-			copy( Automattic\WooCommerce\RestApi\UnitTests\Bootstrap::instance()->get_dir() . '/data/file.txt', $request['filename'] );
+			copy( Automattic\WooCommerce\RestApi\UnitTests\Bootstrap::instance()->get_dir() . '/data/file.txt', $request[ 'filename' ] );
 
 			$mocked_response = array(
 				'response' => array( 'code' => 200 ),
 			);
 		} elseif ( 'http://somedomain.com/' . $this->file_name === $url ) {
 			// we need to manually copy the file as we are mocking the request. without this an empty file is created.
-			copy( Automattic\WooCommerce\RestApi\UnitTests\Bootstrap::instance()->get_dir() . '/data/Dr1Bczxq4q.png', $request['filename'] );
+			copy( Automattic\WooCommerce\RestApi\UnitTests\Bootstrap::instance()->get_dir() . '/data/Dr1Bczxq4q.png', $request[ 'filename' ] );
 
 			$mocked_response = array(
 				'response' => array( 'code' => 200 ),

unit-tests/Tests/Version3/products.php

Spacing +73 added lines, -73 removed lines

@@ -52,10 +52,10 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 
 		$this->assertEquals( 2, count( $products ) );
-		$this->assertEquals( 'Dummy Product', $products[0]['name'] );
-		$this->assertEquals( 'DUMMY SKU', $products[0]['sku'] );
-		$this->assertEquals( 'Dummy External Product', $products[1]['name'] );
-		$this->assertEquals( 'DUMMY EXTERNAL SKU', $products[1]['sku'] );
+		$this->assertEquals( 'Dummy Product', $products[ 0 ][ 'name' ] );
+		$this->assertEquals( 'DUMMY SKU', $products[ 0 ][ 'sku' ] );
+		$this->assertEquals( 'Dummy External Product', $products[ 1 ][ 'name' ] );
+		$this->assertEquals( 'DUMMY EXTERNAL SKU', $products[ 1 ][ 'sku' ] );
 	}
 
 	/**
@@ -167,9 +167,9 @@ 
 		$data         = $response->get_data();
 		$date_created = date( 'Y-m-d\TH:i:s', current_time( 'timestamp' ) );
 
-		$this->assertEquals( 'DUMMY SKU', $data['sku'] );
-		$this->assertEquals( 10, $data['regular_price'] );
-		$this->assertEmpty( $data['sale_price'] );
+		$this->assertEquals( 'DUMMY SKU', $data[ 'sku' ] );
+		$this->assertEquals( 10, $data[ 'regular_price' ] );
+		$this->assertEmpty( $data[ 'sale_price' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/products/' . $product->get_id() );
 		$request->set_body_params(
@@ -190,14 +190,14 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertContains( 'Testing', $data['description'] );
-		$this->assertEquals( '8', $data['price'] );
-		$this->assertEquals( '8', $data['sale_price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertEquals( 'FIXED-SKU', $data['sku'] );
-		$this->assertEquals( $date_created, $data['date_created'] );
-		$this->assertContains( 'Dr1Bczxq4q', $data['images'][0]['src'] );
-		$this->assertContains( 'test upload image', $data['images'][0]['alt'] );
+		$this->assertContains( 'Testing', $data[ 'description' ] );
+		$this->assertEquals( '8', $data[ 'price' ] );
+		$this->assertEquals( '8', $data[ 'sale_price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertEquals( 'FIXED-SKU', $data[ 'sku' ] );
+		$this->assertEquals( $date_created, $data[ 'date_created' ] );
+		$this->assertContains( 'Dr1Bczxq4q', $data[ 'images' ][ 0 ][ 'src' ] );
+		$this->assertContains( 'test upload image', $data[ 'images' ][ 0 ][ 'alt' ] );
 		$product->delete( true );
 
 		// test variable product (variations are tested in product-variations.php).
@@ -206,7 +206,7 @@ 
 		$data     = $response->get_data();
 
 		foreach ( array( 'small', 'large' ) as $term_name ) {
-			$this->assertContains( $term_name, $data['attributes'][0]['options'] );
+			$this->assertContains( $term_name, $data[ 'attributes' ][ 0 ][ 'options' ] );
 		}
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/products/' . $product->get_id() );
@@ -238,10 +238,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( array( 'small' ), $data['attributes'][0]['options'] );
+		$this->assertEquals( array( 'small' ), $data[ 'attributes' ][ 0 ][ 'options' ] );
 
 		foreach ( array( 'red', 'yellow' ) as $term_name ) {
-			$this->assertContains( $term_name, $data['attributes'][1]['options'] );
+			$this->assertContains( $term_name, $data[ 'attributes' ][ 1 ][ 'options' ] );
 		}
 
 		$product->delete( true );
@@ -251,8 +251,8 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/products/' . $product->get_id() ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Buy external product', $data['button_text'] );
-		$this->assertEquals( 'http://woocommerce.com', $data['external_url'] );
+		$this->assertEquals( 'Buy external product', $data[ 'button_text' ] );
+		$this->assertEquals( 'http://woocommerce.com', $data[ 'external_url' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/products/' . $product->get_id() );
 		$request->set_body_params(
@@ -264,8 +264,8 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Test API Update', $data['button_text'] );
-		$this->assertEquals( 'http://automattic.com', $data['external_url'] );
+		$this->assertEquals( 'Test API Update', $data[ 'button_text' ] );
+		$this->assertEquals( 'http://automattic.com', $data[ 'external_url' ] );
 	}
 
 	/**
@@ -319,7 +319,7 @@ 
 		);
 		$response          = $this->server->dispatch( $request );
 		$data              = $response->get_data();
-		$shipping_class_id = $data['id'];
+		$shipping_class_id = $data[ 'id' ];
 
 		// Create simple.
 		$request = new WP_REST_Request( 'POST', '/wc/v3/products' );
@@ -335,13 +335,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '10', $data['price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertTrue( $data['purchasable'] );
-		$this->assertEquals( 'DUMMY SKU SIMPLE API', $data['sku'] );
-		$this->assertEquals( 'Test Simple Product', $data['name'] );
-		$this->assertEquals( 'simple', $data['type'] );
-		$this->assertEquals( $shipping_class_id, $data['shipping_class_id'] );
+		$this->assertEquals( '10', $data[ 'price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertTrue( $data[ 'purchasable' ] );
+		$this->assertEquals( 'DUMMY SKU SIMPLE API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test Simple Product', $data[ 'name' ] );
+		$this->assertEquals( 'simple', $data[ 'type' ] );
+		$this->assertEquals( $shipping_class_id, $data[ 'shipping_class_id' ] );
 
 		// Create external.
 		$request = new WP_REST_Request( 'POST', '/wc/v3/products' );
@@ -358,14 +358,14 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '10', $data['price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertFalse( $data['purchasable'] );
-		$this->assertEquals( 'DUMMY SKU EXTERNAL API', $data['sku'] );
-		$this->assertEquals( 'Test External Product', $data['name'] );
-		$this->assertEquals( 'external', $data['type'] );
-		$this->assertEquals( 'Test Button', $data['button_text'] );
-		$this->assertEquals( 'https://wordpress.org', $data['external_url'] );
+		$this->assertEquals( '10', $data[ 'price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertFalse( $data[ 'purchasable' ] );
+		$this->assertEquals( 'DUMMY SKU EXTERNAL API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test External Product', $data[ 'name' ] );
+		$this->assertEquals( 'external', $data[ 'type' ] );
+		$this->assertEquals( 'Test Button', $data[ 'button_text' ] );
+		$this->assertEquals( 'https://wordpress.org', $data[ 'external_url' ] );
 
 		// Create variable.
 		$request = new WP_REST_Request( 'POST', '/wc/v3/products' );
@@ -391,10 +391,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'DUMMY SKU VARIABLE API', $data['sku'] );
-		$this->assertEquals( 'Test Variable Product', $data['name'] );
-		$this->assertEquals( 'variable', $data['type'] );
-		$this->assertEquals( array( 'small', 'medium' ), $data['attributes'][0]['options'] );
+		$this->assertEquals( 'DUMMY SKU VARIABLE API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test Variable Product', $data[ 'name' ] );
+		$this->assertEquals( 'variable', $data[ 'type' ] );
+		$this->assertEquals( array( 'small', 'medium' ), $data[ 'attributes' ][ 0 ][ 'options' ] );
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/products' ) );
 		$products = $response->get_data();
@@ -461,13 +461,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertContains( 'Updated description.', $data['update'][0]['description'] );
-		$this->assertEquals( 'DUMMY SKU BATCH TEST 1', $data['create'][0]['sku'] );
-		$this->assertEquals( 'DUMMY SKU BATCH TEST 2', $data['create'][1]['sku'] );
-		$this->assertEquals( 'Test Button', $data['create'][0]['button_text'] );
-		$this->assertEquals( 'external', $data['create'][0]['type'] );
-		$this->assertEquals( 'simple', $data['create'][1]['type'] );
-		$this->assertEquals( $product_2->get_id(), $data['delete'][0]['id'] );
+		$this->assertContains( 'Updated description.', $data[ 'update' ][ 0 ][ 'description' ] );
+		$this->assertEquals( 'DUMMY SKU BATCH TEST 1', $data[ 'create' ][ 0 ][ 'sku' ] );
+		$this->assertEquals( 'DUMMY SKU BATCH TEST 2', $data[ 'create' ][ 1 ][ 'sku' ] );
+		$this->assertEquals( 'Test Button', $data[ 'create' ][ 0 ][ 'button_text' ] );
+		$this->assertEquals( 'external', $data[ 'create' ][ 0 ][ 'type' ] );
+		$this->assertEquals( 'simple', $data[ 'create' ][ 1 ][ 'type' ] );
+		$this->assertEquals( $product_2->get_id(), $data[ 'delete' ][ 0 ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v3/products' );
 		$response = $this->server->dispatch( $request );
@@ -504,7 +504,7 @@ 
 
 		$this->assertEquals( 4, count( $products ) );
 		foreach ( $products as $product ) {
-			$this->assertEquals( 'publish', $product['status'] );
+			$this->assertEquals( 'publish', $product[ 'status' ] );
 		}
 
 		// Test filtering with status=draft.
@@ -515,7 +515,7 @@ 
 
 		$this->assertEquals( 4, count( $products ) );
 		foreach ( $products as $product ) {
-			$this->assertEquals( 'draft', $product['status'] );
+			$this->assertEquals( 'draft', $product[ 'status' ] );
 		}
 
 		// Test filtering with no filters - which should return 'any' (all 8).
@@ -537,7 +537,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/products/' . $product->get_id() );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 65, count( $properties ) );
 	}
 
@@ -553,7 +553,7 @@ 
 		$category = wp_insert_term( 'Some Category', 'product_cat' );
 
 		$product = new WC_Product_Simple();
-		$product->set_category_ids( array( $category['term_id'] ) );
+		$product->set_category_ids( array( $category[ 'term_id' ] ) );
 		$product->save();
 
 		// Create one product without category, i.e. Uncategorized.
@@ -562,7 +562,7 @@ 
 
 		// Test product assigned to a single category.
 		$query_params = array(
-			'category' => (string) $category['term_id'],
+			'category' => (string) $category[ 'term_id' ],
 		);
 		$request      = new WP_REST_Request( 'GET', '/wc/v2/products' );
 		$request->set_query_params( $query_params );
@@ -571,8 +571,8 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $product->get_id(), $response_product['id'] );
-			$this->assertEquals( $product->get_category_ids(), wp_list_pluck( $response_product['categories'], 'id' ) );
+			$this->assertEquals( $product->get_id(), $response_product[ 'id' ] );
+			$this->assertEquals( $product->get_category_ids(), wp_list_pluck( $response_product[ 'categories' ], 'id' ) );
 		}
 
 		// Test product without categories.
@@ -581,8 +581,8 @@ 
 		$response_product = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertCount( 1, $response_product['categories'], print_r( $response_product, true ) );
-		$this->assertEquals( 'uncategorized', $response_product['categories'][0]['slug'] );
+		$this->assertCount( 1, $response_product[ 'categories' ], print_r( $response_product, true ) );
+		$this->assertEquals( 'uncategorized', $response_product[ 'categories' ][ 0 ][ 'slug' ] );
 
 	}
 
@@ -607,7 +607,7 @@ 
 		);
 
 		foreach ( $grouped->get_children() as $additional_product ) {
-			$product_ids_for_type['simple'][] = $additional_product;
+			$product_ids_for_type[ 'simple' ][ ] = $additional_product;
 		}
 
 		foreach ( $product_ids_for_type as $product_type => $product_ids ) {
@@ -622,7 +622,7 @@ 
 			$this->assertEquals( 200, $response->get_status() );
 			$this->assertEquals( count( $product_ids ), count( $response_products ) );
 			foreach ( $response_products as $response_product ) {
-				$this->assertContains( $response_product['id'], $product_ids_for_type[ $product_type ], 'REST API: ' . $product_type . ' not found correctly' );
+				$this->assertContains( $response_product[ 'id' ], $product_ids_for_type[ $product_type ], 'REST API: ' . $product_type . ' not found correctly' );
 			}
 		}
 	}
@@ -654,7 +654,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $feat_product->get_id(), $response_product['id'], 'REST API: Featured product not found correctly' );
+			$this->assertEquals( $feat_product->get_id(), $response_product[ 'id' ], 'REST API: Featured product not found correctly' );
 		}
 
 		$query_params = array(
@@ -667,7 +667,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $nonfeat_product->get_id(), $response_product['id'], 'REST API: Featured product not found correctly' );
+			$this->assertEquals( $nonfeat_product->get_id(), $response_product[ 'id' ], 'REST API: Featured product not found correctly' );
 		}
 	}
 
@@ -682,11 +682,11 @@ 
 		$shipping_class_1 = wp_insert_term( 'Bulky', 'product_shipping_class' );
 
 		$product_1 = new WC_Product_Simple();
-		$product_1->set_shipping_class_id( $shipping_class_1['term_id'] );
+		$product_1->set_shipping_class_id( $shipping_class_1[ 'term_id' ] );
 		$product_1->save();
 
 		$query_params = array(
-			'shipping_class' => (string) $shipping_class_1['term_id'],
+			'shipping_class' => (string) $shipping_class_1[ 'term_id' ],
 		);
 		$request      = new WP_REST_Request( 'GET', '/wc/v2/products' );
 		$request->set_query_params( $query_params );
@@ -695,7 +695,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $product_1->get_id(), $response_product['id'] );
+			$this->assertEquals( $product_1->get_id(), $response_product[ 'id' ] );
 		}
 	}
 
@@ -711,14 +711,14 @@ 
 
 		// Product with a tag.
 		$product = \Automattic\WooCommerce\RestApi\UnitTests\Helpers\ProductHelper::create_simple_product();
-		$product->set_tag_ids( array( $test_tag_1['term_id'] ) );
+		$product->set_tag_ids( array( $test_tag_1[ 'term_id' ] ) );
 		$product->save();
 
 		// Product without a tag.
 		$product_2 = \Automattic\WooCommerce\RestApi\UnitTests\Helpers\ProductHelper::create_simple_product();
 
 		$query_params = array(
-			'tag' => (string) $test_tag_1['term_id'],
+			'tag' => (string) $test_tag_1[ 'term_id' ],
 		);
 		$request      = new WP_REST_Request( 'GET', '/wc/v2/products' );
 		$request->set_query_params( $query_params );
@@ -727,7 +727,7 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 		foreach ( $response_products as $response_product ) {
-			$this->assertEquals( $product->get_id(), $response_product['id'] );
+			$this->assertEquals( $product->get_id(), $response_product[ 'id' ] );
 		}
 	}
 
@@ -770,11 +770,11 @@ 
 			$variable_product->get_id(),
 			$product_2->get_id(),
 		);
-		$query_params         = array(
+		$query_params = array(
 			'attribute'      => 'pa_size',
 			'attribute_term' => (string) $term_large->term_id,
 		);
-		$request              = new WP_REST_Request( 'GET', '/wc/v2/products' );
+		$request = new WP_REST_Request( 'GET', '/wc/v2/products' );
 		$request->set_query_params( $query_params );
 		$response          = $this->server->dispatch( $request );
 		$response_products = $response->get_data();
@@ -782,7 +782,7 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( count( $expected_product_ids ), count( $response_products ) );
 		foreach ( $response_products as $response_product ) {
-			$this->assertContains( $response_product['id'], $expected_product_ids );
+			$this->assertContains( $response_product[ 'id' ], $expected_product_ids );
 		}
 
 		// Products with attribute size == small.
@@ -793,7 +793,7 @@ 
 			'attribute'      => 'pa_size',
 			'attribute_term' => (string) $term_small->term_id,
 		);
-		$request              = new WP_REST_Request( 'GET', '/wc/v2/products' );
+		$request = new WP_REST_Request( 'GET', '/wc/v2/products' );
 		$request->set_query_params( $query_params );
 		$response          = $this->server->dispatch( $request );
 		$response_products = $response->get_data();
@@ -801,7 +801,7 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 		$this->assertEquals( count( $expected_product_ids ), count( $response_products ) );
 		foreach ( $response_products as $response_product ) {
-			$this->assertContains( $response_product['id'], $expected_product_ids );
+			$this->assertContains( $response_product[ 'id' ], $expected_product_ids );
 		}
 	}
 }

unit-tests/Tests/Version3/payment-gateways.php

Spacing +25 added lines, -25 removed lines

@@ -162,9 +162,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/payment_gateways/paypal' ) );
 		$paypal   = $response->get_data();
 
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'admin@example.org', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'admin@example.org', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating single setting
 		$request = new WP_REST_Request( 'POST', '/wc/v3/payment_gateways/paypal' );
@@ -179,9 +179,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating multiple settings
 		$request = new WP_REST_Request( 'POST', '/wc/v3/payment_gateways/paypal' );
@@ -197,9 +197,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// Test other parameters, and recheck settings
 		$request = new WP_REST_Request( 'POST', '/wc/v3/payment_gateways/paypal' );
@@ -212,11 +212,11 @@ 
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
 
-		$this->assertFalse( $paypal['enabled'] );
-		$this->assertEquals( 2, $paypal['order'] );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertFalse( $paypal[ 'enabled' ] );
+		$this->assertEquals( 2, $paypal[ 'order' ] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test bogus
 		$request = new WP_REST_Request( 'POST', '/wc/v3/payment_gateways/paypal' );
@@ -240,7 +240,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
-		$this->assertEquals( 'authorization', $paypal['settings']['paymentaction']['value'] );
+		$this->assertEquals( 'authorization', $paypal[ 'settings' ][ 'paymentaction' ][ 'value' ] );
 	}
 
 	/**
@@ -291,7 +291,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/payment_gateways' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 9, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -317,7 +317,7 @@ 
 		$gateway->init_form_fields();
 		foreach ( $gateway->form_fields as $id => $field ) {
 			// Make sure we at least have a title and type
-			if ( empty( $field['title'] ) || empty( $field['type'] ) ) {
+			if ( empty( $field[ 'title' ] ) || empty( $field[ 'type' ] ) ) {
 				continue;
 			}
 			// Ignore 'enabled' and 'description', to be in line with \WC_REST_Payment_Gateways_Controller::get_settings.
@@ -326,16 +326,16 @@ 
 			}
 			$data = array(
 				'id'          => $id,
-				'label'       => empty( $field['label'] ) ? $field['title'] : $field['label'],
-				'description' => empty( $field['description'] ) ? '' : $field['description'],
-				'type'        => $field['type'],
+				'label'       => empty( $field[ 'label' ] ) ? $field[ 'title' ] : $field[ 'label' ],
+				'description' => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'type'        => $field[ 'type' ],
 				'value'       => $gateway->settings[ $id ],
-				'default'     => empty( $field['default'] ) ? '' : $field['default'],
-				'tip'         => empty( $field['description'] ) ? '' : $field['description'],
-				'placeholder' => empty( $field['placeholder'] ) ? '' : $field['placeholder'],
+				'default'     => empty( $field[ 'default' ] ) ? '' : $field[ 'default' ],
+				'tip'         => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'placeholder' => empty( $field[ 'placeholder' ] ) ? '' : $field[ 'placeholder' ],
 			);
-			if ( ! empty( $field['options'] ) ) {
-				$data['options'] = $field['options'];
+			if ( ! empty( $field[ 'options' ] ) ) {
+				$data[ 'options' ] = $field[ 'options' ];
 			}
 			$settings[ $id ] = $data;
 		}

unit-tests/Tests/Version3/shipping-methods.php

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/shipping_methods' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version3/system-status.php

Spacing +39 added lines, -39 removed lines

@@ -79,15 +79,15 @@ 
 		wp_set_current_user( $this->user );
 		$response    = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/system_status' ) );
 		$data        = $response->get_data();
-		$environment = (array) $data['environment'];
+		$environment = (array) $data[ 'environment' ];
 
 		// Make sure all expected data is present.
 		$this->assertEquals( 32, count( $environment ) );
 
 		// Test some responses to make sure they match up.
-		$this->assertEquals( get_option( 'home' ), $environment['home_url'] );
-		$this->assertEquals( get_option( 'siteurl' ), $environment['site_url'] );
-		$this->assertEquals( WC()->version, $environment['version'] );
+		$this->assertEquals( get_option( 'home' ), $environment[ 'home_url' ] );
+		$this->assertEquals( get_option( 'siteurl' ), $environment[ 'site_url' ] );
+		$this->assertEquals( WC()->version, $environment[ 'version' ] );
 	}
 
 	/**
@@ -100,13 +100,13 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/system_status' ) );
 		$data     = $response->get_data();
-		$database = (array) $data['database'];
+		$database = (array) $data[ 'database' ];
 
-		$this->assertEquals( get_option( 'woocommerce_db_version' ), $database['wc_database_version'] );
-		$this->assertEquals( $wpdb->prefix, $database['database_prefix'] );
-		$this->assertEquals( WC_Geolocation::get_local_database_path(), $database['maxmind_geoip_database'] );
-		$this->assertArrayHasKey( 'woocommerce', $database['database_tables'], wc_print_r( $database, true ) );
-		$this->assertArrayHasKey( $wpdb->prefix . 'woocommerce_payment_tokens', $database['database_tables']['woocommerce'], wc_print_r( $database, true ) );
+		$this->assertEquals( get_option( 'woocommerce_db_version' ), $database[ 'wc_database_version' ] );
+		$this->assertEquals( $wpdb->prefix, $database[ 'database_prefix' ] );
+		$this->assertEquals( WC_Geolocation::get_local_database_path(), $database[ 'maxmind_geoip_database' ] );
+		$this->assertArrayHasKey( 'woocommerce', $database[ 'database_tables' ], wc_print_r( $database, true ) );
+		$this->assertArrayHasKey( $wpdb->prefix . 'woocommerce_payment_tokens', $database[ 'database_tables' ][ 'woocommerce' ], wc_print_r( $database, true ) );
 	}
 
 	/**
@@ -123,10 +123,10 @@ 
 		update_option( 'active_plugins', array() );
 
 		$data    = $response->get_data();
-		$plugins = (array) $data['active_plugins'];
+		$plugins = (array) $data[ 'active_plugins' ];
 
 		$this->assertEquals( 1, count( $plugins ) );
-		$this->assertEquals( 'Hello Dolly', $plugins[0]['name'] );
+		$this->assertEquals( 'Hello Dolly', $plugins[ 0 ][ 'name' ] );
 	}
 
 	/**
@@ -140,10 +140,10 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/system_status' ) );
 		$data     = $response->get_data();
-		$theme    = (array) $data['theme'];
+		$theme    = (array) $data[ 'theme' ];
 
 		$this->assertEquals( 13, count( $theme ) );
-		$this->assertEquals( $active_theme->Name, $theme['name'] ); // phpcs:ignore WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar
+		$this->assertEquals( $active_theme->Name, $theme[ 'name' ] ); // phpcs:ignore WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar
 	}
 
 	/**
@@ -162,12 +162,12 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/system_status' ) );
 		$data     = $response->get_data();
-		$settings = (array) $data['settings'];
+		$settings = (array) $data[ 'settings' ];
 
 		$this->assertEquals( 12, count( $settings ) );
-		$this->assertEquals( ( 'yes' === get_option( 'woocommerce_api_enabled' ) ), $settings['api_enabled'] );
-		$this->assertEquals( get_woocommerce_currency(), $settings['currency'] );
-		$this->assertEquals( $term_response, $settings['taxonomies'] );
+		$this->assertEquals( ( 'yes' === get_option( 'woocommerce_api_enabled' ) ), $settings[ 'api_enabled' ] );
+		$this->assertEquals( get_woocommerce_currency(), $settings[ 'currency' ] );
+		$this->assertEquals( $term_response, $settings[ 'taxonomies' ] );
 	}
 
 	/**
@@ -180,11 +180,11 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/system_status' ) );
 		$data     = $response->get_data();
-		$settings = (array) $data['security'];
+		$settings = (array) $data[ 'security' ];
 
 		$this->assertEquals( 2, count( $settings ) );
-		$this->assertEquals( 'https' === substr( wc_get_page_permalink( 'shop' ), 0, 5 ), $settings['secure_connection'] );
-		$this->assertEquals( ! ( defined( 'WP_DEBUG' ) && defined( 'WP_DEBUG_DISPLAY' ) && WP_DEBUG && WP_DEBUG_DISPLAY ) || 0 === intval( ini_get( 'display_errors' ) ), $settings['hide_errors'] );
+		$this->assertEquals( 'https' === substr( wc_get_page_permalink( 'shop' ), 0, 5 ), $settings[ 'secure_connection' ] );
+		$this->assertEquals( ! ( defined( 'WP_DEBUG' ) && defined( 'WP_DEBUG_DISPLAY' ) && WP_DEBUG && WP_DEBUG_DISPLAY ) || 0 === intval( ini_get( 'display_errors' ) ), $settings[ 'hide_errors' ] );
 	}
 
 	/**
@@ -196,7 +196,7 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/system_status' ) );
 		$data     = $response->get_data();
-		$pages    = $data['pages'];
+		$pages    = $data[ 'pages' ];
 		$this->assertEquals( 5, count( $pages ) );
 	}
 
@@ -209,7 +209,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/system_status' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 9, count( $properties ) );
 		$this->assertArrayHasKey( 'environment', $properties );
 		$this->assertArrayHasKey( 'database', $properties );
@@ -307,17 +307,17 @@ 
 
 		$tools_controller = new WC_REST_System_Status_Tools_Controller();
 		$raw_tools        = $tools_controller->get_tools();
-		$raw_tool         = $raw_tools['recount_terms'];
+		$raw_tool         = $raw_tools[ 'recount_terms' ];
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/system_status/tools/recount_terms' ) );
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
-		$this->assertEquals( 'Recount terms', $data['action'] );
-		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data['description'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
+		$this->assertEquals( 'Recount terms', $data[ 'action' ] );
+		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data[ 'description' ] );
 
 		// Test for _fields query parameter.
 		$query_params = array(
@@ -330,8 +330,8 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
 		$this->assertArrayNotHasKey( 'action', $data );
 		$this->assertArrayNotHasKey( 'description', $data );
 		// Links are part of links, not data in single items.
@@ -363,16 +363,16 @@ 
 
 		$tools_controller = new WC_REST_System_Status_Tools_Controller();
 		$raw_tools        = $tools_controller->get_tools();
-		$raw_tool         = $raw_tools['recount_terms'];
+		$raw_tool         = $raw_tools[ 'recount_terms' ];
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'POST', '/wc/v3/system_status/tools/recount_terms' ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
-		$this->assertEquals( 'Recount terms', $data['action'] );
-		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data['description'] );
-		$this->assertTrue( $data['success'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
+		$this->assertEquals( 'Recount terms', $data[ 'action' ] );
+		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data[ 'description' ] );
+		$this->assertTrue( $data[ 'success' ] );
 		$this->assertEquals( 1, did_action( 'woocommerce_rest_insert_system_status_tool' ) );
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'POST', '/wc/v3/system_status/tools/not_a_real_tool' ) );
@@ -388,8 +388,8 @@ 
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertTrue( $data['success'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertTrue( $data[ 'success' ] );
 
 		// Fields that are not requested are not returned in response.
 		$this->assertArrayNotHasKey( 'action', $data );
@@ -425,7 +425,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/system_status/tools' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 6, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version3/reports-reviews-totals.php

Spacing +3 added lines, -3 removed lines

@@ -51,9 +51,9 @@ 
 		);
 
 		for ( $i = 1; $i <= 5; $i++ ) {
-			$query_data['meta_value'] = $i;
+			$query_data[ 'meta_value' ] = $i;
 
-			$data[] = array(
+			$data[ ] = array(
 				'slug'  => 'rated_' . $i . '_out_of_5',
 				/* translators: %s: average rating */
 				'name'  => sprintf( __( 'Rated %s out of 5', 'woocommerce' ), $i ),
@@ -88,7 +88,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/reports/reviews/totals' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'slug', $properties );