woocommerce / woocommerce-rest-api

unit-tests/Bootstrap.php

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
 
 			\WC_Install::install();
 
-			$GLOBALS['wp_roles'] = null; // WPCS: override ok.
+			$GLOBALS[ 'wp_roles' ] = null; // WPCS: override ok.
 			\wp_roles();
 		} );
 	}

unit-tests/Helpers/ProductHelper.php

Spacing +6 added lines, -6 removed lines

@@ -129,13 +129,13 @@ 
 		$attribute_data = self::create_attribute( 'size', array( 'small', 'large' ) ); // Create all attribute related things.
 		$attributes     = array();
 		$attribute      = new WC_Product_Attribute();
-		$attribute->set_id( $attribute_data['attribute_id'] );
-		$attribute->set_name( $attribute_data['attribute_taxonomy'] );
-		$attribute->set_options( $attribute_data['term_ids'] );
+		$attribute->set_id( $attribute_data[ 'attribute_id' ] );
+		$attribute->set_name( $attribute_data[ 'attribute_taxonomy' ] );
+		$attribute->set_options( $attribute_data[ 'term_ids' ] );
 		$attribute->set_position( 1 );
 		$attribute->set_visible( true );
 		$attribute->set_variation( true );
-		$attributes[] = $attribute;
+		$attributes[ ] = $attribute;
 
 		$product->set_attributes( $attributes );
 		$product->save();
@@ -246,9 +246,9 @@ 
 
 			if ( ! $result ) {
 				$result               = wp_insert_term( $term, $attribute->slug );
-				$return['term_ids'][] = $result['term_id'];
+				$return[ 'term_ids' ][ ] = $result[ 'term_id' ];
 			} else {
-				$return['term_ids'][] = $result['term_id'];
+				$return[ 'term_ids' ][ ] = $result[ 'term_id' ];
 			}
 		}
 

unit-tests/Helpers/OrderHelper.php

Spacing +3 added lines, -3 removed lines

@@ -30,7 +30,7 @@ 
 
 		// Delete all products in the order.
 		foreach ( $order->get_items() as $item ) {
-			\Automattic\WooCommerce\RestApi\UnitTests\Helpers\ProductHelper::delete_product( $item['product_id'] );
+			\Automattic\WooCommerce\RestApi\UnitTests\Helpers\ProductHelper::delete_product( $item[ 'product_id' ] );
 		}
 
 		ShippingHelper::delete_simple_flat_rate();
@@ -65,7 +65,7 @@ 
 			'total'         => '',
 		);
 
-		$_SERVER['REMOTE_ADDR'] = '127.0.0.1'; // Required, else wc_create_order throws an exception
+		$_SERVER[ 'REMOTE_ADDR' ] = '127.0.0.1'; // Required, else wc_create_order throws an exception
 		$order                  = wc_create_order( $order_data );
 
 		// Add order products
@@ -113,7 +113,7 @@ 
 
 		// Set payment gateway
 		$payment_gateways = WC()->payment_gateways->payment_gateways();
-		$order->set_payment_method( $payment_gateways['bacs'] );
+		$order->set_payment_method( $payment_gateways[ 'bacs' ] );
 
 		// Set totals
 		$order->set_shipping_total( 10 );

unit-tests/Helpers/SettingsHelper.php

Spacing +5 added lines, -5 removed lines

@@ -30,26 +30,26 @@ 
 	 * @return array
 	 */
 	public static function register_groups( $groups ) {
-		$groups[] = array(
+		$groups[ ] = array(
 			'id'          => 'test',
 			'bad'         => 'value',
 			'label'       => 'Test extension',
 			'description' => 'My awesome test settings.',
 			'option_key'  => '',
 		);
-		$groups[] = array(
+		$groups[ ] = array(
 			'id'          => 'sub-test',
 			'parent_id'   => 'test',
 			'label'       => 'Sub test',
 			'description' => '',
 			'option_key'  => '',
 		);
-		$groups[] = array(
+		$groups[ ] = array(
 			'id'         => 'coupon-data',
 			'label'      => 'Coupon data',
 			'option_key' => '',
 		);
-		$groups[] = array(
+		$groups[ ] = array(
 			'id'         => 'invalid',
 			'option_key' => '',
 		);
@@ -64,7 +64,7 @@ 
 	 * @return array
 	 */
 	public static function register_test_settings( $settings ) {
-		$settings[] = array(
+		$settings[ ] = array(
 			'id'          => 'woocommerce_shop_page_display',
 			'label'       => 'Shop page display',
 			'description' => 'This controls what is shown on the product archive.',

unit-tests/AbstractRestApiTest.php

Spacing +7 added lines, -7 removed lines

@@ -38,14 +38,14 @@ 
 	 *
 	 * @var array Keys are property names, values are supported context.
 	 */
-	protected $properties = [];
+	protected $properties = [ ];
 
 	/**
 	 * Routes that this endpoint creates.
 	 *
 	 * @var array
 	 */
-	protected $routes = [];
+	protected $routes = [ ];
 
 	/**
 	 * User variable.
@@ -93,10 +93,10 @@ 
 	 * @return void
 	 */
 	public function test_schema_properties() {
-		$request    = new \WP_REST_Request( 'OPTIONS', $this->routes[0] );
+		$request    = new \WP_REST_Request( 'OPTIONS', $this->routes[ 0 ] );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( count( array_keys( $this->properties ) ), count( $properties ), print_r( array_diff( array_keys( $properties ), array_keys( $this->properties ) ), true ) );
 
@@ -136,7 +136,7 @@ 
 	 * @param array   $params Request body or query.
 	 * @return object
 	 */
-	protected function do_request( $endpoint, $type = 'GET', $params = [] ) {
+	protected function do_request( $endpoint, $type = 'GET', $params = [ ] ) {
 		$request = new \WP_REST_Request( $type, untrailingslashit( $endpoint ) );
 		'GET' === $type ? $request->set_query_params( $params ) : $request->set_body_params( $params );
 		$response = $this->server->dispatch( $request );
@@ -194,8 +194,8 @@ 
 			$this->assertArrayHasKey( 'id', $meta );
 			$this->assertArrayHasKey( 'key', $meta );
 			$this->assertArrayHasKey( 'value', $meta );
-			$this->assertEquals( $expected_meta_data[ $key ]['key'], $meta['key'] );
-			$this->assertEquals( $expected_meta_data[ $key ]['value'], $meta['value'] );
+			$this->assertEquals( $expected_meta_data[ $key ][ 'key' ], $meta[ 'key' ] );
+			$this->assertEquals( $expected_meta_data[ $key ][ 'value' ], $meta[ 'value' ] );
 		}
 	}
 

unit-tests/Tests/Version3/reports-products-totals.php

Spacing +3 added lines, -3 removed lines

@@ -48,14 +48,14 @@ 
 				'hide_empty' => false,
 			)
 		);
-		$data     = array();
+		$data = array();
 
 		foreach ( $terms as $product_type ) {
 			if ( ! isset( $types[ $product_type->name ] ) ) {
 				continue;
 			}
 
-			$data[] = array(
+			$data[ ] = array(
 				'slug'  => $product_type->name,
 				'name'  => $types[ $product_type->name ],
 				'total' => (int) $product_type->count,
@@ -89,7 +89,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/reports/products/totals' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'slug', $properties );

unit-tests/Tests/Version3/shipping-zones.php

Spacing +50 added lines, -50 removed lines

@@ -27,7 +27,7 @@ 
 				'role' => 'administrator',
 			)
 		);
-		$this->zones    = array();
+		$this->zones = array();
 	}
 
 	/**
@@ -44,7 +44,7 @@ 
 		$zone->set_locations( $locations );
 		$zone->save();
 
-		$this->zones[] = $zone;
+		$this->zones[ ] = $zone;
 
 		return $zone;
 	}
@@ -79,13 +79,13 @@ 
 		$this->assertEquals( count( $data ), 1 );
 		$this->assertContains(
 			array(
-				'id'     => $data[0]['id'],
+				'id'     => $data[ 0 ][ 'id' ],
 				'name'   => 'Locations not covered by your other zones',
 				'order'  => 0,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[0]['id'] ),
+							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[ 0 ][ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -95,7 +95,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[0]['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[ 0 ][ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -113,13 +113,13 @@ 
 		$this->assertEquals( count( $data ), 2 );
 		$this->assertContains(
 			array(
-				'id'     => $data[1]['id'],
+				'id'     => $data[ 1 ][ 'id' ],
 				'name'   => 'Zone 1',
 				'order'  => 0,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[1]['id'] ),
+							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[ 1 ][ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -129,7 +129,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[1]['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[ 1 ][ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -175,10 +175,10 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/shipping/zones' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
-		$this->assertTrue( $properties['id']['readonly'] );
+		$this->assertTrue( $properties[ 'id' ][ 'readonly' ] );
 		$this->assertArrayHasKey( 'name', $properties );
 		$this->assertArrayHasKey( 'order', $properties );
 	}
@@ -204,13 +204,13 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'     => $data['id'],
+				'id'     => $data[ 'id' ],
 				'name'   => 'Test Zone',
 				'order'  => 1,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v3/shipping/zones/' . $data['id'] ),
+							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -220,7 +220,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v3/shipping/zones/' . $data['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v3/shipping/zones/' . $data[ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -597,16 +597,16 @@ 
 		foreach ( $method->get_instance_form_fields() as $id => $field ) {
 			$data = array(
 				'id'          => $id,
-				'label'       => $field['title'],
-				'description' => ( empty( $field['description'] ) ? '' : $field['description'] ),
-				'type'        => $field['type'],
+				'label'       => $field[ 'title' ],
+				'description' => ( empty( $field[ 'description' ] ) ? '' : $field[ 'description' ] ),
+				'type'        => $field[ 'type' ],
 				'value'       => $method->instance_settings[ $id ],
-				'default'     => ( empty( $field['default'] ) ? '' : $field['default'] ),
-				'tip'         => ( empty( $field['description'] ) ? '' : $field['description'] ),
-				'placeholder' => ( empty( $field['placeholder'] ) ? '' : $field['placeholder'] ),
+				'default'     => ( empty( $field[ 'default' ] ) ? '' : $field[ 'default' ] ),
+				'tip'         => ( empty( $field[ 'description' ] ) ? '' : $field[ 'description' ] ),
+				'placeholder' => ( empty( $field[ 'placeholder' ] ) ? '' : $field[ 'placeholder' ] ),
 			);
-			if ( ! empty( $field['options'] ) ) {
-				$data['options'] = $field['options'];
+			if ( ! empty( $field[ 'options' ] ) ) {
+				$data[ 'options' ] = $field[ 'options' ];
 			}
 			$settings[ $id ] = $data;
 		}
@@ -616,7 +616,7 @@ 
 		$expected = array(
 			'id'                 => $instance_id,
 			'instance_id'        => $instance_id,
-			'title'              => $method->instance_settings['title'],
+			'title'              => $method->instance_settings[ 'title' ],
 			'order'              => $method->method_order,
 			'enabled'            => ( 'yes' === $method->enabled ),
 			'method_id'          => $method->id,
@@ -702,12 +702,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'taxable', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '0', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'taxable', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '0', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Update a single value
 		$request = new WP_REST_Request( 'POST', '/wc/v3/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -721,12 +721,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'taxable', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '5', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'taxable', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '5', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Test multiple settings
 		$request = new WP_REST_Request( 'POST', '/wc/v3/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -741,12 +741,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'none', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '10', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'none', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '10', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Test bogus
 		$request = new WP_REST_Request( 'POST', '/wc/v3/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -762,8 +762,8 @@ 
 		$this->assertEquals( 400, $response->get_status() );
 
 		// Test other parameters
-		$this->assertTrue( $data['enabled'] );
-		$this->assertEquals( 1, $data['order'] );
+		$this->assertTrue( $data[ 'enabled' ] );
+		$this->assertEquals( 1, $data[ 'order' ] );
 
 		$request = new WP_REST_Request( 'POST', '/wc/v3/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
 		$request->set_body_params(
@@ -775,10 +775,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertFalse( $data['enabled'] );
-		$this->assertEquals( 2, $data['order'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '10', $data['settings']['cost']['value'] );
+		$this->assertFalse( $data[ 'enabled' ] );
+		$this->assertEquals( 2, $data[ 'order' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '10', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 	}
 
 	/**
@@ -800,10 +800,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertFalse( $data['enabled'] );
-		$this->assertEquals( 2, $data['order'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '0', $data['settings']['cost']['value'] );
+		$this->assertFalse( $data[ 'enabled' ] );
+		$this->assertEquals( 2, $data[ 'order' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '0', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 	}
 
 	/**

unit-tests/Tests/Version3/reports-orders-totals.php

Spacing +2 added lines, -2 removed lines

@@ -48,7 +48,7 @@ 
 				continue;
 			}
 
-			$data[] = array(
+			$data[ ] = array(
 				'slug'  => str_replace( 'wc-', '', $slug ),
 				'name'  => $name,
 				'total' => (int) $totals->$slug,
@@ -82,7 +82,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/reports/orders/totals' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'slug', $properties );

unit-tests/Tests/Version3/settings.php

Spacing +44 added lines, -44 removed lines

@@ -122,7 +122,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/settings' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 5, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
 		$this->assertArrayHasKey( 'parent_id', $properties );
@@ -140,7 +140,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/settings/test/woocommerce_shop_page_display' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 10, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
 		$this->assertArrayHasKey( 'label', $properties );
@@ -178,8 +178,8 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/test' ) );
 		$data     = $response->get_data();
 		$this->assertEquals( 1, count( $data ) );
-		$this->assertEquals( 'woocommerce_shop_page_display', $data[0]['id'] );
-		$this->assertEmpty( $data[0]['value'] );
+		$this->assertEquals( 'woocommerce_shop_page_display', $data[ 0 ][ 'id' ] );
+		$this->assertEmpty( $data[ 0 ][ 'value' ] );
 	}
 
 	/**
@@ -205,7 +205,7 @@ 
 		// test defaults first
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/test/woocommerce_shop_page_display' ) );
 		$data     = $response->get_data();
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( '', $data[ 'value' ] );
 
 		// test updating shop display setting
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v3/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -217,7 +217,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'both', $data['value'] );
+		$this->assertEquals( 'both', $data[ 'value' ] );
 		$this->assertEquals( 'both', get_option( 'woocommerce_shop_page_display' ) );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v3/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -229,7 +229,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'subcategories', $data['value'] );
+		$this->assertEquals( 'subcategories', $data[ 'value' ] );
 		$this->assertEquals( 'subcategories', get_option( 'woocommerce_shop_page_display' ) );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v3/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -241,7 +241,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( '', $data[ 'value' ] );
 		$this->assertEquals( '', get_option( 'woocommerce_shop_page_display' ) );
 	}
 
@@ -256,7 +256,7 @@ 
 		// test defaults first
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/test' ) );
 		$data     = $response->get_data();
-		$this->assertEquals( '', $data[0]['value'] );
+		$this->assertEquals( '', $data[ 0 ][ 'value' ] );
 
 		// test setting both at once
 		$request = new WP_REST_Request( 'POST', '/wc/v3/settings/test/batch' );
@@ -273,7 +273,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'both', $data['update'][0]['value'] );
+		$this->assertEquals( 'both', $data[ 'update' ][ 0 ][ 'value' ] );
 		$this->assertEquals( 'both', get_option( 'woocommerce_shop_page_display' ) );
 
 		// test updating one, but making sure the other value stays the same
@@ -290,7 +290,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$this->assertEquals( 'subcategories', $data['update'][0]['value'] );
+		$this->assertEquals( 'subcategories', $data[ 'update' ][ 0 ][ 'value' ] );
 		$this->assertEquals( 'subcategories', get_option( 'woocommerce_shop_page_display' ) );
 	}
 
@@ -318,11 +318,11 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'woocommerce_shop_page_display', $data['id'] );
-		$this->assertEquals( 'Shop page display', $data['label'] );
-		$this->assertEquals( '', $data['default'] );
-		$this->assertEquals( 'select', $data['type'] );
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( 'woocommerce_shop_page_display', $data[ 'id' ] );
+		$this->assertEquals( 'Shop page display', $data[ 'label' ] );
+		$this->assertEquals( '', $data[ 'default' ] );
+		$this->assertEquals( 'select', $data[ 'type' ] );
+		$this->assertEquals( '', $data[ 'value' ] );
 	}
 
 	/**
@@ -485,7 +485,7 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/products/woocommerce_dimension_unit' ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'cm', $data['default'] );
+		$this->assertEquals( 'cm', $data[ 'default' ] );
 
 		// test update
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v3/settings/%s/%s', 'products', 'woocommerce_dimension_unit' ) );
@@ -497,7 +497,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'yd', $data['value'] );
+		$this->assertEquals( 'yd', $data[ 'value' ] );
 		$this->assertEquals( 'yd', get_option( 'woocommerce_dimension_unit' ) );
 	}
 
@@ -586,7 +586,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
 
-		$this->assertEmpty( $setting['value'] );
+		$this->assertEmpty( $setting[ 'value' ] );
 
 		// test update
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v3/settings/%s/%s', 'email_customer_new_account', 'subject' ) );
@@ -598,13 +598,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'This is my new subject', $setting['value'] );
+		$this->assertEquals( 'This is my new subject', $setting[ 'value' ] );
 
 		// make sure the other is what we left it
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/email_new_order/subject' ) );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'This is my subject', $setting['value'] );
+		$this->assertEquals( 'This is my subject', $setting[ 'value' ] );
 	}
 
 	/**
@@ -685,7 +685,7 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', sprintf( '/wc/v3/settings/%s/%s', 'general', 'woocommerce_specific_allowed_countries' ) ) );
 		$setting  = $response->get_data();
-		$this->assertEmpty( $setting['value'] );
+		$this->assertEmpty( $setting[ 'value' ] );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v3/settings/%s/%s', 'general', 'woocommerce_specific_allowed_countries' ) );
 		$request->set_body_params(
@@ -695,7 +695,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( array( 'AX', 'DZ' ), $setting['value'] );
+		$this->assertEquals( array( 'AX', 'DZ' ), $setting[ 'value' ] );
 	}
 
 	/**
@@ -708,7 +708,7 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', sprintf( '/wc/v3/settings/%s/%s', 'products', 'woocommerce_weight_unit' ) ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'kg', $setting['value'] );
+		$this->assertEquals( 'kg', $setting[ 'value' ] );
 
 		// invalid
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v3/settings/%s/%s', 'products', 'woocommerce_weight_unit' ) );
@@ -729,7 +729,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'lbs', $setting['value'] );
+		$this->assertEquals( 'lbs', $setting[ 'value' ] );
 	}
 
 	/**
@@ -744,9 +744,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/general/woocommerce_default_country' ) );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'select', $setting['type'] );
-		$this->assertArrayHasKey( 'GB', $setting['options'] );
-		$this->assertArrayHasKey( 'US:OR', $setting['options'] );
+		$this->assertEquals( 'select', $setting[ 'type' ] );
+		$this->assertArrayHasKey( 'GB', $setting[ 'options' ] );
+		$this->assertArrayHasKey( 'US:OR', $setting[ 'options' ] );
 	}
 
 	/**
@@ -758,10 +758,10 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/general/woocommerce_store_address' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_address' );
 		$request->set_body_params(
@@ -771,7 +771,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_address' );
@@ -782,7 +782,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -794,10 +794,10 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/general/woocommerce_store_address_2' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_address_2' );
 		$request->set_body_params(
@@ -807,7 +807,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_address_2' );
@@ -818,7 +818,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -830,10 +830,10 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/general/woocommerce_store_city' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_city' );
 		$request->set_body_params(
@@ -843,7 +843,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_city' );
@@ -854,7 +854,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -866,10 +866,10 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/settings/general/woocommerce_store_postcode' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_postcode' );
 		$request->set_body_params(
@@ -879,7 +879,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/settings/general/woocommerce_store_postcode' );
@@ -890,6 +890,6 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 }