woocommerce / woocommerce-rest-api

unit-tests/Tests/Version4/Settings.php

Spacing +44 added lines, -44 removed lines

@@ -142,7 +142,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/settings' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 5, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
 		$this->assertArrayHasKey( 'parent_id', $properties );
@@ -160,7 +160,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/settings/test/woocommerce_shop_page_display' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 10, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
 		$this->assertArrayHasKey( 'label', $properties );
@@ -196,8 +196,8 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/test' ) );
 		$data     = $response->get_data();
 		$this->assertEquals( 1, count( $data ) );
-		$this->assertEquals( 'woocommerce_shop_page_display', $data[0]['id'] );
-		$this->assertEmpty( $data[0]['value'] );
+		$this->assertEquals( 'woocommerce_shop_page_display', $data[ 0 ][ 'id' ] );
+		$this->assertEmpty( $data[ 0 ][ 'value' ] );
 	}
 
 	/**
@@ -221,7 +221,7 @@ 
 		// test defaults first
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/test/woocommerce_shop_page_display' ) );
 		$data     = $response->get_data();
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( '', $data[ 'value' ] );
 
 		// test updating shop display setting
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -233,7 +233,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'both', $data['value'] );
+		$this->assertEquals( 'both', $data[ 'value' ] );
 		$this->assertEquals( 'both', get_option( 'woocommerce_shop_page_display' ) );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -245,7 +245,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'subcategories', $data['value'] );
+		$this->assertEquals( 'subcategories', $data[ 'value' ] );
 		$this->assertEquals( 'subcategories', get_option( 'woocommerce_shop_page_display' ) );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'test', 'woocommerce_shop_page_display' ) );
@@ -257,7 +257,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( '', $data[ 'value' ] );
 		$this->assertEquals( '', get_option( 'woocommerce_shop_page_display' ) );
 	}
 
@@ -270,7 +270,7 @@ 
 		// test defaults first
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/test' ) );
 		$data     = $response->get_data();
-		$this->assertEquals( '', $data[0]['value'] );
+		$this->assertEquals( '', $data[ 0 ][ 'value' ] );
 
 		// test setting both at once
 		$request = new WP_REST_Request( 'POST', '/wc/v4/settings/test/batch' );
@@ -287,7 +287,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'both', $data['update'][0]['value'] );
+		$this->assertEquals( 'both', $data[ 'update' ][ 0 ][ 'value' ] );
 		$this->assertEquals( 'both', get_option( 'woocommerce_shop_page_display' ) );
 
 		// test updating one, but making sure the other value stays the same
@@ -304,7 +304,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$this->assertEquals( 'subcategories', $data['update'][0]['value'] );
+		$this->assertEquals( 'subcategories', $data[ 'update' ][ 0 ][ 'value' ] );
 		$this->assertEquals( 'subcategories', get_option( 'woocommerce_shop_page_display' ) );
 	}
 
@@ -330,11 +330,11 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'woocommerce_shop_page_display', $data['id'] );
-		$this->assertEquals( 'Shop page display', $data['label'] );
-		$this->assertEquals( '', $data['default'] );
-		$this->assertEquals( 'select', $data['type'] );
-		$this->assertEquals( '', $data['value'] );
+		$this->assertEquals( 'woocommerce_shop_page_display', $data[ 'id' ] );
+		$this->assertEquals( 'Shop page display', $data[ 'label' ] );
+		$this->assertEquals( '', $data[ 'default' ] );
+		$this->assertEquals( 'select', $data[ 'type' ] );
+		$this->assertEquals( '', $data[ 'value' ] );
 	}
 
 	/**
@@ -491,7 +491,7 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/products/woocommerce_dimension_unit' ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'cm', $data['default'] );
+		$this->assertEquals( 'cm', $data[ 'default' ] );
 
 		// test update
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'products', 'woocommerce_dimension_unit' ) );
@@ -503,7 +503,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'yd', $data['value'] );
+		$this->assertEquals( 'yd', $data[ 'value' ] );
 		$this->assertEquals( 'yd', get_option( 'woocommerce_dimension_unit' ) );
 	}
 
@@ -590,7 +590,7 @@ 
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
 
-		$this->assertEmpty( $setting['value'] );
+		$this->assertEmpty( $setting[ 'value' ] );
 
 		// test update
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'email_customer_new_account', 'subject' ) );
@@ -602,13 +602,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'This is my new subject', $setting['value'] );
+		$this->assertEquals( 'This is my new subject', $setting[ 'value' ] );
 
 		// make sure the other is what we left it
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/email_new_order/subject' ) );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'This is my subject', $setting['value'] );
+		$this->assertEquals( 'This is my subject', $setting[ 'value' ] );
 	}
 
 	/**
@@ -683,7 +683,7 @@ 
 	public function test_validation_multiselect() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', sprintf( '/wc/v4/settings/%s/%s', 'general', 'woocommerce_specific_allowed_countries' ) ) );
 		$setting  = $response->get_data();
-		$this->assertEmpty( $setting['value'] );
+		$this->assertEmpty( $setting[ 'value' ] );
 
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'general', 'woocommerce_specific_allowed_countries' ) );
 		$request->set_body_params(
@@ -693,7 +693,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( array( 'AX', 'DZ' ), $setting['value'] );
+		$this->assertEquals( array( 'AX', 'DZ' ), $setting[ 'value' ] );
 	}
 
 	/**
@@ -704,7 +704,7 @@ 
 	public function test_validation_select() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', sprintf( '/wc/v4/settings/%s/%s', 'products', 'woocommerce_weight_unit' ) ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'kg', $setting['value'] );
+		$this->assertEquals( 'kg', $setting[ 'value' ] );
 
 		// invalid
 		$request = new WP_REST_Request( 'PUT', sprintf( '/wc/v4/settings/%s/%s', 'products', 'woocommerce_weight_unit' ) );
@@ -725,7 +725,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'lbs', $setting['value'] );
+		$this->assertEquals( 'lbs', $setting[ 'value' ] );
 	}
 
 	/**
@@ -739,9 +739,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_default_country' ) );
 		$setting  = $response->get_data();
 
-		$this->assertEquals( 'select', $setting['type'] );
-		$this->assertArrayHasKey( 'GB', $setting['options'] );
-		$this->assertArrayHasKey( 'US:OR', $setting['options'] );
+		$this->assertEquals( 'select', $setting[ 'type' ] );
+		$this->assertArrayHasKey( 'GB', $setting[ 'options' ] );
+		$this->assertArrayHasKey( 'US:OR', $setting[ 'options' ] );
 	}
 
 	/**
@@ -752,10 +752,10 @@ 
 	public function test_woocommerce_store_address() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_address' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address' );
 		$request->set_body_params(
@@ -765,7 +765,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address' );
@@ -776,7 +776,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -787,10 +787,10 @@ 
 	public function test_woocommerce_store_address_2() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_address_2' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address_2' );
 		$request->set_body_params(
@@ -800,7 +800,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_address_2' );
@@ -811,7 +811,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -822,10 +822,10 @@ 
 	public function test_woocommerce_store_city() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_city' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_city' );
 		$request->set_body_params(
@@ -835,7 +835,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_city' );
@@ -846,7 +846,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 
 	/**
@@ -857,10 +857,10 @@ 
 	public function test_woocommerce_store_postcode() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/settings/general/woocommerce_store_postcode' ) );
 		$setting  = $response->get_data();
-		$this->assertEquals( 'text', $setting['type'] );
+		$this->assertEquals( 'text', $setting[ 'type' ] );
 
 		// Repalce the old value with something uniquely new
-		$old_value = $setting['value'];
+		$old_value = $setting[ 'value' ];
 		$new_value = $old_value . ' ' . rand( 1000, 9999 );
 		$request   = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_postcode' );
 		$request->set_body_params(
@@ -870,7 +870,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $new_value, $setting['value'] );
+		$this->assertEquals( $new_value, $setting[ 'value' ] );
 
 		// Put the original value back
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/settings/general/woocommerce_store_postcode' );
@@ -881,6 +881,6 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$setting  = $response->get_data();
-		$this->assertEquals( $old_value, $setting['value'] );
+		$this->assertEquals( $old_value, $setting[ 'value' ] );
 	}
 }

unit-tests/Tests/Version4/ShippingMethods.php

Spacing +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/shipping_methods' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version4/ProductReviews.php

Spacing +19 added lines, -19 removed lines

@@ -65,9 +65,9 @@ 
 		$this->assertExpectedResponse( $response, 201, $data );
 		$this->assertEquals(
 			array(
-				'id'                   => $response->data['id'],
-				'date_created'         => $response->data['date_created'],
-				'date_created_gmt'     => $response->data['date_created_gmt'],
+				'id'                   => $response->data[ 'id' ],
+				'date_created'         => $response->data[ 'date_created' ],
+				'date_created_gmt'     => $response->data[ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'Admin',
@@ -75,7 +75,7 @@ 
 				'review'               => 'Hello world.',
 				'rating'               => 5,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $response->data['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $response->data[ 'reviewer_avatar_urls' ],
 			),
 			$response->data
 		);
@@ -103,8 +103,8 @@ 
 		$this->assertContains(
 			array(
 				'id'                   => $review_id,
-				'date_created'         => $product_reviews[0]['date_created'],
-				'date_created_gmt'     => $product_reviews[0]['date_created_gmt'],
+				'date_created'         => $product_reviews[ 0 ][ 'date_created' ],
+				'date_created_gmt'     => $product_reviews[ 0 ][ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'admin',
@@ -112,7 +112,7 @@ 
 				'review'               => "<p>Review content here</p>\n",
 				'rating'               => 0,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $product_reviews[0]['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $product_reviews[ 0 ][ 'reviewer_avatar_urls' ],
 				'_links'               => array(
 					'self'       => array(
 						array(
@@ -146,12 +146,12 @@ 
 
 		$response          = $this->do_request( '/wc/v4/products/reviews/' . $product_review_id );
 		$this->assertEquals( 200, $response->status );
-		$this->assertEquals( "<p>Review content here</p>\n", $response->data['review'] );
-		$this->assertEquals( 'admin', $response->data['reviewer'] );
-		$this->assertEquals( 'woo@woo.local', $response->data['reviewer_email'] );
-		$this->assertEquals( 0, $response->data['rating'] );
+		$this->assertEquals( "<p>Review content here</p>\n", $response->data[ 'review' ] );
+		$this->assertEquals( 'admin', $response->data[ 'reviewer' ] );
+		$this->assertEquals( 'woo@woo.local', $response->data[ 'reviewer_email' ] );
+		$this->assertEquals( 0, $response->data[ 'rating' ] );
 
-		$data     = [
+		$data = [
 			'review'         => 'Hello world - updated.',
 			'reviewer'       => 'Justin',
 			'reviewer_email' => 'woo2@woo.local',
@@ -207,8 +207,8 @@ 
 		$this->assertEquals(
 			array(
 				'id'                   => $product_review_id,
-				'date_created'         => $data['date_created'],
-				'date_created_gmt'     => $data['date_created_gmt'],
+				'date_created'         => $data[ 'date_created' ],
+				'date_created_gmt'     => $data[ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'admin',
@@ -216,7 +216,7 @@ 
 				'review'               => "<p>Review content here</p>\n",
 				'rating'               => 0,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $data['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $data[ 'reviewer_avatar_urls' ],
 			),
 			$data
 		);
@@ -383,10 +383,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Updated review.', $data['update'][0]['review'] );
-		$this->assertEquals( 'New review.', $data['create'][0]['review'] );
-		$this->assertEquals( $review_2_id, $data['delete'][0]['previous']['id'] );
-		$this->assertEquals( $review_3_id, $data['delete'][1]['previous']['id'] );
+		$this->assertEquals( 'Updated review.', $data[ 'update' ][ 0 ][ 'review' ] );
+		$this->assertEquals( 'New review.', $data[ 'create' ][ 0 ][ 'review' ] );
+		$this->assertEquals( $review_2_id, $data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
+		$this->assertEquals( $review_3_id, $data[ 'delete' ][ 1 ][ 'previous' ][ 'id' ] );
 
 		$request = new \WP_REST_Request( 'GET', '/wc/v4/products/reviews' );
 		$request->set_param( 'product', $product->get_id() );

unit-tests/Tests/Version2/product-reviews.php

Spacing +23 added lines, -23 removed lines

@@ -53,8 +53,8 @@ 
 		$this->assertContains(
 			array(
 				'id'                   => $review_id,
-				'date_created'         => $product_reviews[0]['date_created'],
-				'date_created_gmt'     => $product_reviews[0]['date_created_gmt'],
+				'date_created'         => $product_reviews[ 0 ][ 'date_created' ],
+				'date_created_gmt'     => $product_reviews[ 0 ][ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'admin',
@@ -62,7 +62,7 @@ 
 				'review'               => "<p>Review content here</p>\n",
 				'rating'               => 0,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $product_reviews[0]['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $product_reviews[ 0 ][ 'reviewer_avatar_urls' ],
 				'_links'               => array(
 					'self'       => array(
 						array(
@@ -125,8 +125,8 @@ 
 		$this->assertEquals(
 			array(
 				'id'                   => $product_review_id,
-				'date_created'         => $data['date_created'],
-				'date_created_gmt'     => $data['date_created_gmt'],
+				'date_created'         => $data[ 'date_created' ],
+				'date_created_gmt'     => $data[ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'admin',
@@ -134,7 +134,7 @@ 
 				'review'               => "<p>Review content here</p>\n",
 				'rating'               => 0,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $data['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $data[ 'reviewer_avatar_urls' ],
 			),
 			$data
 		);
@@ -189,9 +189,9 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                   => $data['id'],
-				'date_created'         => $data['date_created'],
-				'date_created_gmt'     => $data['date_created_gmt'],
+				'id'                   => $data[ 'id' ],
+				'date_created'         => $data[ 'date_created' ],
+				'date_created_gmt'     => $data[ 'date_created_gmt' ],
 				'product_id'           => $product->get_id(),
 				'status'               => 'approved',
 				'reviewer'             => 'Admin',
@@ -199,7 +199,7 @@ 
 				'review'               => 'Hello world.',
 				'rating'               => 5,
 				'verified'             => false,
-				'reviewer_avatar_urls' => $data['reviewer_avatar_urls'],
+				'reviewer_avatar_urls' => $data[ 'reviewer_avatar_urls' ],
 			),
 			$data
 		);
@@ -266,10 +266,10 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v3/products/reviews/' . $product_review_id ) );
 		$data     = $response->get_data();
-		$this->assertEquals( "<p>Review content here</p>\n", $data['review'] );
-		$this->assertEquals( 'admin', $data['reviewer'] );
-		$this->assertEquals( 'woo@woo.local', $data['reviewer_email'] );
-		$this->assertEquals( 0, $data['rating'] );
+		$this->assertEquals( "<p>Review content here</p>\n", $data[ 'review' ] );
+		$this->assertEquals( 'admin', $data[ 'reviewer' ] );
+		$this->assertEquals( 'woo@woo.local', $data[ 'reviewer_email' ] );
+		$this->assertEquals( 0, $data[ 'rating' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v3/products/reviews/' . $product_review_id );
 		$request->set_body_params(
@@ -282,10 +282,10 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
-		$this->assertEquals( 'Hello world - updated.', $data['review'] );
-		$this->assertEquals( 'Justin', $data['reviewer'] );
-		$this->assertEquals( 'woo2@woo.local', $data['reviewer_email'] );
-		$this->assertEquals( 3, $data['rating'] );
+		$this->assertEquals( 'Hello world - updated.', $data[ 'review' ] );
+		$this->assertEquals( 'Justin', $data[ 'reviewer' ] );
+		$this->assertEquals( 'woo2@woo.local', $data[ 'reviewer_email' ] );
+		$this->assertEquals( 3, $data[ 'rating' ] );
 	}
 
 	/**
@@ -424,10 +424,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Updated review.', $data['update'][0]['review'] );
-		$this->assertEquals( 'New review.', $data['create'][0]['review'] );
-		$this->assertEquals( $review_2_id, $data['delete'][0]['previous']['id'] );
-		$this->assertEquals( $review_3_id, $data['delete'][1]['previous']['id'] );
+		$this->assertEquals( 'Updated review.', $data[ 'update' ][ 0 ][ 'review' ] );
+		$this->assertEquals( 'New review.', $data[ 'create' ][ 0 ][ 'review' ] );
+		$this->assertEquals( $review_2_id, $data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
+		$this->assertEquals( $review_3_id, $data[ 'delete' ][ 1 ][ 'previous' ][ 'id' ] );
 
 		$request = new WP_REST_Request( 'GET', '/wc/v3/products/reviews' );
 		$request->set_param( 'product', $product->get_id() );
@@ -449,7 +449,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v3/products/reviews' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 11, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

src/Controllers/Version4/ProductReviews.php

Spacing +60 added lines, -60 removed lines

@@ -176,29 +176,29 @@ 
 			}
 		}
 
-		if ( isset( $registered['orderby'] ) ) {
-			$prepared_args['orderby'] = $this->normalize_query_param( $request['orderby'] );
+		if ( isset( $registered[ 'orderby' ] ) ) {
+			$prepared_args[ 'orderby' ] = $this->normalize_query_param( $request[ 'orderby' ] );
 		}
 
-		if ( isset( $prepared_args['status'] ) ) {
-			$prepared_args['status'] = 'approved' === $prepared_args['status'] ? 'approve' : $prepared_args['status'];
+		if ( isset( $prepared_args[ 'status' ] ) ) {
+			$prepared_args[ 'status' ] = 'approved' === $prepared_args[ 'status' ] ? 'approve' : $prepared_args[ 'status' ];
 		}
 
-		$prepared_args['no_found_rows'] = false;
-		$prepared_args['date_query']    = array();
+		$prepared_args[ 'no_found_rows' ] = false;
+		$prepared_args[ 'date_query' ]    = array();
 
 		// Set before into date query. Date query must be specified as an array of an array.
-		if ( isset( $registered['before'], $request['before'] ) ) {
-			$prepared_args['date_query'][0]['before'] = $request['before'];
+		if ( isset( $registered[ 'before' ], $request[ 'before' ] ) ) {
+			$prepared_args[ 'date_query' ][ 0 ][ 'before' ] = $request[ 'before' ];
 		}
 
 		// Set after into date query. Date query must be specified as an array of an array.
-		if ( isset( $registered['after'], $request['after'] ) ) {
-			$prepared_args['date_query'][0]['after'] = $request['after'];
+		if ( isset( $registered[ 'after' ], $request[ 'after' ] ) ) {
+			$prepared_args[ 'date_query' ][ 0 ][ 'after' ] = $request[ 'after' ];
 		}
 
-		if ( isset( $registered['page'] ) && empty( $request['offset'] ) ) {
-			$prepared_args['offset'] = $prepared_args['number'] * ( absint( $request['page'] ) - 1 );
+		if ( isset( $registered[ 'page' ] ) && empty( $request[ 'offset' ] ) ) {
+			$prepared_args[ 'offset' ] = $prepared_args[ 'number' ] * ( absint( $request[ 'page' ] ) - 1 );
 		}
 
 		/**
@@ -212,7 +212,7 @@ 
 		$prepared_args = apply_filters( 'woocommerce_rest_product_review_query', $prepared_args, $request );
 
 		// Make sure that returns only reviews.
-		$prepared_args['type'] = 'review';
+		$prepared_args[ 'type' ] = 'review';
 
 		// Query reviews.
 		$query        = new \WP_Comment_Query();
@@ -225,7 +225,7 @@ 
 			}
 
 			$data      = $this->prepare_item_for_response( $review, $request );
-			$reviews[] = $this->prepare_response_for_collection( $data );
+			$reviews[ ] = $this->prepare_response_for_collection( $data );
 		}
 
 		$total_reviews = (int) $query->found_comments;
@@ -233,13 +233,13 @@ 
 
 		if ( $total_reviews < 1 ) {
 			// Out-of-bounds, run the query again without LIMIT for total count.
-			unset( $prepared_args['number'], $prepared_args['offset'] );
+			unset( $prepared_args[ 'number' ], $prepared_args[ 'offset' ] );
 
 			$query                  = new \WP_Comment_Query();
-			$prepared_args['count'] = true;
+			$prepared_args[ 'count' ] = true;
 
 			$total_reviews = $query->query( $prepared_args );
-			$max_pages     = ceil( $total_reviews / $request['per_page'] );
+			$max_pages     = ceil( $total_reviews / $request[ 'per_page' ] );
 		}
 
 		$response = rest_ensure_response( $reviews );
@@ -256,7 +256,7 @@ 
 	 */
 	public function create_item( $request ) {
 		try {
-			if ( ! empty( $request['id'] ) ) {
+			if ( ! empty( $request[ 'id' ] ) ) {
 				return new \WP_Error( 'woocommerce_rest_review_exists', __( 'Cannot create existing product review.', 'woocommerce-rest-api' ), array( 'status' => 400 ) );
 			}
 
@@ -312,11 +312,11 @@ 
 				throw new \WC_REST_Exception( 'woocommerce_rest_review_failed_create', __( 'Creating product review failed.', 'woocommerce-rest-api' ), 500 );
 			}
 
-			if ( isset( $request['status'] ) ) {
-				$this->handle_status_param( $request['status'], $review_id );
+			if ( isset( $request[ 'status' ] ) ) {
+				$this->handle_status_param( $request[ 'status' ], $review_id );
 			}
 
-			update_comment_meta( $review_id, 'rating', ! empty( $request['rating'] ) ? $request['rating'] : '0' );
+			update_comment_meta( $review_id, 'rating', ! empty( $request[ 'rating' ] ) ? $request[ 'rating' ] : '0' );
 		} catch ( \WC_REST_Exception $e ) {
 			return new \WP_Error( $e->getErrorCode(), $e->getMessage(), array( 'status' => $e->getCode() ) );
 		}
@@ -358,12 +358,12 @@ 
 	 * @return array
 	 */
 	protected function validate_review( $prepared_review, $creating = false ) {
-		if ( empty( $prepared_review['comment_content'] ) ) {
+		if ( empty( $prepared_review[ 'comment_content' ] ) ) {
 			throw new \WC_REST_Exception( 'woocommerce_rest_review_content_invalid', __( 'Invalid review content.', 'woocommerce-rest-api' ), 400 );
 		}
 
-		if ( ! empty( $prepared_review['comment_post_ID'] ) ) {
-			if ( 'product' !== get_post_type( $prepared_review['comment_post_ID'] ) ) {
+		if ( ! empty( $prepared_review[ 'comment_post_ID' ] ) ) {
+			if ( 'product' !== get_post_type( $prepared_review[ 'comment_post_ID' ] ) ) {
 				throw new \WC_REST_Exception( 'woocommerce_rest_product_invalid_id', __( 'Invalid product ID.', 'woocommerce-rest-api' ), 404 );
 			}
 		}
@@ -376,7 +376,7 @@ 
 		}
 
 		if ( $creating ) {
-			$prepared_review['comment_approved'] = $this->get_comment_approved( $prepared_review );
+			$prepared_review[ 'comment_approved' ] = $this->get_comment_approved( $prepared_review );
 		}
 
 		return $prepared_review;
@@ -388,8 +388,8 @@ 
 	 * @return string
 	 */
 	protected function get_comment_author_ip() {
-		if ( ! empty( $_SERVER['REMOTE_ADDR'] ) && rest_is_ip_address( wp_unslash( $_SERVER['REMOTE_ADDR'] ) ) ) { // WPCS: input var ok, sanitization ok.
-			return wc_clean( wp_unslash( $_SERVER['REMOTE_ADDR'] ) ); // WPCS: input var ok.
+		if ( ! empty( $_SERVER[ 'REMOTE_ADDR' ] ) && rest_is_ip_address( wp_unslash( $_SERVER[ 'REMOTE_ADDR' ] ) ) ) { // WPCS: input var ok, sanitization ok.
+			return wc_clean( wp_unslash( $_SERVER[ 'REMOTE_ADDR' ] ) ); // WPCS: input var ok.
 		} else {
 			return '127.0.0.1';
 		}
@@ -402,8 +402,8 @@ 
 	 * @return string
 	 */
 	protected function get_comment_agent( $request ) {
-		if ( ! empty( $request['author_user_agent'] ) ) {
-			return $request['author_user_agent'];
+		if ( ! empty( $request[ 'author_user_agent' ] ) ) {
+			return $request[ 'author_user_agent' ];
 		} elseif ( $request->get_header( 'user_agent' ) ) {
 			return $request->get_header( 'user_agent' );
 		} else {
@@ -444,7 +444,7 @@ 
 	 * @return \WP_Error|\WP_REST_Response
 	 */
 	public function get_item( $request ) {
-		$review = $this->get_review( $request['id'] );
+		$review = $this->get_review( $request[ 'id' ] );
 		if ( is_wp_error( $review ) ) {
 			return $review;
 		}
@@ -460,7 +460,7 @@ 
 	 */
 	public function update_item( $request ) {
 		try {
-			$review = $this->get_review( $request['id'] );
+			$review = $this->get_review( $request[ 'id' ] );
 
 			if ( is_wp_error( $review ) ) {
 				return $review;
@@ -468,7 +468,7 @@ 
 
 			$review_id = (int) $review->comment_ID;
 
-			if ( isset( $request['type'] ) && 'review' !== get_comment_type( $review_id ) ) {
+			if ( isset( $request[ 'type' ] ) && 'review' !== get_comment_type( $review_id ) ) {
 				return new \WP_Error( 'woocommerce_rest_review_invalid_type', __( 'Sorry, you are not allowed to change the comment type.', 'woocommerce-rest-api' ), array( 'status' => 404 ) );
 			}
 
@@ -493,12 +493,12 @@ 
 
 			wp_update_comment( wp_slash( $prepared_review ) );
 
-			if ( isset( $request['status'] ) ) {
-				$this->handle_status_param( $request['status'], $review_id );
+			if ( isset( $request[ 'status' ] ) ) {
+				$this->handle_status_param( $request[ 'status' ], $review_id );
 			}
 
-			if ( ! empty( $request['rating'] ) ) {
-				update_comment_meta( $review_id, 'rating', $request['rating'] );
+			if ( ! empty( $request[ 'rating' ] ) ) {
+				update_comment_meta( $review_id, 'rating', $request[ 'rating' ] );
 			}
 		} catch ( \WC_REST_Exception $e ) {
 			return new \WP_Error( $e->getErrorCode(), $e->getMessage(), array( 'status' => $e->getCode() ) );
@@ -533,12 +533,12 @@ 
 	 * @return \WP_Error|\WP_REST_Response Response object on success, or error object on failure.
 	 */
 	public function delete_item( $request ) {
-		$review = $this->get_review( $request['id'] );
+		$review = $this->get_review( $request[ 'id' ] );
 		if ( is_wp_error( $review ) ) {
 			return $review;
 		}
 
-		$force = isset( $request['force'] ) ? (bool) $request['force'] : false;
+		$force = isset( $request[ 'force' ] ) ? (bool) $request[ 'force' ] : false;
 
 		/**
 		 * Filters whether a review can be trashed.
@@ -634,17 +634,17 @@ 
 			$prepared_review[ $key ] = $request[ $value ];
 		}
 
-		if ( ! empty( $request['date_created'] ) ) {
-			$date_data = rest_get_date_with_gmt( $request['date_created'] );
+		if ( ! empty( $request[ 'date_created' ] ) ) {
+			$date_data = rest_get_date_with_gmt( $request[ 'date_created' ] );
 
 			if ( ! empty( $date_data ) ) {
-				list( $prepared_review['comment_date'], $prepared_review['comment_date_gmt'] ) = $date_data;
+				list( $prepared_review[ 'comment_date' ], $prepared_review[ 'comment_date_gmt' ] ) = $date_data;
 			}
-		} elseif ( ! empty( $request['date_created_gmt'] ) ) {
-			$date_data = rest_get_date_with_gmt( $request['date_created_gmt'], true );
+		} elseif ( ! empty( $request[ 'date_created_gmt' ] ) ) {
+			$date_data = rest_get_date_with_gmt( $request[ 'date_created_gmt' ], true );
 
 			if ( ! empty( $date_data ) ) {
-				list( $prepared_review['comment_date'], $prepared_review['comment_date_gmt'] ) = $date_data;
+				list( $prepared_review[ 'comment_date' ], $prepared_review[ 'comment_date_gmt' ] ) = $date_data;
 			}
 		}
 
@@ -668,13 +668,13 @@ 
 			),
 		);
 		if ( 0 !== (int) $item->comment_post_ID ) {
-			$links['up'] = array(
+			$links[ 'up' ] = array(
 				'href'       => rest_url( sprintf( '/%s/products/%d', $this->namespace, $item->comment_post_ID ) ),
 				'embeddable' => true,
 			);
 		}
 		if ( 0 !== (int) $item->user_id ) {
-			$links['reviewer'] = array(
+			$links[ 'reviewer' ] = array(
 				'href'       => rest_url( 'wp/v2/users/' . $item->user_id ),
 				'embeddable' => true,
 			);
@@ -769,7 +769,7 @@ 
 					'context'     => array( 'embed', 'view', 'edit' ),
 				);
 			}
-			$schema['properties']['reviewer_avatar_urls'] = array(
+			$schema[ 'properties' ][ 'reviewer_avatar_urls' ] = array(
 				'description' => __( 'Avatar URLs for the object reviewer.', 'woocommerce-rest-api' ),
 				'type'        => 'object',
 				'context'     => array( 'view', 'edit' ),
@@ -789,19 +789,19 @@ 
 	public function get_collection_params() {
 		$params = parent::get_collection_params();
 
-		$params['context']['default'] = 'view';
+		$params[ 'context' ][ 'default' ] = 'view';
 
-		$params['after']            = array(
+		$params[ 'after' ] = array(
 			'description' => __( 'Limit response to resources published after a given ISO8601 compliant date.', 'woocommerce-rest-api' ),
 			'type'        => 'string',
 			'format'      => 'date-time',
 		);
-		$params['before']           = array(
+		$params[ 'before' ] = array(
 			'description' => __( 'Limit response to reviews published before a given ISO8601 compliant date.', 'woocommerce-rest-api' ),
 			'type'        => 'string',
 			'format'      => 'date-time',
 		);
-		$params['exclude']          = array(
+		$params[ 'exclude' ] = array(
 			'description' => __( 'Ensure result set excludes specific IDs.', 'woocommerce-rest-api' ),
 			'type'        => 'array',
 			'items'       => array(
@@ -809,7 +809,7 @@ 
 			),
 			'default'     => array(),
 		);
-		$params['include']          = array(
+		$params[ 'include' ] = array(
 			'description' => __( 'Limit result set to specific IDs.', 'woocommerce-rest-api' ),
 			'type'        => 'array',
 			'items'       => array(
@@ -817,11 +817,11 @@ 
 			),
 			'default'     => array(),
 		);
-		$params['offset']           = array(
+		$params[ 'offset' ] = array(
 			'description' => __( 'Offset the result set by a specific number of items.', 'woocommerce-rest-api' ),
 			'type'        => 'integer',
 		);
-		$params['order']            = array(
+		$params[ 'order' ] = array(
 			'description' => __( 'Order sort attribute ascending or descending.', 'woocommerce-rest-api' ),
 			'type'        => 'string',
 			'default'     => 'desc',
@@ -830,7 +830,7 @@ 
 				'desc',
 			),
 		);
-		$params['orderby']          = array(
+		$params[ 'orderby' ] = array(
 			'description' => __( 'Sort collection by object attribute.', 'woocommerce-rest-api' ),
 			'type'        => 'string',
 			'default'     => 'date_gmt',
@@ -842,27 +842,27 @@ 
 				'product',
 			),
 		);
-		$params['reviewer']         = array(
+		$params[ 'reviewer' ] = array(
 			'description' => __( 'Limit result set to reviews assigned to specific user IDs.', 'woocommerce-rest-api' ),
 			'type'        => 'array',
 			'items'       => array(
 				'type' => 'integer',
 			),
 		);
-		$params['reviewer_exclude'] = array(
+		$params[ 'reviewer_exclude' ] = array(
 			'description' => __( 'Ensure result set excludes reviews assigned to specific user IDs.', 'woocommerce-rest-api' ),
 			'type'        => 'array',
 			'items'       => array(
 				'type' => 'integer',
 			),
 		);
-		$params['reviewer_email']   = array(
+		$params[ 'reviewer_email' ] = array(
 			'default'     => null,
 			'description' => __( 'Limit result set to that from a specific author email.', 'woocommerce-rest-api' ),
 			'format'      => 'email',
 			'type'        => 'string',
 		);
-		$params['product']          = array(
+		$params[ 'product' ] = array(
 			'default'     => array(),
 			'description' => __( 'Limit result set to reviews assigned to specific product IDs.', 'woocommerce-rest-api' ),
 			'type'        => 'array',
@@ -870,7 +870,7 @@ 
 				'type' => 'integer',
 			),
 		);
-		$params['status']           = array(
+		$params[ 'status' ] = array(
 			'default'           => 'approved',
 			'description'       => __( 'Limit result set to reviews assigned a specific status.', 'woocommerce-rest-api' ),
 			'sanitize_callback' => 'sanitize_key',