woocommerce / woocommerce-rest-api

unit-tests/Tests/Version2/products.php

Spacing +51 added lines, -51 removed lines

@@ -52,10 +52,10 @@ 
 		$this->assertEquals( 200, $response->get_status() );
 
 		$this->assertEquals( 2, count( $products ) );
-		$this->assertEquals( 'Dummy Product', $products[0]['name'] );
-		$this->assertEquals( 'DUMMY SKU', $products[0]['sku'] );
-		$this->assertEquals( 'Dummy External Product', $products[1]['name'] );
-		$this->assertEquals( 'DUMMY EXTERNAL SKU', $products[1]['sku'] );
+		$this->assertEquals( 'Dummy Product', $products[ 0 ][ 'name' ] );
+		$this->assertEquals( 'DUMMY SKU', $products[ 0 ][ 'sku' ] );
+		$this->assertEquals( 'Dummy External Product', $products[ 1 ][ 'name' ] );
+		$this->assertEquals( 'DUMMY EXTERNAL SKU', $products[ 1 ][ 'sku' ] );
 	}
 
 	/**
@@ -166,9 +166,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/products/' . $product->get_id() ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'DUMMY SKU', $data['sku'] );
-		$this->assertEquals( 10, $data['regular_price'] );
-		$this->assertEmpty( $data['sale_price'] );
+		$this->assertEquals( 'DUMMY SKU', $data[ 'sku' ] );
+		$this->assertEquals( 10, $data[ 'regular_price' ] );
+		$this->assertEmpty( $data[ 'sale_price' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v2/products/' . $product->get_id() );
 		$request->set_body_params(
@@ -188,13 +188,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertContains( 'Testing', $data['description'] );
-		$this->assertEquals( '8', $data['price'] );
-		$this->assertEquals( '8', $data['sale_price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertEquals( 'FIXED-SKU', $data['sku'] );
-		$this->assertContains( 'Dr1Bczxq4q', $data['images'][0]['src'] );
-		$this->assertContains( 'test upload image', $data['images'][0]['alt'] );
+		$this->assertContains( 'Testing', $data[ 'description' ] );
+		$this->assertEquals( '8', $data[ 'price' ] );
+		$this->assertEquals( '8', $data[ 'sale_price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertEquals( 'FIXED-SKU', $data[ 'sku' ] );
+		$this->assertContains( 'Dr1Bczxq4q', $data[ 'images' ][ 0 ][ 'src' ] );
+		$this->assertContains( 'test upload image', $data[ 'images' ][ 0 ][ 'alt' ] );
 		$product->delete( true );
 
 		// test variable product (variations are tested in product-variations.php).
@@ -203,7 +203,7 @@ 
 		$data     = $response->get_data();
 
 		foreach ( array( 'small', 'large' ) as $term_name ) {
-			$this->assertContains( $term_name, $data['attributes'][0]['options'] );
+			$this->assertContains( $term_name, $data[ 'attributes' ][ 0 ][ 'options' ] );
 		}
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v2/products/' . $product->get_id() );
@@ -235,8 +235,8 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( array( 'small' ), $data['attributes'][0]['options'] );
-		$this->assertEquals( array( 'red', 'yellow' ), $data['attributes'][1]['options'] );
+		$this->assertEquals( array( 'small' ), $data[ 'attributes' ][ 0 ][ 'options' ] );
+		$this->assertEquals( array( 'red', 'yellow' ), $data[ 'attributes' ][ 1 ][ 'options' ] );
 		$product->delete( true );
 
 		// test external product.
@@ -244,8 +244,8 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/products/' . $product->get_id() ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Buy external product', $data['button_text'] );
-		$this->assertEquals( 'http://woocommerce.com', $data['external_url'] );
+		$this->assertEquals( 'Buy external product', $data[ 'button_text' ] );
+		$this->assertEquals( 'http://woocommerce.com', $data[ 'external_url' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v2/products/' . $product->get_id() );
 		$request->set_body_params(
@@ -257,8 +257,8 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'Test API Update', $data['button_text'] );
-		$this->assertEquals( 'http://automattic.com', $data['external_url'] );
+		$this->assertEquals( 'Test API Update', $data[ 'button_text' ] );
+		$this->assertEquals( 'http://automattic.com', $data[ 'external_url' ] );
 	}
 
 	/**
@@ -313,7 +313,7 @@ 
 		);
 		$response          = $this->server->dispatch( $request );
 		$data              = $response->get_data();
-		$shipping_class_id = $data['id'];
+		$shipping_class_id = $data[ 'id' ];
 
 		// Create simple.
 		$request = new WP_REST_Request( 'POST', '/wc/v2/products' );
@@ -329,13 +329,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '10', $data['price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertTrue( $data['purchasable'] );
-		$this->assertEquals( 'DUMMY SKU SIMPLE API', $data['sku'] );
-		$this->assertEquals( 'Test Simple Product', $data['name'] );
-		$this->assertEquals( 'simple', $data['type'] );
-		$this->assertEquals( $shipping_class_id, $data['shipping_class_id'] );
+		$this->assertEquals( '10', $data[ 'price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertTrue( $data[ 'purchasable' ] );
+		$this->assertEquals( 'DUMMY SKU SIMPLE API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test Simple Product', $data[ 'name' ] );
+		$this->assertEquals( 'simple', $data[ 'type' ] );
+		$this->assertEquals( $shipping_class_id, $data[ 'shipping_class_id' ] );
 
 		// Create external.
 		$request = new WP_REST_Request( 'POST', '/wc/v2/products' );
@@ -352,14 +352,14 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( '10', $data['price'] );
-		$this->assertEquals( '10', $data['regular_price'] );
-		$this->assertFalse( $data['purchasable'] );
-		$this->assertEquals( 'DUMMY SKU EXTERNAL API', $data['sku'] );
-		$this->assertEquals( 'Test External Product', $data['name'] );
-		$this->assertEquals( 'external', $data['type'] );
-		$this->assertEquals( 'Test Button', $data['button_text'] );
-		$this->assertEquals( 'https://wordpress.org', $data['external_url'] );
+		$this->assertEquals( '10', $data[ 'price' ] );
+		$this->assertEquals( '10', $data[ 'regular_price' ] );
+		$this->assertFalse( $data[ 'purchasable' ] );
+		$this->assertEquals( 'DUMMY SKU EXTERNAL API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test External Product', $data[ 'name' ] );
+		$this->assertEquals( 'external', $data[ 'type' ] );
+		$this->assertEquals( 'Test Button', $data[ 'button_text' ] );
+		$this->assertEquals( 'https://wordpress.org', $data[ 'external_url' ] );
 
 		// Create variable.
 		$request = new WP_REST_Request( 'POST', '/wc/v2/products' );
@@ -385,10 +385,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'DUMMY SKU VARIABLE API', $data['sku'] );
-		$this->assertEquals( 'Test Variable Product', $data['name'] );
-		$this->assertEquals( 'variable', $data['type'] );
-		$this->assertEquals( array( 'small', 'medium' ), $data['attributes'][0]['options'] );
+		$this->assertEquals( 'DUMMY SKU VARIABLE API', $data[ 'sku' ] );
+		$this->assertEquals( 'Test Variable Product', $data[ 'name' ] );
+		$this->assertEquals( 'variable', $data[ 'type' ] );
+		$this->assertEquals( array( 'small', 'medium' ), $data[ 'attributes' ][ 0 ][ 'options' ] );
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/products' ) );
 		$products = $response->get_data();
@@ -453,13 +453,13 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertContains( 'Updated description.', $data['update'][0]['description'] );
-		$this->assertEquals( 'DUMMY SKU BATCH TEST 1', $data['create'][0]['sku'] );
-		$this->assertEquals( 'DUMMY SKU BATCH TEST 2', $data['create'][1]['sku'] );
-		$this->assertEquals( 'Test Button', $data['create'][0]['button_text'] );
-		$this->assertEquals( 'external', $data['create'][0]['type'] );
-		$this->assertEquals( 'simple', $data['create'][1]['type'] );
-		$this->assertEquals( $product_2->get_id(), $data['delete'][0]['id'] );
+		$this->assertContains( 'Updated description.', $data[ 'update' ][ 0 ][ 'description' ] );
+		$this->assertEquals( 'DUMMY SKU BATCH TEST 1', $data[ 'create' ][ 0 ][ 'sku' ] );
+		$this->assertEquals( 'DUMMY SKU BATCH TEST 2', $data[ 'create' ][ 1 ][ 'sku' ] );
+		$this->assertEquals( 'Test Button', $data[ 'create' ][ 0 ][ 'button_text' ] );
+		$this->assertEquals( 'external', $data[ 'create' ][ 0 ][ 'type' ] );
+		$this->assertEquals( 'simple', $data[ 'create' ][ 1 ][ 'type' ] );
+		$this->assertEquals( $product_2->get_id(), $data[ 'delete' ][ 0 ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v2/products' );
 		$response = $this->server->dispatch( $request );
@@ -496,7 +496,7 @@ 
 
 		$this->assertEquals( 4, count( $products ) );
 		foreach ( $products as $product ) {
-			$this->assertEquals( 'publish', $product['status'] );
+			$this->assertEquals( 'publish', $product[ 'status' ] );
 		}
 
 		// Test filtering with status=draft.
@@ -507,7 +507,7 @@ 
 
 		$this->assertEquals( 4, count( $products ) );
 		foreach ( $products as $product ) {
-			$this->assertEquals( 'draft', $product['status'] );
+			$this->assertEquals( 'draft', $product[ 'status' ] );
 		}
 
 		// Test filtering with no filters - which should return 'any' (all 8).
@@ -529,7 +529,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v2/products/' . $product->get_id() );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 65, count( $properties ) );
 	}
 }

unit-tests/Tests/Version2/payment-gateways.php

Spacing +26 added lines, -26 removed lines

@@ -155,9 +155,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/payment_gateways/paypal' ) );
 		$paypal   = $response->get_data();
 
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'admin@example.org', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'admin@example.org', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating single setting
 		$request = new WP_REST_Request( 'POST', '/wc/v2/payment_gateways/paypal' );
@@ -172,9 +172,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating multiple settings
 		$request = new WP_REST_Request( 'POST', '/wc/v2/payment_gateways/paypal' );
@@ -190,9 +190,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// Test other parameters, and recheck settings
 		$request = new WP_REST_Request( 'POST', '/wc/v2/payment_gateways/paypal' );
@@ -205,11 +205,11 @@ 
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
 
-		$this->assertFalse( $paypal['enabled'] );
-		$this->assertEquals( 2, $paypal['order'] );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertFalse( $paypal[ 'enabled' ] );
+		$this->assertEquals( 2, $paypal[ 'order' ] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test bogus
 		$request = new WP_REST_Request( 'POST', '/wc/v2/payment_gateways/paypal' );
@@ -233,7 +233,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
-		$this->assertEquals( 'authorization', $paypal['settings']['paymentaction']['value'] );
+		$this->assertEquals( 'authorization', $paypal[ 'settings' ][ 'paymentaction' ][ 'value' ] );
 	}
 
 	/**
@@ -284,7 +284,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v2/payment_gateways' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 8, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -309,25 +309,25 @@ 
 		$gateway->init_form_fields();
 		foreach ( $gateway->form_fields as $id => $field ) {
 			// Make sure we at least have a title and type
-			if ( empty( $field['title'] ) || empty( $field['type'] ) ) {
+			if ( empty( $field[ 'title' ] ) || empty( $field[ 'type' ] ) ) {
 				continue;
 			}
 			// Ignore 'title' settings/fields -- they are UI only
-			if ( 'title' === $field['type'] ) {
+			if ( 'title' === $field[ 'type' ] ) {
 				continue;
 			}
 			$data = array(
 				'id'          => $id,
-				'label'       => empty( $field['label'] ) ? $field['title'] : $field['label'],
-				'description' => empty( $field['description'] ) ? '' : $field['description'],
-				'type'        => $field['type'],
+				'label'       => empty( $field[ 'label' ] ) ? $field[ 'title' ] : $field[ 'label' ],
+				'description' => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'type'        => $field[ 'type' ],
 				'value'       => $gateway->settings[ $id ],
-				'default'     => empty( $field['default'] ) ? '' : $field['default'],
-				'tip'         => empty( $field['description'] ) ? '' : $field['description'],
-				'placeholder' => empty( $field['placeholder'] ) ? '' : $field['placeholder'],
+				'default'     => empty( $field[ 'default' ] ) ? '' : $field[ 'default' ],
+				'tip'         => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'placeholder' => empty( $field[ 'placeholder' ] ) ? '' : $field[ 'placeholder' ],
 			);
-			if ( ! empty( $field['options'] ) ) {
-				$data['options'] = $field['options'];
+			if ( ! empty( $field[ 'options' ] ) ) {
+				$data[ 'options' ] = $field[ 'options' ];
 			}
 			$settings[ $id ] = $data;
 		}

unit-tests/Tests/Version2/shipping-methods.php

Spacing +1 added lines, -1 removed lines

@@ -133,7 +133,7 @@
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v2/shipping_methods' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version2/system-status.php

Spacing +35 added lines, -35 removed lines

@@ -76,15 +76,15 @@ 
 		wp_set_current_user( $this->user );
 		$response    = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/system_status' ) );
 		$data        = $response->get_data();
-		$environment = (array) $data['environment'];
+		$environment = (array) $data[ 'environment' ];
 
 		// Make sure all expected data is present.
 		$this->assertEquals( 32, count( $environment ) );
 
 		// Test some responses to make sure they match up.
-		$this->assertEquals( get_option( 'home' ), $environment['home_url'] );
-		$this->assertEquals( get_option( 'siteurl' ), $environment['site_url'] );
-		$this->assertEquals( WC()->version, $environment['version'] );
+		$this->assertEquals( get_option( 'home' ), $environment[ 'home_url' ] );
+		$this->assertEquals( get_option( 'siteurl' ), $environment[ 'site_url' ] );
+		$this->assertEquals( WC()->version, $environment[ 'version' ] );
 	}
 
 	/**
@@ -97,13 +97,13 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/system_status' ) );
 		$data     = $response->get_data();
-		$database = (array) $data['database'];
+		$database = (array) $data[ 'database' ];
 
-		$this->assertEquals( get_option( 'woocommerce_db_version' ), $database['wc_database_version'] );
-		$this->assertEquals( $wpdb->prefix, $database['database_prefix'] );
-		$this->assertEquals( WC_Geolocation::get_local_database_path(), $database['maxmind_geoip_database'] );
-		$this->assertArrayHasKey( 'woocommerce', $database['database_tables'], print_r( $database, true ) );
-		$this->assertArrayHasKey( $wpdb->prefix . 'woocommerce_payment_tokens', $database['database_tables']['woocommerce'], print_r( $database, true ) );
+		$this->assertEquals( get_option( 'woocommerce_db_version' ), $database[ 'wc_database_version' ] );
+		$this->assertEquals( $wpdb->prefix, $database[ 'database_prefix' ] );
+		$this->assertEquals( WC_Geolocation::get_local_database_path(), $database[ 'maxmind_geoip_database' ] );
+		$this->assertArrayHasKey( 'woocommerce', $database[ 'database_tables' ], print_r( $database, true ) );
+		$this->assertArrayHasKey( $wpdb->prefix . 'woocommerce_payment_tokens', $database[ 'database_tables' ][ 'woocommerce' ], print_r( $database, true ) );
 	}
 
 	/**
@@ -120,10 +120,10 @@ 
 		update_option( 'active_plugins', array() );
 
 		$data    = $response->get_data();
-		$plugins = (array) $data['active_plugins'];
+		$plugins = (array) $data[ 'active_plugins' ];
 
 		$this->assertEquals( 1, count( $plugins ) );
-		$this->assertEquals( 'Hello Dolly', $plugins[0]['name'] );
+		$this->assertEquals( 'Hello Dolly', $plugins[ 0 ][ 'name' ] );
 	}
 
 	/**
@@ -137,10 +137,10 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/system_status' ) );
 		$data     = $response->get_data();
-		$theme    = (array) $data['theme'];
+		$theme    = (array) $data[ 'theme' ];
 
 		$this->assertEquals( 13, count( $theme ) );
-		$this->assertEquals( $active_theme->Name, $theme['name'] ); // phpcs:ignore WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar
+		$this->assertEquals( $active_theme->Name, $theme[ 'name' ] ); // phpcs:ignore WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar
 	}
 
 	/**
@@ -159,12 +159,12 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/system_status' ) );
 		$data     = $response->get_data();
-		$settings = (array) $data['settings'];
+		$settings = (array) $data[ 'settings' ];
 
 		$this->assertEquals( 12, count( $settings ) );
-		$this->assertEquals( ( 'yes' === get_option( 'woocommerce_api_enabled' ) ), $settings['api_enabled'] );
-		$this->assertEquals( get_woocommerce_currency(), $settings['currency'] );
-		$this->assertEquals( $term_response, $settings['taxonomies'] );
+		$this->assertEquals( ( 'yes' === get_option( 'woocommerce_api_enabled' ) ), $settings[ 'api_enabled' ] );
+		$this->assertEquals( get_woocommerce_currency(), $settings[ 'currency' ] );
+		$this->assertEquals( $term_response, $settings[ 'taxonomies' ] );
 	}
 
 	/**
@@ -177,11 +177,11 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/system_status' ) );
 		$data     = $response->get_data();
-		$settings = (array) $data['security'];
+		$settings = (array) $data[ 'security' ];
 
 		$this->assertEquals( 2, count( $settings ) );
-		$this->assertEquals( 'https' === substr( wc_get_page_permalink( 'shop' ), 0, 5 ), $settings['secure_connection'] );
-		$this->assertEquals( ! ( defined( 'WP_DEBUG' ) && defined( 'WP_DEBUG_DISPLAY' ) && WP_DEBUG && WP_DEBUG_DISPLAY ) || 0 === intval( ini_get( 'display_errors' ) ), $settings['hide_errors'] );
+		$this->assertEquals( 'https' === substr( wc_get_page_permalink( 'shop' ), 0, 5 ), $settings[ 'secure_connection' ] );
+		$this->assertEquals( ! ( defined( 'WP_DEBUG' ) && defined( 'WP_DEBUG_DISPLAY' ) && WP_DEBUG && WP_DEBUG_DISPLAY ) || 0 === intval( ini_get( 'display_errors' ) ), $settings[ 'hide_errors' ] );
 	}
 
 	/**
@@ -193,7 +193,7 @@ 
 		wp_set_current_user( $this->user );
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/system_status' ) );
 		$data     = $response->get_data();
-		$pages    = $data['pages'];
+		$pages    = $data[ 'pages' ];
 		$this->assertEquals( 5, count( $pages ) );
 	}
 
@@ -206,7 +206,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v2/system_status' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 9, count( $properties ) );
 		$this->assertArrayHasKey( 'environment', $properties );
 		$this->assertArrayHasKey( 'database', $properties );
@@ -273,17 +273,17 @@ 
 
 		$tools_controller = new WC_REST_System_Status_Tools_Controller();
 		$raw_tools        = $tools_controller->get_tools();
-		$raw_tool         = $raw_tools['recount_terms'];
+		$raw_tool         = $raw_tools[ 'recount_terms' ];
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v2/system_status/tools/recount_terms' ) );
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
-		$this->assertEquals( 'Recount terms', $data['action'] );
-		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data['description'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
+		$this->assertEquals( 'Recount terms', $data[ 'action' ] );
+		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data[ 'description' ] );
 	}
 
 	/**
@@ -307,16 +307,16 @@ 
 
 		$tools_controller = new WC_REST_System_Status_Tools_Controller();
 		$raw_tools        = $tools_controller->get_tools();
-		$raw_tool         = $raw_tools['recount_terms'];
+		$raw_tool         = $raw_tools[ 'recount_terms' ];
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'POST', '/wc/v2/system_status/tools/recount_terms' ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
-		$this->assertEquals( 'Recount terms', $data['action'] );
-		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data['description'] );
-		$this->assertTrue( $data['success'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
+		$this->assertEquals( 'Recount terms', $data[ 'action' ] );
+		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data[ 'description' ] );
+		$this->assertTrue( $data[ 'success' ] );
 		$this->assertEquals( 1, did_action( 'woocommerce_rest_insert_system_status_tool' ) );
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'POST', '/wc/v2/system_status/tools/not_a_real_tool' ) );
@@ -343,7 +343,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v2/system_status/tools' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 6, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version4/SystemStatus.php

Spacing +37 added lines, -37 removed lines

@@ -99,15 +99,15 @@ 
 	public function test_get_system_status_info_environment() {
 		$response    = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/system_status' ) );
 		$data        = $response->get_data();
-		$environment = (array) $data['environment'];
+		$environment = (array) $data[ 'environment' ];
 
 		// Make sure all expected data is present.
 		$this->assertEquals( 32, count( $environment ) );
 
 		// Test some responses to make sure they match up.
-		$this->assertEquals( get_option( 'home' ), $environment['home_url'] );
-		$this->assertEquals( get_option( 'siteurl' ), $environment['site_url'] );
-		$this->assertEquals( WC()->version, $environment['version'] );
+		$this->assertEquals( get_option( 'home' ), $environment[ 'home_url' ] );
+		$this->assertEquals( get_option( 'siteurl' ), $environment[ 'site_url' ] );
+		$this->assertEquals( WC()->version, $environment[ 'version' ] );
 	}
 
 	/**
@@ -119,13 +119,13 @@ 
 		global $wpdb;
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/system_status' ) );
 		$data     = $response->get_data();
-		$database = (array) $data['database'];
+		$database = (array) $data[ 'database' ];
 
-		$this->assertEquals( get_option( 'woocommerce_db_version' ), $database['wc_database_version'] );
-		$this->assertEquals( $wpdb->prefix, $database['database_prefix'] );
-		$this->assertEquals( \WC_Geolocation::get_local_database_path(), $database['maxmind_geoip_database'] );
-		$this->assertArrayHasKey( 'woocommerce', $database['database_tables'], wc_print_r( $database, true ) );
-		$this->assertArrayHasKey( $wpdb->prefix . 'woocommerce_payment_tokens', $database['database_tables']['woocommerce'], wc_print_r( $database, true ) );
+		$this->assertEquals( get_option( 'woocommerce_db_version' ), $database[ 'wc_database_version' ] );
+		$this->assertEquals( $wpdb->prefix, $database[ 'database_prefix' ] );
+		$this->assertEquals( \WC_Geolocation::get_local_database_path(), $database[ 'maxmind_geoip_database' ] );
+		$this->assertArrayHasKey( 'woocommerce', $database[ 'database_tables' ], wc_print_r( $database, true ) );
+		$this->assertArrayHasKey( $wpdb->prefix . 'woocommerce_payment_tokens', $database[ 'database_tables' ][ 'woocommerce' ], wc_print_r( $database, true ) );
 	}
 
 	/**
@@ -140,10 +140,10 @@ 
 		update_option( 'active_plugins', array() );
 
 		$data    = $response->get_data();
-		$plugins = (array) $data['active_plugins'];
+		$plugins = (array) $data[ 'active_plugins' ];
 
 		$this->assertEquals( 1, count( $plugins ) );
-		$this->assertEquals( 'Hello Dolly', $plugins[0]['name'] );
+		$this->assertEquals( 'Hello Dolly', $plugins[ 0 ][ 'name' ] );
 	}
 
 	/**
@@ -156,10 +156,10 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/system_status' ) );
 		$data     = $response->get_data();
-		$theme    = (array) $data['theme'];
+		$theme    = (array) $data[ 'theme' ];
 
 		$this->assertEquals( 13, count( $theme ) );
-		$this->assertEquals( $active_theme->Name, $theme['name'] ); // phpcs:ignore WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar
+		$this->assertEquals( $active_theme->Name, $theme[ 'name' ] ); // phpcs:ignore WordPress.NamingConventions.ValidVariableName.NotSnakeCaseMemberVar
 	}
 
 	/**
@@ -176,12 +176,12 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/system_status' ) );
 		$data     = $response->get_data();
-		$settings = (array) $data['settings'];
+		$settings = (array) $data[ 'settings' ];
 
 		$this->assertEquals( 12, count( $settings ) );
-		$this->assertEquals( ( 'yes' === get_option( 'woocommerce_api_enabled' ) ), $settings['api_enabled'] );
-		$this->assertEquals( get_woocommerce_currency(), $settings['currency'] );
-		$this->assertEquals( $term_response, $settings['taxonomies'] );
+		$this->assertEquals( ( 'yes' === get_option( 'woocommerce_api_enabled' ) ), $settings[ 'api_enabled' ] );
+		$this->assertEquals( get_woocommerce_currency(), $settings[ 'currency' ] );
+		$this->assertEquals( $term_response, $settings[ 'taxonomies' ] );
 	}
 
 	/**
@@ -192,11 +192,11 @@ 
 	public function test_get_system_status_info_security() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/system_status' ) );
 		$data     = $response->get_data();
-		$settings = (array) $data['security'];
+		$settings = (array) $data[ 'security' ];
 
 		$this->assertEquals( 2, count( $settings ) );
-		$this->assertEquals( 'https' === substr( wc_get_page_permalink( 'shop' ), 0, 5 ), $settings['secure_connection'] );
-		$this->assertEquals( ! ( defined( 'WP_DEBUG' ) && defined( 'WP_DEBUG_DISPLAY' ) && WP_DEBUG && WP_DEBUG_DISPLAY ) || 0 === intval( ini_get( 'display_errors' ) ), $settings['hide_errors'] );
+		$this->assertEquals( 'https' === substr( wc_get_page_permalink( 'shop' ), 0, 5 ), $settings[ 'secure_connection' ] );
+		$this->assertEquals( ! ( defined( 'WP_DEBUG' ) && defined( 'WP_DEBUG_DISPLAY' ) && WP_DEBUG && WP_DEBUG_DISPLAY ) || 0 === intval( ini_get( 'display_errors' ) ), $settings[ 'hide_errors' ] );
 	}
 
 	/**
@@ -207,7 +207,7 @@ 
 	public function test_get_system_status_info_pages() {
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/system_status' ) );
 		$data     = $response->get_data();
-		$pages    = $data['pages'];
+		$pages    = $data[ 'pages' ];
 		$this->assertEquals( 5, count( $pages ) );
 	}
 
@@ -220,7 +220,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/system_status' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 10, count( $properties ) );
 		$this->assertArrayHasKey( 'environment', $properties );
 		$this->assertArrayHasKey( 'database', $properties );
@@ -312,10 +312,10 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
-		$this->assertEquals( 'Recount terms', $data['action'] );
-		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data['description'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
+		$this->assertEquals( 'Recount terms', $data[ 'action' ] );
+		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data[ 'description' ] );
 
 		// Test for _fields query parameter.
 		$query_params = array(
@@ -328,8 +328,8 @@ 
 
 		$this->assertEquals( 200, $response->get_status() );
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
 		$this->assertArrayNotHasKey( 'action', $data );
 		$this->assertArrayNotHasKey( 'description', $data );
 		// Links are part of links, not data in single items.
@@ -360,11 +360,11 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'POST', '/wc/v4/system_status/tools/recount_terms' ) );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertEquals( 'Term counts', $data['name'] );
-		$this->assertEquals( 'Recount terms', $data['action'] );
-		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data['description'] );
-		$this->assertTrue( $data['success'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertEquals( 'Term counts', $data[ 'name' ] );
+		$this->assertEquals( 'Recount terms', $data[ 'action' ] );
+		$this->assertEquals( 'This tool will recount product terms - useful when changing your settings in a way which hides products from the catalog.', $data[ 'description' ] );
+		$this->assertTrue( $data[ 'success' ] );
 		$this->assertEquals( 1, did_action( 'woocommerce_rest_insert_system_status_tool' ) );
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'POST', '/wc/v4/system_status/tools/not_a_real_tool' ) );
@@ -380,8 +380,8 @@ 
 		$data     = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'recount_terms', $data['id'] );
-		$this->assertTrue( $data['success'] );
+		$this->assertEquals( 'recount_terms', $data[ 'id' ] );
+		$this->assertTrue( $data[ 'success' ] );
 
 		// Fields that are not requested are not returned in response.
 		$this->assertArrayNotHasKey( 'action', $data );
@@ -417,7 +417,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/system_status/tools' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 6, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );

unit-tests/Tests/Version4/Coupons.php

Spacing +9 added lines, -9 removed lines

@@ -158,9 +158,9 @@ 
 			$this->assertArrayHasKey( $property, $response->data );
 		}
 
-		$this->assertEquals( $coupon->get_id(), $response->data['id'] );
-		$this->assertEquals( 'new-code', $response->data['code'] );
-		$this->assertEquals( 'new description', $response->data['description'] );
+		$this->assertEquals( $coupon->get_id(), $response->data[ 'id' ] );
+		$this->assertEquals( 'new-code', $response->data[ 'code' ] );
+		$this->assertEquals( 'new description', $response->data[ 'description' ] );
 	}
 
 	/**
@@ -272,7 +272,7 @@ 
 		);
 
 		$this->assertEquals( 400, $result->status );
-		$this->assertEquals( 'Invalid parameter(s): discount_type', $result->data['message'] );
+		$this->assertEquals( 'Invalid parameter(s): discount_type', $result->data[ 'message' ] );
 	}
 
 	/**
@@ -307,11 +307,11 @@ 
 			)
 		);
 
-		$this->assertEquals( '5.15', $result->data['update'][0]['amount'] );
-		$this->assertEquals( '11.00', $result->data['create'][0]['amount'] );
-		$this->assertEquals( 'new-coupon', $result->data['create'][0]['code'] );
-		$this->assertEquals( $coupon_2->get_id(), $result->data['delete'][0]['previous']['id'] );
-		$this->assertEquals( $coupon_3->get_id(), $result->data['delete'][1]['previous']['id'] );
+		$this->assertEquals( '5.15', $result->data[ 'update' ][ 0 ][ 'amount' ] );
+		$this->assertEquals( '11.00', $result->data[ 'create' ][ 0 ][ 'amount' ] );
+		$this->assertEquals( 'new-coupon', $result->data[ 'create' ][ 0 ][ 'code' ] );
+		$this->assertEquals( $coupon_2->get_id(), $result->data[ 'delete' ][ 0 ][ 'previous' ][ 'id' ] );
+		$this->assertEquals( $coupon_3->get_id(), $result->data[ 'delete' ][ 1 ][ 'previous' ][ 'id' ] );
 
 		$result = $this->do_request( '/wc/v4/coupons' );
 		$this->assertEquals( 3, count( $result->data ) );

unit-tests/Tests/Version4/Customers.php

Spacing +48 added lines, -48 removed lines

@@ -244,11 +244,11 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'create_customer_test@woo.local',
 				'first_name'         => '',
 				'last_name'          => '',
@@ -280,7 +280,7 @@ 
 				),
 				'is_paying_customer' => false,
 				'meta_data'          => array(),
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -310,11 +310,11 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'create_customer_test2@woo.local',
 				'first_name'         => 'Test',
 				'last_name'          => 'McTestFace',
@@ -346,7 +346,7 @@ 
 				),
 				'is_paying_customer' => false,
 				'meta_data'          => array(),
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -397,11 +397,11 @@ 
 
 		$this->assertEquals(
 			array(
-				'id'                 => $data['id'],
-				'date_created'       => $data['date_created'],
-				'date_created_gmt'   => $data['date_created_gmt'],
-				'date_modified'      => $data['date_modified'],
-				'date_modified_gmt'  => $data['date_modified_gmt'],
+				'id'                 => $data[ 'id' ],
+				'date_created'       => $data[ 'date_created' ],
+				'date_created_gmt'   => $data[ 'date_created_gmt' ],
+				'date_modified'      => $data[ 'date_modified' ],
+				'date_modified_gmt'  => $data[ 'date_modified_gmt' ],
 				'email'              => 'get_customer_test@woo.local',
 				'first_name'         => 'Justin',
 				'billing'            => array(
@@ -433,7 +433,7 @@ 
 				'last_name'          => '',
 				'role'               => 'customer',
 				'username'           => 'get_customer_test',
-				'avatar_url'         => $data['avatar_url'],
+				'avatar_url'         => $data[ 'avatar_url' ],
 			),
 			$data
 		);
@@ -471,8 +471,8 @@ 
 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/customers/' . $customer->get_id() ) );
 		$data     = $response->get_data();
-		$this->assertEquals( 'update_customer_test', $data['username'] );
-		$this->assertEquals( 'update_customer_test@woo.local', $data['email'] );
+		$this->assertEquals( 'update_customer_test', $data[ 'username' ] );
+		$this->assertEquals( 'update_customer_test@woo.local', $data[ 'email' ] );
 
 		$request = new WP_REST_Request( 'PUT', '/wc/v4/customers/' . $customer->get_id() );
 		$request->set_body_params(
@@ -484,8 +484,8 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'updated_email@woo.local', $data['email'] );
-		$this->assertEquals( 'UpdatedTest', $data['first_name'] );
+		$this->assertEquals( 'updated_email@woo.local', $data[ 'email' ] );
+		$this->assertEquals( 'UpdatedTest', $data[ 'first_name' ] );
 	}
 
 	/**
@@ -586,11 +586,11 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertEquals( 'McTest', $data['update'][0]['last_name'] );
-		$this->assertEquals( 'newuser', $data['create'][0]['username'] );
-		$this->assertEmpty( $data['create'][0]['last_name'] );
-		$this->assertEquals( $customer_2->get_id(), $data['delete'][0]['id'] );
-		$this->assertEquals( $customer_3->get_id(), $data['delete'][1]['id'] );
+		$this->assertEquals( 'McTest', $data[ 'update' ][ 0 ][ 'last_name' ] );
+		$this->assertEquals( 'newuser', $data[ 'create' ][ 0 ][ 'username' ] );
+		$this->assertEmpty( $data[ 'create' ][ 0 ][ 'last_name' ] );
+		$this->assertEquals( $customer_2->get_id(), $data[ 'delete' ][ 0 ][ 'id' ] );
+		$this->assertEquals( $customer_3->get_id(), $data[ 'delete' ][ 1 ][ 'id' ] );
 
 		$request  = new WP_REST_Request( 'GET', '/wc/v4/customers' );
 		$response = $this->server->dispatch( $request );
@@ -608,7 +608,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/customers' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 16, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -624,26 +624,26 @@ 
 		$this->assertArrayHasKey( 'password', $properties );
 		$this->assertArrayHasKey( 'avatar_url', $properties );
 		$this->assertArrayHasKey( 'billing', $properties );
-		$this->assertArrayHasKey( 'first_name', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'last_name', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'company', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'address_1', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'address_2', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'city', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'state', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'postcode', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'country', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'email', $properties['billing']['properties'] );
-		$this->assertArrayHasKey( 'phone', $properties['billing']['properties'] );
+		$this->assertArrayHasKey( 'first_name', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'last_name', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'company', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_1', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_2', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'city', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'state', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'postcode', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'country', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'email', $properties[ 'billing' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'phone', $properties[ 'billing' ][ 'properties' ] );
 		$this->assertArrayHasKey( 'shipping', $properties );
-		$this->assertArrayHasKey( 'first_name', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'last_name', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'company', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'address_1', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'address_2', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'city', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'state', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'postcode', $properties['shipping']['properties'] );
-		$this->assertArrayHasKey( 'country', $properties['shipping']['properties'] );
+		$this->assertArrayHasKey( 'first_name', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'last_name', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'company', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_1', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'address_2', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'city', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'state', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'postcode', $properties[ 'shipping' ][ 'properties' ] );
+		$this->assertArrayHasKey( 'country', $properties[ 'shipping' ][ 'properties' ] );
 	}
 }

unit-tests/Tests/Version4/ShippingZones.php

Spacing +49 added lines, -49 removed lines

@@ -64,7 +64,7 @@ 
 		$zone->set_locations( $locations );
 		$zone->save();
 
-		$this->zones[] = $zone;
+		$this->zones[ ] = $zone;
 
 		return $zone;
 	}
@@ -97,13 +97,13 @@ 
 		$this->assertEquals( count( $data ), 1 );
 		$this->assertContains(
 			array(
-				'id'     => $data[0]['id'],
+				'id'     => $data[ 0 ][ 'id' ],
 				'name'   => 'Locations not covered by your other zones',
 				'order'  => 0,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[0]['id'] ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 0 ][ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -113,7 +113,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[0]['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 0 ][ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -131,13 +131,13 @@ 
 		$this->assertEquals( count( $data ), 2 );
 		$this->assertContains(
 			array(
-				'id'     => $data[1]['id'],
+				'id'     => $data[ 1 ][ 'id' ],
 				'name'   => 'Zone 1',
 				'order'  => 0,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[1]['id'] ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 1 ][ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -147,7 +147,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[1]['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 1 ][ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -191,10 +191,10 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/shipping/zones' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 		$this->assertEquals( 3, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
-		$this->assertTrue( $properties['id']['readonly'] );
+		$this->assertTrue( $properties[ 'id' ][ 'readonly' ] );
 		$this->assertArrayHasKey( 'name', $properties );
 		$this->assertArrayHasKey( 'order', $properties );
 	}
@@ -218,13 +218,13 @@ 
 		$this->assertEquals( 201, $response->get_status() );
 		$this->assertEquals(
 			array(
-				'id'     => $data['id'],
+				'id'     => $data[ 'id' ],
 				'name'   => 'Test Zone',
 				'order'  => 1,
 				'_links' => array(
 					'self'        => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data['id'] ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 'id' ] ),
 						),
 					),
 					'collection'  => array(
@@ -234,7 +234,7 @@ 
 					),
 					'describedby' => array(
 						array(
-							'href' => rest_url( '/wc/v4/shipping/zones/' . $data['id'] . '/locations' ),
+							'href' => rest_url( '/wc/v4/shipping/zones/' . $data[ 'id' ] . '/locations' ),
 						),
 					),
 				),
@@ -591,16 +591,16 @@ 
 		foreach ( $method->get_instance_form_fields() as $id => $field ) {
 			$data = array(
 				'id'          => $id,
-				'label'       => $field['title'],
-				'description' => ( empty( $field['description'] ) ? '' : $field['description'] ),
-				'type'        => $field['type'],
+				'label'       => $field[ 'title' ],
+				'description' => ( empty( $field[ 'description' ] ) ? '' : $field[ 'description' ] ),
+				'type'        => $field[ 'type' ],
 				'value'       => $method->instance_settings[ $id ],
-				'default'     => ( empty( $field['default'] ) ? '' : $field['default'] ),
-				'tip'         => ( empty( $field['description'] ) ? '' : $field['description'] ),
-				'placeholder' => ( empty( $field['placeholder'] ) ? '' : $field['placeholder'] ),
+				'default'     => ( empty( $field[ 'default' ] ) ? '' : $field[ 'default' ] ),
+				'tip'         => ( empty( $field[ 'description' ] ) ? '' : $field[ 'description' ] ),
+				'placeholder' => ( empty( $field[ 'placeholder' ] ) ? '' : $field[ 'placeholder' ] ),
 			);
-			if ( ! empty( $field['options'] ) ) {
-				$data['options'] = $field['options'];
+			if ( ! empty( $field[ 'options' ] ) ) {
+				$data[ 'options' ] = $field[ 'options' ];
 			}
 			$settings[ $id ] = $data;
 		}
@@ -610,7 +610,7 @@ 
 		$expected = array(
 			'id'                 => $instance_id,
 			'instance_id'        => $instance_id,
-			'title'              => $method->instance_settings['title'],
+			'title'              => $method->instance_settings[ 'title' ],
 			'order'              => $method->method_order,
 			'enabled'            => ( 'yes' === $method->enabled ),
 			'method_id'          => $method->id,
@@ -690,12 +690,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'taxable', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '0', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'taxable', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '0', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Update a single value
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -709,12 +709,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'taxable', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '5', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'taxable', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '5', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Test multiple settings
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -729,12 +729,12 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertArrayHasKey( 'title', $data['settings'] );
-		$this->assertEquals( 'Flat rate', $data['settings']['title']['value'] );
-		$this->assertArrayHasKey( 'tax_status', $data['settings'] );
-		$this->assertEquals( 'none', $data['settings']['tax_status']['value'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '10', $data['settings']['cost']['value'] );
+		$this->assertArrayHasKey( 'title', $data[ 'settings' ] );
+		$this->assertEquals( 'Flat rate', $data[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertArrayHasKey( 'tax_status', $data[ 'settings' ] );
+		$this->assertEquals( 'none', $data[ 'settings' ][ 'tax_status' ][ 'value' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '10', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 
 		// Test bogus
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
@@ -750,8 +750,8 @@ 
 		$this->assertEquals( 400, $response->get_status() );
 
 		// Test other parameters
-		$this->assertTrue( $data['enabled'] );
-		$this->assertEquals( 1, $data['order'] );
+		$this->assertTrue( $data[ 'enabled' ] );
+		$this->assertEquals( 1, $data[ 'order' ] );
 
 		$request = new WP_REST_Request( 'POST', '/wc/v4/shipping/zones/' . $zone->get_id() . '/methods/' . $instance_id );
 		$request->set_body_params(
@@ -763,10 +763,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertFalse( $data['enabled'] );
-		$this->assertEquals( 2, $data['order'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '10', $data['settings']['cost']['value'] );
+		$this->assertFalse( $data[ 'enabled' ] );
+		$this->assertEquals( 2, $data[ 'order' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '10', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 	}
 
 	/**
@@ -787,10 +787,10 @@ 
 		$response = $this->server->dispatch( $request );
 		$data     = $response->get_data();
 
-		$this->assertFalse( $data['enabled'] );
-		$this->assertEquals( 2, $data['order'] );
-		$this->assertArrayHasKey( 'cost', $data['settings'] );
-		$this->assertEquals( '0', $data['settings']['cost']['value'] );
+		$this->assertFalse( $data[ 'enabled' ] );
+		$this->assertEquals( 2, $data[ 'order' ] );
+		$this->assertArrayHasKey( 'cost', $data[ 'settings' ] );
+		$this->assertEquals( '0', $data[ 'settings' ][ 'cost' ][ 'value' ] );
 	}
 
 	/**

unit-tests/Tests/Version4/PaymentGateways.php

Spacing +25 added lines, -25 removed lines

@@ -178,9 +178,9 @@ 
 		$response = $this->server->dispatch( new WP_REST_Request( 'GET', '/wc/v4/payment_gateways/paypal' ) );
 		$paypal   = $response->get_data();
 
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'admin@example.org', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'admin@example.org', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating single setting
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -195,9 +195,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'no', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'no', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test updating multiple settings
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -213,9 +213,9 @@ 
 		$paypal   = $response->get_data();
 
 		$this->assertEquals( 200, $response->get_status() );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// Test other parameters, and recheck settings
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -228,11 +228,11 @@ 
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
 
-		$this->assertFalse( $paypal['enabled'] );
-		$this->assertEquals( 2, $paypal['order'] );
-		$this->assertEquals( 'PayPal - New Title', $paypal['settings']['title']['value'] );
-		$this->assertEquals( 'woo@woo.local', $paypal['settings']['email']['value'] );
-		$this->assertEquals( 'yes', $paypal['settings']['testmode']['value'] );
+		$this->assertFalse( $paypal[ 'enabled' ] );
+		$this->assertEquals( 2, $paypal[ 'order' ] );
+		$this->assertEquals( 'PayPal - New Title', $paypal[ 'settings' ][ 'title' ][ 'value' ] );
+		$this->assertEquals( 'woo@woo.local', $paypal[ 'settings' ][ 'email' ][ 'value' ] );
+		$this->assertEquals( 'yes', $paypal[ 'settings' ][ 'testmode' ][ 'value' ] );
 
 		// test bogus
 		$request = new WP_REST_Request( 'POST', '/wc/v4/payment_gateways/paypal' );
@@ -256,7 +256,7 @@ 
 		);
 		$response = $this->server->dispatch( $request );
 		$paypal   = $response->get_data();
-		$this->assertEquals( 'authorization', $paypal['settings']['paymentaction']['value'] );
+		$this->assertEquals( 'authorization', $paypal[ 'settings' ][ 'paymentaction' ][ 'value' ] );
 	}
 
 	/**
@@ -304,7 +304,7 @@ 
 		$request    = new WP_REST_Request( 'OPTIONS', '/wc/v4/payment_gateways' );
 		$response   = $this->server->dispatch( $request );
 		$data       = $response->get_data();
-		$properties = $data['schema']['properties'];
+		$properties = $data[ 'schema' ][ 'properties' ];
 
 		$this->assertEquals( 9, count( $properties ) );
 		$this->assertArrayHasKey( 'id', $properties );
@@ -330,7 +330,7 @@ 
 		$gateway->init_form_fields();
 		foreach ( $gateway->form_fields as $id => $field ) {
 			// Make sure we at least have a title and type
-			if ( empty( $field['title'] ) || empty( $field['type'] ) ) {
+			if ( empty( $field[ 'title' ] ) || empty( $field[ 'type' ] ) ) {
 				continue;
 			}
 			// Ignore 'enabled' and 'description', to be in line with \WC_REST_Payment_Gateways_Controller::get_settings.
@@ -339,16 +339,16 @@ 
 			}
 			$data = array(
 				'id'          => $id,
-				'label'       => empty( $field['label'] ) ? $field['title'] : $field['label'],
-				'description' => empty( $field['description'] ) ? '' : $field['description'],
-				'type'        => $field['type'],
+				'label'       => empty( $field[ 'label' ] ) ? $field[ 'title' ] : $field[ 'label' ],
+				'description' => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'type'        => $field[ 'type' ],
 				'value'       => $gateway->settings[ $id ],
-				'default'     => empty( $field['default'] ) ? '' : $field['default'],
-				'tip'         => empty( $field['description'] ) ? '' : $field['description'],
-				'placeholder' => empty( $field['placeholder'] ) ? '' : $field['placeholder'],
+				'default'     => empty( $field[ 'default' ] ) ? '' : $field[ 'default' ],
+				'tip'         => empty( $field[ 'description' ] ) ? '' : $field[ 'description' ],
+				'placeholder' => empty( $field[ 'placeholder' ] ) ? '' : $field[ 'placeholder' ],
 			);
-			if ( ! empty( $field['options'] ) ) {
-				$data['options'] = $field['options'];
+			if ( ! empty( $field[ 'options' ] ) ) {
+				$data[ 'options' ] = $field[ 'options' ];
 			}
 			$settings[ $id ] = $data;
 		}