Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like WC_Gateway_Stripe_Sofort often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use WC_Gateway_Stripe_Sofort, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class WC_Gateway_Stripe_Sofort extends WC_Stripe_Payment_Gateway { |
||
| 14 | /** |
||
| 15 | * Notices (array) |
||
| 16 | * @var array |
||
| 17 | */ |
||
| 18 | public $notices = array(); |
||
| 19 | |||
| 20 | /** |
||
| 21 | * Is test mode active? |
||
| 22 | * |
||
| 23 | * @var bool |
||
| 24 | */ |
||
| 25 | public $testmode; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Alternate credit card statement name |
||
| 29 | * |
||
| 30 | * @var bool |
||
| 31 | */ |
||
| 32 | public $statement_descriptor; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * API access secret key |
||
| 36 | * |
||
| 37 | * @var string |
||
| 38 | */ |
||
| 39 | public $secret_key; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Api access publishable key |
||
| 43 | * |
||
| 44 | * @var string |
||
| 45 | */ |
||
| 46 | public $publishable_key; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Should we store the users credit cards? |
||
| 50 | * |
||
| 51 | * @var bool |
||
| 52 | */ |
||
| 53 | public $saved_cards; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * Constructor |
||
| 57 | */ |
||
| 58 | public function __construct() { |
||
| 94 | |||
| 95 | /** |
||
| 96 | * Checks to make sure environment is setup correctly to use this payment method. |
||
| 97 | * |
||
| 98 | * @since 4.0.0 |
||
| 99 | * @version 4.0.0 |
||
| 100 | */ |
||
| 101 | public function check_environment() { |
||
| 118 | |||
| 119 | /** |
||
| 120 | * Checks the environment for compatibility problems. Returns a string with the first incompatibility |
||
| 121 | * found or false if the environment has no problems. |
||
| 122 | * |
||
| 123 | * @since 4.0.0 |
||
| 124 | * @version 4.0.0 |
||
| 125 | */ |
||
| 126 | public function get_environment_warning() { |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Returns all supported currencies for this payment method. |
||
| 138 | * |
||
| 139 | * @since 4.0.0 |
||
| 140 | * @version 4.0.0 |
||
| 141 | * @return array |
||
| 142 | */ |
||
| 143 | public function get_supported_currency() { |
||
| 148 | |||
| 149 | /** |
||
| 150 | * Checks to see if all criteria is met before showing payment method. |
||
| 151 | * |
||
| 152 | * @since 4.0.0 |
||
| 153 | * @version 4.0.0 |
||
| 154 | * @return bool |
||
| 155 | */ |
||
| 156 | public function is_available() { |
||
| 163 | |||
| 164 | /** |
||
| 165 | * Get_icon function. |
||
| 166 | * |
||
| 167 | * @since 1.0.0 |
||
| 168 | * @version 4.0.0 |
||
| 169 | * @return string |
||
| 170 | */ |
||
| 171 | public function get_icon() { |
||
| 180 | |||
| 181 | /** |
||
| 182 | * payment_scripts function. |
||
| 183 | * |
||
| 184 | * Outputs scripts used for stripe payment |
||
| 185 | * |
||
| 186 | * @access public |
||
| 187 | */ |
||
| 188 | public function payment_scripts() { |
||
| 196 | |||
| 197 | /** |
||
| 198 | * Initialize Gateway Settings Form Fields. |
||
| 199 | */ |
||
| 200 | public function init_form_fields() { |
||
| 203 | |||
| 204 | /** |
||
| 205 | * Payment form on checkout page |
||
| 206 | */ |
||
| 207 | View Code Duplication | public function payment_fields() { |
|
| 235 | |||
| 236 | /** |
||
| 237 | * Creates the source for charge. |
||
| 238 | * |
||
| 239 | * @since 4.0.0 |
||
| 240 | * @version 4.0.0 |
||
| 241 | * @param object $order |
||
| 242 | * @return mixed |
||
| 243 | */ |
||
| 244 | public function create_source( $order ) { |
||
| 265 | |||
| 266 | /** |
||
| 267 | * Process the payment |
||
| 268 | * |
||
| 269 | * @param int $order_id Reference. |
||
| 270 | * @param bool $retry Should we retry on fail. |
||
| 271 | * @param bool $force_save_source Force payment source to be saved. |
||
| 272 | * |
||
| 273 | * @throws Exception If payment will not be accepted. |
||
| 274 | * |
||
| 275 | * @return array|void |
||
| 276 | */ |
||
| 277 | public function process_payment( $order_id, $retry = true, $force_save_source = false ) { |
||
| 330 | } |
||
| 331 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.