Complex classes like WC_Gateway_Stripe_P24 often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use WC_Gateway_Stripe_P24, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 13 | class WC_Gateway_Stripe_P24 extends WC_Stripe_Payment_Gateway { |
||
| 14 | /** |
||
| 15 | * Notices (array) |
||
| 16 | * @var array |
||
| 17 | */ |
||
| 18 | public $notices = array(); |
||
| 19 | |||
| 20 | /** |
||
| 21 | * Is test mode active? |
||
| 22 | * |
||
| 23 | * @var bool |
||
| 24 | */ |
||
| 25 | public $testmode; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Alternate credit card statement name |
||
| 29 | * |
||
| 30 | * @var bool |
||
| 31 | */ |
||
| 32 | public $statement_descriptor; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * API access secret key |
||
| 36 | * |
||
| 37 | * @var string |
||
| 38 | */ |
||
| 39 | public $secret_key; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Api access publishable key |
||
| 43 | * |
||
| 44 | * @var string |
||
| 45 | */ |
||
| 46 | public $publishable_key; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Should we store the users credit cards? |
||
| 50 | * |
||
| 51 | * @var bool |
||
| 52 | */ |
||
| 53 | public $saved_cards; |
||
| 54 | |||
| 55 | /** |
||
| 56 | * Constructor |
||
| 57 | */ |
||
| 58 | public function __construct() { |
||
| 94 | |||
| 95 | /** |
||
| 96 | * Checks to make sure environment is setup correctly to use this payment method. |
||
| 97 | * |
||
| 98 | * @since 4.0.0 |
||
| 99 | * @version 4.0.0 |
||
| 100 | */ |
||
| 101 | public function check_environment() { |
||
| 118 | |||
| 119 | /** |
||
| 120 | * Checks the environment for compatibility problems. Returns a string with the first incompatibility |
||
| 121 | * found or false if the environment has no problems. |
||
| 122 | * |
||
| 123 | * @since 4.0.0 |
||
| 124 | * @version 4.0.0 |
||
| 125 | */ |
||
| 126 | public function get_environment_warning() { |
||
| 135 | |||
| 136 | /** |
||
| 137 | * Returns all supported currencies for this payment method. |
||
| 138 | * |
||
| 139 | * @since 4.0.0 |
||
| 140 | * @version 4.0.0 |
||
| 141 | * @return array |
||
| 142 | */ |
||
| 143 | public function get_supported_currency() { |
||
| 149 | |||
| 150 | /** |
||
| 151 | * Checks to see if all criteria is met before showing payment method. |
||
| 152 | * |
||
| 153 | * @since 4.0.0 |
||
| 154 | * @version 4.0.0 |
||
| 155 | * @return bool |
||
| 156 | */ |
||
| 157 | public function is_available() { |
||
| 164 | |||
| 165 | /** |
||
| 166 | * All payment icons that work with Stripe. |
||
| 167 | * |
||
| 168 | * @since 4.0.0 |
||
| 169 | * @version 4.0.0 |
||
| 170 | * @return array |
||
| 171 | */ |
||
| 172 | public function payment_icons() { |
||
| 177 | |||
| 178 | /** |
||
| 179 | * Get_icon function. |
||
| 180 | * |
||
| 181 | * @since 1.0.0 |
||
| 182 | * @version 4.0.0 |
||
| 183 | * @return string |
||
| 184 | */ |
||
| 185 | public function get_icon() { |
||
| 194 | |||
| 195 | /** |
||
| 196 | * payment_scripts function. |
||
| 197 | * |
||
| 198 | * Outputs scripts used for stripe payment |
||
| 199 | * |
||
| 200 | * @access public |
||
| 201 | */ |
||
| 202 | public function payment_scripts() { |
||
| 210 | |||
| 211 | /** |
||
| 212 | * Initialize Gateway Settings Form Fields. |
||
| 213 | */ |
||
| 214 | public function init_form_fields() { |
||
| 217 | |||
| 218 | /** |
||
| 219 | * Payment form on checkout page |
||
| 220 | */ |
||
| 221 | public function payment_fields() { |
||
| 249 | |||
| 250 | /** |
||
| 251 | * Creates the source for charge. |
||
| 252 | * |
||
| 253 | * @since 4.0.0 |
||
| 254 | * @version 4.0.0 |
||
| 255 | * @param object $order |
||
| 256 | * @return mixed |
||
| 257 | */ |
||
| 258 | public function create_source( $order ) { |
||
| 273 | |||
| 274 | /** |
||
| 275 | * Process the payment |
||
| 276 | * |
||
| 277 | * @param int $order_id Reference. |
||
| 278 | * @param bool $retry Should we retry on fail. |
||
| 279 | * @param bool $force_save_source Force payment source to be saved. |
||
| 280 | * |
||
| 281 | * @throws Exception If payment will not be accepted. |
||
| 282 | * |
||
| 283 | * @return array|void |
||
| 284 | */ |
||
| 285 | public function process_payment( $order_id, $retry = true, $force_save_source = false ) { |
||
| 338 | } |
||
| 339 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.