WC_Gateway_Stripe_Eps::get_icon() - Code Metrics - Inspection of "Update save to account checkbox text and allow fil..." - woocommerce/woocommerce-gateway-stripe - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3a5fe...3adadd )

by Roy

created 2018-04-09 14:17 UTC

WC_Gateway_Stripe_Eps::get_icon() A

↳ Parent: WC_Gateway_Stripe_Eps

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	0
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php
if ( ! defined( 'ABSPATH' ) ) {
	exit;
}

/**
 * Class that handles EPS payment method.
 *
 * @extends WC_Gateway_Stripe
 *
 * @since 4.1.0
 */
class WC_Gateway_Stripe_Eps extends WC_Stripe_Payment_Gateway {
	/**
	 * Notices (array)
	 * @var array
	 */
	public $notices = array();

	/**
	 * Is test mode active?
	 *
	 * @var bool
	 */
	public $testmode;

	/**
	 * Alternate credit card statement name
	 *
	 * @var bool
	 */
	public $statement_descriptor;

	/**
	 * API access secret key
	 *
	 * @var string
	 */
	public $secret_key;

	/**
	 * Api access publishable key
	 *
	 * @var string
	 */
	public $publishable_key;

	/**
	 * Should we store the users credit cards?
	 *
	 * @var bool
	 */
	public $saved_cards;

	/**
	 * Constructor
	 */
	public function __construct() {
		$this->id                   = 'stripe_eps';
		$this->method_title         = __( 'Stripe EPS', 'woocommerce-gateway-stripe' );
		/* translators: link */
		$this->method_description   = sprintf( __( 'All other general Stripe settings can be adjusted <a href="%s">here</a>.', 'woocommerce-gateway-stripe' ), admin_url( 'admin.php?page=wc-settings&tab=checkout&section=stripe' ) );
		$this->supports             = array(
			'products',
			'refunds',
		);

		// Load the form fields.
		$this->init_form_fields();

		// Load the settings.
		$this->init_settings();

		$main_settings              = get_option( 'woocommerce_stripe_settings' );
		$this->title                = $this->get_option( 'title' );
		$this->description          = $this->get_option( 'description' );
		$this->enabled              = $this->get_option( 'enabled' );
		$this->testmode             = ( ! empty( $main_settings['testmode'] ) && 'yes' === $main_settings['testmode'] ) ? true : false;
		$this->saved_cards          = ( ! empty( $main_settings['saved_cards'] ) && 'yes' === $main_settings['saved_cards'] ) ? true : false;
		$this->publishable_key      = ! empty( $main_settings['publishable_key'] ) ? $main_settings['publishable_key'] : '';
		$this->secret_key           = ! empty( $main_settings['secret_key'] ) ? $main_settings['secret_key'] : '';
		$this->statement_descriptor = ! empty( $main_settings['statement_descriptor'] ) ? $main_settings['statement_descriptor'] : '';

		if ( $this->testmode ) {
			$this->publishable_key = ! empty( $main_settings['test_publishable_key'] ) ? $main_settings['test_publishable_key'] : '';
			$this->secret_key      = ! empty( $main_settings['test_secret_key'] ) ? $main_settings['test_secret_key'] : '';
		}

		add_action( 'woocommerce_update_options_payment_gateways_' . $this->id, array( $this, 'process_admin_options' ) );
		add_action( 'wp_enqueue_scripts', array( $this, 'payment_scripts' ) );
	}

	/**
	 * Returns all supported currencies for this payment method.
	 *
	 * @since 4.1.0
	 * @version 4.1.0
	 * @return array
	 */
	public function get_supported_currency() {
		return apply_filters( 'wc_stripe_eps_supported_currencies', array(
			'EUR',
		) );
	}

	/**
	 * Checks to see if all criteria is met before showing payment method.
	 *
	 * @since 4.1.0
	 * @version 4.1.0
	 * @return bool
	 */
	public function is_available() {
		if ( ! in_array( get_woocommerce_currency(), $this->get_supported_currency() ) ) {
			return false;
		}

		return parent::is_available();
	}

	/**
	 * Get_icon function.
	 *
	 * @since 1.0.0
	 * @version 4.1.0
	 * @return string
	 */
	public function get_icon() {
		$icons = $this->payment_icons();

		$icons_str = '';

		$icons_str .= $icons['eps'];

		return apply_filters( 'woocommerce_gateway_icon', $icons_str, $this->id );
	}

	/**
	 * payment_scripts function.
	 *
	 * Outputs scripts used for stripe payment
	 *
	 * @access public
	 */
	public function payment_scripts() {
		if ( ! is_cart() && ! is_checkout() && ! isset( $_GET['pay_for_order'] ) && ! is_add_payment_method_page() ) {
			return;
		}

		wp_enqueue_style( 'stripe_styles' );
		wp_enqueue_script( 'woocommerce_stripe' );
	}

	/**
	 * Initialize Gateway Settings Form Fields.
	 */
	public function init_form_fields() {
		$this->form_fields = require( WC_STRIPE_PLUGIN_PATH . '/includes/admin/stripe-eps-settings.php' );
	}

	/**
	 * Payment form on checkout page
	 */
	public function payment_fields() {
		$user  = wp_get_current_user();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$total = WC()->cart->total;

		// If paying from order, we need to get total from order not cart.
		if ( isset( $_GET['pay_for_order'] ) && ! empty( $_GET['key'] ) ) {
			$order = wc_get_order( wc_get_order_id_by_order_key( wc_clean( $_GET['key'] ) ) );
			$total = $order->get_total();
		}

		if ( is_add_payment_method_page() ) {
			$pay_button_text = __( 'Add Payment', 'woocommerce-gateway-stripe' );
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
			$total        = '';
		} else {
			$pay_button_text = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		}

		echo '<div
			id="stripe-eps-payment-data"
			data-amount="' . esc_attr( WC_Stripe_Helper::get_stripe_amount( $total ) ) . '"
			data-currency="' . esc_attr( strtolower( get_woocommerce_currency() ) ) . '">';

		if ( $this->description ) {
			echo apply_filters( 'wc_stripe_description', wpautop( wp_kses_post( $this->description ) ) );
		}

		echo '</div>';
	}

	/**
	 * Creates the source for charge.
	 *
	 * @since 4.1.0
	 * @version 4.1.0
	 * @param object $order
	 * @return mixed
	 */
	public function create_source( $order ) {
		$currency              = WC_Stripe_Helper::is_pre_30() ? $order->get_order_currency() : $order->get_currency();
		$order_id              = WC_Stripe_Helper::is_pre_30() ? $order->id : $order->get_id();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$return_url            = $this->get_stripe_return_url( $order );
		$post_data             = array();
		$post_data['amount']   = WC_Stripe_Helper::get_stripe_amount( $order->get_total(), $currency );
		$post_data['currency'] = strtolower( $currency );
		$post_data['type']     = 'eps';
		$post_data['owner']    = $this->get_owner_details( $order );
		$post_data['redirect'] = array( 'return_url' => $return_url );

		if ( ! empty( $this->statement_descriptor ) ) {
			$post_data['statement_descriptor'] = WC_Stripe_Helper::clean_statement_descriptor( $this->statement_descriptor );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}

		WC_Stripe_Logger::log( 'Info: Begin creating EPS source' );

		return WC_Stripe_API::request( $post_data, 'sources' );
	}

	/**
	 * Process the payment
	 *
	 * @param int  $order_id Reference.
	 * @param bool $retry Should we retry on fail.
	 * @param bool $force_save_source Force payment source to be saved.
	 *
	 * @throws Exception If payment will not be accepted.
	 *
	 * @return array|void
	 */
	public function process_payment( $order_id, $retry = true, $force_save_source = false ) {
		try {
			$order = wc_get_order( $order_id );

			// This will throw exception if not valid.
			$this->validate_minimum_order_amount( $order );

			// This comes from the create account checkbox in the checkout page.
			$create_account = ! empty( $_POST['createaccount'] ) ? true : false;

			if ( $create_account ) {
				$new_customer_id     = WC_Stripe_Helper::is_pre_30() ? $order->customer_user : $order->get_customer_id();
				$new_stripe_customer = new WC_Stripe_Customer( $new_customer_id );
				$new_stripe_customer->create_customer();
			}

			$response = $this->create_source( $order );

			if ( ! empty( $response->error ) ) {
				$order->add_order_note( $response->error->message );

				throw new Exception( $response->error->message );
			}

			if ( WC_Stripe_Helper::is_pre_30() ) {
				update_post_meta( $order_id, '_stripe_source_id', $response->id );
			} else {
				$order->update_meta_data( '_stripe_source_id', $response->id );
				$order->save();
			}

			WC_Stripe_Logger::log( 'Info: Redirecting to EPS...' );

			return array(
				'result'   => 'success',
				'redirect' => esc_url_raw( $response->redirect->url ),
			);
		} catch ( Exception $e ) {
			wc_add_notice( $e->getMessage(), 'error' );
			WC_Stripe_Logger::log( 'Error: ' . $e->getMessage() );

			do_action( 'wc_gateway_stripe_process_payment_error', $e, $order );

			if ( $order->has_status( array( 'pending', 'failed' ) ) ) {
				$this->send_failed_order_email( $order_id );
			}

			return array(
				'result'   => 'fail',
				'redirect' => '',
			);
		}
	}
}


1			<?php
2			if ( ! defined( 'ABSPATH' ) ) {
3			exit;
4			}
5
6			/**
7			* Class that handles EPS payment method.
8			*
9			* @extends WC_Gateway_Stripe
10			*
11			* @since 4.1.0
12			*/
13			class WC_Gateway_Stripe_Eps extends WC_Stripe_Payment_Gateway {
14			/**
15			* Notices (array)
16			* @var array
17			*/
18			public $notices = array();
19
20			/**
21			* Is test mode active?
22			*
23			* @var bool
24			*/
25			public $testmode;
26
27			/**
28			* Alternate credit card statement name
29			*
30			* @var bool
31			*/
32			public $statement_descriptor;
33
34			/**
35			* API access secret key
36			*
37			* @var string
38			*/
39			public $secret_key;
40
41			/**
42			* Api access publishable key
43			*
44			* @var string
45			*/
46			public $publishable_key;
47
48			/**
49			* Should we store the users credit cards?
50			*
51			* @var bool
52			*/
53			public $saved_cards;
54
55			/**
56			* Constructor
57			*/
58			public function __construct() {
59			$this->id = 'stripe_eps';
60			$this->method_title = __( 'Stripe EPS', 'woocommerce-gateway-stripe' );
61			/* translators: link */
62			$this->method_description = sprintf( __( 'All other general Stripe settings can be adjusted <a href="%s">here</a>.', 'woocommerce-gateway-stripe' ), admin_url( 'admin.php?page=wc-settings&tab=checkout&section=stripe' ) );
63			$this->supports = array(
64			'products',
65			'refunds',
66			);
67
68			// Load the form fields.
69			$this->init_form_fields();
70
71			// Load the settings.
72			$this->init_settings();
73
74			$main_settings = get_option( 'woocommerce_stripe_settings' );
75			$this->title = $this->get_option( 'title' );
76			$this->description = $this->get_option( 'description' );
77			$this->enabled = $this->get_option( 'enabled' );
78			$this->testmode = ( ! empty( $main_settings['testmode'] ) && 'yes' === $main_settings['testmode'] ) ? true : false;
79			$this->saved_cards = ( ! empty( $main_settings['saved_cards'] ) && 'yes' === $main_settings['saved_cards'] ) ? true : false;
80			$this->publishable_key = ! empty( $main_settings['publishable_key'] ) ? $main_settings['publishable_key'] : '';
81			$this->secret_key = ! empty( $main_settings['secret_key'] ) ? $main_settings['secret_key'] : '';
82			$this->statement_descriptor = ! empty( $main_settings['statement_descriptor'] ) ? $main_settings['statement_descriptor'] : '';
83
84			if ( $this->testmode ) {
85			$this->publishable_key = ! empty( $main_settings['test_publishable_key'] ) ? $main_settings['test_publishable_key'] : '';
86			$this->secret_key = ! empty( $main_settings['test_secret_key'] ) ? $main_settings['test_secret_key'] : '';
87			}
88
89			add_action( 'woocommerce_update_options_payment_gateways_' . $this->id, array( $this, 'process_admin_options' ) );
90			add_action( 'wp_enqueue_scripts', array( $this, 'payment_scripts' ) );
91			}
92
93			/**
94			* Returns all supported currencies for this payment method.
95			*
96			* @since 4.1.0
97			* @version 4.1.0
98			* @return array
99			*/
100			public function get_supported_currency() {
101			return apply_filters( 'wc_stripe_eps_supported_currencies', array(
102			'EUR',
103			) );
104			}
105
106			/**
107			* Checks to see if all criteria is met before showing payment method.
108			*
109			* @since 4.1.0
110			* @version 4.1.0
111			* @return bool
112			*/
113			public function is_available() {
114			if ( ! in_array( get_woocommerce_currency(), $this->get_supported_currency() ) ) {
115			return false;
116			}
117
118			return parent::is_available();
119			}
120
121			/**
122			* Get_icon function.
123			*
124			* @since 1.0.0
125			* @version 4.1.0
126			* @return string
127			*/
128			public function get_icon() {
129			$icons = $this->payment_icons();
130
131			$icons_str = '';
132
133			$icons_str .= $icons['eps'];
134
135			return apply_filters( 'woocommerce_gateway_icon', $icons_str, $this->id );
136			}
137
138			/**
139			* payment_scripts function.
140			*
141			* Outputs scripts used for stripe payment
142			*
143			* @access public
144			*/
145			public function payment_scripts() {
146			if ( ! is_cart() && ! is_checkout() && ! isset( $_GET['pay_for_order'] ) && ! is_add_payment_method_page() ) {
147			return;
148			}
149
150			wp_enqueue_style( 'stripe_styles' );
151			wp_enqueue_script( 'woocommerce_stripe' );
152			}
153
154			/**
155			* Initialize Gateway Settings Form Fields.
156			*/
157			public function init_form_fields() {
158			$this->form_fields = require( WC_STRIPE_PLUGIN_PATH . '/includes/admin/stripe-eps-settings.php' );
159			}
160
161			/**
162			* Payment form on checkout page
163			*/
164			public function payment_fields() {
165			$user = wp_get_current_user();
			0 ignored issues – show Unused Code introduced 2017-07-27 08:27 UTC by Report Bug Copy Issue Report `$user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
166			$total = WC()->cart->total;
167
168			// If paying from order, we need to get total from order not cart.
169			if ( isset( $_GET['pay_for_order'] ) && ! empty( $_GET['key'] ) ) {
170			$order = wc_get_order( wc_get_order_id_by_order_key( wc_clean( $_GET['key'] ) ) );
171			$total = $order->get_total();
172			}
173
174			if ( is_add_payment_method_page() ) {
175			$pay_button_text = __( 'Add Payment', 'woocommerce-gateway-stripe' );
			0 ignored issues – show Unused Code introduced 2017-07-27 08:27 UTC by Report Bug Copy Issue Report `$pay_button_text` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
176			$total = '';
177			} else {
178			$pay_button_text = '';
			0 ignored issues – show Unused Code introduced 2017-07-27 08:27 UTC by Report Bug Copy Issue Report `$pay_button_text` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
179			}
180
181			echo '<div
182			id="stripe-eps-payment-data"
183			data-amount="' . esc_attr( WC_Stripe_Helper::get_stripe_amount( $total ) ) . '"
184			data-currency="' . esc_attr( strtolower( get_woocommerce_currency() ) ) . '">';
185
186			if ( $this->description ) {
187			echo apply_filters( 'wc_stripe_description', wpautop( wp_kses_post( $this->description ) ) );
188			}
189
190			echo '</div>';
191			}
192
193			/**
194			* Creates the source for charge.
195			*
196			* @since 4.1.0
197			* @version 4.1.0
198			* @param object $order
199			* @return mixed
200			*/
201			public function create_source( $order ) {
202			$currency = WC_Stripe_Helper::is_pre_30() ? $order->get_order_currency() : $order->get_currency();
203			$order_id = WC_Stripe_Helper::is_pre_30() ? $order->id : $order->get_id();
			0 ignored issues – show Unused Code introduced 2018-01-07 16:56 UTC by Report Bug Copy Issue Report `$order_id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
204			$return_url = $this->get_stripe_return_url( $order );
205			$post_data = array();
206			$post_data['amount'] = WC_Stripe_Helper::get_stripe_amount( $order->get_total(), $currency );
207			$post_data['currency'] = strtolower( $currency );
208			$post_data['type'] = 'eps';
209			$post_data['owner'] = $this->get_owner_details( $order );
210			$post_data['redirect'] = array( 'return_url' => $return_url );
211
212			if ( ! empty( $this->statement_descriptor ) ) {
213			$post_data['statement_descriptor'] = WC_Stripe_Helper::clean_statement_descriptor( $this->statement_descriptor );
			0 ignored issues – show Documentation introduced 2018-01-07 16:56 UTC by Report Bug Copy Issue Report `$this->statement_descriptor` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
214			}
215
216			WC_Stripe_Logger::log( 'Info: Begin creating EPS source' );
217
218			return WC_Stripe_API::request( $post_data, 'sources' );
219			}
220
221			/**
222			* Process the payment
223			*
224			* @param int $order_id Reference.
225			* @param bool $retry Should we retry on fail.
226			* @param bool $force_save_source Force payment source to be saved.
227			*
228			* @throws Exception If payment will not be accepted.
229			*
230			* @return array\|void
231			*/
232			public function process_payment( $order_id, $retry = true, $force_save_source = false ) {
233			try {
234			$order = wc_get_order( $order_id );
235
236			// This will throw exception if not valid.
237			$this->validate_minimum_order_amount( $order );
238
239			// This comes from the create account checkbox in the checkout page.
240			$create_account = ! empty( $_POST['createaccount'] ) ? true : false;
241
242			if ( $create_account ) {
243			$new_customer_id = WC_Stripe_Helper::is_pre_30() ? $order->customer_user : $order->get_customer_id();
244			$new_stripe_customer = new WC_Stripe_Customer( $new_customer_id );
245			$new_stripe_customer->create_customer();
246			}
247
248			$response = $this->create_source( $order );
249
250			if ( ! empty( $response->error ) ) {
251			$order->add_order_note( $response->error->message );
252
253			throw new Exception( $response->error->message );
254			}
255
256			if ( WC_Stripe_Helper::is_pre_30() ) {
257			update_post_meta( $order_id, '_stripe_source_id', $response->id );
258			} else {
259			$order->update_meta_data( '_stripe_source_id', $response->id );
260			$order->save();
261			}
262
263			WC_Stripe_Logger::log( 'Info: Redirecting to EPS...' );
264
265			return array(
266			'result' => 'success',
267			'redirect' => esc_url_raw( $response->redirect->url ),
268			);
269			} catch ( Exception $e ) {
270			wc_add_notice( $e->getMessage(), 'error' );
271			WC_Stripe_Logger::log( 'Error: ' . $e->getMessage() );
272
273			do_action( 'wc_gateway_stripe_process_payment_error', $e, $order );
274
275			if ( $order->has_status( array( 'pending', 'failed' ) ) ) {
276			$this->send_failed_order_email( $order_id );
277			}
278
279			return array(
280			'result' => 'fail',
281			'redirect' => '',
282			);
283			}
284			}
285			}
286

woocommerce / woocommerce-gateway-stripe

Push — master ( e3a5fe...3adadd )

WC_Gateway_Stripe_Eps::get_icon() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like