InMemoryTermIdsAcquirer::cleanTerms() - Code Metrics - Inspection of "Improve testCleanTerms_completelyCleansArray" - wmde/mediawiki-term-store - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#18)

by Alaa

created 2019-05-17 09:05 UTC

InMemoryTermIdsAcquirer::cleanTerms() B

↳ Parent: InMemoryTermIdsAcquirer

Complexity

Conditions	7
Paths	15

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	8.8333
c	0
b	0
f	0
cc	7
nc	15
nop	1

<?php

namespace Wikibase\TermStore\MediaWiki\PackagePrivate;

class InMemoryTermIdsAcquirer implements TermIdsAcquirer, TermCleaner {

	private $terms = [];
	private $lastId = 0;

	public function acquireTermIds( array $termsArray ): array {
		$ids = [];

		foreach ( $termsArray as $type => $termsOfType ) {
			foreach ( $termsOfType as $lang => $terms ) {
				$terms = (array)$terms;

				foreach ( $terms as $term ) {
					if ( !isset( $this->terms[$type][$lang][$term] ) ) {
						$this->terms[$type][$lang][$term] = ++$this->lastId;
					}

					$ids[] = $this->terms[$type][$lang][$term];
				}
			}
		}

		return $ids;
	}

	public function cleanTerms( array $termInLangIds ) {
		$termInLangIdsAsKeys = array_flip( $termInLangIds );
		foreach ( $this->terms as $type => &$termsOfType ) {
			foreach ( $termsOfType as $lang => &$termsOfLang ) {
				foreach ( $termsOfLang as $term => $id ) {
					if ( array_key_exists( $id, $termInLangIdsAsKeys ) ) {
						unset( $termsOfLang[$term] );
					}
				}
				if ( $termsOfLang === [] ) {
					unset( $termsOfType[$lang] );
				}
			}
			if ( $termsOfType === [] ) {
				unset( $this->terms[$type] );
			}
		}
	}

	public function hasTerms() {
		$empty = true;
		// if there's any leaf element in terms then it's not empty, otherwise we consider
		// the terms array empty even if it had some sub-arrays that are also empty by
		// this definition
		array_walk_recursive(
			$this->terms,
			function ( $element ) use ( &$empty ) {

				$empty = false;
			}
		);

		return !$empty;
	}

}


1			<?php
2
3			namespace Wikibase\TermStore\MediaWiki\PackagePrivate;
4
5			class InMemoryTermIdsAcquirer implements TermIdsAcquirer, TermCleaner {
6
7			private $terms = [];
8			private $lastId = 0;
9
10			public function acquireTermIds( array $termsArray ): array {
11			$ids = [];
12
13			foreach ( $termsArray as $type => $termsOfType ) {
14			foreach ( $termsOfType as $lang => $terms ) {
15			$terms = (array)$terms;
16
17			foreach ( $terms as $term ) {
18			if ( !isset( $this->terms[$type][$lang][$term] ) ) {
19			$this->terms[$type][$lang][$term] = ++$this->lastId;
20			}
21
22			$ids[] = $this->terms[$type][$lang][$term];
23			}
24			}
25			}
26
27			return $ids;
28			}
29
30			public function cleanTerms( array $termInLangIds ) {
31			$termInLangIdsAsKeys = array_flip( $termInLangIds );
32			foreach ( $this->terms as $type => &$termsOfType ) {
33			foreach ( $termsOfType as $lang => &$termsOfLang ) {
34			foreach ( $termsOfLang as $term => $id ) {
35			if ( array_key_exists( $id, $termInLangIdsAsKeys ) ) {
36			unset( $termsOfLang[$term] );
37			}
38			}
39			if ( $termsOfLang === [] ) {
40			unset( $termsOfType[$lang] );
41			}
42			}
43			if ( $termsOfType === [] ) {
44			unset( $this->terms[$type] );
45			}
46			}
47			}
48
49			public function hasTerms() {
50			$empty = true;
51			// if there's any leaf element in terms then it's not empty, otherwise we consider
52			// the terms array empty even if it had some sub-arrays that are also empty by
53			// this definition
54			array_walk_recursive(
55			$this->terms,
56			function ( $element ) use ( &$empty ) {
			0 ignored issues – show Unused Code introduced 2019-05-17 07:51 UTC by Report Bug Copy Issue Report The parameter `$element` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
57			$empty = false;
58			}
59			);
60
61			return !$empty;
62			}
63
64			}
65

wmde / mediawiki-term-store

Pull Request — master (#18)

InMemoryTermIdsAcquirer::cleanTerms() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like