TextContentsMatcher::matchesSafelyWithDiagnosticDescription() - Code Metrics - Inspection of "[WIP] Optimize all matchers for performance" - wmde/hamcrest-html-matchers - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#9)

by no

created 2018-04-16 10:04 UTC

matchesSafelyWithDiagnosticDescription() A

↳ Parent: TextContentsMatcher

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	2
dl	0
loc	8
ccs	4
cts	4
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace WMDE\HamcrestHtml;

use Hamcrest\Description;
use Hamcrest\Matcher;

class TextContentsMatcher extends TagMatcher
{

    /**
     * @var Matcher|string
     */
    private $matcher;

    /**
     * @param Matcher|string $text
     *
     * @return self
     */
    public static function havingTextContents($text) {
        return new static($text);
    }

    /**
     * @param Matcher|string $matcher
     */
    public function __construct($matcher)
    {
        parent::__construct();
        $this->matcher = $matcher;
    }

    public function describeTo(Description $description)

    {
        $description->appendText('having text contents ');
        if ($this->matcher instanceof Matcher) {
            $description->appendDescriptionOf($this->matcher);
        } else {
            $description->appendValue($this->matcher);
        }
    }

    /**
     * @param \DOMElement $item
     * @param Description $mismatchDescription
     *
     * @return bool
     */
    protected function matchesSafelyWithDiagnosticDescription($item, Description $mismatchDescription)
    {
        if ($this->matcher instanceof Matcher) {
            return $this->matcher->matches($item->textContent);
        } else {
            return $item->textContent === (string)$this->matcher;
        }
    }

}


1			<?php
2
3			namespace WMDE\HamcrestHtml;
4
5			use Hamcrest\Description;
6			use Hamcrest\Matcher;
7
8			class TextContentsMatcher extends TagMatcher
9			{
10
11			/**
12			* @var Matcher\|string
13			*/
14			private $matcher;
15
16			/**
17			* @param Matcher\|string $text
18			*
19			* @return self
20			*/
21			public static function havingTextContents($text) {
22			return new static($text);
23			}
24
25			/**
26			* @param Matcher\|string $matcher
27			*/
28			public function __construct($matcher)
29			{
30			parent::__construct();
31			$this->matcher = $matcher;
32			}
33
34	2	View Code Duplication	public function describeTo(Description $description)
			0 ignored issues – show Duplication introduced 2018-04-16 08:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35			{
36	2		$description->appendText('having text contents ');
37	2		if ($this->matcher instanceof Matcher) {
38			$description->appendDescriptionOf($this->matcher);
39			} else {
40	2		$description->appendValue($this->matcher);
41			}
42	2		}
43
44			/**
45			* @param \DOMElement $item
46			* @param Description $mismatchDescription
47			*
48			* @return bool
49			*/
50	4		protected function matchesSafelyWithDiagnosticDescription($item, Description $mismatchDescription)
51			{
52	4		if ($this->matcher instanceof Matcher) {
53	2		return $this->matcher->matches($item->textContent);
54			} else {
55	2		return $item->textContent === (string)$this->matcher;
56			}
57			}
58
59			}
60

wmde / hamcrest-html-matchers

GitHub Access Token became invalid

Pull Request — master (#9)

matchesSafelyWithDiagnosticDescription() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like