WMDE\Fundraising\AddressChangeContext\Tests\TestAddressChangeContextFactory

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getEntityManager()	0	5	2
A	newConnection()	0	4	1
A	newEntityManager()	0	2	1
A	__construct()	0	7	1

<?php

declare( strict_types = 1 );

namespace WMDE\Fundraising\AddressChangeContext\Tests;

use Doctrine\DBAL\Connection;
use Doctrine\DBAL\DriverManager;
use Doctrine\DBAL\Exception;
use Doctrine\ORM\Configuration;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\ORMSetup;
use WMDE\Fundraising\AddressChangeContext\AddressChangeContextFactory;

class TestAddressChangeContextFactory {

	private Configuration $doctrineConfig;
	private ?EntityManager $entityManager;
	private AddressChangeContextFactory $contextFactory;

	/**
	 * @param array<string,mixed> $config
	 *
	 * @throws Exception
	 */
	public function __construct( private array $config ) {
		$this->contextFactory = new AddressChangeContextFactory();
		$this->doctrineConfig = ORMSetup::createXMLMetadataConfiguration(
			$this->contextFactory->getDoctrineMappingPaths(),
			true
		);
		$this->entityManager = null;
	}

	private function newConnection(): Connection {
		$connection = DriverManager::getConnection( $this->config['db'] );
		$this->contextFactory->registerCustomTypes( $connection );
		return $connection;
	}

	public function newEntityManager(): EntityManager {
		return new EntityManager( $this->newConnection(), $this->doctrineConfig );
	}

	public function getEntityManager(): EntityManager {
		if ( $this->entityManager === null ) {
			$this->entityManager = $this->newEntityManager();
		}
		return $this->entityManager;

The expression return $this->entityManager could return the type null which is incompatible with the type-hinted return Doctrine\ORM\EntityManager. Consider adding an additional type-check to rule them out.

	}
}