Version20241113164504::up() - Code Metrics - Inspection of "Merge pull request #57 from wmde/migrate-ids" - wmde/fundraising-address-change - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 05b1ca...cdc05c )

by Corinna

created 2024-11-20 16:04 UTC

Version20241113164504::up() A

↳ Parent: Version20241113164504

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	2
c	1
b	0
f	0
dl	0
loc	5
rs	10
cc	1
nc	1
nop	1

<?php

declare( strict_types=1 );

namespace WMDE\Fundraising\AddressChangeContext\DataAccess\Migrations;

use Doctrine\DBAL\Schema\Schema;
use Doctrine\Migrations\AbstractMigration;

/**
 * This migration is a followup for commit 82fbafd0df529ba9604b35ef805174d1a4c390fa
 * where we changed how we store the address change identifiers and made the columns non-nullable,
 * but forgot to migrate old address change entries where the `previous_identifier` defaulted to NULL.
 */
final class Version20241113164504 extends AbstractMigration {
	public function getDescription(): string {
		return 'Make address change identifiers non-nullable';
	}

	public function up( Schema $schema ): void {
		$this->addSql( "UPDATE address_change SET previous_identifier=current_identifier WHERE previous_identifier IS NULL AND current_identifier IS NOT NULL" );
		// We can't use $schema here to modify the columns because `addSQL` appends to the SQL generated by $schema calls.
		// We would fail the migration when trying to set a column to non-nullable if it already contains NULL values
		$this->addSql( "ALTER TABLE address_change MODIFY current_identifier VARCHAR(36) NOT NULL, MODIFY previous_identifier VARCHAR(36) NOT NULL " );
	}

	public function down( Schema $schema ): void {
		$addressChange = $schema->getTable( 'address_change' );
		$addressChange->modifyColumn( 'current_identifier', [ 'notnull' => false ] );
		$addressChange->modifyColumn( 'previous_identifier', [ 'notnull' => false ] );
	}
}


1			<?php
2
3			declare( strict_types=1 );
4
5			namespace WMDE\Fundraising\AddressChangeContext\DataAccess\Migrations;
6
7			use Doctrine\DBAL\Schema\Schema;
8			use Doctrine\Migrations\AbstractMigration;
9
10			/**
11			* This migration is a followup for commit 82fbafd0df529ba9604b35ef805174d1a4c390fa
12			* where we changed how we store the address change identifiers and made the columns non-nullable,
13			* but forgot to migrate old address change entries where the `previous_identifier` defaulted to NULL.
14			*/
15			final class Version20241113164504 extends AbstractMigration {
16			public function getDescription(): string {
17			return 'Make address change identifiers non-nullable';
18			}
19
20			public function up( Schema $schema ): void {
21			$this->addSql( "UPDATE address_change SET previous_identifier=current_identifier WHERE previous_identifier IS NULL AND current_identifier IS NOT NULL" );
22			// We can't use $schema here to modify the columns because `addSQL` appends to the SQL generated by $schema calls.
23			// We would fail the migration when trying to set a column to non-nullable if it already contains NULL values
24			$this->addSql( "ALTER TABLE address_change MODIFY current_identifier VARCHAR(36) NOT NULL, MODIFY previous_identifier VARCHAR(36) NOT NULL " );
25			}
26
27			public function down( Schema $schema ): void {
28			$addressChange = $schema->getTable( 'address_change' );
29			$addressChange->modifyColumn( 'current_identifier', [ 'notnull' => false ] );
30			$addressChange->modifyColumn( 'previous_identifier', [ 'notnull' => false ] );
31			}
32			}
33

wmde / fundraising-address-change

Push — main ( 05b1ca...cdc05c )

Version20241113164504::up() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like