WMDE\Fundraising\AddressChangeContext\Tests\TestAddressChangeContextFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	28
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getEntityManager()	0	13	2
A	__construct()	0	6	1

<?php

declare(strict_types = 1);

namespace WMDE\Fundraising\AddressChangeContext\Tests;

use Doctrine\Common\Annotations\AnnotationRegistry;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\DriverManager;
use Doctrine\ORM\Configuration;
use Doctrine\ORM\EntityManager;
use WMDE\Fundraising\AddressChangeContext\AddressChangeContextFactory;

class TestAddressChangeContextFactory {

	private Configuration $doctrineConfig;
	private AddressChangeContextFactory $factory;
	private Connection $connection;
	private ?EntityManager $entityManager;

	public function __construct( array $config, Configuration $doctrineConfig ) {
		$this->doctrineConfig = $doctrineConfig;

		$this->connection = DriverManager::getConnection( $config['db'] );
		$this->factory = new AddressChangeContextFactory();
		$this->entityManager = null;
	}

	public function getEntityManager(): EntityManager {
		if ( $this->entityManager === null ) {
			AnnotationRegistry::registerLoader( 'class_exists' );

The function Doctrine\Common\Annotations\AnnotationRegistry::registerLoader() has been deprecated: This method is deprecated and will be removed in doctrine/annotations 2.0. Annotations will be autoloaded in 2.0.

			$this->doctrineConfig->setMetadataDriverImpl( $this->factory->newMappingDriver() );

			$this->entityManager = EntityManager::create(
				$this->connection,
				$this->doctrineConfig
			);
		}

		return $this->entityManager;

The expression return $this->entityManager could return the type null which is incompatible with the type-hinted return Doctrine\ORM\EntityManager. Consider adding an additional type-check to rule them out.

	}
}