Campaign::selectBucket() - Code Metrics - Inspection of "Banner selection use case" - wmde/banner-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#19)

by Tim

created 2018-10-30 14:42 UTC

Campaign::selectBucket() A

↳ Parent: Campaign

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	3
nop	1
dl	0
loc	7
ccs	5
cts	5
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare( strict_types = 1 );

namespace WMDE\BannerServer\Entity\BannerSelection;

/**
 * @license GNU GPL v2+
 */
class Campaign {

	private $identifier;
	private $start;
	private $end;
	private $rng;
	private $displayPercentage;

	/**
	 * @var Bucket[]
	 */
	private $buckets;

	public function __construct(
		string $identifier,
		\DateTime $start,
		\DateTime $end,
		int $displayPercentage,
		RandomIntegerGenerator $rng,
		Bucket $firstBucket,
		Bucket ...$additionalBuckets ) {

		$this->identifier = $identifier;
		$this->start = $start;
		$this->end = $end;
		$this->displayPercentage = $displayPercentage;
		$this->rng = $rng;
		$this->buckets = $additionalBuckets;
		array_unshift( $this->buckets, $firstBucket );
	}

	public function getIdentifier(): string {
		return $this->identifier;
	}

	public function getEnd(): \DateTime {
		return $this->end;
	}

	public function isInActiveDateRange( \DateTime $time ): bool {
		return $time->getTimestamp() >= $this->start->getTimestamp() &&
			$time->getTimestamp() <= $this->end->getTimestamp();
	}

	public function selectBucket( ?string $bucketId ): Bucket {
		foreach ( $this->buckets as $bucket ) {
			if ( $bucket->getIdentifier() === $bucketId ) {
				return $bucket;
			}
		}
		return $this->buckets[$this->rng->getRandomInteger( 0, count( $this->buckets ) - 1 )];
	}

	public function getDisplayPercentage(): int {
		return $this->displayPercentage;
	}
}

1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace WMDE\BannerServer\Entity\BannerSelection;
6
7		/**
8		* @license GNU GPL v2+
9		*/
10		class Campaign {
11
12		private $identifier;
13		private $start;
14		private $end;
15		private $rng;
16		private $displayPercentage;
17
18		/**
19		* @var Bucket[]
20		*/
21		private $buckets;
22
23	5	public function __construct(
24		string $identifier,
25		\DateTime $start,
26		\DateTime $end,
27		int $displayPercentage,
28		RandomIntegerGenerator $rng,
29		Bucket $firstBucket,
30		Bucket ...$additionalBuckets ) {
31
32	5	$this->identifier = $identifier;
33	5	$this->start = $start;
34	5	$this->end = $end;
35	5	$this->displayPercentage = $displayPercentage;
36	5	$this->rng = $rng;
37	5	$this->buckets = $additionalBuckets;
38	5	array_unshift( $this->buckets, $firstBucket );
39	5	}
40
41		public function getIdentifier(): string {
42		return $this->identifier;
43		}
44
45		public function getEnd(): \DateTime {
46		return $this->end;
47		}
48
49	2	public function isInActiveDateRange( \DateTime $time ): bool {
50	2	return $time->getTimestamp() >= $this->start->getTimestamp() &&
51	2	$time->getTimestamp() <= $this->end->getTimestamp();
52		}
53
54	3	public function selectBucket( ?string $bucketId ): Bucket {
55	3	foreach ( $this->buckets as $bucket ) {
56	3	if ( $bucket->getIdentifier() === $bucketId ) {
57	3	return $bucket;
58		}
59		}
60	2	return $this->buckets[$this->rng->getRandomInteger( 0, count( $this->buckets ) - 1 )];
61		}
62
63		public function getDisplayPercentage(): int {
64		return $this->displayPercentage;
65		}
66		}

wmde / banner-server

Pull Request — master (#19)

Campaign::selectBucket() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like