Bucket::getLastBanner() - Code Metrics - Inspection of "Banner selection use case" - wmde/banner-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#19)

by Tim

created 2018-10-30 14:42 UTC

Bucket::getLastBanner() A

↳ Parent: Bucket

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	0
dl	0
loc	2
ccs	2
cts	2
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php

declare( strict_types = 1 );

namespace WMDE\BannerServer\Entity\BannerSelection;

/**
 * @license GNU GPL v2+
 */
class Bucket {

	private $identifier;
	private $firstBanner;

	/**
	 * @var Banner[]
	 */
	private $banners = [];

	public function __construct( string $identifier, Banner $firstBanner, Banner ...$otherBanners ) {
		$this->identifier = $identifier;
		$this->firstBanner = $firstBanner;
		$this->banners[] = $firstBanner;
		$this->banners = array_merge( $this->banners, $otherBanners );
	}

	public function getIdentifier(): string {
		return $this->identifier;
	}

	private function getLastBanner(): Banner {
		return $this->banners[count( $this->banners ) - 1];
	}

	/**
	 * Decides which banner to return based on visitor's impression count
	 */
	public function getBanner( int $visitorImpressionCount ): string {
		if ( $visitorImpressionCount >= count( $this->banners ) ) {
			return $this->getLastBanner()->getIdentifier();
		}
		return $this->banners[$visitorImpressionCount]->getIdentifier();
	}
}

1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace WMDE\BannerServer\Entity\BannerSelection;
6
7		/**
8		* @license GNU GPL v2+
9		*/
10		class Bucket {
11
12		private $identifier;
13		private $firstBanner;
14
15		/**
16		* @var Banner[]
17		*/
18		private $banners = [];
19
20	4	public function __construct( string $identifier, Banner $firstBanner, Banner ...$otherBanners ) {
21	4	$this->identifier = $identifier;
22	4	$this->firstBanner = $firstBanner;
23	4	$this->banners[] = $firstBanner;
24	4	$this->banners = array_merge( $this->banners, $otherBanners );
25	4	}
26
27		public function getIdentifier(): string {
28		return $this->identifier;
29		}
30
31	1	private function getLastBanner(): Banner {
32	1	return $this->banners[count( $this->banners ) - 1];
33		}
34
35		/**
36		* Decides which banner to return based on visitor's impression count
37		*/
38	4	public function getBanner( int $visitorImpressionCount ): string {
39	4	if ( $visitorImpressionCount >= count( $this->banners ) ) {
40	1	return $this->getLastBanner()->getIdentifier();
41		}
42	3	return $this->banners[$visitorImpressionCount]->getIdentifier();
43		}
44		}

wmde / banner-server

Pull Request — master (#19)

Bucket::getLastBanner() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like