Campaign::selectBucket() - Code Metrics - Inspection of "Banner selection use case" - wmde/banner-server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#19)

by Tim

created 2018-10-26 12:00 UTC

Campaign::selectBucket() A

↳ Parent: Campaign

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	3
nop	1
dl	0
loc	7
ccs	5
cts	5
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare( strict_types = 1 );

namespace WMDE\BannerServer\Entity\BannerSelection;

use WMDE\BannerServer\Utils\RandomIntegerInterface;

/**
 * @license GNU GPL v2+
 */
class Campaign {

	private $identifier;
	private $start;
	private $end;
	private $rng;
	private $displayRatio;

	/**
	 * @var Bucket[]
	 */
	private $buckets;

	public function __construct( string $identifier, \DateTime $start, \DateTime $end, array $buckets, float $displayRatio, RandomIntegerInterface $rng ) {
		$this->identifier = $identifier;
		$this->start = $start;
		$this->end = $end;
		$this->buckets = $buckets;
		$this->displayRatio = $displayRatio;
		$this->rng = $rng;
	}

	public function getIdentifier(): string {
		return $this->identifier;
	}

	public function getEnd(): \DateTime {
		return $this->end;
	}

	public function isInActiveDateRange( \DateTime $time ): bool {
		return $time->getTimestamp() >= $this->start->getTimestamp() &&
			$time->getTimestamp() <= $this->end->getTimestamp();
	}

	public function selectBucket( ?string $bucketId ): Bucket {
		foreach ( $this->buckets as $bucket ) {
			if ( $bucket->getIdentifier() === $bucketId ) {
				return $bucket;
			}
		}
		return $this->buckets[$this->rng->getRandomInteger( 0, count( $this->buckets ) - 1 )];
	}

	public function isRatioLimited(): bool {
		return ( $this->rng->getRandomInteger( 1, 100 ) / 100 ) > $this->displayRatio;
	}
}

1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace WMDE\BannerServer\Entity\BannerSelection;
6
7		use WMDE\BannerServer\Utils\RandomIntegerInterface;
8
9		/**
10		* @license GNU GPL v2+
11		*/
12		class Campaign {
13
14		private $identifier;
15		private $start;
16		private $end;
17		private $rng;
18		private $displayRatio;
19
20		/**
21		* @var Bucket[]
22		*/
23		private $buckets;
24
25	10	public function __construct( string $identifier, \DateTime $start, \DateTime $end, array $buckets, float $displayRatio, RandomIntegerInterface $rng ) {
26	10	$this->identifier = $identifier;
27	10	$this->start = $start;
28	10	$this->end = $end;
29	10	$this->buckets = $buckets;
30	10	$this->displayRatio = $displayRatio;
31	10	$this->rng = $rng;
32	10	}
33
34	1	public function getIdentifier(): string {
35	1	return $this->identifier;
36		}
37
38		public function getEnd(): \DateTime {
39		return $this->end;
40		}
41
42	4	public function isInActiveDateRange( \DateTime $time ): bool {
43	4	return $time->getTimestamp() >= $this->start->getTimestamp() &&
44	4	$time->getTimestamp() <= $this->end->getTimestamp();
45		}
46
47	3	public function selectBucket( ?string $bucketId ): Bucket {
48	3	foreach ( $this->buckets as $bucket ) {
49	3	if ( $bucket->getIdentifier() === $bucketId ) {
50	3	return $bucket;
51		}
52		}
53	2	return $this->buckets[$this->rng->getRandomInteger( 0, count( $this->buckets ) - 1 )];
54		}
55
56	3	public function isRatioLimited(): bool {
57	3	return ( $this->rng->getRandomInteger( 1, 100 ) / 100 ) > $this->displayRatio;
58		}
59		}

wmde / banner-server

Pull Request — master (#19)

Campaign::selectBucket() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like