AlreadyDonatedController::index() - Code Metrics - Inspection of "Add new route for "Already donated" cookie" - wmde/banner-server - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — new-cookie-route ( 6ee6e7 )

by Gabriel

created 2024-10-25 18:32 UTC

AlreadyDonatedController::index() A

↳ Parent: AlreadyDonatedController

Complexity

Conditions	3
Paths	3

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	9
rs	10
cc	3
nc	3
nop	1

<?php

declare( strict_types = 1 );

namespace WMDE\BannerServer\Controller;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

/**
 * This controller allows to set the cookie lifetime dynamically with the "d" (="duration") query parameter.
 */
class AlreadyDonatedController extends AbstractCookieController {

	public const MAX_INTERVAL_LENGTH = 'P28D';

	private \DateInterval $cookieLifetime;

	public function __construct() {
		$this->cookieLifetime = new \DateInterval( self::MAX_INTERVAL_LENGTH );
	}

	public function index( Request $request ): Response {
		if ( $request->query->has( 'd' ) ) {
			$potentialLifetime = $this->getDurationHours( $request->query->get( 'd' ) );
			$now = new \DateTimeImmutable();
			if ( $now->add( $potentialLifetime ) < $now->add( new \DateInterval( self::MAX_INTERVAL_LENGTH ) ) ) {
				$this->cookieLifetime = $potentialLifetime;
			}
		}
		return parent::index( $request );
	}

	protected function getCookieLifetime(): \DateInterval {
		return $this->cookieLifetime;
	}

	private function getDurationHours( float|bool|int|string|null $durationInHours ): \DateInterval {
		$durationInHours = filter_var( $durationInHours, FILTER_VALIDATE_INT );
		if ( $durationInHours === false ) {
			return new \DateInterval( self::MAX_INTERVAL_LENGTH );
		}
		return new \DateInterval( 'PT' . $durationInHours . 'H' );
	}
}


1			<?php
2
3			declare( strict_types = 1 );
4
5			namespace WMDE\BannerServer\Controller;
6
7			use Symfony\Component\HttpFoundation\Request;
8			use Symfony\Component\HttpFoundation\Response;
9
10			/**
11			* This controller allows to set the cookie lifetime dynamically with the "d" (="duration") query parameter.
12			*/
13			class AlreadyDonatedController extends AbstractCookieController {
14
15			public const MAX_INTERVAL_LENGTH = 'P28D';
16
17			private \DateInterval $cookieLifetime;
18
19			public function __construct() {
20			$this->cookieLifetime = new \DateInterval( self::MAX_INTERVAL_LENGTH );
21			}
22
23			public function index( Request $request ): Response {
24			if ( $request->query->has( 'd' ) ) {
25			$potentialLifetime = $this->getDurationHours( $request->query->get( 'd' ) );
26			$now = new \DateTimeImmutable();
27			if ( $now->add( $potentialLifetime ) < $now->add( new \DateInterval( self::MAX_INTERVAL_LENGTH ) ) ) {
28			$this->cookieLifetime = $potentialLifetime;
29			}
30			}
31			return parent::index( $request );
32			}
33
34			protected function getCookieLifetime(): \DateInterval {
35			return $this->cookieLifetime;
36			}
37
38			private function getDurationHours( float\|bool\|int\|string\|null $durationInHours ): \DateInterval {
39			$durationInHours = filter_var( $durationInHours, FILTER_VALIDATE_INT );
40			if ( $durationInHours === false ) {
41			return new \DateInterval( self::MAX_INTERVAL_LENGTH );
42			}
43			return new \DateInterval( 'PT' . $durationInHours . 'H' );
44			}
45			}
46

wmde / banner-server

Push — new-cookie-route ( 6ee6e7 )

AlreadyDonatedController::index() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like