Campaign::impressionThresholdReached() - Code Metrics - Inspection of "Banner selection use case" - wmde/banner-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

by Tim

created 2018-10-25 23:59 UTC

Campaign::impressionThresholdReached() A

↳ Parent: Campaign

Complexity

Conditions	1
Paths	1

Size

Total Lines	2
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	2
ccs	0
cts	0
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php

declare( strict_types = 1 );

namespace WMDE\BannerServer\Entity\BannerSelection;

/**
 * @license GNU GPL v2+
 */
class Campaign {

	private $identifier;
	private $start;
	private $end;
	private $impressionThreshold;

	/**
	 * @var Bucket[]
	 */
	private $buckets;

	public function __construct( string $identifier, \DateTime $start, \DateTime $end, array $buckets, ImpressionThresholdInterface $impressionThreshold ) {
		$this->identifier = $identifier;
		$this->start = $start;
		$this->end = $end;
		$this->buckets = $buckets;
		$this->impressionThreshold = $impressionThreshold;
	}

	public function getIdentifier(): string {
		return $this->identifier;
	}

	public function getCampaignExpiration(): \DateTime {
		return $this->end;
	}

	public function isInActiveDateRange( \DateTime $time ): bool {
		return $time->getTimestamp() >= $this->start->getTimestamp() &&
			$time->getTimestamp() <= $this->end->getTimestamp();
	}

	public function selectBucket( ?string $bucketId, callable $fallbackSelectionStrategy ): Bucket {
		foreach ( $this->buckets as $bucket ) {
			if ( $bucket->getIdentifier() === $bucketId ) {
				return $bucket;
			}
		}
		return $fallbackSelectionStrategy( $this->buckets );
	}

	public function impressionThresholdReached( int $visitorImpressions ): bool {
		return $this->impressionThreshold->getIsOverThreshold( $visitorImpressions );
	}
}

1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace WMDE\BannerServer\Entity\BannerSelection;
6
7		/**
8		* @license GNU GPL v2+
9		*/
10		class Campaign {
11
12		private $identifier;
13		private $start;
14		private $end;
15		private $impressionThreshold;
16
17		/**
18		* @var Bucket[]
19		*/
20		private $buckets;
21	7
22	7	public function __construct( string $identifier, \DateTime $start, \DateTime $end, array $buckets, ImpressionThresholdInterface $impressionThreshold ) {
23	7	$this->identifier = $identifier;
24	7	$this->start = $start;
25	7	$this->end = $end;
26	7	$this->buckets = $buckets;
27		$this->impressionThreshold = $impressionThreshold;
28	1	}
29	1
30		public function getIdentifier(): string {
31		return $this->identifier;
32		}
33
34		public function getCampaignExpiration(): \DateTime {
35		return $this->end;
36	4	}
37	4
38	4	public function isInActiveDateRange( \DateTime $time ): bool {
39		return $time->getTimestamp() >= $this->start->getTimestamp() &&
40		$time->getTimestamp() <= $this->end->getTimestamp();
41	3	}
42	3
43	3	public function selectBucket( ?string $bucketId, callable $fallbackSelectionStrategy ): Bucket {
44	3	foreach ( $this->buckets as $bucket ) {
45		if ( $bucket->getIdentifier() === $bucketId ) {
46		return $bucket;
47	2	}
48		}
49		return $fallbackSelectionStrategy( $this->buckets );
50		}
51
52		public function impressionThresholdReached( int $visitorImpressions ): bool {
53		return $this->impressionThreshold->getIsOverThreshold( $visitorImpressions );
54		}
55		}

wmde / banner-server

Pull Request — master (#19)

Campaign::impressionThresholdReached() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like