Campaign::selectBucket() - Code Metrics - Inspection of "[WIP] Add unit tests for Entities" - wmde/banner-server - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Tim

created 2018-10-25 22:20 UTC

Campaign::selectBucket() A

↳ Parent: Campaign

Complexity

Conditions	3
Paths	3

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	3

Importance

Changes

Metric	Value
cc	3
eloc	4
nc	3
nop	2
dl	0
loc	7
ccs	5
cts	5
cp	1
crap	3
rs	10
c	0
b	0
f	0

<?php

declare( strict_types = 1 );

namespace WMDE\BannerServer\Entity\BannerSelection;

/**
 * @license GNU GPL v2+
 */
class Campaign {

	private $identifier;
	private $start;
	private $end;

	/**
	 * @var Bucket[]
	 */
	private $buckets;

	public function __construct( string $identifier, \DateTime $start, \DateTime $end, array $buckets ) {
		$this->identifier = $identifier;
		$this->start = $start;
		$this->end = $end;
		$this->buckets = $buckets;
	}

	public function getIdentifier(): string {
		return $this->identifier;
	}

	public function getCampaignExpiration(): \DateTime {
		return $this->end;
	}

	public function isInActiveDateRange( \DateTime $time ): bool {
		return $time->getTimestamp() >= $this->start->getTimestamp() &&
			$time->getTimestamp() <= $this->end->getTimestamp();
	}

	public function selectBucket( ?string $bucketId, callable $fallbackSelectionStrategy ): Bucket {
		foreach ( $this->buckets as $bucket ) {
			if ( $bucket->getIdentifier() === $bucketId ) {
				return $bucket;
			}
		}
		return $fallbackSelectionStrategy( $this->buckets );
	}
}

1		<?php
2
3		declare( strict_types = 1 );
4
5		namespace WMDE\BannerServer\Entity\BannerSelection;
6
7		/**
8		* @license GNU GPL v2+
9		*/
10		class Campaign {
11
12		private $identifier;
13		private $start;
14		private $end;
15
16		/**
17		* @var Bucket[]
18		*/
19		private $buckets;
20
21	7	public function __construct( string $identifier, \DateTime $start, \DateTime $end, array $buckets ) {
22	7	$this->identifier = $identifier;
23	7	$this->start = $start;
24	7	$this->end = $end;
25	7	$this->buckets = $buckets;
26	7	}
27
28	1	public function getIdentifier(): string {
29	1	return $this->identifier;
30		}
31
32		public function getCampaignExpiration(): \DateTime {
33		return $this->end;
34		}
35
36	4	public function isInActiveDateRange( \DateTime $time ): bool {
37	4	return $time->getTimestamp() >= $this->start->getTimestamp() &&
38	4	$time->getTimestamp() <= $this->end->getTimestamp();
39		}
40
41	3	public function selectBucket( ?string $bucketId, callable $fallbackSelectionStrategy ): Bucket {
42	3	foreach ( $this->buckets as $bucket ) {
43	3	if ( $bucket->getIdentifier() === $bucketId ) {
44	3	return $bucket;
45		}
46		}
47	2	return $fallbackSelectionStrategy( $this->buckets );
48		}
49		}

wmde / banner-server

Pull Request — master (#16)

Campaign::selectBucket() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like