|
1
|
|
|
<?php |
|
2
|
|
|
|
|
3
|
|
|
namespace Tests\Wikibase\InternalSerialization\Deserializers; |
|
4
|
|
|
|
|
5
|
|
|
use Deserializers\Deserializer; |
|
6
|
|
|
use Deserializers\Exceptions\DeserializationException; |
|
7
|
|
|
use Wikibase\DataModel\Snak\PropertyNoValueSnak; |
|
8
|
|
|
use Wikibase\DataModel\Snak\PropertySomeValueSnak; |
|
9
|
|
|
use Wikibase\DataModel\Snak\SnakList; |
|
10
|
|
|
use Wikibase\InternalSerialization\Deserializers\LegacySnakDeserializer; |
|
11
|
|
|
use Wikibase\InternalSerialization\Deserializers\LegacySnakListDeserializer; |
|
12
|
|
|
|
|
13
|
|
|
/** |
|
14
|
|
|
* @covers Wikibase\InternalSerialization\Deserializers\LegacySnakListDeserializer |
|
15
|
|
|
* |
|
16
|
|
|
* @license GPL-2.0-or-later |
|
17
|
|
|
* @author Jeroen De Dauw < [email protected] > |
|
18
|
|
|
*/ |
|
19
|
|
|
class LegacySnakListDeserializerTest extends \PHPUnit\Framework\TestCase { |
|
20
|
|
|
|
|
21
|
|
|
/** |
|
22
|
|
|
* @var Deserializer |
|
23
|
|
|
*/ |
|
24
|
|
|
private $deserializer; |
|
25
|
|
|
|
|
26
|
|
|
protected function setUp() : void { |
|
27
|
|
|
$snakDeserializer = new LegacySnakDeserializer( $this->createMock( Deserializer::class ) ); |
|
|
|
|
|
|
28
|
|
|
|
|
29
|
|
|
$this->deserializer = new LegacySnakListDeserializer( $snakDeserializer ); |
|
30
|
|
|
} |
|
31
|
|
|
|
|
32
|
|
|
public function invalidSerializationProvider() { |
|
33
|
|
|
return array( |
|
34
|
|
|
array( null ), |
|
35
|
|
|
array( array( null ) ), |
|
36
|
|
|
array( array( 1337 ) ), |
|
37
|
|
|
array( array( array() ) ), |
|
38
|
|
|
array( array( array( 'novalue', 42 ), array( 'hax' ) ) ), |
|
39
|
|
|
); |
|
40
|
|
|
} |
|
41
|
|
|
|
|
42
|
|
|
/** |
|
43
|
|
|
* @dataProvider invalidSerializationProvider |
|
44
|
|
|
*/ |
|
45
|
|
|
public function testGivenInvalidSerialization_deserializeThrowsException( $serialization ) { |
|
46
|
|
|
$this->expectException( DeserializationException::class ); |
|
47
|
|
|
$this->deserializer->deserialize( $serialization ); |
|
48
|
|
|
} |
|
49
|
|
|
|
|
50
|
|
|
public function testGivenEmptyArray_deserializeReturnsEmptySnakList() { |
|
51
|
|
|
$this->assertEquals( |
|
52
|
|
|
new SnakList( array() ), |
|
53
|
|
|
$this->deserializer->deserialize( array() ) |
|
54
|
|
|
); |
|
55
|
|
|
} |
|
56
|
|
|
|
|
57
|
|
|
public function testGivenValidSerialization_deserializeReturnsCorrectSnakList() { |
|
58
|
|
|
$expected = new SnakList( array( |
|
59
|
|
|
new PropertyNoValueSnak( 42 ), |
|
60
|
|
|
new PropertySomeValueSnak( 1337 ), |
|
61
|
|
|
) ); |
|
62
|
|
|
|
|
63
|
|
|
$serialization = array( |
|
64
|
|
|
array( |
|
65
|
|
|
'novalue', |
|
66
|
|
|
42, |
|
67
|
|
|
), |
|
68
|
|
|
array( |
|
69
|
|
|
'somevalue', |
|
70
|
|
|
1337, |
|
71
|
|
|
) |
|
72
|
|
|
); |
|
73
|
|
|
|
|
74
|
|
|
$this->assertEquals( |
|
75
|
|
|
$expected, |
|
76
|
|
|
$this->deserializer->deserialize( $serialization ) |
|
77
|
|
|
); |
|
78
|
|
|
} |
|
79
|
|
|
|
|
80
|
|
|
} |
|
81
|
|
|
|
It seems like the type of the argument is not accepted by the function/method which you are calling.
In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.
We suggest to add an explicit type cast like in the following example: