wmde / WikibaseDataModelServices

src/Lookup/LegacyAdapterItemLookup.php

<?php

namespace Wikibase\DataModel\Services\Lookup;

use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;

/**
 * ItemLookup implementation providing a migration path away from
 * the EntityLookup interface.
 *
 * @license GPL-2.0-or-later
 * @author Jeroen De Dauw < jeroendedauw@gmail.com >
 */
class LegacyAdapterItemLookup implements ItemLookup {

	private EntityLookup $lookup;

	public function __construct( EntityLookup $lookup ) {
		$this->lookup = $lookup;
	}

	/**
	 * @param ItemId $itemId
	 *
	 * @return Item|null
	 * @throws ItemLookupException
	 */
	public function getItemForId( ItemId $itemId ) {
		try {
			return $this->lookup->getEntity( $itemId );

The expression return $this->lookup->getEntity($itemId) also could return the type Wikibase\DataModel\Entity\EntityDocument which includes types incompatible with the return type mandated by Wikibase\DataModel\Services\Lookup\ItemLookup::getItemForId() of Wikibase\DataModel\Entity\Item|null. Consider adding a type-check to rule them out.

		} catch ( EntityLookupException $ex ) {
			throw new ItemLookupException( $itemId, $ex->getMessage(), $ex );
		}
	}

}