wmde / WikibaseDataModelServices

src/Diff/EntityTypeAwareDiffOpFactory.php

Spacing +10 added lines, -10 removed lines

@@ -22,21 +22,21 @@ 
 	 * @return DiffOp
 	 * @throws InvalidArgumentException
 	 */
-	public function newFromArray( array $diffOp ) {
-		$this->assertHasKey( 'type', $diffOp );
+	public function newFromArray(array $diffOp) {
+		$this->assertHasKey('type', $diffOp);
 
 		// see EntityDiff::getType() and ItemDiff::getType()
-		if ( preg_match( '!^diff/(.*)$!', $diffOp['type'], $matches ) ) {
+		if (preg_match('!^diff/(.*)$!', $diffOp['type'], $matches)) {
 			$itemType = $matches[1];
-			$this->assertHasKey( 'operations', $diffOp );
+			$this->assertHasKey('operations', $diffOp);
 
-			$operations = $this->createOperations( $diffOp['operations'] );
-			$diff = EntityDiff::newForType( $itemType, $operations );
+			$operations = $this->createOperations($diffOp['operations']);
+			$diff = EntityDiff::newForType($itemType, $operations);
 
 			return $diff;
 		}
 
-		return parent::newFromArray( $diffOp );
+		return parent::newFromArray($diffOp);
 	}
 
 	/**
@@ -46,11 +46,11 @@ 
 	 * @param array $data the input data
 	 * @return DiffOp[] The diff ops
 	 */
-	private function createOperations( array $data ) {
+	private function createOperations(array $data) {
 		$operations = [];
 
-		foreach ( $data as $key => $operation ) {
-			$operations[$key] = $this->newFromArray( $operation );
+		foreach ($data as $key => $operation) {
+			$operations[$key] = $this->newFromArray($operation);
 		}
 
 		return $operations;

src/Diff/ItemPatcher.php

Spacing +12 added lines, -12 removed lines

@@ -42,7 +42,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canPatchEntityType( $entityType ) {
+	public function canPatchEntityType($entityType) {
 		return $entityType === 'item';
 	}
 
@@ -52,27 +52,27 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function patchEntity( EntityDocument $entity, EntityDiff $patch ) {
-		$item = $this->assertIsItemAndCast( $entity );
+	public function patchEntity(EntityDocument $entity, EntityDiff $patch) {
+		$item = $this->assertIsItemAndCast($entity);
 
-		$this->patchItem( $item, $patch );
+		$this->patchItem($item, $patch);
 	}
 
-	private function assertIsItemAndCast( EntityDocument $item ): Item {
-		if ( !( $item instanceof Item ) ) {
-			throw new InvalidArgumentException( '$item must be an instance of Item' );
+	private function assertIsItemAndCast(EntityDocument $item): Item {
+		if (!($item instanceof Item)) {
+			throw new InvalidArgumentException('$item must be an instance of Item');
 		}
 		return $item;
 	}
 
-	private function patchItem( Item $item, EntityDiff $patch ) {
-		$this->fingerprintPatcher->patchFingerprint( $item->getFingerprint(), $patch );
+	private function patchItem(Item $item, EntityDiff $patch) {
+		$this->fingerprintPatcher->patchFingerprint($item->getFingerprint(), $patch);
 
-		if ( $patch instanceof ItemDiff ) {
-			$item->setSiteLinkList( $this->siteLinkListPatcher->getPatchedSiteLinkList(
+		if ($patch instanceof ItemDiff) {
+			$item->setSiteLinkList($this->siteLinkListPatcher->getPatchedSiteLinkList(
 				$item->getSiteLinkList(),
 				$patch->getSiteLinkDiff()
-			) );
+			));
 		}
 
 		$this->statementListPatcher->patchStatementList(

src/Diff/EntityDifferStrategy.php

Spacing +4 added lines, -4 removed lines

@@ -18,7 +18,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canDiffEntityType( $entityType );
+	public function canDiffEntityType($entityType);
 
 	/**
 	 * @param EntityDocument $from
@@ -27,7 +27,7 @@ 
 	 * @return EntityDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function diffEntities( EntityDocument $from, EntityDocument $to );
+	public function diffEntities(EntityDocument $from, EntityDocument $to);
 
 	/**
 	 * @param EntityDocument $entity
@@ -35,7 +35,7 @@ 
 	 * @return EntityDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function getConstructionDiff( EntityDocument $entity );
+	public function getConstructionDiff(EntityDocument $entity);
 
 	/**
 	 * @param EntityDocument $entity
@@ -43,6 +43,6 @@ 
 	 * @return EntityDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function getDestructionDiff( EntityDocument $entity );
+	public function getDestructionDiff(EntityDocument $entity);
 
 }

src/Diff/ItemDiffer.php

Spacing +25 added lines, -25 removed lines

@@ -28,7 +28,7 @@ 
 	private $statementListDiffer;
 
 	public function __construct() {
-		$this->recursiveMapDiffer = new MapDiffer( true );
+		$this->recursiveMapDiffer = new MapDiffer(true);
 		$this->statementListDiffer = new StatementListDiffer();
 	}
 
@@ -37,7 +37,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canDiffEntityType( $entityType ) {
+	public function canDiffEntityType($entityType) {
 		return $entityType === 'item';
 	}
 
@@ -48,50 +48,50 @@ 
 	 * @return ItemDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function diffEntities( EntityDocument $from, EntityDocument $to ) {
-		$fromItem = $this->assertIsItemAndCast( $from );
-		$toItem = $this->assertIsItemAndCast( $to );
+	public function diffEntities(EntityDocument $from, EntityDocument $to) {
+		$fromItem = $this->assertIsItemAndCast($from);
+		$toItem = $this->assertIsItemAndCast($to);
 
-		return $this->diffItems( $fromItem, $toItem );
+		return $this->diffItems($fromItem, $toItem);
 	}
 
-	private function assertIsItemAndCast( EntityDocument $item ): Item {
-		if ( !( $item instanceof Item ) ) {
-			throw new InvalidArgumentException( '$item must be an instance of Item' );
+	private function assertIsItemAndCast(EntityDocument $item): Item {
+		if (!($item instanceof Item)) {
+			throw new InvalidArgumentException('$item must be an instance of Item');
 		}
 		return $item;
 	}
 
-	public function diffItems( Item $from, Item $to ): ItemDiff {
+	public function diffItems(Item $from, Item $to): ItemDiff {
 		$diffOps = $this->recursiveMapDiffer->doDiff(
-			$this->toDiffArray( $from ),
-			$this->toDiffArray( $to )
+			$this->toDiffArray($from),
+			$this->toDiffArray($to)
 		);
 
-		$diffOps['claim'] = $this->statementListDiffer->getDiff( $from->getStatements(), $to->getStatements() );
+		$diffOps['claim'] = $this->statementListDiffer->getDiff($from->getStatements(), $to->getStatements());
 
-		return new ItemDiff( $diffOps );
+		return new ItemDiff($diffOps);
 	}
 
-	private function toDiffArray( Item $item ): array {
+	private function toDiffArray(Item $item): array {
 		$array = [];
 
 		$array['aliases'] = $item->getAliasGroups()->toTextArray();
 		$array['label'] = $item->getLabels()->toTextArray();
 		$array['description'] = $item->getDescriptions()->toTextArray();
-		$array['links'] = $this->getSiteLinksInDiffFormat( $item->getSiteLinkList() );
+		$array['links'] = $this->getSiteLinksInDiffFormat($item->getSiteLinkList());
 
 		return $array;
 	}
 
-	private function getSiteLinksInDiffFormat( SiteLinkList $siteLinks ): array {
+	private function getSiteLinksInDiffFormat(SiteLinkList $siteLinks): array {
 		$linksInDiffFormat = [];
 
-		foreach ( $siteLinks->toArray() as $siteLink ) {
+		foreach ($siteLinks->toArray() as $siteLink) {
 			$linksInDiffFormat[$siteLink->getSiteId()] = [
 				'name' => $siteLink->getPageName(),
 				'badges' => array_map(
-					static function( ItemId $id ) {
+					static function(ItemId $id) {
 						return $id->getSerialization();
 					},
 					$siteLink->getBadges()
@@ -108,9 +108,9 @@ 
 	 * @return ItemDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function getConstructionDiff( EntityDocument $entity ) {
-		$item = $this->assertIsItemAndCast( $entity );
-		return $this->diffEntities( new Item(), $item );
+	public function getConstructionDiff(EntityDocument $entity) {
+		$item = $this->assertIsItemAndCast($entity);
+		return $this->diffEntities(new Item(), $item);
 	}
 
 	/**
@@ -119,9 +119,9 @@ 
 	 * @return ItemDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function getDestructionDiff( EntityDocument $entity ) {
-		$item = $this->assertIsItemAndCast( $entity );
-		return $this->diffEntities( $item, new Item() );
+	public function getDestructionDiff(EntityDocument $entity) {
+		$item = $this->assertIsItemAndCast($entity);
+		return $this->diffEntities($item, new Item());
 	}
 
 }

src/Diff/PropertyPatcher.php

Spacing +9 added lines, -9 removed lines

@@ -35,7 +35,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function canPatchEntityType( $entityType ) {
+	public function canPatchEntityType($entityType) {
 		return $entityType === 'property';
 	}
 
@@ -45,21 +45,21 @@ 
 	 *
 	 * @throws InvalidArgumentException
 	 */
-	public function patchEntity( EntityDocument $entity, EntityDiff $patch ) {
-		$property = $this->assertIsPropertyAndCast( $entity );
+	public function patchEntity(EntityDocument $entity, EntityDiff $patch) {
+		$property = $this->assertIsPropertyAndCast($entity);
 
-		$this->patchProperty( $property, $patch );
+		$this->patchProperty($property, $patch);
 	}
 
-	private function assertIsPropertyAndCast( EntityDocument $property ): Property {
-		if ( !( $property instanceof Property ) ) {
-			throw new InvalidArgumentException( '$property must be an instance of Property' );
+	private function assertIsPropertyAndCast(EntityDocument $property): Property {
+		if (!($property instanceof Property)) {
+			throw new InvalidArgumentException('$property must be an instance of Property');
 		}
 		return $property;
 	}
 
-	private function patchProperty( Property $property, EntityDiff $patch ) {
-		$this->fingerprintPatcher->patchFingerprint( $property->getFingerprint(), $patch );
+	private function patchProperty(Property $property, EntityDiff $patch) {
+		$this->fingerprintPatcher->patchFingerprint($property->getFingerprint(), $patch);
 
 		$this->statementListPatcher->patchStatementList(
 			$property->getStatements(),

src/Diff/ItemDiff.php

Spacing +4 added lines, -4 removed lines

@@ -18,10 +18,10 @@ 
 	/**
 	 * @param DiffOp[] $operations
 	 */
-	public function __construct( array $operations = [] ) {
-		$this->fixSubstructureDiff( $operations, 'links' );
+	public function __construct(array $operations = []) {
+		$this->fixSubstructureDiff($operations, 'links');
 
-		parent::__construct( $operations );
+		parent::__construct($operations);
 	}
 
 	/**
@@ -30,7 +30,7 @@ 
 	 * @return Diff
 	 */
 	public function getSiteLinkDiff() {
-		return $this['links'] ?? new Diff( [], true );
+		return $this['links'] ?? new Diff([], true);
 	}
 
 	/**

src/Diff/EntityDiffer.php

Spacing +17 added lines, -17 removed lines

@@ -20,11 +20,11 @@ 
 	private $differStrategies;
 
 	public function __construct() {
-		$this->registerEntityDifferStrategy( new ItemDiffer() );
-		$this->registerEntityDifferStrategy( new PropertyDiffer() );
+		$this->registerEntityDifferStrategy(new ItemDiffer());
+		$this->registerEntityDifferStrategy(new PropertyDiffer());
 	}
 
-	public function registerEntityDifferStrategy( EntityDifferStrategy $differStrategy ) {
+	public function registerEntityDifferStrategy(EntityDifferStrategy $differStrategy) {
 		$this->differStrategies[] = $differStrategy;
 	}
 
@@ -36,15 +36,15 @@ 
 	 * @throws InvalidArgumentException
 	 * @throws RuntimeException
 	 */
-	public function diffEntities( EntityDocument $from, EntityDocument $to ) {
-		$this->assertTypesMatch( $from, $to );
+	public function diffEntities(EntityDocument $from, EntityDocument $to) {
+		$this->assertTypesMatch($from, $to);
 
-		return $this->getDiffStrategy( $from->getType() )->diffEntities( $from, $to );
+		return $this->getDiffStrategy($from->getType())->diffEntities($from, $to);
 	}
 
-	private function assertTypesMatch( EntityDocument $from, EntityDocument $to ) {
-		if ( $from->getType() !== $to->getType() ) {
-			throw new InvalidArgumentException( 'Can only diff two entities of the same type' );
+	private function assertTypesMatch(EntityDocument $from, EntityDocument $to) {
+		if ($from->getType() !== $to->getType()) {
+			throw new InvalidArgumentException('Can only diff two entities of the same type');
 		}
 	}
 
@@ -54,14 +54,14 @@ 
 	 * @throws RuntimeException
 	 * @return EntityDifferStrategy
 	 */
-	private function getDiffStrategy( $entityType ) {
-		foreach ( $this->differStrategies as $diffStrategy ) {
-			if ( $diffStrategy->canDiffEntityType( $entityType ) ) {
+	private function getDiffStrategy($entityType) {
+		foreach ($this->differStrategies as $diffStrategy) {
+			if ($diffStrategy->canDiffEntityType($entityType)) {
 				return $diffStrategy;
 			}
 		}
 
-		throw new RuntimeException( 'Diffing the provided types of entities is not supported' );
+		throw new RuntimeException('Diffing the provided types of entities is not supported');
 	}
 
 	/**
@@ -70,8 +70,8 @@ 
 	 * @return EntityDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function getConstructionDiff( EntityDocument $entity ) {
-		return $this->getDiffStrategy( $entity->getType() )->getConstructionDiff( $entity );
+	public function getConstructionDiff(EntityDocument $entity) {
+		return $this->getDiffStrategy($entity->getType())->getConstructionDiff($entity);
 	}
 
 	/**
@@ -80,8 +80,8 @@ 
 	 * @return EntityDiff
 	 * @throws InvalidArgumentException
 	 */
-	public function getDestructionDiff( EntityDocument $entity ) {
-		return $this->getDiffStrategy( $entity->getType() )->getDestructionDiff( $entity );
+	public function getDestructionDiff(EntityDocument $entity) {
+		return $this->getDiffStrategy($entity->getType())->getDestructionDiff($entity);
 	}
 
 }

src/Diff/EntityPatcher.php

Spacing +9 added lines, -9 removed lines

@@ -21,11 +21,11 @@ 
 	private $patcherStrategies;
 
 	public function __construct() {
-		$this->registerEntityPatcherStrategy( new ItemPatcher() );
-		$this->registerEntityPatcherStrategy( new PropertyPatcher() );
+		$this->registerEntityPatcherStrategy(new ItemPatcher());
+		$this->registerEntityPatcherStrategy(new PropertyPatcher());
 	}
 
-	public function registerEntityPatcherStrategy( EntityPatcherStrategy $patcherStrategy ) {
+	public function registerEntityPatcherStrategy(EntityPatcherStrategy $patcherStrategy) {
 		$this->patcherStrategies[] = $patcherStrategy;
 	}
 
@@ -36,8 +36,8 @@ 
 	 * @throws InvalidArgumentException
 	 * @throws RuntimeException
 	 */
-	public function patchEntity( EntityDocument $entity, EntityDiff $patch ) {
-		$this->getPatcherStrategy( $entity->getType() )->patchEntity( $entity, $patch );
+	public function patchEntity(EntityDocument $entity, EntityDiff $patch) {
+		$this->getPatcherStrategy($entity->getType())->patchEntity($entity, $patch);
 	}
 
 	/**
@@ -46,14 +46,14 @@ 
 	 * @throws RuntimeException
 	 * @return EntityPatcherStrategy
 	 */
-	private function getPatcherStrategy( $entityType ) {
-		foreach ( $this->patcherStrategies as $patcherStrategy ) {
-			if ( $patcherStrategy->canPatchEntityType( $entityType ) ) {
+	private function getPatcherStrategy($entityType) {
+		foreach ($this->patcherStrategies as $patcherStrategy) {
+			if ($patcherStrategy->canPatchEntityType($entityType)) {
 				return $patcherStrategy;
 			}
 		}
 
-		throw new RuntimeException( 'Patching the provided types of entities is not supported' );
+		throw new RuntimeException('Patching the provided types of entities is not supported');
 	}
 
 }

src/Diff/EntityDiff.php

Spacing +22 added lines, -22 removed lines

@@ -22,24 +22,24 @@ 
 	 *
 	 * @return self
 	 */
-	public static function newForType( $entityType, array $operations = [] ) {
-		if ( $entityType === Item::ENTITY_TYPE ) {
-			return new ItemDiff( $operations );
+	public static function newForType($entityType, array $operations = []) {
+		if ($entityType === Item::ENTITY_TYPE) {
+			return new ItemDiff($operations);
 		} else {
-			return new self( $operations );
+			return new self($operations);
 		}
 	}
 
 	/**
 	 * @param DiffOp[] $operations
 	 */
-	public function __construct( array $operations = [] ) {
-		$this->fixSubstructureDiff( $operations, 'aliases' );
-		$this->fixSubstructureDiff( $operations, 'label' );
-		$this->fixSubstructureDiff( $operations, 'description' );
-		$this->fixSubstructureDiff( $operations, 'claim' );
+	public function __construct(array $operations = []) {
+		$this->fixSubstructureDiff($operations, 'aliases');
+		$this->fixSubstructureDiff($operations, 'label');
+		$this->fixSubstructureDiff($operations, 'description');
+		$this->fixSubstructureDiff($operations, 'claim');
 
-		parent::__construct( $operations, true );
+		parent::__construct($operations, true);
 	}
 
 	/**
@@ -52,18 +52,18 @@ 
 	 *        substructure diff can be replaced if need be.
 	 * @param string $key The key of the substructure
 	 */
-	protected function fixSubstructureDiff( array &$operations, $key ) {
-		if ( !isset( $operations[$key] ) ) {
+	protected function fixSubstructureDiff(array &$operations, $key) {
+		if (!isset($operations[$key])) {
 			return;
 		}
 
-		if ( !( $operations[$key] instanceof Diff ) ) {
-			$warning = "Invalid substructure diff for key $key: " . get_class( $operations[$key] );
+		if (!($operations[$key] instanceof Diff)) {
+			$warning = "Invalid substructure diff for key $key: " . get_class($operations[$key]);
 
-			if ( function_exists( 'wfLogWarning' ) ) {
-				wfLogWarning( $warning );
+			if (function_exists('wfLogWarning')) {
+				wfLogWarning($warning);
 			} else {
-				trigger_error( $warning, E_USER_WARNING );
+				trigger_error($warning, E_USER_WARNING);
 			}
 
 			// We could look into the atomic diff, see if it uses arrays as values,
@@ -71,7 +71,7 @@ 
 			// actual old behavior of MapDiffer didn't cause that to happen, let's
 			// just use an empty diff, which is what MapDiffer should have returned
 			// in the actual broken case mentioned in bug 51363.
-			$operations[$key] = new Diff( [], true );
+			$operations[$key] = new Diff([], true);
 		}
 	}
 
@@ -83,7 +83,7 @@ 
 	 * @return Diff
 	 */
 	public function getAliasesDiff() {
-		return $this['aliases'] ?? new Diff( [], true );
+		return $this['aliases'] ?? new Diff([], true);
 	}
 
 	/**
@@ -94,7 +94,7 @@ 
 	 * @return Diff
 	 */
 	public function getLabelsDiff() {
-		return $this['label'] ?? new Diff( [], true );
+		return $this['label'] ?? new Diff([], true);
 	}
 
 	/**
@@ -105,7 +105,7 @@ 
 	 * @return Diff
 	 */
 	public function getDescriptionsDiff() {
-		return $this['description'] ?? new Diff( [], true );
+		return $this['description'] ?? new Diff([], true);
 	}
 
 	/**
@@ -116,7 +116,7 @@ 
 	 * @return Diff
 	 */
 	public function getClaimsDiff() {
-		return $this['claim'] ?? new Diff( [], true );
+		return $this['claim'] ?? new Diff([], true);
 	}
 
 	/**