RedirectResolvingEntityLookupTest::hasEntity() - Code Metrics - Inspection of "Inline trivial returnCallback as closure" - wmde/WikibaseDataModelServices - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#166)

by no

created 2016-12-13 09:23 UTC

RedirectResolvingEntityLookupTest::hasEntity() A

↳ Parent: RedirectResolvingEntityLookupTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Wikibase\DataModel\Services\Tests\Lookup;

use Wikibase\DataModel\Entity\EntityId;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Services\Lookup\EntityLookup;
use Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup;
use Wikibase\DataModel\Services\Lookup\UnresolvedEntityRedirectException;

/**
 * @covers Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup
 *
 * @license GPL-2.0+
 * @author Daniel Kinzler
 */
class RedirectResolvingEntityLookupTest extends \PHPUnit_Framework_TestCase {

	/**
	 * @param EntityId $id
	 *
	 * @return null|Item
	 * @throws UnresolvedEntityRedirectException
	 */
	public function getEntity( EntityId $id ) {
		switch ( $id->getSerialization() ) {
			case 'Q10':
				return new Item( $id );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			case 'Q11':
				throw new UnresolvedEntityRedirectException( new ItemId( 'Q11' ), new ItemId( 'Q10' ) );
			case 'Q12':
				throw new UnresolvedEntityRedirectException( new ItemId( 'Q12' ), new ItemId( 'Q11' ) );
			case 'Q21':
				throw new UnresolvedEntityRedirectException( new ItemId( 'Q21' ), new ItemId( 'Q20' ) );
			default:
				return null;
		}
	}

	/**
	 * @return EntityLookup
	 */
	public function getLookupDouble() {
		$mock = $this->getMock( 'Wikibase\DataModel\Services\Lookup\EntityLookup' );

		$mock->expects( $this->any() )
			->method( 'getEntity' )
			->will( $this->returnCallback( [ $this, 'getEntity' ] ) );

		$mock->expects( $this->any() )
			->method( 'hasEntity' )
			->will( $this->returnCallback( function ( EntityId $id ) {
				return $this->getEntity( $id ) !== null;
			} ) );

		return $mock;
	}

	public function getEntityProvider() {
		return [
			'no redirect' => [ new ItemId( 'Q10' ), new ItemId( 'Q10' ) ],
			'one redirect' => [ new ItemId( 'Q11' ), new ItemId( 'Q10' ) ],
		];
	}

	/**
	 * @dataProvider getEntityProvider
	 */
	public function testGetEntity( EntityId $id, EntityId $expected ) {
		$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );

		$entity = $lookup->getEntity( $id );

		if ( $expected === null ) {
			$this->assertNull( $entity );
		} else {
			$this->assertTrue( $expected->equals( $entity->getId() ) );
		}
	}

	public function testGetEntity_missing() {
		$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );

		$id = new ItemId( 'Q7' ); // entity Q7 is not known
		$this->assertNull( $lookup->getEntity( $id ) );
	}

	public function testGetEntity_brokenRedirect() {
		$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );

		$id = new ItemId( 'Q20' ); // Q20 is a broken redirect
		$this->assertNull( $lookup->getEntity( $id ) );
	}

	public function testGetEntity_doubleRedirect() {
		$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );

		$id = new ItemId( 'Q12' ); // Q12 is a double redirect

		$this->setExpectedException( 'Wikibase\DataModel\Services\Lookup\UnresolvedEntityRedirectException' );
		$lookup->getEntity( $id );
	}

	public function hasEntityProvider() {
		return [
			'unknown entity' => [ new ItemId( 'Q7' ), false ],
			'no redirect' => [ new ItemId( 'Q10' ), true ],
			'one redirect' => [ new ItemId( 'Q11' ), true ],
			'broken redirect' => [ new ItemId( 'Q21' ), false ],
		];
	}

	/**
	 * @dataProvider hasEntityProvider
	 */
	public function testHasEntity( EntityId $id, $exists ) {
		$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );

		$this->assertEquals( $exists, $lookup->hasEntity( $id ) );
	}

}


1			<?php
2
3			namespace Wikibase\DataModel\Services\Tests\Lookup;
4
5			use Wikibase\DataModel\Entity\EntityId;
6			use Wikibase\DataModel\Entity\Item;
7			use Wikibase\DataModel\Entity\ItemId;
8			use Wikibase\DataModel\Services\Lookup\EntityLookup;
9			use Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup;
10			use Wikibase\DataModel\Services\Lookup\UnresolvedEntityRedirectException;
11
12			/**
13			* @covers Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup
14			*
15			* @license GPL-2.0+
16			* @author Daniel Kinzler
17			*/
18			class RedirectResolvingEntityLookupTest extends \PHPUnit_Framework_TestCase {
19
20			/**
21			* @param EntityId $id
22			*
23			* @return null\|Item
24			* @throws UnresolvedEntityRedirectException
25			*/
26			public function getEntity( EntityId $id ) {
27			switch ( $id->getSerialization() ) {
28			case 'Q10':
29			return new Item( $id );
			0 ignored issues – show Documentation introduced 2015-11-23 08:52 UTC by Report Bug Copy Issue Report `$id` is of type `object<Wikibase\DataModel\Entity\EntityId>`, but the function expects a `null\|object<Wikibase\DataModel\Entity\ItemId>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			case 'Q11':
31			throw new UnresolvedEntityRedirectException( new ItemId( 'Q11' ), new ItemId( 'Q10' ) );
32			case 'Q12':
33			throw new UnresolvedEntityRedirectException( new ItemId( 'Q12' ), new ItemId( 'Q11' ) );
34			case 'Q21':
35			throw new UnresolvedEntityRedirectException( new ItemId( 'Q21' ), new ItemId( 'Q20' ) );
36			default:
37			return null;
38			}
39			}
40
41			/**
42			* @return EntityLookup
43			*/
44			public function getLookupDouble() {
45			$mock = $this->getMock( 'Wikibase\DataModel\Services\Lookup\EntityLookup' );
46
47			$mock->expects( $this->any() )
48			->method( 'getEntity' )
49			->will( $this->returnCallback( [ $this, 'getEntity' ] ) );
50
51			$mock->expects( $this->any() )
52			->method( 'hasEntity' )
53			->will( $this->returnCallback( function ( EntityId $id ) {
54			return $this->getEntity( $id ) !== null;
55			} ) );
56
57			return $mock;
58			}
59
60			public function getEntityProvider() {
61			return [
62			'no redirect' => [ new ItemId( 'Q10' ), new ItemId( 'Q10' ) ],
63			'one redirect' => [ new ItemId( 'Q11' ), new ItemId( 'Q10' ) ],
64			];
65			}
66
67			/**
68			* @dataProvider getEntityProvider
69			*/
70			public function testGetEntity( EntityId $id, EntityId $expected ) {
71			$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );
72
73			$entity = $lookup->getEntity( $id );
74
75			if ( $expected === null ) {
76			$this->assertNull( $entity );
77			} else {
78			$this->assertTrue( $expected->equals( $entity->getId() ) );
79			}
80			}
81
82			public function testGetEntity_missing() {
83			$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );
84
85			$id = new ItemId( 'Q7' ); // entity Q7 is not known
86			$this->assertNull( $lookup->getEntity( $id ) );
87			}
88
89			public function testGetEntity_brokenRedirect() {
90			$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );
91
92			$id = new ItemId( 'Q20' ); // Q20 is a broken redirect
93			$this->assertNull( $lookup->getEntity( $id ) );
94			}
95
96			public function testGetEntity_doubleRedirect() {
97			$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );
98
99			$id = new ItemId( 'Q12' ); // Q12 is a double redirect
100
101			$this->setExpectedException( 'Wikibase\DataModel\Services\Lookup\UnresolvedEntityRedirectException' );
102			$lookup->getEntity( $id );
103			}
104
105			public function hasEntityProvider() {
106			return [
107			'unknown entity' => [ new ItemId( 'Q7' ), false ],
108			'no redirect' => [ new ItemId( 'Q10' ), true ],
109			'one redirect' => [ new ItemId( 'Q11' ), true ],
110			'broken redirect' => [ new ItemId( 'Q21' ), false ],
111			];
112			}
113
114			/**
115			* @dataProvider hasEntityProvider
116			*/
117			public function testHasEntity( EntityId $id, $exists ) {
118			$lookup = new RedirectResolvingEntityLookup( $this->getLookupDouble() );
119
120			$this->assertEquals( $exists, $lookup->hasEntity( $id ) );
121			}
122
123			}
124

wmde / WikibaseDataModelServices

Pull Request — master (#166)

RedirectResolvingEntityLookupTest::hasEntity() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like