EntityDiffOldTest::provideConflictDetection() - Code Metrics - Inspection of "Merge pull request #122 from wmde/release350" - wmde/WikibaseDataModelServices - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dfbbd6...7f838a )

by Daniel

created 2016-03-14 17:39 UTC

EntityDiffOldTest::provideConflictDetection() A

↳ Parent: EntityDiffOldTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	63
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	63
rs	9.4347
cc	1
eloc	41
nc	1
nop	0

How to fix Long Method

<?php

namespace Wikibase\DataModel\Services\Tests\Diff;

use RuntimeException;
use Wikibase\DataModel\Entity\EntityDocument;
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\Services\Diff\EntityDiffer;
use Wikibase\DataModel\Services\Diff\EntityPatcher;

/**
 * @covers Wikibase\DataModel\Services\Diff\EntityDiff
 *
 * @licence GNU GPL v2+
 * @author Daniel Kinzler
 * @author Jens Ohlig <[email protected]>
 */
abstract class EntityDiffOldTest extends \PHPUnit_Framework_TestCase {

	private static function newEntity( $entityType ) {
		switch ( $entityType ) {
			case Item::ENTITY_TYPE:
				return new Item();
			case Property::ENTITY_TYPE:
				return Property::newFromType( 'string' );
			default:
				throw new RuntimeException( "unknown entity type: $entityType" );
		}
	}

	protected function generateApplyData( $entityType ) {
		$tests = array();

		// #0: add label
		$a = self::newEntity( $entityType );
		$a->setLabel( 'en', 'Test' );

		$b = self::newEntity( $entityType );
		$b->setLabel( 'en', 'Test' );
		$b->setLabel( 'de', 'Test' );

		$tests[] = array( $a, $b );

		// #1: remove label
		$a = self::newEntity( $entityType );
		$a->setLabel( 'en', 'Test' );
		$a->setLabel( 'de', 'Test' );

		$b = self::newEntity( $entityType );
		$b->setLabel( 'de', 'Test' );

		$tests[] = array( $a, $b );

		// #2: change label
		$a = self::newEntity( $entityType );
		$a->setLabel( 'en', 'Test' );

		$b = self::newEntity( $entityType );
		$b->setLabel( 'en', 'Test!!!' );

		// #3: add description ------------------------------
		$a = self::newEntity( $entityType );
		$a->setDescription( 'en', 'Test' );

		$b = self::newEntity( $entityType );
		$b->setDescription( 'en', 'Test' );
		$b->setDescription( 'de', 'Test' );

		$tests[] = array( $a, $b );

		// #4: remove description
		$a = self::newEntity( $entityType );
		$a->setDescription( 'en', 'Test' );
		$a->setDescription( 'de', 'Test' );

		$b = self::newEntity( $entityType );
		$b->setDescription( 'de', 'Test' );

		$tests[] = array( $a, $b );

		// #5: change description
		$a = self::newEntity( $entityType );
		$a->setDescription( 'en', 'Test' );

		$b = self::newEntity( $entityType );
		$b->setDescription( 'en', 'Test!!!' );

		$tests[] = array( $a, $b );

		// #6: add alias ------------------------------
		$a = self::newEntity( $entityType );
		$a->setAliases( 'en', array( 'Foo', 'Bar' ) );

		$b = self::newEntity( $entityType );
		$b->setAliases( 'en', array( 'Foo', 'Bar', 'Quux' ) );

		$tests[] = array( $a, $b );

		// #7: add alias language
		$a = self::newEntity( $entityType );
		$a->setAliases( 'en', array( 'Foo', 'Bar' ) );

		$b = self::newEntity( $entityType );
		$b->setAliases( 'en', array( 'Foo', 'Bar' ) );
		$b->setAliases( 'de', array( 'Quux' ) );

		$tests[] = array( $a, $b );

		// #8: remove alias
		$a = self::newEntity( $entityType );
		$a->setAliases( 'en', array( 'Foo', 'Bar' ) );

		$b = self::newEntity( $entityType );
		$b->setAliases( 'en', array( 'Bar' ) );

		$tests[] = array( $a, $b );

		// #9: remove alias language
		$a = self::newEntity( $entityType );
		$a->setAliases( 'en', array( 'Foo', 'Bar' ) );

		$b = self::newEntity( $entityType );

		$tests[] = array( $a, $b );
		return $tests;
	}

	public function provideConflictDetection() {
		$cases = array();

		// #0: adding a label where there was none before
		$base = self::newEntity( Item::ENTITY_TYPE );
		$current = unserialize( serialize( $base ) );

		$new = unserialize( serialize( $base ) );
		$new->setLabel( 'en', 'TEST' );

		$cases[] = array(
			$base,
			$current,
			$new,
			0 // there should eb no conflicts.
		);

		// #1: adding an alias where there was none before
		$base = self::newEntity( Item::ENTITY_TYPE );
		$current = $base;

		$new = unserialize( serialize( $base ) );
		$new->setAliases( 'en', array( 'TEST' ) );

		$cases[] = array(
			$base,
			$current,
			$new,
			0 // there should eb no conflicts.
		);

		// #2: adding an alias where there already was one before
		$base = self::newEntity( Item::ENTITY_TYPE );
		$base->setAliases( 'en', array( 'Foo' ) );
		$current = $base;

		$new = unserialize( serialize( $base ) );
		$new->setAliases( 'en', array( 'Bar' ) );

		$cases[] = array(
			$base,
			$current,
			$new,
			0 // there should be no conflicts.
		);

		// #3: adding an alias where there already was one in another language
		$base = self::newEntity( Item::ENTITY_TYPE );
		$base->setAliases( 'en', array( 'Foo' ) );
		$current = $base;

		$new = unserialize( serialize( $base ) );
		$new->setAliases( 'de', array( 'Bar' ) );

		$cases[] = array(
			$base,
			$current,
			$new,
			0 // there should be no conflicts.
		);

		return $cases;
	}

	/**
	 * @dataProvider provideConflictDetection
	 */
	public function testConflictDetection(
		EntityDocument $base,
		EntityDocument $current,
		EntityDocument $new,
		$expectedConflicts
	) {
		$differ = new EntityDiffer();
		$patcher = new EntityPatcher();

		$patch = $differ->diffEntities( $base, $new );

		$patchedCurrent = unserialize( serialize( $current ) );
		$patcher->patchEntity( $patchedCurrent, $patch );

		$cleanPatch = $differ->diffEntities( $base, $patchedCurrent );

		$conflicts = $patch->count() - $cleanPatch->count();

		$this->assertEquals( $expectedConflicts, $conflicts, 'check number of conflicts detected' );
	}

}


1			<?php
2
3			namespace Wikibase\DataModel\Services\Tests\Diff;
4
5			use RuntimeException;
6			use Wikibase\DataModel\Entity\EntityDocument;
7			use Wikibase\DataModel\Entity\Item;
8			use Wikibase\DataModel\Entity\Property;
9			use Wikibase\DataModel\Services\Diff\EntityDiffer;
10			use Wikibase\DataModel\Services\Diff\EntityPatcher;
11
12			/**
13			* @covers Wikibase\DataModel\Services\Diff\EntityDiff
14			*
15			* @licence GNU GPL v2+
16			* @author Daniel Kinzler
17			* @author Jens Ohlig <[email protected]>
18			*/
19			abstract class EntityDiffOldTest extends \PHPUnit_Framework_TestCase {
20
21			private static function newEntity( $entityType ) {
22			switch ( $entityType ) {
23			case Item::ENTITY_TYPE:
24			return new Item();
25			case Property::ENTITY_TYPE:
26			return Property::newFromType( 'string' );
27			default:
28			throw new RuntimeException( "unknown entity type: $entityType" );
29			}
30			}
31
32			protected function generateApplyData( $entityType ) {
33			$tests = array();
34
35			// #0: add label
36			$a = self::newEntity( $entityType );
37			$a->setLabel( 'en', 'Test' );
38
39			$b = self::newEntity( $entityType );
40			$b->setLabel( 'en', 'Test' );
41			$b->setLabel( 'de', 'Test' );
42
43			$tests[] = array( $a, $b );
44
45			// #1: remove label
46			$a = self::newEntity( $entityType );
47			$a->setLabel( 'en', 'Test' );
48			$a->setLabel( 'de', 'Test' );
49
50			$b = self::newEntity( $entityType );
51			$b->setLabel( 'de', 'Test' );
52
53			$tests[] = array( $a, $b );
54
55			// #2: change label
56			$a = self::newEntity( $entityType );
57			$a->setLabel( 'en', 'Test' );
58
59			$b = self::newEntity( $entityType );
60			$b->setLabel( 'en', 'Test!!!' );
61
62			// #3: add description ------------------------------
63			$a = self::newEntity( $entityType );
64			$a->setDescription( 'en', 'Test' );
65
66			$b = self::newEntity( $entityType );
67			$b->setDescription( 'en', 'Test' );
68			$b->setDescription( 'de', 'Test' );
69
70			$tests[] = array( $a, $b );
71
72			// #4: remove description
73			$a = self::newEntity( $entityType );
74			$a->setDescription( 'en', 'Test' );
75			$a->setDescription( 'de', 'Test' );
76
77			$b = self::newEntity( $entityType );
78			$b->setDescription( 'de', 'Test' );
79
80			$tests[] = array( $a, $b );
81
82			// #5: change description
83			$a = self::newEntity( $entityType );
84			$a->setDescription( 'en', 'Test' );
85
86			$b = self::newEntity( $entityType );
87			$b->setDescription( 'en', 'Test!!!' );
88
89			$tests[] = array( $a, $b );
90
91			// #6: add alias ------------------------------
92			$a = self::newEntity( $entityType );
93			$a->setAliases( 'en', array( 'Foo', 'Bar' ) );
94
95			$b = self::newEntity( $entityType );
96			$b->setAliases( 'en', array( 'Foo', 'Bar', 'Quux' ) );
97
98			$tests[] = array( $a, $b );
99
100			// #7: add alias language
101			$a = self::newEntity( $entityType );
102			$a->setAliases( 'en', array( 'Foo', 'Bar' ) );
103
104			$b = self::newEntity( $entityType );
105			$b->setAliases( 'en', array( 'Foo', 'Bar' ) );
106			$b->setAliases( 'de', array( 'Quux' ) );
107
108			$tests[] = array( $a, $b );
109
110			// #8: remove alias
111			$a = self::newEntity( $entityType );
112			$a->setAliases( 'en', array( 'Foo', 'Bar' ) );
113
114			$b = self::newEntity( $entityType );
115			$b->setAliases( 'en', array( 'Bar' ) );
116
117			$tests[] = array( $a, $b );
118
119			// #9: remove alias language
120			$a = self::newEntity( $entityType );
121			$a->setAliases( 'en', array( 'Foo', 'Bar' ) );
122
123			$b = self::newEntity( $entityType );
124
125			$tests[] = array( $a, $b );
126			return $tests;
127			}
128
129			public function provideConflictDetection() {
130			$cases = array();
131
132			// #0: adding a label where there was none before
133			$base = self::newEntity( Item::ENTITY_TYPE );
134			$current = unserialize( serialize( $base ) );
135
136			$new = unserialize( serialize( $base ) );
137			$new->setLabel( 'en', 'TEST' );
138
139			$cases[] = array(
140			$base,
141			$current,
142			$new,
143			0 // there should eb no conflicts.
144			);
145
146			// #1: adding an alias where there was none before
147			$base = self::newEntity( Item::ENTITY_TYPE );
148			$current = $base;
149
150			$new = unserialize( serialize( $base ) );
151			$new->setAliases( 'en', array( 'TEST' ) );
152
153			$cases[] = array(
154			$base,
155			$current,
156			$new,
157			0 // there should eb no conflicts.
158			);
159
160			// #2: adding an alias where there already was one before
161			$base = self::newEntity( Item::ENTITY_TYPE );
162			$base->setAliases( 'en', array( 'Foo' ) );
163			$current = $base;
164
165			$new = unserialize( serialize( $base ) );
166			$new->setAliases( 'en', array( 'Bar' ) );
167
168			$cases[] = array(
169			$base,
170			$current,
171			$new,
172			0 // there should be no conflicts.
173			);
174
175			// #3: adding an alias where there already was one in another language
176			$base = self::newEntity( Item::ENTITY_TYPE );
177			$base->setAliases( 'en', array( 'Foo' ) );
178			$current = $base;
179
180			$new = unserialize( serialize( $base ) );
181			$new->setAliases( 'de', array( 'Bar' ) );
182
183			$cases[] = array(
184			$base,
185			$current,
186			$new,
187			0 // there should be no conflicts.
188			);
189
190			return $cases;
191			}
192
193			/**
194			* @dataProvider provideConflictDetection
195			*/
196			public function testConflictDetection(
197			EntityDocument $base,
198			EntityDocument $current,
199			EntityDocument $new,
200			$expectedConflicts
201			) {
202			$differ = new EntityDiffer();
203			$patcher = new EntityPatcher();
204
205			$patch = $differ->diffEntities( $base, $new );
206
207			$patchedCurrent = unserialize( serialize( $current ) );
208			$patcher->patchEntity( $patchedCurrent, $patch );
209
210			$cleanPatch = $differ->diffEntities( $base, $patchedCurrent );
211
212			$conflicts = $patch->count() - $cleanPatch->count();
213
214			$this->assertEquals( $expectedConflicts, $conflicts, 'check number of conflicts detected' );
215			}
216
217			}
218

wmde / WikibaseDataModelServices

Push — master ( dfbbd6...7f838a )

EntityDiffOldTest::provideConflictDetection() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like