Conditions | 1 |
Paths | 1 |
Total Lines | 110 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
113 | public function statementOrderProvider() { |
||
114 | $statement1 = new Statement( new PropertyNoValueSnak( 1 ), null, null, 's1' ); |
||
115 | $statement2 = new Statement( new PropertyNoValueSnak( 2 ), null, null, 's2' ); |
||
116 | $statement3 = new Statement( new PropertyNoValueSnak( 3 ), null, null, 's3' ); |
||
117 | |||
118 | return [ |
||
119 | 'Simple associative add' => [ |
||
120 | new StatementList(), |
||
121 | new Diff( [ |
||
122 | 's1' => new DiffOpAdd( $statement1 ), |
||
123 | ], true ), |
||
124 | [ 's1' ] |
||
125 | ], |
||
126 | 'Simple non-associative add' => [ |
||
127 | new StatementList(), |
||
128 | new Diff( [ |
||
129 | 's1' => new DiffOpAdd( $statement1 ), |
||
130 | ], false ), |
||
131 | [ 's1' ] |
||
132 | ], |
||
133 | 'Simple associative remove' => [ |
||
134 | new StatementList( $statement1 ), |
||
135 | new Diff( [ |
||
136 | 's1' => new DiffOpRemove( $statement1 ), |
||
137 | ], true ), |
||
138 | [] |
||
139 | ], |
||
140 | 'Simple non-associative remove' => [ |
||
141 | new StatementList( $statement1 ), |
||
142 | new Diff( [ |
||
143 | 's1' => new DiffOpRemove( $statement1 ), |
||
144 | ], false ), |
||
145 | [] |
||
146 | ], |
||
147 | |||
148 | // Change operations |
||
149 | 'Remove and add' => [ |
||
150 | new StatementList( $statement1 ), |
||
151 | new Diff( [ |
||
152 | 's1' => new DiffOpRemove( $statement1 ), |
||
153 | 's2' => new DiffOpAdd( $statement2 ), |
||
154 | ] ), |
||
155 | [ 's2' ] |
||
156 | ], |
||
157 | 'Add and remove' => [ |
||
158 | new StatementList( $statement1 ), |
||
159 | new Diff( [ |
||
160 | 's2' => new DiffOpAdd( $statement2 ), |
||
161 | 's1' => new DiffOpRemove( $statement1 ), |
||
162 | ] ), |
||
163 | [ 's2' ] |
||
164 | ], |
||
165 | 'Simple associative replace' => [ |
||
166 | new StatementList( $statement1 ), |
||
167 | new Diff( [ |
||
168 | 's1' => new DiffOpChange( $statement1, $statement2 ), |
||
169 | ], true ), |
||
170 | [ 's2' ] |
||
171 | ], |
||
172 | 'Simple non-associative replace' => [ |
||
173 | new StatementList( $statement1 ), |
||
174 | new Diff( [ |
||
175 | 's1' => new DiffOpChange( $statement1, $statement2 ), |
||
176 | ], false ), |
||
177 | [ 's2' ] |
||
178 | ], |
||
179 | 'Replacing first element retains order' => [ |
||
180 | new StatementList( $statement1, $statement2 ), |
||
181 | new Diff( [ |
||
182 | 's1' => new DiffOpChange( $statement1, $statement3 ), |
||
183 | ] ), |
||
184 | [ 's3', 's2' ] |
||
185 | ], |
||
186 | 'Replacing last element retains order' => [ |
||
187 | new StatementList( $statement1, $statement2 ), |
||
188 | new Diff( [ |
||
189 | 's2' => new DiffOpChange( $statement2, $statement3 ), |
||
190 | ] ), |
||
191 | [ 's1', 's3' ] |
||
192 | ], |
||
193 | |||
194 | // No-ops |
||
195 | 'Empty diff' => [ |
||
196 | new StatementList( $statement1 ), |
||
197 | new Diff(), |
||
198 | [ 's1' ] |
||
199 | ], |
||
200 | 'Adding existing element is no-op' => [ |
||
201 | new StatementList( $statement1 ), |
||
202 | new Diff( [ |
||
203 | 's1' => new DiffOpAdd( $statement1 ), |
||
204 | ] ), |
||
205 | [ 's1' ] |
||
206 | ], |
||
207 | 'Removing non-existing element is no-op' => [ |
||
208 | new StatementList( $statement1 ), |
||
209 | new Diff( [ |
||
210 | 's2' => new DiffOpRemove( $statement2 ), |
||
211 | ] ), |
||
212 | [ 's1' ] |
||
213 | ], |
||
214 | 'Replacing non-existing element is no-op' => [ |
||
215 | new StatementList( $statement1 ), |
||
216 | new Diff( [ |
||
217 | 's2' => new DiffOpChange( $statement2, $statement3 ), |
||
218 | ] ), |
||
219 | [ 's1' ] |
||
220 | ], |
||
221 | ]; |
||
222 | } |
||
223 | |||
286 |