Completed
Push — master ( 0bba95...d49286 )
by Bene
03:40
created

TermListSerializerTest::buildSerializer()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 1 Features 0
Metric Value
c 1
b 1
f 0
dl 0
loc 3
rs 10
cc 1
eloc 2
nc 1
nop 1
1
<?php
2
3
namespace Tests\Wikibase\DataModel\Serializers;
4
5
use PHPUnit_Framework_TestCase;
6
use Wikibase\DataModel\Serializers\TermListSerializer;
7
use Wikibase\DataModel\Serializers\TermSerializer;
8
use Wikibase\DataModel\Term\Term;
9
use Wikibase\DataModel\Term\TermFallback;
10
use Wikibase\DataModel\Term\TermList;
11
12
/**
13
 * @covers Wikibase\DataModel\Serializers\TermListSerializer
14
 *
15
 * @licence GNU GPL v2+
16
 * @author Addshore
17
 */
18
class TermListSerializerTest extends PHPUnit_Framework_TestCase {
19
20
	/**
21
	 * @param bool $useObjectsForMaps
22
	 *
23
	 * @return TermListSerializer
24
	 */
25
	private function buildSerializer( $useObjectsForMaps = false ) {
26
		return new TermListSerializer( new TermSerializer(), $useObjectsForMaps );
27
	}
28
29
	/**
30
	 * @dataProvider serializationProvider
31
	 */
32
	public function testSerialization( TermList $input, $useObjectsForMaps, $expected ) {
33
		$serializer = $this->buildSerializer( $useObjectsForMaps );
34
35
		$output = $serializer->serialize( $input );
36
37
		$this->assertEquals( $expected, $output );
38
	}
39
40
	public function serializationProvider() {
41
		return array(
42
			array(
43
				new TermList( array() ),
44
				false,
45
				array()
46
			),
47
			array(
48
				new TermList( array() ),
49
				true,
50
				new \stdClass()
51
			),
52
			array(
53
				new TermList( array(
54
					new Term( 'en', 'Water' ),
55
					new Term( 'it', 'Lama' ),
56
					new TermFallback( 'pt', 'Lama', 'de', 'zh' ),
57
				) ),
58
				false,
59
				array(
60
					'en' => array( 'language' => 'en', 'value' => 'Water' ),
61
					'it' => array( 'language' => 'it', 'value' => 'Lama' ),
62
					'pt' => array( 'language' => 'de', 'value' => 'Lama', 'source' => 'zh' ),
63
				)
64
			),
65
		);
66
	}
67
68
	public function testWithUnsupportedObject() {
69
		$serializer = $this->buildSerializer();
70
		$this->setExpectedException( 'Serializers\Exceptions\UnsupportedObjectException' );
71
		$serializer->serialize( new \stdClass() );
0 ignored issues
show
Documentation introduced by
new \stdClass() is of type object<stdClass>, but the function expects a object<Wikibase\DataModel\Term\TermList>.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
72
	}
73
74
	public function testTermListSerializerWithOptionObjectsForMaps() {
75
		$serializer = $this->buildSerializer( true );
76
77
		$terms = new TermList( array( new Term( 'en', 'foo' ) ) );
78
79
		$serial = new \stdClass();
80
		$serial->en = array(
81
			'language' => 'en',
82
			'value' => 'foo'
83
		);
84
85
		$this->assertEquals( $serial, $serializer->serialize( $terms ) );
86
	}
87
88
}
89