SnakListSerializerTest - Code Metrics - wmde/WikibaseDataModelSerialization - Measure and Improve Code Quality continuously with Scrutinizer

SnakListSerializerTest A
last analyzed 2021-06-01 10:13 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	7
dl	0
loc	86
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	buildSerializer()	12	1
A	serializableProvider()	12	1
A	nonSerializableProvider()	13	1
A	serializationProvider()	21	1
A	testSnakListSerializerWithOptionObjectsForMaps()	20	1

<?php

namespace Tests\Wikibase\DataModel\Serializers;

use Serializers\Serializer;
use stdClass;
use Wikibase\DataModel\Serializers\SnakListSerializer;
use Wikibase\DataModel\Snak\PropertyNoValueSnak;
use Wikibase\DataModel\Snak\SnakList;

/**
 * @covers Wikibase\DataModel\Serializers\SnakListSerializer
 *
 * @license GPL-2.0-or-later
 * @author Thomas Pellissier Tanon
 */
class SnakListSerializerTest extends DispatchableSerializerTest {

	protected function buildSerializer() {
		$snakSerializerMock = $this->getMockBuilder( Serializer::class )->getMock();
		$snakSerializerMock->expects( $this->any() )
			->method( 'serialize' )
			->with( $this->equalTo( new PropertyNoValueSnak( 42 ) ) )
			->will( $this->returnValue( [
				'snaktype' => 'novalue',
				'property' => "P42"
			] ) );

		return new SnakListSerializer( $snakSerializerMock, false );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	public function serializableProvider() {
		return [
			[
				new SnakList()
			],
			[
				new SnakList( [
					new PropertyNoValueSnak( 42 )
				] )
			],
		];
	}

	public function nonSerializableProvider() {
		return [
			[
				5
			],
			[
				[]
			],
			[
				new PropertyNoValueSnak( 42 )
			],
		];
	}

	public function serializationProvider() {
		return [
			[
				[],
				new SnakList()
			],
			[
				[
					'P42' => [
						[
							'snaktype' => 'novalue',
							'property' => 'P42'
						]
					]
				],
				new SnakList( [
					new PropertyNoValueSnak( 42 )
				] )
			],
		];
	}

	public function testSnakListSerializerWithOptionObjectsForMaps() {
		$snakSerializerMock = $this->getMockBuilder( Serializer::class )->getMock();
		$snakSerializerMock->expects( $this->any() )
			->method( 'serialize' )
			->with( $this->equalTo( new PropertyNoValueSnak( 42 ) ) )
			->will( $this->returnValue( [
				'snaktype' => 'novalue',
				'property' => "P42"
			] ) );
		$serializer = new SnakListSerializer( $snakSerializerMock, true );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		$snaklist = new SnakList( [ new PropertyNoValueSnak( 42 ) ] );

		$serial = new stdClass();
		$serial->P42 = [ [
			'snaktype' => 'novalue',
			'property' => 'P42',
	 ] ];
		$this->assertEquals( $serial, $serializer->serialize( $snaklist ) );
	}

}


1			<?php
2
3			namespace Tests\Wikibase\DataModel\Serializers;
4
5			use Serializers\Serializer;
6			use stdClass;
7			use Wikibase\DataModel\Serializers\SnakListSerializer;
8			use Wikibase\DataModel\Snak\PropertyNoValueSnak;
9			use Wikibase\DataModel\Snak\SnakList;
10
11			/**
12			* @covers Wikibase\DataModel\Serializers\SnakListSerializer
13			*
14			* @license GPL-2.0-or-later
15			* @author Thomas Pellissier Tanon
16			*/
17			class SnakListSerializerTest extends DispatchableSerializerTest {
18
19			protected function buildSerializer() {
20			$snakSerializerMock = $this->getMockBuilder( Serializer::class )->getMock();
21			$snakSerializerMock->expects( $this->any() )
22			->method( 'serialize' )
23			->with( $this->equalTo( new PropertyNoValueSnak( 42 ) ) )
24			->will( $this->returnValue( [
25			'snaktype' => 'novalue',
26			'property' => "P42"
27			] ) );
28
29			return new SnakListSerializer( $snakSerializerMock, false );
			0 ignored issues – show Documentation introduced 2020-01-25 11:10 UTC by Report Bug Copy Issue Report `$snakSerializerMock` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Serializers\Serializer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			}
31
32			public function serializableProvider() {
33			return [
34			[
35			new SnakList()
36			],
37			[
38			new SnakList( [
39			new PropertyNoValueSnak( 42 )
40			] )
41			],
42			];
43			}
44
45			public function nonSerializableProvider() {
46			return [
47			[
48			5
49			],
50			[
51			[]
52			],
53			[
54			new PropertyNoValueSnak( 42 )
55			],
56			];
57			}
58
59			public function serializationProvider() {
60			return [
61			[
62			[],
63			new SnakList()
64			],
65			[
66			[
67			'P42' => [
68			[
69			'snaktype' => 'novalue',
70			'property' => 'P42'
71			]
72			]
73			],
74			new SnakList( [
75			new PropertyNoValueSnak( 42 )
76			] )
77			],
78			];
79			}
80
81			public function testSnakListSerializerWithOptionObjectsForMaps() {
82			$snakSerializerMock = $this->getMockBuilder( Serializer::class )->getMock();
83			$snakSerializerMock->expects( $this->any() )
84			->method( 'serialize' )
85			->with( $this->equalTo( new PropertyNoValueSnak( 42 ) ) )
86			->will( $this->returnValue( [
87			'snaktype' => 'novalue',
88			'property' => "P42"
89			] ) );
90			$serializer = new SnakListSerializer( $snakSerializerMock, true );
			0 ignored issues – show Documentation introduced 2020-01-25 11:10 UTC by Report Bug Copy Issue Report `$snakSerializerMock` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Serializers\Serializer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
91
92			$snaklist = new SnakList( [ new PropertyNoValueSnak( 42 ) ] );
93
94			$serial = new stdClass();
95			$serial->P42 = [ [
96			'snaktype' => 'novalue',
97			'property' => 'P42',
98			] ];
99			$this->assertEquals( $serial, $serializer->serialize( $snaklist ) );
100			}
101
102			}
103

wmde / WikibaseDataModelSerialization

SnakListSerializerTest A last analyzed 2021-06-01 10:13 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like

SnakListSerializerTest A
last analyzed 2021-06-01 10:13 UTC