PropertyTest::testSetClaims() - Code Metrics - Inspection of "Remove getClaims/setClaims from all Entity classes" - wmde/WikibaseDataModel - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — getclaims ( a434c3...798844 )

by no

created 2016-02-05 14:15 UTC

PropertyTest::testSetClaims() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	17
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	17
rs	9.4285
cc	1
eloc	11
nc	1
nop	0

<?php

namespace Wikibase\DataModel\Tests\Entity;

use InvalidArgumentException;
use Wikibase\DataModel\Claim\Claims;
use Wikibase\DataModel\Entity\Property;
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Snak\PropertyNoValueSnak;
use Wikibase\DataModel\Snak\PropertySomeValueSnak;
use Wikibase\DataModel\Statement\Statement;
use Wikibase\DataModel\Statement\StatementList;
use Wikibase\DataModel\Term\Fingerprint;

/**
 * @covers Wikibase\DataModel\Entity\Property
 * @covers Wikibase\DataModel\Entity\Entity
 *
 * @group Wikibase
 * @group WikibaseProperty
 * @group WikibaseDataModel
 * @group PropertyTest
 *
 * @licence GNU GPL v2+
 * @author Jeroen De Dauw < [email protected] >
 */
class PropertyTest extends EntityTest {


	/**
	 * @see EntityTest::getNewEmpty
	 *
	 * @since 0.1
	 *
	 * @return Property
	 */
	protected function getNewEmpty() {
		return Property::newFromType( 'string' );
	}

	public function testConstructorWithAllParameters() {
		$property = new Property(
			new PropertyId( 'P42' ),
			new Fingerprint(),
			'string',
			new StatementList()
		);
		$this->assertInstanceOf( 'Wikibase\DataModel\Entity\Property', $property );
		$this->assertEquals( new PropertyId( 'P42' ), $property->getId() );
		$this->assertEquals( new Fingerprint(), $property->getFingerprint() );
		$this->assertEquals( 'string', $property->getDataTypeId() );
		$this->assertEquals( new StatementList(), $property->getStatements() );
	}

	public function testConstructorWithMinimalParameters() {
		$property = new Property( null, null, '' );
		$this->assertInstanceOf( 'Wikibase\DataModel\Entity\Property', $property );
		$this->assertNull( $property->getId() );
		$this->assertEquals( new Fingerprint(), $property->getFingerprint() );
		$this->assertEquals( '', $property->getDataTypeId() );
		$this->assertEquals( new StatementList(), $property->getStatements() );
	}

	/**
	 * @expectedException InvalidArgumentException
	 */
	public function testGivenInvalidType_ConstructorThrowsException() {
		new Property( null, null, null );
	}

	public function testNewFromType() {
		$property = Property::newFromType( 'string' );
		$this->assertInstanceOf( 'Wikibase\DataModel\Entity\Property', $property );
		$this->assertEquals( 'string', $property->getDataTypeId() );
	}

	public function testSetAndGetDataTypeId() {
		$property = Property::newFromType( 'string' );

		foreach ( array( 'string', 'foobar', 'nyan', 'string' ) as $typeId ) {
			$property->setDataTypeId( $typeId );
			$this->assertEquals( $typeId, $property->getDataTypeId() );
		}
	}

	public function testWhenIdSetWithNumber_GetIdReturnsPropertyId() {
		$property = Property::newFromType( 'string' );
		$property->setId( 42 );

		$this->assertHasCorrectIdType( $property );
	}

	protected function assertHasCorrectIdType( Property $property ) {
		$this->assertInstanceOf( 'Wikibase\DataModel\Entity\PropertyId', $property->getId() );
	}

	public function testWhenIdSetWithPropertyId_GetIdReturnsPropertyId() {
		$property = Property::newFromType( 'string' );
		$property->setId( new PropertyId( 'P42' ) );

		$this->assertHasCorrectIdType( $property );
	}

	public function testPropertyWithTypeIsEmpty() {
		$this->assertTrue( Property::newFromType( 'string' )->isEmpty() );
	}

	public function testPropertyWithIdIsEmpty() {
		$property = Property::newFromType( 'string' );
		$property->setId( 1337 );
		$this->assertTrue( $property->isEmpty() );
	}

	public function testPropertyWithFingerprintIsNotEmpty() {
		$property = Property::newFromType( 'string' );
		$property->getFingerprint()->setAliasGroup( 'en', array( 'foo' ) );
		$this->assertFalse( $property->isEmpty() );
	}

	public function testClearRemovesAllButId() {
		$property = Property::newFromType( 'string' );

		$property->setId( 42 );
		$property->getFingerprint()->setLabel( 'en', 'foo' );

		$property->clear();

		$this->assertEquals( new PropertyId( 'P42' ), $property->getId() );
		$this->assertTrue( $property->getFingerprint()->isEmpty() );
	}

	public function testGetStatementsReturnsEmptyListForEmptyProperty() {
		$property = Property::newFromType( 'string' );

		$this->assertEquals( new StatementList(), $property->getStatements() );
	}

	public function testSetAndGetStatements() {
		$property = Property::newFromType( 'string' );

		$statementList = $this->newNonEmptyStatementList();
		$property->setStatements( $statementList );

		$this->assertEquals( $statementList, $property->getStatements() );
	}

	private function newNonEmptyStatementList() {
		$statementList = new StatementList();
		$statementList->addNewStatement( new PropertyNoValueSnak( 42 ) );
		$statementList->addNewStatement( new PropertyNoValueSnak( 1337 ) );

		return $statementList;
	}

	public function equalsProvider() {
		$firstProperty = Property::newFromType( 'string' );
		$firstProperty->setStatements( $this->newNonEmptyStatementList() );

		$secondProperty = Property::newFromType( 'string' );
		$secondProperty->setStatements( $this->newNonEmptyStatementList() );

		$secondPropertyWithId = $secondProperty->copy();
		$secondPropertyWithId->setId( 42 );

		$differentId = $secondPropertyWithId->copy();
		$differentId->setId( 43 );

		return array(
			array( Property::newFromType( 'string' ), Property::newFromType( 'string' ) ),
			array( $firstProperty, $secondProperty ),
			array( $secondProperty, $secondPropertyWithId ),
			array( $secondPropertyWithId, $differentId ),
		);
	}

	/**
	 * @dataProvider equalsProvider
	 */
	public function testEquals( Property $firstProperty, Property $secondProperty ) {
		$this->assertTrue( $firstProperty->equals( $secondProperty ) );
		$this->assertTrue( $secondProperty->equals( $firstProperty ) );
	}

	private function getBaseProperty() {
		$property = Property::newFromType( 'string' );

		$property->setId( 42 );
		$property->getFingerprint()->setLabel( 'en', 'Same' );
		$property->getFingerprint()->setDescription( 'en', 'Same' );
		$property->getFingerprint()->setAliasGroup( 'en', array( 'Same' ) );
		$property->setStatements( $this->newNonEmptyStatementList() );

		return $property;
	}

	public function notEqualsProvider() {
		$differentLabel = $this->getBaseProperty();
		$differentLabel->getFingerprint()->setLabel( 'en', 'Different' );

		$differentDescription = $this->getBaseProperty();
		$differentDescription->getFingerprint()->setDescription( 'en', 'Different' );

		$differentAlias = $this->getBaseProperty();
		$differentAlias->getFingerprint()->setAliasGroup( 'en', array( 'Different' ) );

		$differentStatement = $this->getBaseProperty();
		$differentStatement->setStatements( new StatementList() );

		$property = $this->getBaseProperty();

		return array(
			'empty' => array( $property, Property::newFromType( 'string' ) ),
			'label' => array( $property, $differentLabel ),
			'description' => array( $property, $differentDescription ),
			'alias' => array( $property, $differentAlias ),
			'dataType' => array( Property::newFromType( 'string' ), Property::newFromType( 'foo' ) ),
			'statement' => array( $property, $differentStatement ),
		);
	}

	/**
	 * @dataProvider notEqualsProvider
	 */
	public function testNotEquals( Property $firstProperty, Property $secondProperty ) {
		$this->assertFalse( $firstProperty->equals( $secondProperty ) );
		$this->assertFalse( $secondProperty->equals( $firstProperty ) );
	}

	public function testPropertyWithStatementsIsNotEmpty() {
		$property = Property::newFromType( 'string' );
		$property->setStatements( $this->newNonEmptyStatementList() );

		$this->assertFalse( $property->isEmpty() );
	}

}


1			<?php
2
3			namespace Wikibase\DataModel\Tests\Entity;
4
5			use InvalidArgumentException;
6			use Wikibase\DataModel\Claim\Claims;
7			use Wikibase\DataModel\Entity\Property;
8			use Wikibase\DataModel\Entity\PropertyId;
9			use Wikibase\DataModel\Snak\PropertyNoValueSnak;
10			use Wikibase\DataModel\Snak\PropertySomeValueSnak;
11			use Wikibase\DataModel\Statement\Statement;
12			use Wikibase\DataModel\Statement\StatementList;
13			use Wikibase\DataModel\Term\Fingerprint;
14
15			/**
16			* @covers Wikibase\DataModel\Entity\Property
17			* @covers Wikibase\DataModel\Entity\Entity
18			*
19			* @group Wikibase
20			* @group WikibaseProperty
21			* @group WikibaseDataModel
22			* @group PropertyTest
23			*
24			* @licence GNU GPL v2+
25			* @author Jeroen De Dauw < [email protected] >
26			*/
27			class PropertyTest extends EntityTest {
			0 ignored issues – show Deprecated Code introduced 2015-11-27 17:36 UTC by Report Bug Copy Issue Report The class `Wikibase\DataModel\Tests\Entity\EntityTest` has been deprecated with message: This test class is to be phased out, and should not be used from outside of the component! This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
28
29			/**
30			* @see EntityTest::getNewEmpty
31			*
32			* @since 0.1
33			*
34			* @return Property
35			*/
36			protected function getNewEmpty() {
37			return Property::newFromType( 'string' );
38			}
39
40			public function testConstructorWithAllParameters() {
41			$property = new Property(
42			new PropertyId( 'P42' ),
43			new Fingerprint(),
44			'string',
45			new StatementList()
46			);
47			$this->assertInstanceOf( 'Wikibase\DataModel\Entity\Property', $property );
48			$this->assertEquals( new PropertyId( 'P42' ), $property->getId() );
49			$this->assertEquals( new Fingerprint(), $property->getFingerprint() );
50			$this->assertEquals( 'string', $property->getDataTypeId() );
51			$this->assertEquals( new StatementList(), $property->getStatements() );
52			}
53
54			public function testConstructorWithMinimalParameters() {
55			$property = new Property( null, null, '' );
56			$this->assertInstanceOf( 'Wikibase\DataModel\Entity\Property', $property );
57			$this->assertNull( $property->getId() );
58			$this->assertEquals( new Fingerprint(), $property->getFingerprint() );
59			$this->assertEquals( '', $property->getDataTypeId() );
60			$this->assertEquals( new StatementList(), $property->getStatements() );
61			}
62
63			/**
64			* @expectedException InvalidArgumentException
65			*/
66			public function testGivenInvalidType_ConstructorThrowsException() {
67			new Property( null, null, null );
68			}
69
70			public function testNewFromType() {
71			$property = Property::newFromType( 'string' );
72			$this->assertInstanceOf( 'Wikibase\DataModel\Entity\Property', $property );
73			$this->assertEquals( 'string', $property->getDataTypeId() );
74			}
75
76			public function testSetAndGetDataTypeId() {
77			$property = Property::newFromType( 'string' );
78
79			foreach ( array( 'string', 'foobar', 'nyan', 'string' ) as $typeId ) {
80			$property->setDataTypeId( $typeId );
81			$this->assertEquals( $typeId, $property->getDataTypeId() );
82			}
83			}
84
85			public function testWhenIdSetWithNumber_GetIdReturnsPropertyId() {
86			$property = Property::newFromType( 'string' );
87			$property->setId( 42 );
88
89			$this->assertHasCorrectIdType( $property );
90			}
91
92			protected function assertHasCorrectIdType( Property $property ) {
93			$this->assertInstanceOf( 'Wikibase\DataModel\Entity\PropertyId', $property->getId() );
94			}
95
96			public function testWhenIdSetWithPropertyId_GetIdReturnsPropertyId() {
97			$property = Property::newFromType( 'string' );
98			$property->setId( new PropertyId( 'P42' ) );
99
100			$this->assertHasCorrectIdType( $property );
101			}
102
103			public function testPropertyWithTypeIsEmpty() {
104			$this->assertTrue( Property::newFromType( 'string' )->isEmpty() );
105			}
106
107			public function testPropertyWithIdIsEmpty() {
108			$property = Property::newFromType( 'string' );
109			$property->setId( 1337 );
110			$this->assertTrue( $property->isEmpty() );
111			}
112
113			public function testPropertyWithFingerprintIsNotEmpty() {
114			$property = Property::newFromType( 'string' );
115			$property->getFingerprint()->setAliasGroup( 'en', array( 'foo' ) );
116			$this->assertFalse( $property->isEmpty() );
117			}
118
119			public function testClearRemovesAllButId() {
120			$property = Property::newFromType( 'string' );
121
122			$property->setId( 42 );
123			$property->getFingerprint()->setLabel( 'en', 'foo' );
124
125			$property->clear();
126
127			$this->assertEquals( new PropertyId( 'P42' ), $property->getId() );
128			$this->assertTrue( $property->getFingerprint()->isEmpty() );
129			}
130
131			public function testGetStatementsReturnsEmptyListForEmptyProperty() {
132			$property = Property::newFromType( 'string' );
133
134			$this->assertEquals( new StatementList(), $property->getStatements() );
135			}
136
137			public function testSetAndGetStatements() {
138			$property = Property::newFromType( 'string' );
139
140			$statementList = $this->newNonEmptyStatementList();
141			$property->setStatements( $statementList );
142
143			$this->assertEquals( $statementList, $property->getStatements() );
144			}
145
146			private function newNonEmptyStatementList() {
147			$statementList = new StatementList();
148			$statementList->addNewStatement( new PropertyNoValueSnak( 42 ) );
149			$statementList->addNewStatement( new PropertyNoValueSnak( 1337 ) );
150
151			return $statementList;
152			}
153
154			public function equalsProvider() {
155			$firstProperty = Property::newFromType( 'string' );
156			$firstProperty->setStatements( $this->newNonEmptyStatementList() );
157
158			$secondProperty = Property::newFromType( 'string' );
159			$secondProperty->setStatements( $this->newNonEmptyStatementList() );
160
161			$secondPropertyWithId = $secondProperty->copy();
162			$secondPropertyWithId->setId( 42 );
163
164			$differentId = $secondPropertyWithId->copy();
165			$differentId->setId( 43 );
166
167			return array(
168			array( Property::newFromType( 'string' ), Property::newFromType( 'string' ) ),
169			array( $firstProperty, $secondProperty ),
170			array( $secondProperty, $secondPropertyWithId ),
171			array( $secondPropertyWithId, $differentId ),
172			);
173			}
174
175			/**
176			* @dataProvider equalsProvider
177			*/
178			public function testEquals( Property $firstProperty, Property $secondProperty ) {
179			$this->assertTrue( $firstProperty->equals( $secondProperty ) );
180			$this->assertTrue( $secondProperty->equals( $firstProperty ) );
181			}
182
183			private function getBaseProperty() {
184			$property = Property::newFromType( 'string' );
185
186			$property->setId( 42 );
187			$property->getFingerprint()->setLabel( 'en', 'Same' );
188			$property->getFingerprint()->setDescription( 'en', 'Same' );
189			$property->getFingerprint()->setAliasGroup( 'en', array( 'Same' ) );
190			$property->setStatements( $this->newNonEmptyStatementList() );
191
192			return $property;
193			}
194
195			public function notEqualsProvider() {
196			$differentLabel = $this->getBaseProperty();
197			$differentLabel->getFingerprint()->setLabel( 'en', 'Different' );
198
199			$differentDescription = $this->getBaseProperty();
200			$differentDescription->getFingerprint()->setDescription( 'en', 'Different' );
201
202			$differentAlias = $this->getBaseProperty();
203			$differentAlias->getFingerprint()->setAliasGroup( 'en', array( 'Different' ) );
204
205			$differentStatement = $this->getBaseProperty();
206			$differentStatement->setStatements( new StatementList() );
207
208			$property = $this->getBaseProperty();
209
210			return array(
211			'empty' => array( $property, Property::newFromType( 'string' ) ),
212			'label' => array( $property, $differentLabel ),
213			'description' => array( $property, $differentDescription ),
214			'alias' => array( $property, $differentAlias ),
215			'dataType' => array( Property::newFromType( 'string' ), Property::newFromType( 'foo' ) ),
216			'statement' => array( $property, $differentStatement ),
217			);
218			}
219
220			/**
221			* @dataProvider notEqualsProvider
222			*/
223			public function testNotEquals( Property $firstProperty, Property $secondProperty ) {
224			$this->assertFalse( $firstProperty->equals( $secondProperty ) );
225			$this->assertFalse( $secondProperty->equals( $firstProperty ) );
226			}
227
228			public function testPropertyWithStatementsIsNotEmpty() {
229			$property = Property::newFromType( 'string' );
230			$property->setStatements( $this->newNonEmptyStatementList() );
231
232			$this->assertFalse( $property->isEmpty() );
233			}
234
235			}
236

wmde / WikibaseDataModel

Push — getclaims ( a434c3...798844 )

PropertyTest::testSetClaims() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like