Issues in DispatchingDeserializerTest.php - New Issues - Inspection of "Merge pull request #19 from wmde/release330" - wmde/Serialization - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( dafcf1...02f9b1 )

by Jeroen De

created 2017-08-14 00:08 UTC

Tests/Phpunit/DispatchingDeserializerTest.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Deserializers\Tests\Phpunit\Deserializers;

use Deserializers\DispatchingDeserializer;

/**
 * @covers Deserializers\DispatchingDeserializer
 *
 * @license GPL-2.0+
 * @author Jeroen De Dauw < [email protected] >
 */
class DispatchingDeserializerTest extends \PHPUnit_Framework_TestCase {

	public function testCanConstructWithNoDeserializers() {
		new DispatchingDeserializer( [] );
		$this->assertTrue( true );
	}

	public function testCannotConstructWithNonDeserializers() {
		$this->setExpectedException( 'InvalidArgumentException' );
		new DispatchingDeserializer( [ 42, 'foobar' ] );
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
	}

	public function testCanDeserialize() {
		$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );

		$subDeserializer->expects( $this->exactly( 4 ) )
			->method( 'isDeserializerFor' )
			->will( $this->returnCallback( function( $value ) {
				return $value > 9000;
			} ) );

		$serializer = new DispatchingDeserializer( [ $subDeserializer ] );

		$this->assertFalse( $serializer->isDeserializerFor( 0 ) );
		$this->assertFalse( $serializer->isDeserializerFor( 42 ) );
		$this->assertTrue( $serializer->isDeserializerFor( 9001 ) );
		$this->assertTrue( $serializer->isDeserializerFor( 31337 ) );
	}

	public function testDeserializeWithDeserializableValues() {
		$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );

		$subDeserializer->expects( $this->any() )
			->method( 'isDeserializerFor' )
			->will( $this->returnValue( true ) );

		$subDeserializer->expects( $this->any() )
			->method( 'deserialize' )
			->will( $this->returnValue( 42 ) );

		$serializer = new DispatchingDeserializer( [ $subDeserializer ] );

		$this->assertEquals( 42, $serializer->deserialize( 'foo' ) );
		$this->assertEquals( 42, $serializer->deserialize( null ) );
	}

	public function testSerializeWithUnserializableValue() {
		$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );

		$subDeserializer->expects( $this->once() )
			->method( 'isDeserializerFor' )
			->will( $this->returnValue( false ) );

		$serializer = new DispatchingDeSerializer( [ $subDeserializer ] );

		$this->setExpectedException( 'Deserializers\Exceptions\DeserializationException' );
		$serializer->deserialize( 0 );
	}

	public function testSerializeWithMultipleSubSerializers() {
		$subDeserializer0 = $this->getMock( 'Deserializers\DispatchableDeserializer' );

		$subDeserializer0->expects( $this->any() )
			->method( 'isDeserializerFor' )
			->will( $this->returnValue( true ) );

		$subDeserializer0->expects( $this->any() )
			->method( 'deserialize' )
			->will( $this->returnValue( 42 ) );

		$subDeserializer1 = $this->getMock( 'Deserializers\DispatchableDeserializer' );

		$subDeserializer1->expects( $this->any() )
			->method( 'isDeserializerFor' )
			->will( $this->returnValue( false ) );

		$subDeserializer2 = clone $subDeserializer1;

		$serializer = new DispatchingDeserializer( [
			$subDeserializer1,
			$subDeserializer0,
			$subDeserializer2,
		] );

		$this->assertEquals( 42, $serializer->deserialize( 'foo' ) );
	}

	public function testAddSerializer() {
		$deserializer = new DispatchingDeserializer( [] );

		$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );

		$subDeserializer->expects( $this->any() )
			->method( 'isDeserializerFor' )
			->will( $this->returnValue( true ) );

		$subDeserializer->expects( $this->any() )
			->method( 'deserialize' )
			->will( $this->returnValue( 42 ) );

		$deserializer->addDeserializer( $subDeserializer );

		$this->assertEquals(
			42,
			$deserializer->deserialize( null )
		);
	}

}


1			<?php
2
3			namespace Deserializers\Tests\Phpunit\Deserializers;
4
5			use Deserializers\DispatchingDeserializer;
6
7			/**
8			* @covers Deserializers\DispatchingDeserializer
9			*
10			* @license GPL-2.0+
11			* @author Jeroen De Dauw < [email protected] >
12			*/
13			class DispatchingDeserializerTest extends \PHPUnit_Framework_TestCase {
14
15			public function testCanConstructWithNoDeserializers() {
16			new DispatchingDeserializer( [] );
17			$this->assertTrue( true );
18			}
19
20			public function testCannotConstructWithNonDeserializers() {
21			$this->setExpectedException( 'InvalidArgumentException' );
22			new DispatchingDeserializer( [ 42, 'foobar' ] );
			0 ignored issues – show Documentation introduced 2017-08-12 20:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array(42, 'foobar')` is of type `array<integer,integer\|st...integer","1":"string"}>`, but the function expects a `array<integer,object<Des...patchableDeserializer>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23			}
24
25			public function testCanDeserialize() {
26			$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );
27
28			$subDeserializer->expects( $this->exactly( 4 ) )
29			->method( 'isDeserializerFor' )
30			->will( $this->returnCallback( function( $value ) {
31			return $value > 9000;
32			} ) );
33
34			$serializer = new DispatchingDeserializer( [ $subDeserializer ] );
35
36			$this->assertFalse( $serializer->isDeserializerFor( 0 ) );
37			$this->assertFalse( $serializer->isDeserializerFor( 42 ) );
38			$this->assertTrue( $serializer->isDeserializerFor( 9001 ) );
39			$this->assertTrue( $serializer->isDeserializerFor( 31337 ) );
40			}
41
42			public function testDeserializeWithDeserializableValues() {
43			$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );
44
45			$subDeserializer->expects( $this->any() )
46			->method( 'isDeserializerFor' )
47			->will( $this->returnValue( true ) );
48
49			$subDeserializer->expects( $this->any() )
50			->method( 'deserialize' )
51			->will( $this->returnValue( 42 ) );
52
53			$serializer = new DispatchingDeserializer( [ $subDeserializer ] );
54
55			$this->assertEquals( 42, $serializer->deserialize( 'foo' ) );
56			$this->assertEquals( 42, $serializer->deserialize( null ) );
57			}
58
59			public function testSerializeWithUnserializableValue() {
60			$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );
61
62			$subDeserializer->expects( $this->once() )
63			->method( 'isDeserializerFor' )
64			->will( $this->returnValue( false ) );
65
66			$serializer = new DispatchingDeSerializer( [ $subDeserializer ] );
67
68			$this->setExpectedException( 'Deserializers\Exceptions\DeserializationException' );
69			$serializer->deserialize( 0 );
70			}
71
72			public function testSerializeWithMultipleSubSerializers() {
73			$subDeserializer0 = $this->getMock( 'Deserializers\DispatchableDeserializer' );
74
75			$subDeserializer0->expects( $this->any() )
76			->method( 'isDeserializerFor' )
77			->will( $this->returnValue( true ) );
78
79			$subDeserializer0->expects( $this->any() )
80			->method( 'deserialize' )
81			->will( $this->returnValue( 42 ) );
82
83			$subDeserializer1 = $this->getMock( 'Deserializers\DispatchableDeserializer' );
84
85			$subDeserializer1->expects( $this->any() )
86			->method( 'isDeserializerFor' )
87			->will( $this->returnValue( false ) );
88
89			$subDeserializer2 = clone $subDeserializer1;
90
91			$serializer = new DispatchingDeserializer( [
92			$subDeserializer1,
93			$subDeserializer0,
94			$subDeserializer2,
95			] );
96
97			$this->assertEquals( 42, $serializer->deserialize( 'foo' ) );
98			}
99
100			public function testAddSerializer() {
101			$deserializer = new DispatchingDeserializer( [] );
102
103			$subDeserializer = $this->getMock( 'Deserializers\DispatchableDeserializer' );
104
105			$subDeserializer->expects( $this->any() )
106			->method( 'isDeserializerFor' )
107			->will( $this->returnValue( true ) );
108
109			$subDeserializer->expects( $this->any() )
110			->method( 'deserialize' )
111			->will( $this->returnValue( 42 ) );
112
113			$deserializer->addDeserializer( $subDeserializer );
114
115			$this->assertEquals(
116			42,
117			$deserializer->deserialize( null )
118			);
119			}
120
121			}
122

wmde / Serialization

Push — master ( dafcf1...02f9b1 )

Tests/Phpunit/DispatchingDeserializerTest.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like